Repository navigation
Conversation
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Half the described fix is missing: the diff contains no CONTRIBUTING.md hunk, yet the description claims a paragraph was added there. Watch
Suggestions
[DESIGN-REVIEWED] 1f7860a |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
buluoray
left a comment
There was a problem hiding this comment.
Approving. The premise holds and the mechanics are described accurately — I verified each claim against .github/workflows/fork-pr-description.yml on current origin/main rather than from the PR body.
Verified
- The four
REQUIRED_SECTIONSare exactly as named, andREQUIRED_SECTIONSis declared "kept byte-identical to the maintainer cron's" list, so naming them in contributor-facing docs cannot drift from the gate on its own. - The match really is a case-insensitive prefix against real ATX heading lines, so the "a suffix after the heading is fine" note is correct and the template's own
## What changed (motivation → approach → change)keeps passing. The awk scanner also excludes fenced blocks, so the docs' "the heading is PRESENT" framing is right in both directions. editedis in thepull_request_targettrigger list, so "no push needed, editing the description re-runs the check" is accurate.- The presence-not-content limit is stated in the workflow's own header comment ("A PR that keeps the template verbatim passes"), so the docs match the source's own self-description.
- The gap is real:
git grep -i "Fork PR Description"overorigin/mainreturns no hit inCONTRIBUTING.md, the template, or anywhere underdocs/. The only prose that namesREQUIRED_SECTIONStoday isbuiltin_skills/kirocrew-dev/prepare-pr/references/rationale.md, which a fork contributor has no reason to read. python3 scripts/docs_lint.py --baseline .github/docs-lint-baseline.txt→ "All documentation checks passed". The graduated-baseline entries it lists are all in files this PR does not touch.
Non-blocking nit — one attribution is slightly off
CONTRIBUTING.md says the check "holds auto-approval of your workflow runs until they are". The workflow header is explicit that it does not: the maintainer-side cron evaluates the same rules and is what decides approval, while the check-run only explains the state — "The cron keeps EVALUATING the rules — that is what decides approval … and no longer NOTIFIES."
Nothing actionable changes for a contributor (fix the description → check goes green → runs get approved), and the template's own wording sidesteps this by stating it as correlation ("fails the check, and its workflow runs stay unapproved"). But CONTRIBUTING.md is read by maintainers too, and the repo deliberately documents the check-vs-cron split, so mirroring the template's phrasing here would be strictly more accurate. Entirely your call — I would not hold the PR for it.
Two notes on the red checks, neither of which is this PR's
-
Backend Tests (3.12, 2)andBackend Tests (Windows)both fail ontest/test_ci_fleet_routing_expression_parity.py::test_every_ci_yml_resolver_consumer_reads_the_resolver_not_a_literal—("ci.yml", "backend-test")readingneeds.changes.outputs.linux_runnerwhile absent from_EXPECTED_RESOLVER_CONSUMER_JOBS. This diff is two prose files and touches no workflow and no test. On currentorigin/mainthat set already contains("ci.yml", "backend-test"), so the mismatch is resolved upstream; these runs are from 2026-09-18 and a PR's checks are not re-run when main advances.Coverage Gatefailed closed purely onbackend-test=failure. All three should clear on the next run against current main. -
Fork workflow-change guardis a genuine gate, not stale: "fork PR modifies.github/**— blocked", because the template lives under.github/. It needs a maintainer to apply theallow-fork-workflow-changelabel; an approval alone does not clear it. Flagging so this does not sit waiting on the wrong action.
|
@buluoray I believe this needs the |
bolichen97
left a comment
There was a problem hiding this comment.
Approving. I checked the claims this comment makes against the workflow that enforces them, since a template comment that lies is worse than no comment.
fork-pr-description.yml matches, exactly:
- The four required headings are
## Problem / Motivation,## Why it matters,## What changed,## Tests(REQUIRED_SECTIONS, lines 91-95), kept byte-identical to the maintainer cron's list so the check and the approval decision cannot disagree. - "a suffix after the heading is fine" is right — the match is a case-insensitive prefix, which is why the template's own
## What changed (motivation -> approach -> change)passes. - "The check only verifies the heading is PRESENT" is the workflow's own stated limit, verbatim.
- "no push needed — editing the description re-runs the check" is right:
pull_request_targetincludesedited, which the comment correctly identifies as the remedy path.
This is a real trap for fork contributors — the failure mode is workflow runs sitting unapproved with nothing on the PR explaining why — and the fix is two comment blocks. Worth having.
I applied allow-fork-workflow-change. The guard fired because .github/PULL_REQUEST_TEMPLATE.md counts as a CI file; the diff changes an HTML comment and a CONTRIBUTING paragraph, touches no workflow logic, and cannot influence a check result.
On the three test reds: they are not yours. Backend Tests (3.12, 2), Backend Tests (Windows) (2) and Coverage Gate all failed on test_ci_fleet_routing_expression_parity.py::test_every_ci_yml_resolver_consumer_reads_the_resolver_not_a_literal, complaining that ("ci.yml", "backend-test") reads the runner resolver without being in _EXPECTED_RESOLVER_CONSUMER_JOBS. That pair is in the expected set on current main (test_ci_fleet_routing_expression_parity.py:135), so it was main debt on 2026-09-18 and has since been fixed. Your runs are from that day and this branch is ~476 commits behind. Actions tests the refs/pull/N/merge ref against current main, so a re-run clears them with no rebase and no push from you — I have kicked the failed jobs.
The Fork PR Description check (.github/workflows/fork-pr-description.yml) holds auto-approval of a fork PR's workflow runs until the description carries four headings: Problem / Motivation, Why it matters, What changed, and Tests. The template's opening comment said only to "omit a section when it is genuinely not applicable", giving no signal that these four are mandatory -- so a description that dropped ## Tests looked compliant yet silently failed the gate (as happened on kirodotdev#11886). Name the four required headings in the template's opening block, explain that editing the description re-runs the check with no push needed, and reinforce it inline on the Tests section.
ff2068a to
dddd30a
Compare
Problem / Motivation
The
.github/PULL_REQUEST_TEMPLATE.mdopening comment tells contributors to"omit a section only when it is genuinely not applicable" and gives every
section equal weight. But four of those headings are hard-required: the
Fork PR Descriptioncheck (.github/workflows/fork-pr-description.yml) holdsauto-approval of a fork PR's workflow runs until the description contains
## Problem / Motivation,## Why it matters,## What changed, and## Tests. Nothing in the template orCONTRIBUTING.mdnames that requirement,so a contributor who drops one — commonly
## Tests— has a description thatlooks compliant yet silently fails the gate (this happened on #11886).
Why it matters
Every external contributor hits this gate, and the failure is invisible at
authoring time: the template reads as "all optional", so the first signal is a
failed check and stalled workflow runs after the PR is already open. Naming the
four required headings where contributors actually look removes an avoidable
round-trip for every fork PR.
What changed
.github/PULL_REQUEST_TEMPLATE.md: rewrote the opening comment to name thefour required headings, explain that the
Fork PR Descriptioncheck gatesfork auto-approval on them, that it checks presence (not content) and re-runs
on a description edit with no push, and clarified that every other section
stays omittable. Added an inline "Required" note on the
## Testssection.CONTRIBUTING.md: added a short paragraph to the "CI checks on your PR(forks vs. direct branches)" section documenting the same rule and linking
the template.
Docs-only; no heading text or check logic changed, so the existing prefix match
(including the
## What changed (…)suffix) is untouched.Tests
No automated tests — this changes template prose and a contributor doc only.
Verified
python3 scripts/docs_lint.py --baseline .github/docs-lint-baseline.txtpasses with no new findings after the edits.
Related Issues
Follow-up to the
Fork PR Descriptiongate observed on #11886.