Skip to content

feat(command-bar): reach folders through a view row, like sessions - #12013

Merged
iamwhatever merged 1 commit into
mainfrom
feat/command-bar-folder-scope
Sep 19, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/command-bar-folder-scope

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

What is the problem?

Folder search reached the reader through the wrong shape, and through two
implementations instead of one.

Shape. The Command Bar is the default Cmd+K surface, and PR #11525 put the
sidebar's folders into it as individual root rows. On that surface a folder list
behaves unlike every other corpus the bar holds:

  • with an empty query the rows carried idleDemote and a group cap of two, so at
    most two folders appeared, chosen by the alphabet rather than by the user;
  • with a query they competed with commands, apps and settings for the first page;
  • nothing named the capability, so a reader who did not already know folders were
    searchable had no row telling them so.

Sessions and artifacts, the surface's other two corpora, are reached the opposite
way: one Search Sessions or Search Artifacts row you enter, which then owns
the whole list.

Ownership. The same PR also gave the HOST quick-search palette its own folder
search: a Folders scope in its tab list plus a registration in its All aggregator,
with the corpus filed under components/commandPalette/providers/. So the gesture
"find a folder by name and land on it" had two implementations, on two surfaces,
free to disagree about ranking and about what a reveal does.

Why this issue matters to the user

The feature reads as missing. A user who shipped it and then went looking for it in
the launcher asked where it had gone: the two surviving folder rows were not the two
they wanted, and no row in the bar mentions folders at all. The inconsistency is
also a learning cost, because the bar teaches "a corpus is a row you enter" through
Search Sessions and then contradicts itself for folders.

The second implementation costs the user in a quieter way. Only one of the two
surfaces is the one people use, since Command Bar is enabled by default and replaces
the quick-search slot, so the host's copy is the one that receives no attention and
drifts, and the reader who does disable the launcher gets whatever it drifted into.

How our fix solves it

One corpus row per corpus, entered. The root holds one row per corpus, and each
one is a view the reader enters:

The Command Bar root page: Search Folders, Search Artifacts and Search Sessions as sibling View rows under Commands, and no folder name among them

Entering the row lands on the whole folder list in the order the sidebar draws it,
with each row's ancestry path under its name:

Inside the folders view with an empty query: the breadcrumb reads Search Folders, the placeholder reads Search all folders, and every folder is listed in sidebar order with its parent path

It narrows from the first character, because the corpus is the cached
['chat-folders'] list rather than a backend, so there is no minimum query length:

Inside the folders view with the query oss: one row remains, titled oss, with its parent kirocrew beneath it

One implementation, owned by the app. The host palette now carries no Folders
scope at all. Typing fold there raises no hint beside the input, and Tab adopts
nothing, while the sidebar behind it holds six folders, so the absence is the
palette's and not the fixture's:

The host quick-search palette with the launcher disabled: the query fold returns only Channels settings rows, no Folders scope hint beside the input and no folder row, while the sidebar behind it shows six folders

The corpus moved with the capability: components/commandPalette/providers/foldersProvider.ts
is now apps/command-bar/foldersProvider.ts, and useFoldersProvider is deleted
because the host was its only caller. What stays shared is the Result row
contract, which every corpus view in this app renders and the Enter matrix
dispatches; forking that would fork the Enter matrix with it.

The rest of the shape:

  • A typed word still reaches folders without knowing to enter first: the root's tail
    offers Search folders for "<query>", next to the existing sessions and
    artifacts ones, and entering through it carries the query so nothing is retyped.
  • Inside the view, the two dead ends are rows rather than paragraphs, so the
    keyboard can act on them: a failed folder read is a retry row, and a query that
    matches nothing offers the full list back.
  • The footer names what Enter does per corpus, so a folder row says Open, not Open
    Session.
  • The corpus is hook-free, which is what keeps its React-Query fetch and its route
    change in CommandBarOverlay alongside this app's other two engines. Every
    navigation in that component goes through usePaletteActions, and one component
    holding two navigation mechanisms is how one of them ends up unexercised.
  • The root stays request-free. Building the provider issues nothing; entering the
    view is the activation event that may pay for one folder fetch on a cold cache,
    the same bargain the sessions view makes.
  • The now-dead folders root group goes, with its idle cap and its two catalog
    keys, so a future caller cannot push folder rows back into the root without
    reopening the question. ROOT_GROUPS is asserted not to contain it.

The folders view follows the per-corpus slot tags this file already uses for
artifacts (fallback-folders, retry-folders), so the three corpora are wired the
same way and the artifacts paths are untouched.

docs/feature-map/README.md and docs/system-specs/modules/command-bar.md record
both halves: the entry point that now exists, and which layer owns the corpus.

What tests we did

  • CommandBarOverlay.folders.test.tsx rewritten for the new shape: the root offers
    the corpus row and never a folder row even when the cache holds a matching folder;
    a failed read gives a retryable row; a non-array cache and a non-string folder
    name leave the launcher standing.
  • rootIndex.test.ts: the folders-group tests are replaced by one that pins the
    group's absence, and the opening-page composition test now reads apps/settings.
  • CommandPalette.test.tsx gains the assertion for the other direction: typing
    fold raises no Folders hint and Tab adopts no folders scope. It is
    mutation-verified rather than assumed. Putting a stub Folders provider back into
    the host's tab list fails exactly that test and nothing else (1 failed, 49 passed),
    and the file was restored from a copy taken before the mutation.
  • src/apps/command-bar/ and src/components/commandPalette/ run green together at
    570 tests across 33 files, which includes the 25 artifacts-corpus tests, so the
    three corpora coexist rather than one replacing another. foldersProvider.test.ts
    carries 13 of them at its new path.
  • website/scripts/capture-command-bar-folder-scope.mjs is the harness that took the
    four frames above. It drives the real built SPA with /api/** stubbed and asserts
    what each frame is supposed to evidence, so it fails instead of quietly
    photographing a regression: that both corpus rows are offered at the root, that a
    folder's own name typed at the root produces no folder row, that the placeholder
    changes inside the view, that an empty query lists the corpus, that a query
    narrows it, that a narrowed row still carries its parent path, and now that the
    host palette under a disabled launcher raises no folders scope and adopts none on
    Tab. Frame 4 checks the surface it is on before asserting anything about it, so a
    frame of the wrong overlay fails rather than passing vacuously.
  • tsc --noEmit, eslint and npm run build clean.
  • npm run i18n:pseudo regenerated en-XA; i18n:check reports the 5 new keys as
    well-shaped with zero passthrough findings among the values added.

Any other suggestions on the work

The five new catalog keys are translated in all eleven translated
website/src/i18n/locales catalogs by mirroring each one's existing sessions
wording with its own word for a folder, so no locale ships an English placeholder;
en-XA.json is regenerated, not hand-edited. Two keys the removed root group owned
(group_folders, kind.folder) are deleted from every catalog.

The sidebar's own search box still matches folder names, keeping a matched folder
with its whole subtree. That is left in place deliberately: it is a different
gesture on a different surface (filter the list I am looking at, rather than jump to
a folder from anywhere), and it is the one folder-search surface that is not a second
copy of the launcher's. Removing it is a separate call, not a consequence of this
one.

One asymmetry is left alone deliberately: the Search Artifacts row carries a
subtitle and the other two corpus rows do not. That is how the artifacts row landed,
and changing it belongs to whoever owns that copy.

This is the same work as #11921, re-raised from a branch on this repository. On the
fork PR both hard-gate reviewers returned "review incomplete" on every head and every
re-run for five hours: the Opus job died fetching its toolchain
(connect ECONNREFUSED ... :443, exit 127) and the GPT job failed both passes with
Connection failed: error sending request after five reconnects. It was repo-wide,
not this diff: over the same window every fork PR measured (#11967, #11972) carried
the identical review incomplete title on both lanes, while same-repo PRs carried
real verdicts. A fork lane consumes no /ai-review override marker, so an override
could not have produced a verdict either. The commits here are the fork branch's,
rebased onto current main; #11921 is closed pointing at this PR.

Supersedes #11921

Refs #11525

Root with "oss" typed, scrolled to the tail row: Search folders for "oss"

Folders view with nothing filed: No folders yet

Folders view, failed read: Search failed notice above the list, Retry still an option

Folders view, no match: the full list offered back as a row, footer verb Show All Folders

@chenmingwei23
chenmingwei23 requested review from a team and CrysisDeu September 19, 2026 11:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 19, 2026
@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 2f19b161ff0bf086c44209b411fee21cf94bee62 and found no blocking issues.

This comment is updated in place on each push.

Review details

FINDING -- website/src/apps/command-bar/CommandBarOverlay.tsx:984 -- "['command-bar', 'folders', folderQuery]" survives folder invalidations, so a recently renamed/deleted folder remains actionable for 15s -> Fix: nest this key under ['chat-folders', 'command-bar', 'view', folderQuery]. (origin: validation)
[GPT-REVIEWED] 2f19b16

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2f19b161ff0bf086c44209b411fee21cf94bee62: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 2f19b161ff0bf086c44209b411fee21cf94bee62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the accepted trade-off: with the launcher disabled, palette folder search is gone entirely — the sidebar filter is the only remaining surface there.

[DESIGN-REVIEWED] 2f19b16

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 19, 2026
@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 2f19b161ff0bf086c44209b411fee21cf94bee62 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Primary rows were only guessed, not known: nothing on screen says the "Search Folders" row opens a view rather than searching immediately.

Watch

  • The blind reader read every main-path control correctly but rated the "Search Folders" row and the folder rows "a guess", and wrote "nothing on screen tells me so for certain" that the row opens the folder screen. Every first-time user hits this once, mild friction, self-correcting → low CONCERNS. Smallest fix: a one-line subtitle on cmd_search_folders (the pattern cmd_search_artifacts already uses), e.g. "Jump to one of your sidebar folders".
  • "Folder" means two things on one screen: in shot-05 the new "Search folders for “oss”" row renders beside the pre-existing "Folder name (iMessage/Slack/…)" Channels settings, and the reader "cannot tell if they are related". The settings copy is not this PR's, but the new row lands in the collision — worth a human look.

Suggestions

  • searchFailedText for the folders scope reuses generic search_failed ("Search failed") even when the failure is the empty-query folder listing the user never searched; a folders-specific string ("Couldn't load folders") would match the artifacts precedent (artifact_search_failed).

[UX-REVIEWED] 2f19b16

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ human override accepted

@chenmingwei23 overrode this lane for 2f19b161ff0bf086c44209b411fee21cf94bee62 via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed 2f19b161ff0bf086c44209b411fee21cf94bee62 — this comment is updated in place on each push.

Review details

Verified the two load-bearing facts: search_failed exists in the commandBar catalog (so the new foldersFailed path renders a real string), and chatFolders is still used via chatFoldersRef for the session-filing path (read through a ref, so dropping it from the rebuilt memo's deps at line 1044 introduces no stale closure — the memo body no longer references it).

The candidate list produced no candidates, and independent falsification confirms this frontend refactor has no reachable defect: the new folders scope mirrors the artifacts scope exactly (gated useQuery, Array.isArray guard on the shared ['chat-folders'] cache, reveal-before-navigate ordering), all seven new i18n keys are present across all 13 hand-authored locales with consistent {{query}} interpolation, and the removed flat-group machinery leaves no dangling references. Nothing grounds a new finding at the required bar.

No findings.

[OPUS-REVIEWED] 2f19b16

Verdict parsed from the review's SHA-scoped output markers for commit 2f19b161ff0bf086c44209b411fee21cf94bee62.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2f19b161ff0bf086c44209b411fee21cf94bee62: <one-sentence reason>

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 19, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Dispositions for head e0818ad3ec.

GPT 5.6 (blocking, errors-use-error-notice) - fixed. The folder failure no longer renders its own red title inside a listbox option. ErrorNotice above the list now covers the folders scope as well as artifacts and resolves its journal report from the folders query's own rejection, and the retry-folders row carries the action only, like retry-artifacts. The sessions row keeps its separate tag and stays byte-identical to main, so this change still does not reshape that surface. The test asserts the notice by role, that the backend wording stays out of the copy, and that the failure text is NOT a row, so a later change cannot move it back inside an option.

UX evidence gaps - closed with four frames, all produced by the harness against the real built SPA, each with its own assertion so a frame of the wrong state fails instead of passing vacuously:

  • 5-root-tail-row-carries-query.png - the root with oss typed, scrolled to the tail row Search folders for "oss".
  • 6-scope-empty-corpus.png - the view with zero folders: No folders yet..., and the assertion also pins that the sessions copy is absent.
  • 7-scope-read-failed.png - the failed read: the Search failed notice above the list, Retry still an option inside it. The assertion is scoped to the dialog, because the sidebar reads the same endpoint and raises its own notice behind the overlay.
  • 8-scope-no-match.png - the dead end naming the query, with the footer verb Show All Folders.

UX watch, "two doors" - answered, not changed. The two rows are already distinguishable by their own text: the View row reads Search Folders and enters empty, the tail row reads Search folders for "oss" and carries what you typed. That pair is main's own shape for the sessions corpus, where the tail row carries no subtitle either, so a gloss on the folders row alone would add an asymmetry rather than remove one. If the rule should be that every corpus tail row carries a gloss, that is a change to all three rows and belongs to whoever owns the artifacts copy.

First Principles (blocking) - not something this PR can close. It asks for an accepted RFC on base for the product-shape decision, or a maintainer's recorded decision. The shape here was requested directly by the repository owner; the decision is his to record, so it is left for him rather than self-authorized here.

Reaching a session folder by name had the wrong shape on the default launcher,
and two implementations instead of one.

Shape: PR #11525 put the sidebar's folders into the Command Bar as individual
root rows, which no other corpus there is. The bar teaches "a corpus is a row
you enter" -- Search Sessions and Search Artifacts both do -- so folders are now
a Search Folders view row: enter it, see every folder in sidebar order with its
ancestry, and narrow from the first character. The root also keeps a tail row,
"Search folders for <query>", which carries text already typed into that view.

Ownership: the host quick-search palette carried a second folder search, a
Folders scope plus an All-aggregator registration. Two surfaces answering the
same gesture are free to disagree about ranking and about what a reveal does,
and only one of them is the surface people use, since Command Bar is default-on
and replaces the quick-search slot. That copy is deleted, the corpus moved to
apps/command-bar/foldersProvider.ts, and useFoldersProvider, whose only caller
was the host, is gone.

Failure states: a folder read that fails renders through ErrorNotice above the
list, like the artifacts view's, rather than as a hand-written red title inside
a listbox option (AUTOSDE errors-use-error-notice). The retry row carries the
action only. The sessions row keeps its own tag and stays byte-identical to
main, so this change does not reshape a surface it does not own.

Pinned in tests: a palette test fails if a Folders scope comes back; the
overlay test asserts the failure notice by role, that backend wording stays out
of the copy, and that the failure text is not a row; the capture harness shoots
eight states, including the host palette with the launcher off.

Refs #11525
@chenmingwei23
chenmingwei23 force-pushed the feat/command-bar-folder-scope branch from e0818ad to 2f19b16 Compare September 19, 2026 11:56
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 19, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 2f19b16: The repository owner asked for this exact shape (folder search entered as a corpus view, like session search) and records that decision here, so the launcher's folder-search placement is settled without a separate RFC.

@github-actions

Copy link
Copy Markdown
Contributor

Human judgment recorded

@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 2f19b161ff0bf086c44209b411fee21cf94bee62.

The repository owner asked for this exact shape (folder search entered as a corpus view, like session search) and records that decision here, so the launcher's folder-search placement is settled without a separate RFC.

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 19, 2026
@iamwhatever
iamwhatever merged commit e9ccb18 into main Sep 19, 2026
124 of 126 checks passed
@iamwhatever
iamwhatever deleted the feat/command-bar-folder-scope branch September 19, 2026 17:34
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 19, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…irodotdev#12013)

Reaching a session folder by name had the wrong shape on the default launcher,
and two implementations instead of one.

Shape: PR kirodotdev#11525 put the sidebar's folders into the Command Bar as individual
root rows, which no other corpus there is. The bar teaches "a corpus is a row
you enter" -- Search Sessions and Search Artifacts both do -- so folders are now
a Search Folders view row: enter it, see every folder in sidebar order with its
ancestry, and narrow from the first character. The root also keeps a tail row,
"Search folders for <query>", which carries text already typed into that view.

Ownership: the host quick-search palette carried a second folder search, a
Folders scope plus an All-aggregator registration. Two surfaces answering the
same gesture are free to disagree about ranking and about what a reveal does,
and only one of them is the surface people use, since Command Bar is default-on
and replaces the quick-search slot. That copy is deleted, the corpus moved to
apps/command-bar/foldersProvider.ts, and useFoldersProvider, whose only caller
was the host, is gone.

Failure states: a folder read that fails renders through ErrorNotice above the
list, like the artifacts view's, rather than as a hand-written red title inside
a listbox option (AUTOSDE errors-use-error-notice). The retry row carries the
action only. The sessions row keeps its own tag and stays byte-identical to
main, so this change does not reshape a surface it does not own.

Pinned in tests: a palette test fails if a Folders scope comes back; the
overlay test asserts the failure notice by role, that backend wording stays out
of the copy, and that the failure text is not a row; the capture harness shoots
eight states, including the host palette with the launcher off.

Refs kirodotdev#11525
iamwhatever pushed a commit that referenced this pull request Sep 30, 2026
The Command Bar's Folders view derives its rows from the sidebar's own
`['chat-folders']` cache, but cached them under `['command-bar', 'folders', q]`
— a key outside that namespace. React-Query invalidates by key PREFIX, so the
`invalidateQueries({ queryKey: ['chat-folders'] })` that ends every folder
create, delete and update in `ChatSidebar` reached the corpus and not the rows
built from it.

`QuickSearchSurface` mounts the overlay only while the bar is open, and a
remount refetches only what is stale. A folder deleted while the bar was closed
therefore came back on the next open: listed, selectable, and carrying an id the
sidebar no longer has, so activating it asked for a reveal that silently did
nothing. The window is the view's own `staleTime`, 15s.

The key is now nested under the corpus, `['chat-folders', 'command-bar', 'view',
q]` — the shape the artifacts view in this same file already uses
(`['artifacts', 'command-bar', 'view', q]`), which is why that view has never had
this gap. Nothing reads `['chat-folders']` as a prefix except `invalidateQueries`
and `cancelQueries`; every get/set in the repo uses the exact key, so no other
reader's match changes.

Named by the Design review on #12013 and shipped unaddressed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Leon <276034861+leonlaiyc@users.noreply.github.com>
iamwhatever pushed a commit that referenced this pull request Sep 30, 2026
The Command Bar's Folders view derives its rows from the sidebar's own
`['chat-folders']` cache, but cached them under `['command-bar', 'folders', q]`
— a key outside that namespace. React-Query invalidates by key PREFIX, so the
`invalidateQueries({ queryKey: ['chat-folders'] })` that ends every folder
create, delete and update in `ChatSidebar` reached the corpus and not the rows
built from it.

`QuickSearchSurface` mounts the overlay only while the bar is open, and a
remount refetches only what is stale. A folder deleted while the bar was closed
therefore came back on the next open: listed, selectable, and carrying an id the
sidebar no longer has, so activating it asked for a reveal that silently did
nothing. The window is the view's own `staleTime`, 15s.

The key is now nested under the corpus, `['chat-folders', 'command-bar', 'view',
q]` — the shape the artifacts view in this same file already uses
(`['artifacts', 'command-bar', 'view', q]`), which is why that view has never had
this gap. Nothing reads `['chat-folders']` as a prefix except `invalidateQueries`
and `cancelQueries`; every get/set in the repo uses the exact key, so no other
reader's match changes.

Named by the Design review on #12013 and shipped unaddressed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Leon <276034861+leonlaiyc@users.noreply.github.com>
iamwhatever pushed a commit that referenced this pull request Sep 30, 2026
The Command Bar's Folders view derives its rows from the sidebar's own
`['chat-folders']` cache, but cached them under `['command-bar', 'folders', q]`
— a key outside that namespace. React-Query invalidates by key PREFIX, so the
`invalidateQueries({ queryKey: ['chat-folders'] })` that ends every folder
create, delete and update in `ChatSidebar` reached the corpus and not the rows
built from it.

`QuickSearchSurface` mounts the overlay only while the bar is open, and a
remount refetches only what is stale. A folder deleted while the bar was closed
therefore came back on the next open: listed, selectable, and carrying an id the
sidebar no longer has, so activating it asked for a reveal that silently did
nothing. The window is the view's own `staleTime`, 15s.

The key is now nested under the corpus, `['chat-folders', 'command-bar', 'view',
q]` — the shape the artifacts view in this same file already uses
(`['artifacts', 'command-bar', 'view', q]`), which is why that view has never had
this gap. Nothing reads `['chat-folders']` as a prefix except `invalidateQueries`
and `cancelQueries`; every get/set in the repo uses the exact key, so no other
reader's match changes.

Named by the Design review on #12013 and shipped unaddressed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Leon <276034861+leonlaiyc@users.noreply.github.com>
chenmingwei23 pushed a commit that referenced this pull request Sep 30, 2026
…ist (#15339)

The Command Bar's Folders view derives its rows from the sidebar's own
`['chat-folders']` cache, but cached them under `['command-bar', 'folders', q]`
— a key outside that namespace. React-Query invalidates by key PREFIX, so the
`invalidateQueries({ queryKey: ['chat-folders'] })` that ends every folder
create, delete and update in `ChatSidebar` reached the corpus and not the rows
built from it.

`QuickSearchSurface` mounts the overlay only while the bar is open, and a
remount refetches only what is stale. A folder deleted while the bar was closed
therefore came back on the next open: listed, selectable, and carrying an id the
sidebar no longer has, so activating it asked for a reveal that silently did
nothing. The window is the view's own `staleTime`, 15s.

The key is now nested under the corpus, `['chat-folders', 'command-bar', 'view',
q]` — the shape the artifacts view in this same file already uses
(`['artifacts', 'command-bar', 'view', q]`), which is why that view has never had
this gap. Nothing reads `['chat-folders']` as a prefix except `invalidateQueries`
and `cancelQueries`; every get/set in the repo uses the exact key, so no other
reader's match changes.

Named by the Design review on #12013 and shipped unaddressed.

Co-authored-by: Leon <leon.lai.yc@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Leon <276034861+leonlaiyc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants