Repository navigation
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the 30-second window, which starts at the 5-second denial, covers a slow gateway restart; past it the link quietly falls back to a sidebar click. [DESIGN-REVIEWED] 84a3355 Description read[DESCRIPTION-READ] 46e66c181e2fa4941f8a94fcc8c2007d777ee82f6677b9531c945dedb51ccb8b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Before merge, confirm a slow gateway restart or large session restore finishes within 30 s. Nothing measured backs Not justified as shipped
What this change shipsInventory (4 items) — 3 justifiedIntent: stop a link to a missing session from pulling the user away from the session they're on when the session list arrives minutes later. FIX.
[FIRST-PRINCIPLES-REVIEWED] 84a3355 Description read[DESCRIPTION-READ] ca9d1fa9c12051c68c2de7d2cb2a4c2d1c33bbf536e3589023eade751efaa4f4 That sha256 names the PR description this verdict read. Recompute it with |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
🤖 Kiro Crew [operator: chenmingwei23#de330d0c]: This PR has been inactive for 7+ days with failing CI. I've assessed the blockers and they appear resolvable — I'll push fixes directly to this branch as a co-author. Assessment: The If you'd prefer I don't touch this PR, add the |
Expire automatic recovery after thirty seconds while still clearing a disproved not-found notice. Reconnect does not renew the recovery latch.
2035c50 to
84a3355
Compare
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
UX Review (Opus 5.5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Check this before merge: after 30 seconds the "not found" banner just disappears. Nothing tells the user that the session they linked to has since appeared. [UX-REVIEWED] 84a3355 Description read[DESCRIPTION-READ] 7ea5bcf5d0d5901c99028816070913dc48ddfb928c5e40d0c6ecd0be76cf7105 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
Thank you, @leonlaiyc, for this fix and the thorough fake-time tests. Your commit has been carried to a main-repository branch as #19296 so CI could run with full permissions. It is cherry-picked unchanged with your authorship kept in git history (plus a Closing this PR in favour of #19296. Your branch is left untouched. |
Problem / Motivation
Goal: Bound automatic denied deep-link recovery to the intended restore window.
A denied
/chat?sid=<key>recovery record can remain armed indefinitely. A much later slots or reconnect frame can navigate away from the session the user is reading or composing in. This is the expiry defect raised by the Design review on #11870 and tracked by #16504; #12026 is the existing proposed fix.Why it matters
A late slots frame can interrupt the session a user is reading or composing in.
Not a goal
No general routing redesign, new navigation UI or changes to explicit session switching.
What changed (motivation → approach → change)
Timestamp the denial in the current session controller and permit automatic activation only within thirty seconds of that denial. An expired matching frame still clears the false not-found banner, but leaves the active session alone. The existing away-and-back latch and explicit user navigation remain intact. Disconnect/reconnect does not renew the recovery timestamp.
The semantic rebase preserves current main's close-hold key guard and ChatPage owner split. The owning dashboard spec records the recovery bound. This is one logical commit on current main.
Backwards compatibility
Compatible: explicit switching and recovery inside the window still work. Automatic recovery after expiry is intentionally narrowed.
Reader: website/src/pages/chat/useChatPageSessionController.ts:deniedSidRef -- entry: chat -- expired frames clear the stale notice; explicit switchSlot is unaffected and fake-time tests cover both paths.
Tests
Current live description validated with main's PR description checker on 2026-10-04: passed.
ChatPage.sid.test.tsx: 67 passed. Fake time covers recovery inside the window, notice-only clearing outside it, reconnect without renewal, and explicit switching after expiry.Changed-file ESLint and diff checks passed. Independent GPT and Opus-contract fallback local reviews found no blockers.
Production typecheck and Vite build passed. Adjacent contracts: 7 passed, with 1 Windows path-separator failure reproduced against clean main. Documentation lint passed. The two expired/reconnect regressions fail against main and pass on this head; current-head CI supplies the wider matrix.
Manual verification
N/A — fake-time component tests deterministically reproduce the delayed slots-frame behavior.
Screenshots / video
Why no screenshot: This changes the timing of an existing navigation path without changing layout, components, styling or copy.
Related Issues
Closes #16504 — exact defect; repository triage is pending. This PR fully resolves its bounded-recovery behavior once the issue is triaged.
Provenance: Design review on #11870.
Pattern harvest
Rule candidate: review-prompt
Pattern: A retained recovery latch needs a bounded temporal predicate. An unchanged active session does not prove that a user is still waiting for a restore; test a matching frame after expiry and after reconnect.
Checklist