Skip to content

fix(git-panel): scope the filter refusal to the half it reports, and split its two causes - #12254

Merged
iamwhatever merged 1 commit into
mainfrom
fix/git-panel-filter-copy-12080
Sep 20, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/git-panel-filter-copy-12080

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The Git panel's filter-driver refusal shipped with one title and one sentence per
cause, and the UX lane on #11982 then named a different defect in that copy on
every pushed head. Eight items accumulated, all in the same string family:

  1. In the divergent state the refusal reads that changes and history cannot
    be shown while the status notice directly above it already reports the changes
    half. Reaching that state means both routes failed, so the sentence is true --
    but it is reporting on a half that is not its own.
  2. Both notices render the same Ask the agent label, so nothing says which
    failure each hand-off carries. The reports genuinely differ: each has its own
    endpoint, status and code.
  3. The two causes open on the same noun phrase (This repository's Git config)
    and are told apart only by a verb several words in, although their retry
    advice is opposite.
  4. They also share one bold headline, so a reader who reads only that line cannot
    tell the permanent condition from the one that clears itself, and a reader
    habituated to the permanent case gives up on the self-healing one.
  5. The inert refresh glyph is not distinguishable from the live one at
    size={13}: a reader shown three frames called all three crossed-out, when
    only one was.
  6. filter_refused_unreadable says checks are kept off while its refresh button
    is deliberately left live, so a reader had no idea whether pressing it would
    do anything.
  7. Both sentences say Kiro "keeps these checks off here", while the surface the
    reader is looking at is labelled Changes and Commits.
  8. The two stacked notices read as one problem said twice, because both strings
    are about reading or checking changes.

A ninth state was reachable and unreported: when one route refuses and the other
is simply healthy, the panel still coalesces and the refusal claims both
halves while the recovered route's list renders underneath it.

Why it matters

Item 1 and the ninth state are attribution failures with a visible consequence:
the panel either reports a sibling notice's failure as its own or denies a list
that is on screen, which is the same class of wrong answer as drawing a clean
badge over a status nobody read. Item 4 is the one that costs a user something
concrete -- the unreadable-config state clears by itself, and a headline shared
with the permanent state teaches people to stop waiting for it.

The rest is comprehension friction on the rarest states of the surface. The
reason they are batched is mechanical rather than editorial: every one of them
rewrites strings that exist in thirteen catalogs, and settling them one per head
re-rolls every review lane for one string. It had not converged after five
rounds. Hand-written catalog values were also #11982's measured defect source (a
Korean non-word, a malformed Bengali conjunction, Hindi spellings missing a
nukta), and writing the family once is fewer chances to produce another.

What changed (motivation → approach → change)

Symptom -- a refusal notice that claims both halves of the panel in states
where it only accounts for one.

Root cause -- scope was not modelled at all. The copy carried a fixed
"Changes and history can't be shown" clause, so every render site said the same
thing whichever routes had actually refused.

Change -- scope is now derived from the two routes' refusal flags
(gitFilterRefusalScope: both when both refuse, otherwise the one that does)
and the title carries it. Putting it on the title rather than in the body is
what keeps the body one sentence per cause: the cause clause does not vary with
scope, and a title is where a reader looks for what is unavailable. That same
move gives item 4 its home -- the unreadable titles say "right now" and the
declared ones do not, so permanence is on the bold line instead of a body-read
away. Six title keys, indexed by an as const map beside the existing
gitFilterRefusalCopyKey so every key stays a greppable literal.

With scope off the body, the two sentences were rewritten once for the remaining
editorial items: the declared one leads with Git LFS or another conversion program (item 3), and neither says "checks" any more (item 7).
refresh_unavailable follows the same vocabulary.

Those two bodies are shared, and that constrains what they may say.
gitFilterRefusalCopyKey has three rendering consumers: GitPanel, the chat
FileBrowserRail and PierreWorkspaceTreeImpl. The latter two render NO title by
deliberate design (an inline notice at rail width stacks a title into two-word
fragments), and the workspace tree has no refresh control at all. So the shared
bodies carry neither the scope clause nor any retry cue: scope is the panel's
title's job, and a cue would name a control that exists one panel over. On the
panel the invitation is still there -- the unreadable titles say "right now" and
the control beside them is live. The retry cue lives only on
status_failed_no_history, which has exactly one consumer, and whose surface's
refresh control is live whenever it renders.

That also removes an over-claim from the two title-less surfaces rather than
adding one: they show changed files and no history, so the old shared clause
"Changes and history can't be shown" was naming a half neither of them renders.

For item 2, ErrorNotice gained an optional askAgentLabel, forwarded to
AskAgentButton as an optional label; the Git panel's two notices pass labels
naming the half each carries. Item 8 is status_failed_no_history marking itself
as a separate failure, which is the lane's own proposed wording. It also carries
the retry cue, because it stated what had happened and offered no next step -- a
reader called it the one red box they would least know what to do with. The cue is
safe on that string in particular, which is why it is the only string that has it:
one consumer, it renders only in the branch where at least one route is not
refusing, and the refresh control goes inert only when both are, so refresh is
live wherever those words appear. Its sibling status_failed deliberately keeps
no cue, since there the commit list is still on screen and the sentence is about
staleness.

Item 5 is the only non-copy item. The inert button moves from opacity-40 to
opacity-60 and its glyph to strokeWidth={2.5}. That is a deliberate
deviation from the repo's dominant disabled treatment, argued in a comment at
the call site: everywhere else a disabled glyph carries no information, so the
fade IS the message and 40% costs nothing, whereas here the entire difference
between the two causes' controls is one thin diagonal that 40% erases first. It
is still weaker than the live glyph, so the text-muted hover:text-text
resting convention 78 other buttons share is untouched, and no new colour or
shape language is introduced.

All eleven translated catalogs plus the regenerated en-XA carry every value.

Backwards compatibility

Compatible. No catalog key is removed or renamed -- filter_refused,
filter_refused_unreadable, filter_refused_title, refresh_unavailable and
status_failed_no_history keep their keys with new values, and the five new
titles plus two hand-off labels are additions. askAgentLabel on ErrorNotice
and label on AskAgentButton are optional and default to the shared
components.askAgent.ask_the_agent, so the roughly eighty existing call sites
render exactly as before.

Tests

src/i18n/gitPanelRefusalCopy.test.ts (new) pins the family as STRUCTURE across
every shipped catalog rather than as literals, because the wording is allowed to
change and the relationships are what broke: the three titles of a cause are
pairwise distinct (scope is real), the declared and unreadable titles differ at
every scope (permanence is on the headline), the declared body starts with the
do-not-translate term Git LFS (it leads with its cause), and the two hand-off
labels differ from each other and from the shared one. Two more assertions guard
the sharing itself: neither shared body may name the refresh control, because two
of its three surfaces do not have one; and the six titles plus
status_failed_no_history must be referenced by no source file other than
GitPanel.tsx and gitStatusError.ts, so a future surface cannot quietly adopt a
panel-only promise. A first assertion fails if
it resolved fewer than thirteen catalogs, so it cannot pass vacuously. The rules
that cannot be expressed language-independently -- the retry cue, the panel's
vocabulary, the separate-failure marker -- are asserted on English.

src/test/GitPanel.test.tsx gains the render-level pairing: the log-side
divergence titles the refusal on history and not on both halves, the status-side
divergence titles it on changes, a refusal beside a healthy sibling names only
its own half, the unreadable cause gets its own headline, and the inert glyph
keeps its stroke weight and fade. The two existing divergent-state tests were
updated from the both-halves title to the scoped one, which is the assertion that
had been pinning the defect. The zh-CN hand-off lookup now resolves its label
through the catalog instead of a hardcoded string.

Nine mutations, each killed by the test that names the property, no survivors
(harness asserted every mutation applied and restored from a file copy taken
before the run):

mutation red test failures
scope always claims both halves both divergence tests + healthy-sibling test 3
unreadable cause reuses the declared headline unreadable-headline test 1
inert glyph loses its heavier stroke inert-glyph test 1
inert button falls back to the 40% fade inert-glyph test 1
ErrorNotice drops the per-notice label divergence test + zh-CN hand-off test 2
declared sentence stops leading with its cause leads-with-its-cause 1
unreadable sentence loses its retry cue retry-only-where-it-can-clear 1
refusal copy goes back to talking about checks changes-and-history-not-checks 1
status notice stops marking itself separate separate-failure marker 1

Green locally: GitPanel.test.tsx + the new gate (37 tests), the four other
suites that read the changed keys or props (PierreWorkspaceTreeImpl,
AskAgentButton.cov80, errorToAgent, inlineNoticeTruncate -- 132 tests), and
the whole src/i18n/ catalog gate suite (43 files, 702 tests) which owns the
thirteen changed catalogs. Also tsc -b, eslint at --max-warnings 0 on the
changed files, i18n:check, i18n:render, lint:phantom-classes, jscpd,
check_brand_name, check_comment_history, check_focus_cue, the analyze build,
check-bundle-size (697 chunks within budget) and check-chunk-cycles.

Manual verification

N/A -- these are 503-driven error notices, and the two divergent ones need a
second independent failure on the sibling route at the same moment. They are
staged through the query layer instead, both in the unit suite and in the
screenshot harness below, which drives the REAL built SPA with /api/project/git/*
answered from fixtures. The copy's cross-language relationships are verified by
the catalog gate rather than by eye.

Screenshots / video

website/scripts/capture-git-panel-refusal-scope.mjs (new, in this diff) shoots
these against the real built SPA. Ten frames cover all six title states on dark
plus the inert control on light. It asserts, per frame, that the strings the frame
is evidence for are present AND that a wider scope's title, or a cue that belongs
to another string, is absent; and for the header frames that the control's
disabled state, stroke weight and opacity class are what the diff claims. Any of
those failing exits non-zero, so a frame that disagrees with the code is never
produced -- it caught the retry cue's removal on the first run after it.

The divergent state the issue was filed for. Two notices: the outage marks itself
a separate problem and hands off "about the changes", the refusal names history
only and hands off "about the history".

Divergent state: a status outage above a log refusal, each with its own title and its own hand-off label

The same divergence on the OTHER cause, which is the pair the UX lane found
missing: "right now" instead of the permanent wording, beside a sibling notice
that owns the changes half.

Divergent state, unreadable cause: the refusal says it cannot show history right now and invites a refresh

The state no notice covered before: one route refuses while the other is healthy,
so the commit list renders underneath. The refusal names changes only, which is
what stops it denying something on screen. Both causes.

Declared refusal beside a healthy log route: the title names changes only, and the COMMITS list renders below it
Unreadable refusal beside a healthy log route: changes only, right now, with the COMMITS list below

The two causes' headers, which is the pair item 5 asked for. First: a declared
driver, refresh inert, opacity-60 and strokeWidth={2.5}. Second: an
unreadable config, refresh live at the resting convention, and a body that says
to use it. The slash reads at size={13} and the two controls are not mistakable
for each other.

Declared cause: the slashed refresh glyph beside the both-halves title
Unreadable cause: the live refresh glyph beside the right-now title

The same inert control in light theme, because the argument is about contrast
between a muted glyph and what is behind it, and a theme changes exactly that.

The inert refresh control in light theme: the slash still reads

The remaining three frames: both-halves scope per cause, and the mirror divergence

Both routes refuse on a declared driver: the only state that legitimately names both halves
Both routes refuse on an unreadable config: the right-now title and the retry cue
Mirror divergence: the status route refuses and the log route fails for its own reason, so the refusal names changes only

Related Issues

Closes #12080

Pattern harvest

Rule candidate: review-prompt

Pattern: user-facing copy that states an EFFECT ("changes and history can't be
shown") while the code path that renders it only establishes a CAUSE. The copy
then over-claims in every state where the cause holds for less than the whole
effect, and it reads as correct in the common state, so review catches it only
when someone imagines the rare one. The generalisation: when a notice names what
is unavailable, that clause belongs to whatever the renderer actually knows is
unavailable, not to the condition's worst case. Sibling instance already in this
file: the panel drops "Commit history may be out of date" exactly when the log
route has its own notice.

@chenmingwei23
chenmingwei23 requested review from a team and hoang-phan98 September 20, 2026 09:10
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of cd3b06c5aedcd2bb1936b50533cb88b80a83ad60 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

Scope nouns don't match the panel's visible labels: titles say "history" while the surviving list is headed "Commits" — the blind reader couldn't map the halves.

Watch

  • The scoped titles name halves as "changes"/"history", but the panel's section headers are "Changes" and "Commits"; the blind reader said the COMMITS list "looks like history to me… I'd have to experiment to learn which half is which" (report, "Could not tell"). Rare states × comprehension friction × every render of a scoped title. Smallest fix: filter_refused_title_history → "Kiro can't show commits…" (and ask_agent_history → "…about the commits"), binding the title to the header the user can see.

Suggestions

  • status_failed_no_history's "Refresh to try again" names no control; the reader saw two refresh-shaped affordances and couldn't tell if they retry the same thing — point the cue at the panel's refresh button (e.g. "Use the refresh button above to try again").

[UX-REVIEWED] cd3b06c

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of cd3b06c5aedcd2bb1936b50533cb88b80a83ad60 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cd3b06c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cd3b06c5aedcd2bb1936b50533cb88b80a83ad60: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 20, 2026
@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of cd3b06c5aedcd2bb1936b50533cb88b80a83ad60 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Native-speaker spot-check of the six new titles in the eleven translated catalogs — hand-written values were this family's measured defect source.

[DESIGN-REVIEWED] cd3b06c

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of cd3b06c5aedcd2bb1936b50533cb88b80a83ad60 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify on #11982/#12080 that the "reader called all three frames crossed-out" report exists — the opacity-60 deviation (item 7) is the only item whose harm rests on evidence outside this repo.

Every copy item traces to a numbered defect on the linked reviews, the fix models scope at the cause (gitFilterRefusalScope derived from the two refusal flags) rather than patching a render site, and the counts check out: gitFilterRefusalCopyKey has exactly the 3 rendering consumers the description claims (GitPanel, FileBrowserRail:544, PierreWorkspaceTreeImpl:643, grepped), the six title keys render only in GitPanel (pinned by the new confinement test), the retry cue sits on a key with 1 consumer (GitPanel.tsx:170), and the two optional label props default to the shared string so the ~80 existing AskAgentButton sites are untouched. The capture script follows the repo's established evidence convention (553 capture-*.mjs siblings) and the prior script's frames log rather than assert copy, so it is not broken by the rewrite.

What this change ships

Inventory (10 items) — 10 justified

Intent: make the Git panel's filter-refusal notices report only the failure each actually accounts for, and make the two causes and hand-offs distinguishable — a FIX.

  1. Refusal title names only the refusing half in divergent and half-healthy states — justified
  2. Unreadable-cause titles say "right now"; declared ones don't — permanence on the headline — justified
  3. The two stacked notices' Ask-the-agent buttons carry distinct labels — justified
  4. Declared body leads with "Git LFS…"; bodies stop saying "checks" — justified
  5. Shared bodies stop claiming "changes and history" on the two title-less surfaces — justified
  6. Status notice now opens "A separate problem" and says to refresh — justified
  7. Inert refresh glyph renders at opacity-60 / stroke 2.5 instead of opacity-40 — justified
  8. Optional askAgentLabel/label props, defaulting to the shared label everywhere else — justified
  9. New structure test pinning the copy family across all 13 catalogs — justified
  10. New capture script asserting the seven scoped states on real frames — justified

[FIRST-PRINCIPLES-REVIEWED] cd3b06c

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed cd3b06c5aedcd2bb1936b50533cb88b80a83ad60 — this comment is updated in place on each push.

Review details

Both candidates fail falsification.

Candidate 1 (shared body loses the consequence clause on the two title-less surfaces): the PR author deliberately restructured this — the body now carries only the cause, and "what can't be shown" moved to the title. gitStatusError.ts:49-51 documents it ("The body states the CAUSE... What cannot be shown is the title's job"), and the drift test explicitly reasons about all three surfaces including the title-less ones, keeping the retry cue and consequence out of the shared body on purpose. On the rail/tree the notice replaces an empty changes area, so surrounding context supplies the consequence. Whether the bare-cause wording reads acceptably is a copy/UX judgment, not a concrete observable failure — it does not clear the real-defect bar.

Candidate 2 (declared-cause body beside a live refresh in the partial-healthy state): the candidate itself concedes the filterRefused predicate and refreshInert formula are unchanged by this PR — pre-existing, untouched code, and a mild contradiction at most. Fails the bar.

No new grounded defect emerged from reading the changed logic; the scope resolution and the 13-catalog key additions are covered by the added tests.

No findings.

[OPUS-REVIEWED] cd3b06c

Verdict parsed from the review's SHA-scoped output markers for commit cd3b06c5aedcd2bb1936b50533cb88b80a83ad60.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cd3b06c5aedcd2bb1936b50533cb88b80a83ad60: <one-sentence reason>

@chenmingwei23
chenmingwei23 force-pushed the fix/git-panel-filter-copy-12080 branch from 59d1ae1 to a7ef1e4 Compare September 20, 2026 09:36
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 20, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/git-panel-filter-copy-12080 branch from a7ef1e4 to c6531b8 Compare September 20, 2026 09:51
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 20, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Round 1 disposition, head c6531b8701d21fb186d3523479a9c3b0f3960a0a.

UX Review, Design Review and Screenshot Evidence were all the same finding, and it is now closed. Seven frames are attached to the description as permanent assets. Both lanes said staging the refusal through the query layer was admissible, and they were right that my earlier "not captured" reasoning was wrong: the frame verifies rendering, not the query layer. website/scripts/capture-git-panel-refusal-scope.mjs in this diff produces them against the REAL built SPA and asserts per frame that the strings it is evidence for are present AND that a wider scope's title is absent, so a frame cannot silently disagree with the code.

The two frames that answer the specific asks: the divergent two-notice stack, with the scoped title and the two distinct hand-off labels composited; and the two causes' headers side by side, which is what item 5 needed, showing that the slash reads at size={13} and that the inert control is not mistakable for the live one.

Frontend Tests (1) and (2) were two real copy defects, now fixed. Worth recording how they got past a local run: frStyle and bnStyle both carry [changed-values] checks that compute the changed set from I18N_BASE_REF and SKIP when it is unset. Running the suite locally without it makes them non-discriminating, so they passed on values that were wrong. With the base ref set they fail on the original values and pass on these:

  • fr status_failed_no_history needed U+202F before the colon, not a plain space (style/fr.md section 1). It now carries the narrow no-break space.
  • bn filter_refused_unreadable, ask_agent_changes and ask_agent_history used the formal register. style/bn.md section 5 requires the informal verb forms, so all three now use them.

Frontend Coverage Merge and Coverage Gate were downstream of those two shards.

Backend Tests (Windows) (1) is main-owned, not this PR. Four test/test_acp_runtime.py kill-summary tests assert a POSIX signal returncode Windows cannot produce. That file is byte-identical to origin/main on this branch, and this diff contains no backend path at all -- it is website/src plus one website/scripts capture harness. Already tracked as #12247, so nothing is folded in here.

This head is also rebased onto current main, which had moved to Tailwind CSS v4 in #12220. The changed-file set is unchanged across the rebase and no new main commit touches any file in this diff.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 20, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/git-panel-filter-copy-12080 branch from c6531b8 to c83760a Compare September 20, 2026 10:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 20, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Round 2 disposition, head c83760ab800ece191d6885e4d479b111633cfa02.

Design Review, First Principles, GPT 5.6 and Opus 4.8 all came back clean on the previous head. UX Review was the only blocker and both of its items are now closed.

The BLOCK: two of the six title states had no frame. Correct -- the frame set reached filter_refused_title, _changes, _history and _unreadable, and never reached the unreadable cause at the two narrow scopes. The harness now shoots those two as well, so all six title states are covered by nine frames: the unreadable cause in the divergent state (history only, "right now", beside a sibling notice that owns the changes half), and the unreadable cause beside a HEALTHY log route (changes only, with the commit list rendering under it).

The Watch: status_failed_no_history stated what happened and offered no next step. Taken, with the lane's own proposed wording -- it now ends with the retry cue, in all thirteen catalogs. The cue is safe on that string specifically, and that is worth stating rather than assuming: the notice renders only in the branch where at least one route is NOT refusing, and the refresh control goes inert only when BOTH refuse, so refresh is live wherever those words appear. Its sibling status_failed deliberately keeps no cue, because there the commit list is still on screen and the sentence is about staleness rather than about something that cannot be shown.

Both halves of that are pinned, and both pins were mutation-checked. Removing the cue reddens the catalog gate and the divergent-state GitPanel test; adding a cue to status_failed reddens the catalog gate on its own assertion.

One thing worth recording about the frames, because it nearly produced dishonest evidence. The first capture run after the rebase reported every assertion passing while the build had FAILED, so it photographed the previous dist -- frames showing the copy as it was before the retry cue. Main's Tailwind v4 upgrade (#12220) was the cause: this worktree had website/node_modules symlinked from an older checkout, and that symlink SHADOWS a correct local install, because the CSS import of tailwindcss/theme.css resolves from website/ and finds Tailwind 3 first. Fixed by giving this worktree its own real install; the frames attached now come from a build that succeeded, and the assertion output shows the shipped copy including the cue.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 20, 2026
@chenmingwei23
chenmingwei23 force-pushed the fix/git-panel-filter-copy-12080 branch from c83760a to b1c1ad1 Compare September 20, 2026 10:47
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 20, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running labels Sep 20, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Round 3 disposition, head b1c1ad19ea0706b3dea862d07362a26b3d80f223.

UX flipped BLOCK to CONCERNS and Design, GPT and Opus are clean. First Principles moved PASS to CONCERNS with a finding that was right, and it is the one real defect this round.

First Principles: the shared refusal bodies reach three surfaces and I reasoned about one. Verified before acting, and the lane's grep is accurate: gitFilterRefusalCopyKey is rendered by GitPanel.tsx:149, FileBrowserRail.tsx:544 and PierreWorkspaceTreeImpl.tsx:643. The latter two render no title by deliberate design, and the workspace tree has zero refresh controls. So round 2's retry cue named a control that exists one panel over. Taken as the lane's own subtraction: the cue is out of the shared filter_refused_unreadable in all thirteen catalogs. The panel does not lose the invitation, because its unreadable titles already say "right now" and the control beside them is live; and round 2's cue was answering a confusion ("keeps these checks off" beside a live button) whose wording this PR had already removed.

The same reading resolves the other half of that finding in the opposite direction from how it reads. On those two title-less surfaces the body no longer states what became unavailable -- but the clause it lost was "Changes and history can't be shown", and neither of them renders history. So the scope clause was over-claiming there before this PR, and removing it removes an over-claim rather than creating a gap. That is now declared in the description rather than left implicit.

Two guards were added for the class, because the defect was a shared string quietly acquiring a surface-specific promise:

  • neither shared body may name the refresh control, since two of its three surfaces do not have one. This is the inverse of the assertion I had, which required the cue.
  • the six titles and status_failed_no_history must be referenced by no source file other than GitPanel.tsx and gitStatusError.ts, so a future surface cannot adopt a panel-only promise without the gate saying so. status_failed_no_history keeps its cue: one consumer, and that panel's control is live whenever it renders.

The capture harness caught the change on its first run after it -- it had been using the cue as its marker for the unreadable cause and failed two assertions, which is what it is for. Its marker is now the cause sentence, and a new assertion pins that the cue is ABSENT from a frame whose only notice is the refusal.

UX's light-theme gap: taken. A tenth frame shoots the inert control in light theme. The item 5 argument is about contrast between a muted glyph and what sits behind it, and a theme changes exactly that, so one theme was half an answer. The slash reads on both.

UX's noun-binding suggestion: not taken here, and worth saying why rather than going quiet on it. The proposal is to move the six titles from "changes"/"history" to "the changes list"/"commit history" so the nouns name something visible. The panel's own visible section labels are Changes and Commits, so neither the current nouns nor the proposed ones bind to a label exactly; "commit history" would name a thing the panel does not label at all. Set against that, it is a rewrite of six titles across thirteen catalogs, and hand-written catalog values are this family's measured defect source -- two of them bit this PR on its first CI round. I would rather not spend that risk on a swap that does not clearly land, and the lane rates it comprehension friction on the rarest state under an advisory verdict. If a maintainer wants the swap, it is mechanical from here and I will do it.

Backend Tests (Windows) (1) remains main-owned #12247, unchanged from round 1: test/test_acp_runtime.py is byte-identical to origin/main on this branch and this diff contains no backend path.

@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Round 4 disposition, head b1c1ad19ea0706b3dea862d07362a26b3d80f223. Every blocking lane is now clean: Design PASS, First Principles PASS, GPT 5.6 and Opus 4.8 no findings. UX is CONCERNS, which is advisory, and this is a reply rather than a new head. That is a deliberate stopping point, not a shrug: these lanes re-sample on every pushed head, so a fourth head to reword copy spends four clean verdicts on friction findings, and the PASS from First Principles above was itself earned by a round that a re-roll would discard. Each item is dispositioned below.

Opposing retry advice on one screen. Real observation, and mine: the cue I added to status_failed_no_history last round sits above the declared refusal's "Retrying won't help." on one screen. Each sentence is true of its own failure -- the status read can be retried, the config refusal cannot -- so this is an attribution problem rather than a contradiction, which is the same class the titles now fix. The lane's smallest fix is sound ("Refresh to retry the changes list"), and scoping the cue the way the title is scoped is the consistent answer. I am leaving it for a maintainer to call rather than spending a head on it, because the alternative reading is also defensible: the notice already opens "A separate problem:", which is exactly the marker that tells a reader the two sentences belong to different failures.

Titles say "history" while the section is headed Commits. Re-raised, and I under-weighted it last round: I argued "commit history" names nothing the panel labels, and the better argument is the lane's -- the panel already uses that exact term in status_failed ("Commit history may be out of date") and "the changes list" in status_failed_no_history, so both nouns bind to the panel's own shipped prose even where a section header is absent. That is the state the reader tripped on: when the refusal names changes, the Changes section is not rendered, so the noun has nothing on screen to bind to and the Commits list below looks like a contradiction. The swap is six titles across thirteen catalogs. Mechanical, and I will do it on request; not worth a self-initiated re-roll of four clean lanes while the finding is advisory.

Hand-off labels differ only in their last word. Agreed as a reading; same disposition. Front-loading them ("Ask about the changes list" / "Ask about the commit history") would also make the two labels carry the same vocabulary as the retitled headings, so it belongs in the same pass as the item above rather than on its own.

No screenshot of the rail or the workspace tree. The lane calls this verification rather than a gap, which is right -- the exact strings are evidenced in the panel frames, and the round-3 guards pin what those surfaces may receive: neither shared body may name a control, and the panel-only strings cannot be referenced outside GitPanel.tsx and gitStatusError.ts. #11982 already carries capture-git-filter-refusal-surfaces.mjs for exactly those two surfaces, so a frame is available; it needs a vite dev server rather than the built-SPA harness the other ten frames use, which is why it is not in this set.

To be explicit about what I am not doing: I am not asking for an override, and nothing here is being dismissed as a false positive. Three of the four are edits I would make and would defend; the reason they are not in this head is the cost of re-rolling verdicts that are already clean, on findings the lane itself rates as friction on the rarest state of the surface.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 20, 2026
…split its two causes

The Git panel's filter-driver refusal rendered one title and one sentence for
every state it can be in. Three of those states are not about both halves: the
status route can fail on its own terms while the log route refuses, the log
route can do the same, and a recovered route leaves the other's cached refusal
standing while its list renders underneath. In all three the refusal claimed
that changes AND history could not be shown, so it either reported a sibling
notice's failure as its own or denied a list that was on screen.

Scope now comes from which routes are actually refusing, and the title carries
it. The title also carries permanence, so a reader who reads only the bold line
gets the right one of the two causes: a declared driver stands while the repo
config does, an unreadable config can clear by itself and its sentence says to
refresh. The declared sentence leads with Git LFS rather than with the Git
config that both causes name. Neither sentence says "checks" any more, because
the surface in front of the reader is labelled Changes and Commits. In the
divergent state the two stacked hand-offs name the half each one carries, and
the status notice marks itself as a separate failure. The inert refresh glyph
keeps the slash that distinguishes it legible at the size the header renders it.

All eleven values plus the pseudolocale are updated for every string in the
family, in one pass rather than one per review round.

Closes #12080
@chenmingwei23
chenmingwei23 force-pushed the fix/git-panel-filter-copy-12080 branch from b1c1ad1 to cd3b06c Compare September 20, 2026 11:09
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Round 5, head cd3b06c5aedcd2bb1936b50533cb88b80a83ad60. The previous round finished terminal with 78 passing lanes and exactly one failure, Backend Tests (Windows) (1), which I had been reporting as main-owned #12247 since round 1. That was right at the time and is now out of date: the fix landed.

#12247 is CLOSED COMPLETED and its fix is #12269, merged as 954fb69185, which is origin/main's tip. It was not an ancestor of my head, so my run tested main WITHOUT it. Its own commit message names my four failures exactly -- "four existing assertions about the post-reap status failed on the Windows shard alone: the double disagreeing with the code rather than the code being wrong. The stand-in now drains the way the real one does" -- and the assertion text it quotes is byte-for-byte the one on my shard.

A pull_request run pins the merge ref at event time, so a re-run would have replayed the same base and failed identically; only a new head picks the fix up. This head is that rebase and nothing else: the changed-file set hashes identically before and after, no main commit since my previous base touches any file in this diff, and 954fb69185 is now an ancestor. The six directly affected test files still pass locally with the base ref set.

The still-open #12271 targets the same defect with the same quoted assertion. #12269 having merged appears to make it redundant, but that is its author's call, not mine, and nothing here depends on it.

Round 4's dispositions stand unchanged: every blocking lane was clean at the previous head, and the four advisory UX items are answered in the comment above rather than in this head. This rebase is not a response to any of them -- it is the only action that could clear the last blocking red.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 20, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the current head: CI green, readiness passed, no security-sensitive path in the diff.

@iamwhatever
iamwhatever merged commit 46313ef into main Sep 20, 2026
93 checks passed
@iamwhatever
iamwhatever deleted the fix/git-panel-filter-copy-12080 branch September 20, 2026 17:05
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 20, 2026
amadsalmon pushed a commit to amadsalmon/KiroCrew that referenced this pull request Sep 22, 2026
…split its two causes (kirodotdev#12254)

The Git panel's filter-driver refusal rendered one title and one sentence for
every state it can be in. Three of those states are not about both halves: the
status route can fail on its own terms while the log route refuses, the log
route can do the same, and a recovered route leaves the other's cached refusal
standing while its list renders underneath. In all three the refusal claimed
that changes AND history could not be shown, so it either reported a sibling
notice's failure as its own or denied a list that was on screen.

Scope now comes from which routes are actually refusing, and the title carries
it. The title also carries permanence, so a reader who reads only the bold line
gets the right one of the two causes: a declared driver stands while the repo
config does, an unreadable config can clear by itself and its sentence says to
refresh. The declared sentence leads with Git LFS rather than with the Git
config that both causes name. Neither sentence says "checks" any more, because
the surface in front of the reader is labelled Changes and Commits. In the
divergent state the two stacked hand-offs name the half each one carries, and
the status notice marks itself as a separate failure. The inert refresh glyph
keeps the slash that distinguishes it legible at the size the header renders it.

All eleven values plus the pseudolocale are updated for every string in the
family, in one pass rather than one per review round.

Closes kirodotdev#12080
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

git-panel: the filter-refusal copy over-claims its scope in the divergent state, and its two causes open on the same words

2 participants