Repository navigation
revert: drop the git working-tree badge from the composer footer - #12273
Conversation
|
Intent: Remove the composer footer's git working-tree badge, so the Git panel is the one place that reports working-tree state. |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Removal cites "requested directly by the maintainer" with no linked issue — confirm that authorization exists before merging a feature deletion. [DESIGN-REVIEWED] 3506e35 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ human override accepted@bolichen97 overrode this lane for |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Confirm the Git panel is still reachable at 390px, since after removal it is the only working-tree signal on narrow viewports. [UX-REVIEWED] 3506e35 |
|
self-added: no
|
|
self-added: no
|
|
Four Evidence this PR cannot be the cause:
No rerun: the shard cannot pass on any head until one of the three fixes merges. Not folding an unrelated ACP fix into a frontend deletion. |
The composer footer carried a second, smaller copy of the Git panel: a changed-file count and ahead/behind arrows beside the branch name. It was a passive readout with no action, it repeated what the Git panel already shows in full, and it put a number next to the branch label that reads as a claim about the tree the moment it goes stale. Removing it takes out the badge markup, its tooltip builder and its four props from ChatInput, plus the ChatPage query that fed it: a ['git-status', dir] observer on a 60s interval with a running-to-idle invalidation, which existed only for the badge. The Git panel keeps its own fetch on the same key, so nothing else loses data, and a project with no panel open no longer polls git status at all. The badge's own test file and its screenshot harness go with it. The dashboard spec's sentence about the footer badge being the silent ['git-status', ...] consumer is rewritten to the two consumers that remain, and the sibling capture script no longer points at a script that does not exist.
c18bbbe to
3506e35
Compare
|
Rebased: The patch itself is unchanged -- Also on the previous head, Still blocked on the First Principles lane, which needs a maintainer override on the new head sha. |
|
|
|
/ai-review override first-principles 3506e35: maintainer decision: the badge duplicates the Git panel and crushes the session labels at 390px |
Human judgment recorded@bolichen97 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
…odotdev#12273) The composer footer carried a second, smaller copy of the Git panel: a changed-file count and ahead/behind arrows beside the branch name. It was a passive readout with no action, it repeated what the Git panel already shows in full, and it put a number next to the branch label that reads as a claim about the tree the moment it goes stale. Removing it takes out the badge markup, its tooltip builder and its four props from ChatInput, plus the ChatPage query that fed it: a ['git-status', dir] observer on a 60s interval with a running-to-idle invalidation, which existed only for the badge. The Git panel keeps its own fetch on the same key, so nothing else loses data, and a project with no panel open no longer polls git status at all. The badge's own test file and its screenshot harness go with it. The dashboard spec's sentence about the footer badge being the silent ['git-status', ...] consumer is rewritten to the two consumers that remain, and the sibling capture script no longer points at a script that does not exist.
Problem / Motivation
The message box's bottom row carried a small git readout beside the branch
name: a changed-file count in a yellow pill, then
↑1 ↓2for commits ahead andbehind. It was not a button. Clicking it did nothing. It said a shorter version
of what the Git panel already says in full, one click away in the sidebar.
Why it matters
A number beside the branch label reads as a fact about your working tree. This
one was fetched every 60 seconds, so between fetches it was a guess. The panel
it copied is the same data, complete, with the file names. Two places showing
one truth means one of them is wrong at any moment, and the smaller one is the
one with no file names to check it against.
It also cost the row its labels on a phone. At 390px the badge pushed the three
chips beside it down to
k…,d…andm…; without it the same row readskiro…,demo-s…,main…. The badge's own comment said it stayed at narrowwidths on purpose, because it was then the only tree-state signal. The Git panel
is that signal, and it was before this badge existed.
What changed (motivation → approach → change)
website/src/components/ChatInput.tsxwebsite/src/pages/ChatPage.tsxwebsite/src/test/,website/scripts/The badge was one
<span role="status">plus auseMemothat built itstooltip. Both are deleted, along with
projectGitDirty,projectGitDirtyTruncated,projectGitAheadandprojectGitBehind, and thenow-unused
FileDifficon import.ChatPagefed it from a['git-status', dir]query on a 60-second interval,plus an effect that refetched when the agent stopped running. Nothing else read
that query's result, so it goes too. The Git panel owns its own fetch on the
same key, so the panel loses nothing. A project with the panel closed now makes
no git status request at all.
Two files mentioned the badge and had to stop. The dashboard spec said the
footer badge was the silent one of three
['git-status', …]consumers; thereare two consumers now, and the sentence says so. A sibling capture script
pointed readers at the harness this change deletes, so that pointer is gone.
The Git panel, the branch label, the folder chip and the context readout are
all untouched.
Backwards compatibility
Compatible: nothing accepts less than before. The removed props were internal
to two components in this repo, the API routes are unchanged, and no setting
turned the badge on or off.
Tests
No new tests. The change removes a component and its only test file
(
ChatInput.gitBadge.test.tsx, which asserted the badge's segments, tooltip andhidden-when-clean behaviour). The frontend suite's other
ChatInputtests andthe
GitPaneltests run unchanged and cover what is left.Manual verification
Both frames below come from the badge's own screenshot harness, run against the
real built dashboard with the git endpoints fixtured to 3 uncommitted files, 1
ahead and 2 behind — the exact input the badge existed to render. On this branch
the harness finds zero elements matching the badge, in dark, in light, and at
390px. The
mainframes are the same harness onorigin/main, which finds one.Screenshots / video
Before, on
main—mainline · [3] ↑1 ↓2:After, on this branch — the branch name, nothing after it:
At 390px the badge was taking the room the labels needed. Before, then after:
Light theme, and the full composer with the Git panel open
Related Issues
no linked issue: removal requested directly by the maintainer.
Pattern harvest
Rule candidate: review-prompt
Pattern: a second, smaller copy of an existing panel's data, added as a passive
readout with no action, which restates the panel and goes stale on its own
interval.
Checklist
feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)