Skip to content

feat(members): a Deploy my crew panel, read-only and crew-wide - #12400

Merged
iamwhatever merged 1 commit into
mainfrom
feat/deploy-my-crew
Sep 21, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/deploy-my-crew

Conversation

@chenmingwei23

@chenmingwei23 chenmingwei23 commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

A crew's cloud deployment state is reachable only by hunting through the
Settings tab that owns the whole set-up flow, and the first cut of a Members
page panel for it answered the wrong question. It listed launch records with
their stack tag, provisioner chip, raw status enum and SSM target, behind an
icon-only cloud button nobody could name. A reader who opened it could not
tell whether their crew was deployed or what to do next, and its title
promised an action ("Deploy my crew") that the panel did not offer.

The question a crew owner brings to this panel is plain: is my crew deployed,
is it still being set up, and what is the one thing I should do now?

Why it matters

The Members page is where an owner meets their crew as people, not as launch
jobs. If the one surface that says "your crew now runs somewhere other than
this computer" reads like a CloudFormation console, the feature is invisible
to exactly the people it exists for, and a reader who does find it either
waits on a launch that is waiting on them, or copies an identifier they do not
know where to paste. A panel that names the state in one sentence and offers
one action per state turns "deploy my crew" from a Settings expedition into a
button.

What changed (motivation -> approach -> change)

Goal: persona first, plain language, one obvious next step per state, and
technical identifiers demoted rather than deleted.

Approach: the panel leads with the crew's faces (the roster, rendered through
the existing CrewAvatar, folded into a "+N" tile past six), then one
sentence for the state the NEWEST launch is in, then the one thing a reader
can do about it. Every action is a navigation into Settings > Remote Instances,
which owns creating, repairing and tearing down a launch; the panel never
writes. Crew-WIDE, not per-member: a launch ships the whole local checkout to
one machine and names one stack, so the trigger stays in the page header and
the faces are the whole roster.

The five states, from deployView(jobs), an exported pure function:

newest launch sentence the action offered (Details and Close are always present)
none Right now your crew runs only on this computer. Open Remote Instances in Settings (under it: nothing is created until you confirm the steps there)
pending / running Deploying your crew... Step N of M, then the name of the step under way. Closing this window does not stop the deploy. Open Remote Instances in Settings (a muted link; nothing here acts on the launch); the list is re-read every 4 s while a launch moves
awaiting_signin Your crew is waiting for you to sign in. Closing this window does not stop the deploy. Open Remote Instances in Settings to sign in
done, machine still registered Your crew is deployed in the cloud. + two numbers + the Session Manager target (EC2 lane only) Copy the target
done, machine not registered A deploy finished N ago in REGION. + either "Its machine is no longer in your instances list." or "This page cannot tell whether it is still running." with a link to that region's console Open Remote Instances in Settings when the registry no longer holds the machine; nothing when it cannot say
failed / cancelled The last deploy did not finish. + the recorded error Open Remote Instances in Settings (same line under it)

awaiting_signin is split from the other moving statuses on purpose: waiting
achieves nothing there, because the launch is waiting on the user.

The two buttons name what they do, not the outcome a reader wants. Both only
open Settings, and a first-time reader who takes a "Deploy to the cloud"
button for the act itself (something created outside this computer, possibly
costing money, with no visible undo) does not press it, so the panel's whole
point fails on the state every first-time reader lands on. The labels name
the navigation and the real destination, the Settings page called Remote
Instances (which opens on its Your crews tab): "Open Remote Instances in
Settings" and "Open Remote Instances in Settings to sign in". Every pointer
on the card names that page by that one name, so three doors do not read as
three places. A muted line under the deploy button says the one thing the
label cannot:
"Nothing is created until you confirm the steps there." Every other button on
the card was checked against its handler the same way: Copy copies, Try again
re-reads, Close closes, Details toggles. While a launch is moving or waiting
on the sign-in, a line says closing the window does not stop the deploy: the
work runs in the gateway, not in the dialog, and a reader who fears Close
cancels it would otherwise babysit the window. The moving state also
carries one muted link, "Open Remote Instances in Settings", into the page
whose launch row carries the Cancel, so a reader told that nothing here
stops the deploy is not left with no idea where anything would; the panel
itself still acts on nothing. The step counter names the
step under way in the gateway's own words ("Step 2 of 4 - Create the instance
and install Kiro Crew"), so the count is not a bare number.

Honest numbers only. No duration estimate is shown while a launch moves:
nothing in the repo measures a typical launch, and a figure nothing attests
is not shown here; the step counter is the progress. The deployed state shows
two: the time since the launch
was created (labelled "Since deploy", because nothing here can see whether the
machine ran the whole time) and its region. Both come off the launch record.
Sessions running on the deployment and turns it served are deliberately
absent: the deployed side has no counter and no path to report back, and the
local activity log counts the LOCAL crew, so its numbers here would state a
scope the data does not have. Month-to-date spend was measured and dropped:
the costs route belongs to the aws-control app, which is off by default, and a
launch record carries a profile and a region but no account id to key it by.
An unknown value renders as an en dash, never 0, matching the member stat
cards.

Errors go through ErrorNotice with askAgent on, and a hand-off that closes
the dialog first: a failed launch list read, and a failed launch's recorded
error. Both are read surfaces with nothing to lose.

The target row. A Session Manager target is offered only for a finished launch
on the built-in EC2 provisioner that kept a machine, with one line saying what
the value is for ("Paste this ID into AWS Session Manager (in the AWS console)
to open a terminal on the machine"). The Fargate lane records the task's ARN in
the same instance_id field, and Session Manager does not accept an ARN, so a
finished Fargate launch gets no row and, where the row would be, one muted
line: "That deploy was a container task, not a machine, so it has no Session
Manager target. Its task ID is in Details." That sentence is keyed on the
Fargate provisioner id
(deployRunsAsTask), not on "anything but EC2": a provisioner this panel does
not know is drawn verbatim in Details and gets no sentence, and an EC2 launch
that recorded no machine gets no row and no sentence either. A failed or
cancelled launch that still carries an instance_id is never offered as
reachable (deployIsReachable).

Copying the target reports its own failure. When both clipboard layers refuse
(the async API rejects and execCommand answers false, the everyday shape of
a plain-HTTP LAN dashboard), the row says "Copy failed. Select the text and
copy it manually." instead of painting a tick over an unchanged clipboard, and
the target stays readable for that manual copy. The notice carries the agent
hand-off: nothing on the row is unsaved, so the hand-off can destroy nothing,
and the agent has a remedy the message does not (read the id off the launch
record and open the session itself). The dialog closes first, as for the
panel's other notices. The failure sentence is the one the Settings panel's
own copy button already uses.

Technical identifiers (stack tag, provisioner id, raw status, profile, region,
instance id) survive in a collapsed Details line, one per launch, newest first.
The provisioner id is drawn verbatim there, which retires the client-side
label map; the lint exemption that once served its literals had already left
main independently, so this diff does not touch the lint config. The raw
status token is deliberate in that line: it is the name the gateway logs use,
and the sentence above is the plain-language version.

The header trigger is a labelled control (a plain cloud glyph + "Cloud")
rather than an icon alone, with a hairline border in the secondary button
style: an icon-plus-word beside the page title with no edge reads as a status
chip, and this is the feature's only entry. The glyph is the plain cloud, not
the upload arrow: an arrow into a cloud reads as "send something up", and a
reader who takes the button for an action never opens the read-only panel. The dialog is titled by state ("Your crew in
the cloud") rather than by an action it delegates.

The in-flight status list lives once: IN_FLIGHT_LAUNCH_STATUSES and
launchIsInFlight in utils/remoteCrew.ts, beside the provisioner ids, and
both this panel and the remote-crew Settings panel classify a launch through
it, so a status the gateway adds is classified in one place. It lives there
rather than on the API client because most test files replace that module
with a hand-written mock (an earlier attempt to export it from api/client
reddened 105 tests for exactly that reason); utils/remoteCrew.ts is mocked
by none of them, and the three RemoteCrewPanel suites pass unchanged.
Declared plainly, since it reaches outside the panel: utils/remoteCrew.ts
gains FARGATE_PROVISIONER_ID (mirroring the gateway's id beside the EC2 one
already there) and the status set behind launchIsInFlight (the set itself
is not exported: the predicate is the one spelling); RemoteCrewPanel.tsx drops its
private IN_PROGRESS list and calls launchIsInFlight instead (+6/-5). Each
has two consumers, this panel and the Settings panel; the classification is
unchanged, so this is a harm-free dedupe riding along, not a behaviour change.

"Deployed" is said only while the Instances registry still holds the machine.
The launch record cannot carry that claim by itself: a Settings delete
(_teardown_after_delete in handlers_cloud.py) waits for AWS to confirm the
stack is gone, then unregisters the instance and removes the uploaded source,
and nothing in the gateway ever re-statuses the done launch record, so on
the record alone the panel would read "is deployed" forever after the one
action its own button leads to. The registry is the field a teardown does
update, and the EC2 launcher registers the instance (its id as the SSM
target) as a hard condition of done, so for that lane "registered" and
"exists" move together. The panel therefore reads GET /api/instances too
(api.listInstances, under the same ['instances'] query key the Settings
panels use, so both read one cache entry), only once some launch has
finished, and a 403 (the Instances feature is off) is not retried.
deployLiveness answers live / gone / unknown, and deployView says
"Your crew is deployed in the cloud." only for live. Anything else a done
record supports is a past event, and the new finished state says it in the
past tense: "A deploy finished ago in ." followed by either
"Its machine is no longer in your instances list." (gone: the registry was
read and does not hold it; the set-up button and its line follow, as with no
launch at all) or "This page cannot tell whether it is still running."
(unknown: the Fargate lane registers nothing by design, an EC2 record that
kept no machine, or the registry could not be read) with one line pointing
at the AWS console in that region; that line is itself a link to the
region's console home when the record's region parses as a region id
(awsConsoleUrl; the value comes off a stored record and becomes a
hostname, so anything else gets plain words and no link). Neither form ever says the crew is
deployed, and neither says it is not; the two stats and the target row are
shown only in the live state. Unknown is never rounded to either answer,
because both roundings put a false sentence about a paying machine on the
screen. The panel stays in its loading state until both reads have answered,
so a finished launch is not drawn as unconfirmed and then as deployed. A
failure of the registry read other than a 403 is an error, not a fact about
the machine: it renders through the same ErrorNotice (with the agent
hand-off) and Try again as a failed launch read, Try again re-reads the read
that failed, and no state is drawn behind it.

The headline follows the newest launch, and one line names what that would
otherwise bury. Another launch whose machine the registry still holds keeps
running (and billing) behind a failed retry, a launch still moving, a finish
the registry cannot vouch for, or a re-deploy that finished, since nothing in
the launch flow tears an earlier stack down; so a line under the state reads
"An earlier deploy is still running in . You can delete it under
Remote Instances in Settings; its identifiers are in Details."
(earlierReachableLaunch), under the deployed headline as much as under the
others, since that is the headline a reader has least reason to look past.
The line requires the registry's word: a done record it does not hold or
cannot speak to is not named, because the line's whole claim is that a
machine is running now; and an older record of the newest launch's own
machine is not named either, since two records of one machine are one
machine. It ends with where to act, because a warning about a paying machine
with no way to stop it only frightens.

The feature-map row takes the shape of its neighbours: one sentence on what
the surface is for a user, the entry point, the files and the endpoints. It
narrates no mechanism (no state list, no failure path, no "what Try again
re-reads"): every such sentence is made false by the next change to the code
it describes, while a row that states what the feature is stays true across
them. The panel's behaviour is specified by the header comment of
DeployMyCrew.tsx and pinned by its tests.

Catalogs: 28 keys added across all 13 languages plus the regenerated
pseudo-locale. Hindi and Bengali use the informal register the style gates
require, and French carries U+202F before its double punctuation. With them the all-catalog chunk measures 12281.1 KB, inside the
12870 KB ceiling the bundle-size gate already carries on main (main measured
12254.6 KB there at 34fe0de), so the gate file is byte-identical to main.

Backwards compatibility

Compatible: one labelled button and one dialog on an existing page; no route,
endpoint, schema or default changes. The panel is read-only, so no write path
exists to be compatible with. A launch record from an older gateway (empty
steps, no provider_id) renders: the step total falls back to the four
steps every launch has, and a record with no provisioner id is treated as EC2,
the only kind that predates the field. A provisioner id the panel does not
know is drawn verbatim in Details and gets neither the target row nor the
container-task sentence.

Tests

website/src/pages/members/DeployMyCrew.test.tsx (65 cases, 98.9% of the
component's lines). Each behaviour below was mutation-checked: the named
change to the source reddens the suite, and the un-mutated suite is green.

  • deployIsReachable: true only for done with a machine; false for every
    in-flight status, for done with no machine, and for failed/cancelled
    even when the fixture still carries an instance_id. Mutation: dropping the
    status check reddens 2 tests.
  • The target row is EC2-only: a finished Fargate launch whose instance_id
    is a task ARN renders as finished (past tense, no claim about now) with no
    target row, no stats, the console pointer, and the ARN in Details.
    Mutation: dropping the provisioner gate reddens the suite.
  • deployLiveness: live only when the registry holds the finished EC2
    machine (by SSM target, or by host on a legacy row); gone when the registry
    was read and does not; unknown for an unreadable registry, for the Fargate
    lane, for an EC2 record with no machine, and for a launch that is not done.
    Panel: a registry without the machine renders the gone sentence with the
    set-up button; a 403 renders the unknown sentence with the console pointer
    and is not retried (one call); a 500 renders the read error with the
    hand-off and Try again, no state behind it, and Try again re-reads the
    registry (the launch list is not re-read); a running launch reads the
    registry not at all. Mutations: letting the record alone earn "deployed"
    reddens 6 tests; rounding an unreadable registry to gone reddens 3;
    rendering a failed registry read as the unknown state reddens 1.
  • deployRunsAsTask: true for the Fargate id only; false for EC2, for a
    record with no provisioner id, and for an unknown provisioner. The
    container-task sentence renders for the Fargate launch, and not for an EC2
    launch with a row, nor for an EC2 launch that recorded no machine.
    Mutations: dropping the gate reddens 2 tests; widening the predicate back to
    "anything but EC2" reddens 2.
  • awsConsoleUrl: the region's console home for a region id (us-east-1,
    ap-southeast-2, us-gov-west-1); undefined for a missing region, a
    half-id, upper case, a hostname or anything carrying a path or query.
    Panel: the console sentence is a _blank/noreferrer link to that URL
    on the Fargate launch, and plain words with no link when the record has
    no region. The URL is built with the URL API from one whole-URL literal,
    so the i18n strings gate (which reads each template fragment alone) sees
    a URL rather than a bare host fragment; the link keeps its underline and
    carries an external-link glyph, so it reads as a door without hovering.
  • The deploying state's one control is the muted "Open Remote Instances in
    Settings" link; no deploy button, no sign-in button, no target row.
  • newestLaunch picks by created_at, not list order. Mutation: jobs[0]
    reddens 2 tests.
  • earlierReachableLaunch: the newest other launch whose machine the
    registry still holds, under any headline: behind a failed retry, behind a
    newer Fargate launch the registry cannot confirm, and behind a live newest
    launch on another machine; undefined when no other launch is confirmed
    live (torn down, or the registry unreadable) and for an older record of the
    newest launch's own machine. The line renders behind a failed retry with
    the earlier region and the delete path, under the deployed headline with
    the target row still the newest machine's, and never behind a retry whose
    earlier machine the registry no longer holds. Mutations: falling back to
    the record reddens 2 tests; silencing the line under a live newest reddens
    2; dropping the same-machine guard reddens 2; never rendering the line
    reddens 1.
  • deployView: none / deploying / signin / deployed / finished / failed;
    deployed only with the registry's word, else finished with gone or unknown;
    awaiting_signin is signin, not deploying; with an older finished launch and a newer failed
    one, the panel describes the failed one. Mutations: folding signin into
    deploying reddens 2 tests; picking the oldest launch reddens 1.
  • deployProgress: finished steps plus the one under way, over the recorded
    total; empty steps fall back to four; never past the total.
  • deployStepLabel: the step marked active, else the first not done, else
    empty for a record with no steps; a skipped step before the active one does
    not win. Mutations: silencing the label reddens 1 test; dropping the active
    preference reddens 1.
  • deployAge: en dash for a missing or future timestamp; day/hour,
    hour/minute and minute bands; a zero part is dropped. Mutation: rendering a
    future timestamp as an age reddens 1 test.
  • The panel tells a failed read apart from "runs only here": the read error
    renders through ErrorNotice (role="alert") with a Retry, and the
    not-deployed sentence is absent.
  • Each state renders its one action and no other: the deploy and sign-in
    buttons call navigate('/settings/instances') and close the dialog first
    (mutation: leaving it open reddens 3 tests); deploying offers nothing to
    press.
  • Both Settings buttons name Settings in their label, and the cost/undo line
    accompanies the deploy button in the not-deployed and the failed state.
    Mutation: silencing the line reddens 2 tests.
  • While a launch is moving the list is re-read after 4 s and not once it has
    settled (fake timers), the close line and the step's name are shown, and no
    duration estimate is; the sign-in state shows the close line too.
    Mutations: removing the interval reddens 1 test; silencing the close line
    reddens 1; putting a minutes line back reddens 1.
  • Deployed: region and age are shown, the target is copyable (clipboard
    stubbed) and the button flips to Copied with no failure notice, the Details
    disclosure is closed and carries the raw provisioner id and tag; a missing
    region is the en dash; a finished launch with no machine offers no target.
  • Copy failure: with the async clipboard rejecting and execCommand answering
    false, the failure notice renders with the agent hand-off, Copied is never
    painted, and the target text is still on the page. Mutations: silencing the
    failure branch, painting Copied regardless, and dropping the hand-off each
    redden the suite.
  • Failed: the recorded error renders through ErrorNotice (mutation: a
    hand-written text-danger div reddens 2 tests), no target is offered, the
    deploy button navigates; a cancelled launch with no error renders no notice.
  • Faces: six drawn and "+3" for a roster of nine (mutation: never folding
    reddens 1 test); no face row for an empty roster.
  • No launch read is made while the dialog is closed.

Also run locally on the final tree: tsc -b (0 errors), eslint on the changed
source files, the i18n vitest suites with I18N_BASE_REF=origin/main (43
files, 703 tests, including every language style gate's changed-values arm,
the dead-key ratchet and the context sidecar; without the base ref those
arms see no changed values and pass vacuously), check-i18n-strings.mjs
with the same base ref, check-i18n-keys.mjs, check-theme-colors.mjs,
check-phantom-classes.mjs, the bundle-size gate on an analyze build (697
chunks within budget), the feature-map gate enforced against origin/main,
and the RemoteCrewPanel and MembersPage suites.

Manual verification

Performed against the built SPA, not a live gateway. The capture harness
(website/scripts/capture-deploy-my-crew.mjs) serves website/dist through
the repo's shared loopback static server with every /api/** call answered
from fixtures (no gateway, no AWS), drives the real Members page, and asserts
each claim before it writes a frame: the trigger's label and visible border,
the one sentence per state, the single action and the absence of any other
(the moving state's only control being the link into Settings),
both Settings buttons' labels, the cost/undo line under the deploy button and
its position below it, the close hint and the absence of any estimate while deploying, the EC2-only target
row with the reworded hint (with the machine registered in the stubbed
registry), the Fargate launch's past-tense finished sentence, its
container-task line and console pointer with its ARN confined to Details, the
failed copy's notice with its hand-off and no Copied, the landed copy's
Copied with no notice, the read error's Retry, the earlier-launch line with
its delete path behind a failed retry (and its absence when the newest launch
is live), the gone sentence with the set-up button when the registry no
longer holds the machine, the unknown sentence with the console pointer and
no deploy button when the registry answers 403 (the console sentence linking
to that region's console on both), the earlier-launch line
under the deployed headline when a second machine is registered (the target
row still the newest machine's), and the read error with the hand-off and
Try again, no state behind it, when the registry answers 500. 20 frames,
every assertion green.

Not exercised here: a launch record produced by a live gateway, a real
teardown (the gone state rests on _teardown_after_delete removing the
registry row, which the fixture mirrors by answering an empty registry), a
real Fargate launch (the container-task sentence rests on the provisioner
writing the task ARN into instance_id, which the fixture mirrors), and the
browser's real clipboard permission prompt. The pod route refuses the pod's token mint with
403 on every start from this sandbox, including fresh ones on the rebased
tree, so no frame comes from a running gateway.

Screenshots / video

From the harness above, dark theme unless named. Fixture data throughout
(fake instance and task ids, default profile).

Header trigger, labelled Cloud, with its border:

The Members page header with the bordered Cloud button and its plain cloud glyph

Not deployed, one action named for what it does:

Faces, the runs-only-here sentence, the Open Remote Instances in Settings button, and the line saying nothing is created until the steps there are confirmed

Deploying, the step under way named, nothing to press, and Close does not cancel:

Step 2 of 4 with the step's name, the close line, and the muted Open Remote Instances in Settings link

Waiting on the sign-in, one action:

The sign-in sentence, the Open Remote Instances in Settings to sign in button, and the close line

Deployed on EC2, dark and light:

Since deploy, Region, the Session Manager target with Copy and the reworded hint, Details collapsed

The same deployed state in the light theme

Details opened, identifiers one line per launch:

Details expanded showing tag, provisioner id, raw status, profile, region and instance id

Finished on Fargate, said in the past tense, the container-task line and the console link where the row would be:

A deploy finished 2d 5h ago in us-east-1, this page cannot tell whether it is still running, the container-task line, the underlined console link, and the task ARN in Details

Failed, the recorded error, the Settings button and its line:

The last deploy did not finish, the error through ErrorNotice, Open Remote Instances in Settings and the cost/undo line

The list is still being read:

Reading your deployments, no state yet

The list could not be read:

Could not read your deployments with a Try again button

The copy failed:

Copy failed. Select the text and copy it manually. with Ask the agent, under the still-readable target, no Copied

A failed retry over an earlier launch that still runs:

The failed headline and error, the Settings button, and the line naming the earlier deploy still running in us-east-1 with its delete path under Remote Instances in Settings

The copy landed:

The button reads Copied with a check, no notice

The launch finished, but a Settings delete has since unregistered its machine: a past event in the past tense, and the set-up flow again:

A deploy finished 3h 12m ago in us-east-1, its machine is no longer in your instances list, the Open Remote Instances in Settings button and its line

The Instances feature is off, so the registry answers 403: the panel says it cannot tell, never gone, and points at the console:

A deploy finished 3h 12m ago in us-east-1, this page cannot tell whether it is still running, and the underlined console link

A re-deploy finished and the older machine is still registered: the headline and the target belong to the newest machine, and the line names the older one:

Your crew is deployed in the cloud, the target row for the newest machine, and the line naming an earlier deploy still running in eu-west-1 with its delete path

The registry read fails outright (not a 403): the same read error, hand-off and Try again as a failed launch read, and no state behind it:

Could not read your deployments with Ask the agent and Try again, Details collapsed, no state sentence

Review dispositions

Current-head review findings and what was done with each:

  • UX Review, blocker: the action labels promised the act while the buttons
    only navigate. Fixed by changing the words to match the action, never the
    other way round: both labels name the navigation and the real destination
    ("Open Remote Instances in Settings", "Open Remote Instances in Settings to
    sign in"), and the line under the deploy button carries the cost/undo fact.
    No button on this read-only card triggers a deploy. Every other button was
    checked against its handler; none mismatches.
  • UX Review, watch: Close might cancel the deploy. Fixed: the close hint.
  • UX Review, watch: the Fargate launch had no target row and no reason. Fixed:
    the container-task sentence, keyed on the Fargate id.
  • UX Review, watch: the header trigger read as a status chip. Fixed: the
    hairline border. The + sibling keeps its ghost style; it is icon-only and
    out of this change's scope.
  • UX Review, evidence gaps: no loading frame, no Copied frame. Both added.
  • UX Review, suggestion: the hint under the target left the reader unable to
    use the value. Adopted: "Paste this ID into AWS Session Manager (in the AWS
    console) to open a terminal on the machine."
  • GPT 5.6, upheld three times on the feature-map row, each time on a
    different mechanism sentence (the landing tab; "every button opens that
    page"; the registry-failure path and what Try again re-reads), each made
    false by the round that changed the code it described. Fixed structurally:
    the row now has the shape of its neighbours (one sentence on what the
    surface is for a user, the entry point, the files, the endpoints) and
    narrates no mechanism, so no branch or failure-path sentence is left to
    drift. The panel's behaviour is specified by the header comment of
    DeployMyCrew.tsx and pinned by its tests. Whether the buttons should open
    the Set up a new one tab directly (a ?tab= read in RemoteCrewPanel, whose
    tab is local state with no URL read today) is a separate product decision
    and is not changed here.
  • GPT 5.6, upheld on re-roll: the copy-failure notice carried no hand-off
    and its comment named no protected draft, which is not one of the rule's
    sanctioned states. Fixed: askAgent is on (nothing on the row is unsaved),
    the dialog closes first, and the test pins the hand-off.
  • UX Review, watch: the bare "Cloud" trigger label was a hesitant guess.
    Tried "Crew in the cloud": at the harness's 1920-wide viewport it pushes
    the page title to "Crew ..." in the members header, so the label stays
    "Cloud" with the tooltip carrying "Your crew in the cloud". The dialog's
    title names the subject the moment it opens.
  • UX Review, watch (later round): the upload-arrow glyph read as an action.
    Fixed: plain cloud glyph.
  • UX Review, watch (later round): the sign-in state lacked the close
    reassurance. Fixed: the same line renders there, reworded so it is true in
    both states ("Closing this window does not stop the deploy").
  • UX Review, suggestion (later round): "Step 2 of 4" never named the steps.
    Adopted: the step under way is named beside the counter from job.steps.
  • UX Review, suggestion (later round): the Fargate task ARN in Details has no
    Copy. Deferred: Details is the debugging line for every identifier, and a
    copy control there is a separate change to that line, not to this panel's
    states; the ARN stays selectable text.
  • Design Review, CONCERNS: the newest-launch headline could hide a live older
    deployment behind a failed retry. Fixed with the line the review asked for:
    earlierReachableLaunch names the earlier deploy and its region when the
    newest launch is not the deployed one.
  • First Principles, CONCERNS: the in-flight list existed twice. Fixed: one
    exported set in utils/remoteCrew.ts, consumed by both panels; the
    RemoteCrewPanel suites pass unchanged.
  • UX Review, watch: crew-wide scope is carried by the roster of faces and by
    the sentence "Your crew ..."; left for a human eye, as the review asks.
  • First Principles, CONCERNS: "Usually ready in about 6 minutes" had no
    measurement behind it. Fixed by deletion, as suggested: the step counter
    carries the progress, and the panel's own rule (only attested numbers) now
    holds for the deploying state too.
  • Design Review, PASS with a note to verify one transition against a live
    gateway record. Not possible from this sandbox (Manual verification above);
    the fixture shapes mirror the gateway's launch record fields.
  • First Principles, CONCERNS (item 7, premise): the earlier-live line and the
    deployed headline read liveness off a launch record that teardown never
    mutates, so a destroyed machine read as live forever. Confirmed in the
    gateway (_teardown_after_delete unregisters and deletes the source only;
    no site re-statuses a done launch). Fixed by keying liveness on the
    registry, the truth source the review named: deployLiveness over
    GET /api/instances; "deployed" only for a registered EC2 machine; every
    other done record is a past-tense finished state (gone / unknown); the
    earlier-live line requires the registry's word. The Fargate lane registers
    nothing by design, so its liveness is unknown and it is never called
    deployed.
  • First Principles, CONCERNS (item 9, undeclared): the shared
    launchIsInFlight / FARGATE_PROVISIONER_ID extraction and the
    RemoteCrewPanel reclassification were not in the description. Declared
    above (What changed): two consumers each, a harm-free dedupe rider.
  • UX Review, watch: the earlier-live line warned of a paying machine with no
    way to act. Fixed as suggested: the sentence ends with the path to act
    ("You can delete it under Remote Instances in Settings", the page and the
    verb Settings itself uses).
  • UX Review, watch: the bare "Cloud" label read correctly but as a guess;
    the review leaves it for a human to weigh, as does this PR (the longer
    label truncates the page title, see above).
  • UX Review, suggestion: a line under the failed state's button saying what
    the set-up flow does with the failed launch. Deferred: whether the failed
    launch stays listed there is Settings' behaviour, and this panel only
    states what it can read; the button's own line already says nothing is
    created until the steps there are confirmed.
  • GPT 5.6, blocking (later round): a non-403 failure of the registry read
    rendered the unknown state silently, with no ErrorNotice and no hand-off.
    Fixed as the review asked: the failure routes through the same notice and
    Try again as a failed launch read, is excluded from ready, and draws no
    state; a 403 stays the capability answer it is (feature off, unknown).
  • Design Review, CONCERNS (later round): the earlier-live line went silent
    under a live headline, so two registered machines read as one. Fixed:
    the line renders under any headline when another launch's machine is still
    registered, the target row stays the newest machine's, and an older record
    of the same machine is not named.
  • Design Review, suggestion: file the ?tab= deep-link now. Not filed: the
    repository's owner keeps no tracking issues for features, and whether the
    deep-link lands (initializer-only read of useLocation().search in
    RemoteCrewPanel.tsx) is the conductor's call, measured and recorded in
    the review thread; the labels name the destination page truthfully today.
  • First Principles, CONCERNS (item 8, zero consumers): the status set was
    exported with no importer. Fixed as suggested: the export is dropped;
    launchIsInFlight is the one spelling.
  • UX Review, BLOCK (evidence gap, later round): shot 13 in this body still
    showed the earlier-live sentence without its delete remedy. Fixed: shot 13
    re-captured at HEAD with the shipped sentence (and shot 16 shows the same
    sentence under the deployed headline).
  • UX Review, watch: the "Check the AWS console in " line pointed at
    a possibly-billing machine with no link. Fixed as suggested: the sentence
    links to that region's console home, when the region parses as one.
  • UX Review, watch: the deploying state offered no action, and "closing this
    window does not stop the deploy" read as alarming with no way to stop it
    anywhere. Fixed as suggested: one muted link, "Open Remote Instances in
    Settings", into the page whose launch row carries the Cancel; the label
    names the navigation and the destination, and the panel still acts on
    nothing.
  • First Principles, PASS with a note that ECS Exec targets exist on Fargate.
    The Fargate sentence says there is no Session Manager target, which is what
    the row is for, and does not claim the task cannot be reached.
  • GPT 5.6, finding, and UX Review, watch: the three Settings pointers read
    as three places ("the cloud set-up", "the sign-in step", "Your
    instances"). Fixed as both asked: every pointer names the one page by its
    own name, "Open Remote Instances in Settings" (the sign-in variant adds
    "to sign in"), and the earlier-live sentence says "under Remote Instances
    in Settings".
  • UX Review, watch: the console sentence carried a link with no affordance.
    Fixed: the link keeps its underline and carries an external-link glyph.
  • UX Review, watch: the earlier-live sentence names where to act without a
    control of its own. Deferred: under the none, failed and sign-in states
    the card's one button already opens that page, and under the deployed
    headline the sentence names the page by its Settings name; adding a second
    navigation control to that state is left for a separate decision.
  • UX Review, suggestion: add "usually because it was deleted there" to the
    gone sentence. Declined: the registry says only that the machine is not
    listed, not why; the sentence states what the read supports.

Related Issues

None. This is a new surface, so the PR carries its full context.

Pattern harvest

Not generalizable: the redesign is a product decision about this one panel.
One reusable check did come out of it: a class name that exists nowhere
renders as nothing, and a usage count that includes the file under review
cannot detect it, so every class in the new component was counted with that
file excluded, and the one novel utility was confirmed in the built CSS.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@chenmingwei23
chenmingwei23 requested review from a team and buluoray September 21, 2026 00:34
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of f2d645cbe1a1168ce222fb94ee51271878435774 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the deployed / gone / unknown liveness transitions once against a live gateway teardown — every frame here comes from fixtures mirroring _teardown_after_delete.

[DESIGN-REVIEWED] f2d645c

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of f2d645cbe1a1168ce222fb94ee51271878435774 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The feature's only entry, the bare "Cloud" chip, was read correctly but only as a guess — the panel's discoverability rests on that one word.

Watch

  • "Cloud" trigger (shot-01): the blind reader got it right ("something about running the crew somewhere other than my computer… opens a cloud window") but rated it a guess. Sole entry point, hit on every first visit, persistent; the PR itself leaves the label "for a human to weigh" — this is that weighing. Smallest fix: a two-word label ("Cloud status") if it survives the header at narrow widths.
  • Deployed + earlier-live state (shot-17): "An earlier deploy is still running in eu-west-1. You can delete it under Remote Instances in Settings" renders with no way there — that state's only controls are Copy and Close. The reader called it "the money-worry sentence; I'd want to go delete that old one," then must hunt Settings unaided. Rare state, but billing-anxiety impact every time it shows. Fix: render the existing deploy_action_manage muted link whenever deploy-earlier-live is visible.

Suggestions

  • deploy_earlier_live: "The machine from an earlier deploy is still running in {{region}}…" — the reader flagged "a deploy finished… is still running" as a contradiction until they worked out process vs. artifact; earlier-live is always a registered EC2 machine, so "machine" is accurate.

[UX-REVIEWED] f2d645c

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of f2d645cbe1a1168ce222fb94ee51271878435774 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] f2d645c

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f2d645cbe1a1168ce222fb94ee51271878435774: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Opus 4.8 Review — ✅ no blocking findings

Reviewed f2d645cbe1a1168ce222fb94ee51271878435774 — this comment is updated in place on each push.

Review details

Based on my independent review: the discovery pass reported no candidates, so there is nothing to falsify in Step 1. For Step 2, I traced the production logic in DeployMyCrew.tsx (state machine, deployLiveness/earlierReachableLaunch/deployView, awsConsoleUrl region validation, the copy/error surfaces), the MembersPage.tsx trigger, and the remoteCrew.ts/RemoteCrewPanel.tsx launchIsInFlight refactor, and checked the changed files against the base-branch blocking rules (max-two-buttons-per-row: the header row carries exactly two action buttons; use-lucide-icons: no inline SVG; icon-buttons-need-labels: the Cloud button is text-labelled and Plus has aria-label; errors-use-error-notice: every failure renders through ErrorNotice with an explicit askAgent/onHandoff decision; narrow-viewport/page-layout: src/pages/members/*.tsx is outside their single-level src/pages/*.tsx patterns). I could not ground a reachable defect or a rule violation at 80+.

No findings.

[OPUS-REVIEWED] f2d645c

Verdict parsed from the review's SHA-scoped output markers for commit f2d645cbe1a1168ce222fb94ee51271878435774.

False positive or not applicable? A repository writer can comment:
/ai-review override fable f2d645cbe1a1168ce222fb94ee51271878435774: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of f2d645cbe1a1168ce222fb94ee51271878435774 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Open the capture frames before merge: the panel's entire justification is at-a-glance legibility, which the DOM tests cannot attest — only the screenshots do.

The load-bearing premises were verified in-repo rather than taken from the description: registration is a condition of a done launch (handlers_cloud.py:942), teardown unregisters without re-statusing (handlers_cloud.py:1085), and the registry 403s when instances.enabled is off (handlers_instances.py:136), so the liveness derivation and the 403→unknown branch are derived, not asserted. The nearest existing mechanism, Settings → Remote Instances (RemoteCrewPanel.tsx), is a management surface this panel deliberately points into rather than re-spells: it never writes, and the one classification both share was extracted (launchIsInFlight, 4 call sites across 2 files) instead of copied. New surface counts: FARGATE_PROVISIONER_ID has 1 consumer and mirrors platform/defaults.py:674; the capture harness follows 574 sibling capture-*.mjs scripts; locale strings across 13 catalogs are mandated by the i18n gates.

What this change ships

Inventory (10 items) — 10 justified

Intent: let a crew owner see whether their crew is deployed in the cloud and what to do next, from the Members page — an ADDITION.

  1. A labelled "Cloud" button appears in the Members page header — justified
  2. A read-only "Your crew in the cloud" dialog: roster faces, one sentence per state, at most one action, all actions landing in Settings — justified
  3. "Deployed" is said only while the Instances registry still holds the machine; otherwise the finish is reported in the past tense — justified
  4. A copyable Session Manager target on finished EC2 launches, with the copy reporting its own failure; Fargate gets an explanatory sentence instead — justified
  5. A line naming an earlier still-registered (billing) machine behind any headline — justified
  6. The launch list re-reads every 4 s, only while a launch is moving and only while the dialog is open — justified
  7. Settings → Remote Instances now classifies in-flight launches through the shared helper, deleting its local status list — justified
  8. Two new exports in utils/remoteCrew.ts (launchIsInFlight, FARGATE_PROVISIONER_ID), consumers counted at 4 and 1 — justified
  9. An asserting screenshot harness (capture-deploy-my-crew.mjs), matching the repo's 574 sibling capture scripts — justified
  10. ~28 strings in all 13 locale catalogs plus a feature-map row — justified

[FIRST-PRINCIPLES-REVIEWED] f2d645c

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for c15ed31d4a4a9aaf80be4bd15baf680a34ffa816; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt c15ed31d4a4a9aaf80be4bd15baf680a34ffa816: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for fad0c000ab888d88e203c5ba51d26332305d88d3; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt fad0c000ab888d88e203c5ba51d26332305d88d3: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision labels Sep 21, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 21, 2026
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 21, 2026
@chenmingwei23

Copy link
Copy Markdown
Contributor Author

Dispositions for the advisory findings on f567991669dde782a626533b205f473c0986177e (Design PASS, GPT and Opus no findings, First Principles PASS with one note, UX CONCERNS). Recorded here rather than in the description because a description edit re-runs the GPT lane on an unchanged tree.

First Principles, verify note -- deployHasShellTarget assumes a record without provider_id is EC2. Verified true on two grounds. (1) The backend already makes the same assumption at the source: LaunchJob.from_dict in src/kiro_crew/cloud/launch_job.py rewrites a missing provider_id to the built-in EC2 id, and to_dict always writes the field, so the API never serves a record without it; the panel's fallback mirrors that rule rather than inventing one. (2) The field predates the only other lane: provider_id entered the launch record with the provisioner seam (#9654), and the Fargate lane arrived later (#10771, #11556), so every record written without the field was produced by the EC2 lane.

UX, watch: "instance" in three senses. Of the three phrasings the blind reader quoted, "Create the instance" is the gateway's own step name (job.steps[].label), rendered verbatim beside the step counter, so it is not this panel's copy to change; "Remote Instances in Settings" is the Settings page's own name, which every pointer on the card now uses on purpose. The third, "your instances list" in deploy_state_gone, is the one this panel owns. Declined for this head: the sentence is true, and a push for one advisory string re-rolls five review lanes on an otherwise unchanged tree. The reviewer's wording ("Its machine is no longer listed under Remote Instances in Settings.") is the first change folded into any later revision of this branch.

UX, watch: the failed state explains the failure only through the recorded error. No change: the recorded error is the gateway's own message, and the "Ask the agent" hand-off on that notice is the designed remedy, which the reviewer read as such. Left as residual risk to observe with real users.

UX, suggestion: reword deploy_state_gone. Same disposition as the first watch.

buluoray
buluoray previously approved these changes Sep 21, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified at f5679916. Frontend-only — no .py, no route, no schema, no API-client method added.

The panel issues exactly two calls, api.cloudLaunches() and api.listInstances(), both GET. No POST/PATCH/DELETE anywhere in DeployMyCrew.tsx; every action is navigate('/settings/instances') via goToSettings, and copy uses the local clipboard helper rather than a request.

Both routes gate before reading state. /api/cloud/launch returns from _guard(...) ahead of _astore/store.list (handlers_cloud.py:492-495), rejecting a slack: origin with 403, unauthenticated with 401, and a non-owner via is_owner_dashboard_request. /api/instances rejects slack, unauthenticated and feature-disabled, and the panel treats that 403 as "unknown, do not retry" rather than retrying into it.

On "crew-wide": both GETs are gateway-global and owner-only, and what one crew sees of another is only whole-checkout deployment infrastructure (stack tag, provisioner id, raw status, profile, region, instance id). A launch ships the whole local checkout to one machine, so there is no per-crew deployment to leak. No private memory, per-member store, credential, token, or per-member path is read or rendered — from /api/instances the panel consumes only ssm_target/ssh_host for a liveness compare and never renders the instances list.

Frontend is clean: no dangerouslySetInnerHTML, no iframe, no inline style, no fixed palette or hex — only semantic theme tokens, so both schemes resolve. Every record field renders as React text. The single external link's href is built through the URL API and gated by ^[a-z]{2}(-[a-z]+)+-\d$, so a javascript: or arbitrary host cannot reach it, and it carries rel="noreferrer".

The client-side provisioner ids mirror the gateway (platform/defaults.py:674, platform/interfaces.py:1348), which matters because a mismatch would have offered a Fargate ARN as an SSM target. The dedupe into remoteCrew.ts is behaviour-preserving — the old IN_PROGRESS list equals the new set, and awaiting_signin is still matched before launchIsInFlight so it maps to signin rather than deploying.

One thing to know about the "read-only" framing, not a defect this PR adds: GET /api/cloud/launch goes through _astore, which runs a once-per-process store.reap_orphans() that globs the job dir and save()s stale non-terminal records to terminal on disk (handlers_cloud.py:138-151). It is owner-gated, idempotent-once restart-recovery bookkeeping, and the Settings RemoteCrewPanel already triggers it on the same route today. So the panel's own code never writes, but the read it issues is not side-effect-free at the store layer — worth knowing if anyone later reads "read-only" as "safe to poll from anywhere."

A finished Fargate launch's instance_id is a task ARN, which embeds the account id, and it renders in the collapsed Details line. That is the owner reading their own account id on their own local dashboard, so not a leak — noting it only because it is the kind of string that matters elsewhere.

…er state

The Crew Members page gets a labelled Cloud button that opens a panel
answering "is my crew deployed, and what do I do next?" in plain
language. The crew's faces lead; the newest launch decides one of six
states, each with at most one action: not deployed (a button into
Settings), deploying (step N of M with the name of the step under way,
re-read every few seconds, nothing to press), waiting on the user's
sign-in (a button into Settings), deployed (time since the launch was
created, its region, and on the EC2 lane a copyable Session Manager
target with one line saying what to do with it), finished but not
confirmed live (a past event in the past tense, see below), failed (the
recorded error through ErrorNotice with the agent hand-off, and the
Settings button again). Every navigation lands in Settings > Remote
Instances, which owns creating, repairing and tearing down a launch; the
panel never writes.

Only numbers the launch record can attest are shown; a duration estimate
is not one of them, so none is shown. Sessions running on
the deployment and turns it served are deliberately absent: the deployed
side has no counter and no path to report back, and the local activity
log counts the local crew, so its numbers here would state a scope the
data does not have. An unknown value is an en dash, never 0. Month-to-
date spend was measured and dropped: the costs route belongs to the
aws-control app, which is off by default, and a launch record carries no
account id to key it by.

"Deployed" is said only while the Instances registry still holds the
machine. The launch record cannot carry that claim by itself: a Settings
delete waits for AWS to confirm the stack is gone, unregisters the
instance and removes the uploaded source, and nothing ever re-statuses
the done launch record, so on the record alone the panel would read "is
deployed" forever after the one action its own button leads to. The
registry is the field a teardown does update, and the EC2 launcher
registers the instance (its id as the SSM target) as a hard condition of
done. So the panel also reads GET /api/instances, under the query key the
Settings panels already use, only once some launch has finished, and a
403 (feature off) is not retried. deployLiveness answers live, gone or
unknown; only live earns the present tense. Every other done record is
the finished state, a past event in the past tense ("A deploy finished
<age> ago in <region>."): gone adds that the machine is no longer in the
instances list and offers the Settings button; unknown (the Fargate lane
registers nothing by design, an EC2 record that kept no machine, or an
unreadable registry) adds that this page cannot tell and points at the
AWS console in that region, the sentence itself linking to that region's
console home when the record's region parses as a region id; the link
keeps its underline and carries an external-link glyph, so it reads as a
door without hovering, and its URL is built with the URL API from one
whole-URL literal. Unknown is never rounded to either answer. The panel
stays loading until both reads have answered, and a failure of the
registry read other than a 403 is reported as a read error (the same
notice, hand-off and Try again as a failed launch read), never drawn as
a state.

The target row is offered only for the built-in EC2 provisioner. The
Fargate lane records the task's ARN in the same field, and Session
Manager does not accept an ARN, so that launch gets no row and, where
the row would be, one muted line saying the deploy was a container task
with no Session Manager target; its ARN stays in Details.

The buttons name what they do and where they lead, not the outcome a
reader wants. Both only open Settings, and a reader who takes a "Deploy
to the cloud" button for the act itself (something created outside this
computer, possibly costing money, with no visible undo) does not press
it. So the labels name the navigation and the real destination, the
Settings page called Remote Instances, which opens on its Your crews tab:
"Open Remote Instances in Settings" and "Open Remote Instances in
Settings to sign in". Every pointer on the card names that page by that
one name, so three doors do not read as three places. A muted line under
the deploy button says the one thing the label cannot: nothing is created
until the steps there are confirmed. While a launch is moving or waiting
on the sign-in, a line says closing the window does not stop the deploy,
since the work runs in the gateway, not in the dialog; the moving state
also carries one muted link, "Open Remote Instances in Settings", into
the page whose launch row has the Cancel, so the panel still acts on
nothing but names where to. The header trigger carries a hairline border
like the secondary button style, so an icon-plus-word beside the page
title reads as a button, not a status chip, and a plain cloud glyph
rather than an upload arrow, so it does not read as sending something
up.

Copying the target reports its own failure. When both clipboard layers
refuse (the async API rejects, execCommand answers false, the everyday
shape of a plain-HTTP LAN dashboard), the row says the copy failed and
names the remedy instead of painting a tick over an unchanged clipboard,
and the notice carries the agent hand-off: nothing on the row is unsaved,
so the hand-off can destroy nothing, and the agent has a remedy the
message does not (read the id off the launch record and open the session
itself). The dialog closes first, as for the panel's other notices.

Technical identifiers (stack tag, provisioner id, raw status, profile,
region, instance id) survive in a collapsed Details line, one per launch,
so an owner debugging a deploy still has them. The provisioner id is
drawn verbatim there, so no client-side label map or lint exemption is
needed for it. Read failures and a failed launch's error render through
ErrorNotice with askAgent and a hand-off that closes the dialog first.

The in-flight status list lives once, in utils/remoteCrew beside the
provisioner ids (FARGATE_PROVISIONER_ID is added there, mirroring the
gateway's id; the set itself is not exported), and both this panel and
RemoteCrewPanel classify a launch through launchIsInFlight, so a status
the gateway adds is classified in one place; RemoteCrewPanel drops its
private list for it, with no change in classification. It sits there
rather than in the API client because most test files replace that
module with a hand-written mock.

The headline follows the newest launch, and one line names what that
would otherwise bury: another launch whose machine the registry still
holds keeps running (and billing) behind a failed retry, a launch still
moving, an unconfirmed finish or a re-deploy that finished, since
nothing in the launch flow tears an earlier stack down; so the panel
says so under any headline, says it can be deleted under Remote
Instances in Settings, and points at Details. The line requires the
registry's word; a done record it cannot vouch for is not named, nor is
an older record of the newest launch's own machine.

The feature-map row for this surface takes the shape of its neighbours:
one sentence on what it is for a user, the entry point, the files and
the endpoints. It narrates no mechanism, because every sentence about a
branch, a failure path or what a button re-reads is made false by the
next change to the code it describes.

A capture harness (scripts/capture-deploy-my-crew.mjs) renders the
trigger and every panel state, the failed copy included, against the
built SPA with stubbed API answers, asserting each state before it
writes a frame.

Catalogs: 28 strings added to all 13 languages plus the regenerated
pseudo-locale; French carries U+202F before its double punctuation, and
Hindi and Bengali use the informal register. With them the all-catalog
chunk measures 12281.1 KB, inside the 12870 KB ceiling the bundle-size
gate already carries on main (measured 12254.6 KB there at 34fe0de).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants