Repository navigation
fix(catalog): restore companion runtime_policy on member rows - #12686
Conversation
|
👋 Hi! This PR's description is missing some required sections from our PR template. Workflow runs won't be auto-approved until the description is updated. Missing sections:
Please update your PR description to include these sections, then push or re-save the description. The workflows will be approved on the next cycle. |
756f053 to
c6f0117
Compare
c6f0117 to
832a3d9
Compare
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the out-of-repo companion keys its policy by Suggestions
[DESIGN-REVIEWED] 216ac3d Description read[DESCRIPTION-READ] 42f19ab52d7decb372dd2c45b78d9142cd5b5590f68253ad5588f52f480645a0 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Core contract gains a method and wire field with zero in-repo consumers — the stated consumer is out-of-repo and uncheckable — under a Not justified as shipped
What this change shipsInventory (5 items) — 4 justifiedIntent: give a companion edition a channel to publish per-agent model-selection metadata on the agent picker's catalog rows — an ADDITION by the description's own statement, despite the
[FIRST-PRINCIPLES-REVIEWED] 216ac3d Description read[DESCRIPTION-READ] e5d59100de800fa76f46dc8135e99ce6bb82555838509068eaa8950c80a70e08 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
832a3d9 to
309e8b2
Compare
309e8b2 to
b1e361b
Compare
b1e361b to
5ebbcc3
Compare
da7e78a to
1582107
Compare
1582107 to
216ac3d
Compare
iamwhatever
left a comment
There was a problem hiding this comment.
Reviewed. The seam is read and emitted only under if not redact (redacted test covers four caller shapes), DefaultProviderRegistry.agent_runtime_policy returns None so standalone is unchanged, and an older companion lacking the method is caught by safe_context_call with the field omitted.
Non-blocking: title says restore while the body says addition; the Tests section says two cases but the diff adds five functions; deleting the isinstance(policy, dict) guard at agent_catalog.py:56 survives every test.
Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com> (cherry picked from commit fa1b47d)
Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com> (cherry picked from commit fa1b47d)
Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com> (cherry picked from commit fa1b47d)
…/0.8.0) (#16385) * fix(catalog): restore companion runtime_policy on member rows (#12686) Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com> (cherry picked from commit fa1b47d) * fix(agents): let an installed agent become the default agent (release/0.8.0) Backport of #16323, #16410, #16455, #16512 to release/0.8.0, cherry-picked in main's merge order. * fix(agents): let an installed agent become the default agent (#16323) (cherry picked from commit 5c6268a) Backport adaptation: test/integration/conftest.py conflicted only on context; the source's added reset lines (config_loader import, docstring bullet, the three _MATERIALIZED_* resets and checks) were applied, nothing else. Every other file applied cleanly. * fix(agents): reset a default agent only when its template was removed (#16410) (cherry picked from commit f16fa23) Backport adaptation: test/integration/conftest.py conflicted on context only (a main-only updates-loop entry next to it); only this change's _MATERIALIZED_SEEN lines were applied. Every other file applied cleanly. * fix(agents): harden the default-agent healer and the file-name map (#16455) (cherry picked from commit 4a11ed2) * fix(agents): heal a default agent only after a scan that read every spec (#16512) (cherry picked from commit 4576a29) --------- Co-authored-by: Premshay <premshay@gmail.com> Co-authored-by: Premshay <28099628+Premshay@users.noreply.github.com>
Problem / Motivation
Goal: An edition that projects engine capabilities can tell the agent picker, per member, whether that agent's model is selectable.
GET /api/agents/catalog(introduced in #12224) ships member rows with noper-agent
runtime_policy. An edition that projects engine capabilitiesthrough the platform seam therefore has no channel to publish per-agent model
selection, and every agent in the picker shows the configured default
backend's models.
Why it matters
With the field, a companion edition's picker gates per-agent model discovery
on
runtime_policy.model == "selectable"; without it the edition losesper-agent model selection entirely.
Not a goal
Nonehere and public rows are unchanged.What changed (motivation → approach → change)
ProviderRegistry.agent_runtime_policy(agent_name)seamin
src/kiro_crew/platform/interfaces.py(returnsdict | None; the publicedition supplies no implementation).
safe_context_call(lambda: current_context().providers, fallback=None)— andemits
runtime_policyon a member row exactly when the seam supplies a dict.The field is omitted when the seam is absent, so the public edition's rows
are unchanged.
kiro_agent, falling back to its roster aliaswhen empty. The policy is read and emitted only for owner-visible rows: a
redacted (non-owner) request neither queries the seam nor carries the field,
the same contract every other member-row field follows. Template rows never
carry it.
request.app["platform_context"], an aiohttp app key nothing installs; thatversion could never emit.
the field (an equivalent seam lived in the fork's lineage, never upstream).
The consumer is the edition's dashboard picker, owned out-of-repo by the
companion.
Backwards compatibility
Compatible: adds an optional, default-absent seam; nothing main currently
accepts is rejected, renamed or removed, and public-edition rows are unchanged.
Tests
Two cases in
test/test_agent_execution_catalog.pypin propagation throughthe composed seam and omission without a companion; the file passes 19/19.
Manual verification
N/A — unit coverage sufficient: both emission and omission are exercised
through the real endpoint, and the public-edition path is the omission case.
Related Issues
Pattern harvest
Rule candidate: review-prompt
Pattern: a platform-seam field whose only reader falls back silently when the
field is absent; pair every seam-field removal with a propagation test for
each reader.