Repository navigation
test: skip the non-UTF-8 pool name test on macOS, like its siblings - #12914
Conversation
test_a_name_that_is_not_utf8_round_trips (#12709) creates a directory whose name is not valid UTF-8 to compare the child's realpath against the thread's. APFS/HFS+ refuse such a name unit: os.mkdir raises EILSEQ before the resolver is reached, so the macOS lane fails on the fixture, not on the code under test. Every other non-UTF-8 path test in the suite already skips on darwin as well as Windows (#11566); give this one the same marker and keep the newline-name case, which is legal on APFS, running there.
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the next on-demand macOS lane run goes green — that run is the only real proof the remaining newline case passes on APFS. [DESIGN-REVIEWED] fa8cf69 |
Opus 4.8 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — 🔴 changes requested (blocking)GPT 5.6 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- test/test_subprocess_pool.py:46 -- Broadened skip disables the macOS parity ratchet Adjudication (Opus 4.8) — is blocking on each finding proportionate?The finding is anchored to AUTOSDE rule Per the adjudication contract, a finding anchored to an AUTOSDE rule with Harm rung: N/A — governed by an AUTOSDE blocking rule, not my harm/remedy weighing. False positive or not applicable? A repository writer can comment: |
…irodotdev#12914) test_a_name_that_is_not_utf8_round_trips (kirodotdev#12709) creates a directory whose name is not valid UTF-8 to compare the child's realpath against the thread's. APFS/HFS+ refuse such a name unit: os.mkdir raises EILSEQ before the resolver is reached, so the macOS lane fails on the fixture, not on the code under test. Every other non-UTF-8 path test in the suite already skips on darwin as well as Windows (kirodotdev#11566); give this one the same marker and keep the newline-name case, which is legal on APFS, running there.
Problem / Motivation
macOS Tests / Backend Tests (macOS) (3)fails on every PR that runs the on-demand macOS lane since #12709 landed:The test creates a directory whose name is not valid UTF-8 to compare the pool child's
realpath_spellingsagainst the thread's. APFS/HFS+ do not accept such a name unit, soos.mkdirraisesEILSEQin the fixture, before the resolver is reached.maindid not catch it because the macOS lane is on-demand.Why it matters
Any PR whose author opts into the macOS lane sees a red check unrelated to their change (seen on #12782), and the lane cannot tell a real regression in the pool's resolution parity from this fixture failure.
What changed (motivation → approach → change)
Every other non-UTF-8 path test in the suite already skips on darwin as well as Windows with the same reason string (#11566:
test_git_worktree_scope.py,test_governance_updates.py,test_md_notebook.py). This PR gives the pool test the same marker.posix_names_onlycannot simply be widened: it also guardstest_a_name_containing_a_newline_resolves, and a newline IS a legal APFS name unit, so that case keeps running on macOS. A second marker,utf8_relaxed_names_only(os.name == "nt" or sys.platform == "darwin"), is applied to the non-UTF-8 case alone.test/test_subprocess_pool.pyutf8_relaxed_names_onlymarker; applied totest_a_name_that_is_not_utf8_round_tripsBackwards compatibility
Test-only. No code under test changes; Linux runs both cases exactly as before.
Tests
test/test_subprocess_pool.py— 57 passed (both odd-name cases run).sys.platform == "darwin"the module's marks were checked directly: the non-UTF-8 case carriesskipif(True), the newline caseskipif(False).Manual verification
Not needed beyond the lane itself; the next macOS run on a PR carrying this change is the check.
Related Issues
Follow-up to #12709 (introduced the test) and #11566 (the macOS skip its siblings carry). Seen on #12782.
Checklist
<type>: <summary>