Skip to content

feat: Meet CrewMates first-run flow that creates the first crewmate - #12927

Merged
iamwhatever merged 1 commit into
mainfrom
feat/meet-crewmates-first-run
Sep 24, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
feat/meet-crewmates-first-run

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

A new user has no crewmates and no custom agents, and nothing tells them what a crewmate is or gets them one. The Crewmates page's empty state sends them to the crew editor, a form that assumes they already know what to fill in. The Customize tour ends and the product's headline idea — a teammate that keeps working while you are away — is never shown.

Why it matters

CrewMates is the launch story. A first-run user who never meets one uses Kiro Crew as a chat box and misses the point of the product; the first crewmate is the moment the idea becomes real, and today that moment has no path.

What changed (motivation → approach → change)

Step What the user sees What happens
1 Meet CrewMates what a crewmate is, three example rows (Radar / Scribe / Fixer); picking one preselects its name and job Not now records a dismissal
2 Name your first crewmate name (prefilled Radar) + suggestion chips, Starting setup nothing written yet; Next stays off until the name fits the roster's grammar
3 Give <Name> a job what it looks after, When, Where it reports POST /api/agents then POST /api/crons bound to the crewmate
4 <Name> is ready big avatar, when it starts, where its reports land (its own chat and the bell; every run on the Schedule page) Done closes; Open <Name>'s chat lands in its chat

Implements the accepted RFC: docs/request-for-change/rfc-crewmates-launch.md (screen 08, "Meet CrewMates onboarding"). The RFC's screen 08 carries an implementation amendment recording the Slack status row, the "Starting setup" wording and the name grammar.

Goal: take a user from "what is a crewmate" to owning one, in the same first-run chrome the other chapters use, without a new form or a new API.

Approach: a four-step chapter (components/MeetCrewmatesFlow.tsx) on the shipped OnboardingChapterShell, mounted in App.tsx inside OnboardingShellHost after the Customize tour. It fires once, only while the Crew Members preview is on (Settings → Developer → Feature Previews, PREVIEW_CREW — the switch that already shows the Crewmates page, so the flow ships dark and launches with it), and only when the roster holds nothing beyond the built-in default row and every installed agent is one Kiro Crew wrote itself — the server's kirocrew_owned flag alone decides (hooks/useMeetCrewmatesGate.ts). An existing user with custom agents gets the opt-in step instead, so the two never both fire. The Crewmates page (pages/members/MembersPage.tsx) re-opens it on demand (mc-start-meet-crewmates) when only default is on the roster. Steps slide (Framer Motion, prefers-reduced-motion honoured); Tab is trapped and Escape means Not now before the crewmate exists and Close after.

Change: Create reuses the two existing writes. POST /api/agents makes the crewmate with the job text as its description (the roster's "what it is for" field). POST /api/crons binds the schedule to it through member_id = that immutable identity (never the display name, which the server late-resolves and a same-named remake could capture), so the job runs on the crewmate's own memory. Delivery is mechanical, never an instruction to the model: the job is created non-silent, so every run rings the bell and — when Slack is connected — reaches the owner's Slack DM through the runtime's own leg (the Slack row on step 3 therefore only states that fact in its label line — "Slack DM — Active" / "Off" — with the toggle column left empty; it is not a switch, because the runtime offers no such choice), and Its own chat maps to hide_in_chat, the one delivery choice the runtime does offer; the message is the job text alone. The crewmate's identity is held only from a clean create response (the immutable member_id the server allocates with its member memory; POST /api/agents now returns it beside memory_store) and is the one thing the flow binds to or reconciles against; nothing is claimed by display name, since two openings prefill the same example name and a same-named crewmate the flow cannot prove it made is someone else's. A 409 agent_exists is therefore a taken name on every attempt (back on step 2 with the error under the field, an "Open the Crew Members page" button on that notice — the wizard otherwise gave no way there — and the suggestion chip carrying that name marked "already exists"), a refused create (other 4xx) says "could not be created" inline, and a create with no usable answer (dropped response, 5xx) stops on step 3 saying the crewmate "may or may not have been created", posts no schedule, and carries a button to the Crew Members page (the page's shipped title, which every notice in the flow now uses; the rename is the sibling PR) so the user checks before making a second one. The Crew Members entry's gloss is a block line under its button (beside it, the phrase wrapped mid-sentence in the narrow list and read as part of the control); the page's "no crewmate yet" test is the gate's own hasNoCrewmates, so the page and the auto-fire cannot disagree. Step-1 copy: the Fixer example says "failing checks" (not "red CI"), and the footnote quotes “default” and no longer restates the panel's memory/chat/notes line. Every failure is an ErrorNotice following errors-use-error-notice: the agent hand-off is on where nothing can be lost (the eligibility notice, the step-4 schedule notices, the "done" notice on steps 1 and 4; it closes the flow the way that step's own exit does, because the chat sits behind the dialog) and off beside the unsaved name and job on steps 2–3, each notice naming the draft. A failed eligibility read is shown by App.tsx as a dismissible notice (MeetCrewmatesEligibilityNotice) instead of silently never firing — its remedy is an Open Meet CrewMates button that fires the same event as the Crew Members entry, not the name of a page the user may already be on: a taken name sends the user back to step 2 with the error under the name field, POST /api/agents (handlers/agents.py) now refuses a crew name that fails validation._AGENT_NAME_RE (invalid_agent_name) — the fix lives at that route, for every client of it, because GET /api/members skips such a row (kirocrew agent create still writes a name unchecked; a pre-existing level left as it is); the flow previews the same grammar under the name field as the user types (a plain warning-coloured hint that appears only once the name fails, not an ErrorNotice) and disables Next until it passes, and a server refusal lands under the field like a taken name; the cron message is the job text itself; a schedule the server refused (4xx) still reaches step 4 and says the schedule was not saved, with a button to the Schedule page on the notice, while a schedule write with no usable answer (a dropped response, a 5xx) is reconciled against GET /api/crons — only a job that IS the one asked for (member_id = the held identity, same name, same message, same schedule) means saved; an older or foreign job on the crewmate is not evidence — and only when that read fails too says it may not have been saved, pointing at the Schedule page instead of inviting a duplicate, a failed read of the custom agents or of the Slack status says so on its step, and a refused write of the "done" flag (markCrewmatesOnboarded awaits its PUT) is shown on the current step when it is the create-time write, or on the next entry when it is the write at exit. "Done" is persisted the moment the crewmate exists while the ready step stays open (onCreated) and again when the user leaves (onDone); an exit never waits for the server — the chapter closes at once and persists afterwards, since several exits navigate (/members, /schedule) and a full-screen chapter gated on a round trip would cover the page the user just asked for — and a refusal marks nothing locally (markCrewmatesOnboarded applies the render cache, the pending-mark clear and the in-memory flag only after the server accepted), so this browser is still due the chapter after a reload, as the notice says, rather than seeding a completion the server never recorded; the flow does not auto-fire again within the same session. "Only when I ask" posts no schedule and step 4 then says nothing about reports or the Schedule page. Completion or dismissal is recorded as a new dashboard.crewmates_onboarded flag (config/infra: sections.py, loader.py, config-baseline.json), read on GET /api/theme/boot and written through PUT /api/config/theme (handlers/core.py, api/client.ts), mirrored in hooks/useTheme.tsx like the other first-run flags. A workspace that was already onboarded counts as done and reaches the flow from the Crew Members page, which also keeps the E2E and capture harnesses (they seed only mc-onboarded) clear of it — with one exception that protects the launch's own target user: a FIRST tour completion (markOnboarded while not yet onboarded — never a replay from Settings) leaves an mc-crewmates-pending mark on that browser, so a new user who reloads or restarts between the tour and this chapter is still due it (the seed and the boot rule both honour the mark; it is cleared when the chapter is marked done). Only a workspace onboarded with no such mark — before this shipped, or from another machine — is treated as an existing install. All copy is in the catalog (components.meetCrewmatesFlow.*, pages.membersPage.meet_crewmates, website/src/i18n/locales/en.json plus the 11 translations and the regenerated en-XA.json) in the 12 languages; specs and the feature map name the flow. The ~60 new keys × 12 languages grow the translations chunk past its budget, so scripts/check-bundle-size.mjs raises the t budget to the usual 5% over the new measured size.

Backwards compatibility

Compatible: one new optional boolean on DashboardConfig with a False default; the theme endpoints accept it beside the existing flags and reject nothing they accepted before. No route, key or default changes.

Tests

  • test/gui_user/scenarios/meet-crewmates-flow.yaml (agentic gui-user scenario, tier nightly, feature members) — a tester with the new-user persona turns on the Crew Members preview, opens the empty Crew Members page (seed rich, no members: the roster holds only the built-in default row), clicks Meet CrewMates, walks the four steps with the prefilled Radar / job / "Every morning at 9:00" and Create Radar, then Open Radar's chat; expects a Radar row in the roster, an open conversation for Radar and no more Meet CrewMates button. Runs nightly via gui-user-test.yml; its static schema check runs in CI, and test/gui_user/test_scenarios_and_report.py lists it in the shipped roster (37 scenarios, 5 nightly).
  • website/src/components/MeetCrewmatesFlow.test.tsx — closed renders nothing; step 1 lists the three examples with the counter; Not now and Escape report dismissed without writing; step 2 prefills Radar, a chip swaps name and job, an empty name blocks Next; Back works; Create posts the crewmate (description = the job) then a non-silent schedule with member_id, cron 0 9 * * *, hide_in_chat: false while Its own chat is on, fires onCreated, keeps the ready step open and reports completed only on Open chat; a 409 agent_exists returns to step 2 with the error under the name field (aria-invalid, cleared on edit), a button to the Crew Members page that reports a dismissal, the matching chip marked taken, and no schedule; an unanswered create stops on step 3 with the "may or may not" notice and its Crewmates-page button, posts no schedule and never reads the roster by name; a 409 after an unanswered create is a taken name; a refused create (4xx) is the inline notice with no button; the schedule is posted with member_id = the identity from the create response; the schedule reconcile counts only the exact job asked for and ignores another job on the crewmate (other message or schedule) and the same job on another identity; a 4xx schedule lands on "ready" saying "not saved"; an unanswered schedule write whose job (matched by the roster slug) the Schedule list then shows counts as saved, and one the list does not show says "may not have been saved"; "Only when I ask" posts no cron and shows no schedule copy; a name with a space disables Next with the grammar as a plain hint under the field (no alert) and posts nothing; a server invalid_agent_name lands under the name field on step 2; isValidCrewmateName cases; the schedule-failure notice's Schedule button completes the flow; a suggestion chip never overwrites a job the user typed; a failed custom-agent read shows an ErrorNotice and still offers the default agent; the Slack row is a status row (plain "Active" / "Off" text plus the reason, no pill so it cannot read as a disabled switch), never a switch; a step-1 example row preselects its crewmate and opens step 2; entering a step seats focus on a control inside the NEW step (the seat runs from the incoming step's own mount, after AnimatePresence mode="wait" has removed the outgoing one, so it can never land on a control about to unmount and leave the Tab trap open); the eligibility notice renders its message, the agent hand-off and Dismiss, and its Open button fires the start event then dismisses; the Slack state word sits in the label line ("Slack DM — Off"); scheduleFor, builtFromOptions and the two gate predicates.
  • test/test_agents_roster_contract.py — POST /api/agents refuses Issue Radar, -radar, radar-, Радар, ra/dar and a 65-char name with invalid_agent_name and stores nothing.
  • test/test_config_api.py — the Hypothesis create round-trip (names drawn from all Unicode letters and digits) now expects 400 invalid_agent_name and an untouched config.json for any name failing _AGENT_NAME_RE, before the memory-store rule is judged; the strategy stays wide so that branch runs; a created crew's response carries a non-empty member_id.
  • test/test_meet_crewmates_builtin_pin.py — the flow's AGENT_NAME_RE preview agrees with validation._AGENT_NAME_RE on a probe set (spaces, edge dashes, non-ASCII, 63/64 chars).
  • website/src/hooks/useMeetCrewmatesGate.test.tsx — any kirocrew_owned: true row counts as built-in; a row flagged false, or without the flag, is a custom agent; a persist refused at onCreated is shown while the ready step is up and onDone still closes at once (before the server answers); a persist refused at exit closes at once too and is carried to the next entry until a write succeeds; a refusal marks nothing locally (no render cache, pending mark intact, flag false) and does not auto-fire again that session while the entry still opens it; a failed eligibility read sets eligibilityError (dismissible) while the flow stays closed and the page entry still opens it; the real gate against the real useTheme: closed until the tour ends, opens, stays open through onCreated, closes on onDone; a new user who reloads between the tour and the chapter (server says onboarded, browser holds mc-crewmates-pending) is still offered it, and finishing it clears the mark; stays closed (and reads nothing) while the Crew Members preview is off; stays closed with an existing crewmate or an installed custom agent; an already-onboarded workspace counts as done yet the Crewmates page event still opens it.
  • test/test_api_theme_config.py — the payload carries crewmates_onboarded; PUT persists it and rejects a non-boolean.
  • test/test_config_loader.py — default False, round-trips.
  • website/src/test/App.importChapterReopen.test.tsx — theme mock carries the two new members.

Manual verification

Static gates locally (tsc, eslint, i18n gates, phantom-classes, black/isort/flake8/mypy, docs lint, feature map, jscpd, npm run build); CI runs the suites. The flow below was driven through its own buttons by Playwright against a Vite dev server of this head, every /api/* answered by fixtures; the capture asserted 135 checks per run (one dialog, step counter, vocabulary, theme, no raw keys, every footer button inside the viewport, the two writes' bodies: POST /api/agents with the job as description, POST /api/crons with member_id = the identity the create returned, non-silent, hide_in_chat: false, 0 9 * * *, a message that is the job text alone).

Screenshots / video

Screenshots: real components rendered against stubbed /api (Vite + Playwright); backend exercised by CI only. 1440x900. Every frame below was driven through the flow's own buttons; the capture asserts the state before each shot.

Step Dark Light
1 Meet CrewMates Step 1, dark Step 1, light
2 Name your first crewmate Step 2, dark Step 2, light
3 Give Radar a job Step 3, dark Step 3, light
4 Radar is ready Step 4, dark Step 4, light

Step transitions 1 → 4 (slide between steps, footer cross-fade), dark:

Meet CrewMates step transitions

Entry point and every introduced error / busy state (dark)
State Frame
Crewmates page, only the built-in default row: the Meet CrewMates entry with its one-line gloss as a block line under the button Crewmates page entry
Step 2, a name that fails the grammar ("Issue Radar"): the rule as a plain hint under the field, Next disabled, nothing posted Name hint
Step 2, custom agents could not be read (default agent still offered) Built from unavailable
Name already taken (409): back on step 2, error under the name field with a button to the Crew Members page, the Radar chip marked "already exists", Next disabled Name taken
Step 3, create got no usable answer (5xx / dropped): "may or may not have been created", no schedule posted, button to the Crewmates page Create outcome unknown
Step 3, create refused by the server (4xx): nothing was made Create failed
Step 3, busy while the create is in flight Creating Radar
Step 3, Slack connected: status row reads "Active" (no switch) Slack connected
Step 3, Slack status could not be read Slack status unavailable
Step 4, "Only when I ask": no schedule posted, no reports or Schedule-page copy Only when I ask
Step 4, crewmate created but the schedule was refused by the server (4xx): nothing saved; button to the Schedule page Schedule not saved
Step 4, the schedule write got no usable answer (5xx / dropped response): "may not have been saved"; button to the Schedule page Schedule did not answer
App-level notice when the eligibility read failed (flow closed; Dismiss, or Open Meet CrewMates) Eligibility read failed
"Done" could not be persisted: shown on the ready step when the create-time write failed, or on the next entry when the write at exit failed (the exit itself closed at once) Save failed

The page behind the scrim still reads "Crew Members": the roster rename is a sibling PR of the launch, not this one. A fresh workspace's roster carries the built-in default row (the main assistant), which is why the entry condition is "only default", not "empty".

Related Issues

Part of the CrewMates launch (screen 08). The job text is stored in the existing description field; if a dedicated standing-job field lands in a sibling PR, this flow should write it too (one-line follow-up). A failed roster or installed-agent read in the gate itself keeps the automatic chapter closed on purpose (fail-safe: do not interrupt when unsure); the Crewmates page entry stays available.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested review from a team and cixuuz September 22, 2026 22:12
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Intent: Give a brand-new user (no crewmates, no custom agents) a four-step first-run path from "what is a crewmate" to owning one with a standing job and a schedule, using the shipped onboarding chrome and the existing agent/cron APIs.
Not a goal: Renaming the Crewmates page or its roster vocabulary, a dedicated standing-job field, delivery settings beyond the cron message, or the opt-in step for users who already have custom agents.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 22, 2026
@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of cbcf16238686c7b89c0766919a312e4eb4f9df95 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Confirm the in-PR RFC amendment: accepted screen 08 decided a "Slack DM" report choice; this ships a status row instead — runtime constraint verified (slack/gateway.py:4084).

Not justified as shipped

  • Item 10 — undeclared: chunk-t bundle budget raised 951→955 KB; a mechanical consequence of ~60 new catalog keys × 12 locales, stated only in the diff's own comment.

What this change ships

Inventory (10 items) — 9 justified

Intent: give a first-run user a guided path from "what is a crewmate" to owning one with a standing job — an ADDITION, covered by rfc-crewmates-launch.md (accepted on base, screen 08).

  1. Four-step Meet CrewMates chapter auto-fires once after the tour, dark behind PREVIEW_CREW, only for an empty roster with only Kiro-owned agents — justified
  2. Crew Members page offers a "Meet CrewMates" button while only default is on the roster — justified
  3. Step-3 Slack line is a status row, not the RFC's decided "Slack DM" choice; RFC amended in this same PR — justified
  4. POST /api/agents now refuses names the roster would skip (invalid_agent_name), for every client; CLI sibling declared unfixed — justified
  5. Create response returns member_id; the schedule binds by it, never by name — justified
  6. New server-backed config key dashboard.crewmates_onboarded on the theme boot/GET/PUT surface — justified
  7. Already-onboarded workspaces are never auto-interrupted (mc-onboarded seed + mc-crewmates-pending reload guard) — justified
  8. A failed eligibility read shows a dismissible notice with an "Open Meet CrewMates" remedy — justified
  9. Live name-grammar hint from a frontend copy of the backend regex, pinned by test_meet_crewmates_builtin_pin.py — justified
  10. Chunk-t bundle budget 951→955 KB — undeclared

Evidence checked: roster skip is real (handlers/members.py:124), kirocrew_owned is server-stamped (agent_discovery.py:1642), cron accepts member_id/hide_in_chat (handlers/cron.py:719,744), no per-job Slack knob exists (slack/gateway.py:4084 owner-DM leg fires on every non-silent, channel-less job), CLI sibling count = 1 (cli_commands.py:1273), and the whole flow sits behind an off-by-default preview, so lens 9's product-shape trigger does not fire.

[FIRST-PRINCIPLES-REVIEWED] cbcf162

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of cbcf16238686c7b89c0766919a312e4eb4f9df95 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the localStorage-only mc-crewmates-pending mark: a new user switching browsers between tour and chapter is silently reclassified as an existing install.

Suggestions

  • The new/existing distinction could ride the server like everything else here: one more boolean on the theme PUT you already added would survive a browser switch or cleared storage; the page entry makes this optional, not required.

[DESIGN-REVIEWED] cbcf162

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed cbcf16238686c7b89c0766919a312e4eb4f9df95 — this comment is updated in place on each push.

Review details

The first crewmate's own schedule is invisible in its wake pane, and the Slack row states "Off" for an unread Slack — both advisory, neither blocks.

FINDING — website/src/components/MeetCrewmatesFlow.tsx:344 — the schedule is bound with member_id: identity (the server's slug, "radar" for the prefilled name "Radar") and bind_cron_memory re-stamps the stored job with that same canonical id, but the crewmate editor's wake pane and rail count filter with wakesCrew(j, editing, …) → job.member_id === crew against the display name, so "radar" === "Radar" is false and the schedule the flow just created is absent from that crewmate's Schedules pane and its count for any name that is not already lowercase → Fix: pass the crew's member_id (from the roster row) into wakesCrew/CrewWakeSection instead of the display name — an edit to website/src/components/crew/wakesCrew.ts and KiroCrewAgentsPage.tsx, files this PR does not touch, so it cannot land inside this change.

FINDING — website/src/components/MeetCrewmatesFlow.tsx:786 — const slackReady = !!slack?.connected collapses a failed GET /api/slack/config (the query is retry: false, so one transient 5xx or a restart is enough) into a definite report_slack_state_off / report_slack_not_connected row, telling the user reports do not reach Slack for a workspace that is in fact connected, while the adjacent slack_status_unavailable notice says the opposite → Fix: when slackFailed, suppress the state word and the not-connected hint (render the unread case) instead of rendering the "Off" claim.

[OPUS-REVIEWED] cbcf162

Verdict parsed from the review's SHA-scoped output markers for commit cbcf16238686c7b89c0766919a312e4eb4f9df95.

False positive or not applicable? A repository writer can comment:
/ai-review override fable cbcf16238686c7b89c0766919a312e4eb4f9df95: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of cbcf16238686c7b89c0766919a312e4eb4f9df95 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

"Ask the agent" on the flow's error notices is vocabulary this first-run user was never taught, and the reader avoided it; the transitions GIF is blank.

Watch

  • "Ask the agent" hand-off: the flow teaches "crewmate"/"member", then error notices say "agent" — blind reader: "I can't tell which 'agent' it means … I'd leave it alone", so the recovery affordance goes unused (error-path only, friction, every notice). MeetCrewmatesEligibilityNotice's own comment states "No agent hand-off, by decision: a first-run user has not met the agent yet" yet the code passes askAgent (MeetCrewmatesFlow.tsx). Smallest fix: drop askAgent there per the stated decision, and reconsider it on the step-1/4 notices, which already carry specific remedy buttons.
  • The recording claimed as "Step transitions 1 → 4 … dark" (shot-09.gif) renders as a blank white frame — the blind reader saw "a plain white rectangle", and this lane's read shows the same, so a human may have nothing to watch. Re-capture and re-attach the GIF.

Suggestions

  • report_chat_hint / ready_where say "rings the bell" — the reader never saw a bell in any screenshot; say "the notification bell in the header" (or equivalent) once.

[UX-REVIEWED] cbcf162

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of cbcf16238686c7b89c0766919a312e4eb4f9df95 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] cbcf162

False positive or not applicable? A repository writer can comment:
/ai-review override gpt cbcf16238686c7b89c0766919a312e4eb4f9df95: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu

CrysisDeu commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor Author

Ships dark. The flow is behind the existing Crew Members feature preview (Settings → Developer → Feature Previews, PREVIEW_CREW, off by default) — the same switch that shows the Crewmates page. Nothing is visible to a user who has not opted in, so this can merge ahead of the CrewMates launch and be iterated on in follow-ups.

@CrysisDeu
CrysisDeu force-pushed the feat/meet-crewmates-first-run branch from f938239 to daf2e1f Compare September 22, 2026 22:31
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for f938239abd3d7e2d1b200765eaaeda69c347b0ba; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt f938239abd3d7e2d1b200765eaaeda69c347b0ba: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for daf2e1ff60540fbd36f3149376b3c2069de9047f; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt daf2e1ff60540fbd36f3149376b3c2069de9047f: <one-sentence reason>

@CrysisDeu
CrysisDeu force-pushed the feat/meet-crewmates-first-run branch from daf2e1f to de05346 Compare September 22, 2026 23:01
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 22, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/meet-crewmates-first-run branch from de05346 to 197f33f Compare September 22, 2026 23:38
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 22, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=afaae5c82a69

  • completion persistence failures are silent — fixed in 197f33f

markCrewmatesOnboarded now awaits its PUT (mutateAsync) and rejects on failure; useMeetCrewmatesGate catches it into persistFailed and MeetCrewmatesFlow renders that as an inline ErrorNotice on the current step.
The flow stays open after a refused write; the user's next exit closes it anyway (the local mark is already set, so this machine cannot replay the chapter; another machine might once). Covered by useMeetCrewmatesGate.test.tsx ("a refused persist keeps the flow open…") and MeetCrewmatesFlow.test.tsx ("a refused 'done' write is shown as an ErrorNotice…"); the state is in the PR's evidence table.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=56704161f83d

  • "This chat" contradicts its hint — fixed in 197f33f

The toggle label is now "Its own chat" in all 12 catalogs (components.meetCrewmatesFlow.report_chat); the hint "posts a summary in its own chat" is unchanged, so label and hint name the same place. New step-3 frames in the PR body show it.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=9b01b09e763d

  • "Built from" hint leans on "custom agent" — fixed in 197f33f

The hint is now "What {{name}} starts from. You can swap it later." (components.meetCrewmatesFlow.built_from_hint, all 12 catalogs); "agent" survives only in the select's own option label "Default agent", which names the thing being picked.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=b2e03d9a649b

  • Step 4's only visible exit forces navigation — fixed in 197f33f

Step 4 now has a quiet secondary Done (closes the flow, no navigation) beside the primary "Open {{name}}'s chat" — two buttons, within the row limit. Escape still closes. Shown in the new step-4 frames.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=5c5d1e3af4db

  • Step-1 example rows read as maybe-selectable — rebutted

The three rows are illustrations of what a crewmate is, not choices: step 1 has no state to set, and the very next step offers the same three names as real, pressable chips (with aria-pressed) that prefill name and job. Making the rows clickable would duplicate that control one screen earlier and give step 1 a hidden effect with no visible confirmation.
Proportionality: a once-per-workspace intro screen; the rows are plain li with no hover/focus affordance, so they do not advertise interactivity. Kept as static examples.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=42865c6a409c

  • Delivery is instruction-only on the first-run cron — fixed in 197f33f (second clearance path)

The ready step now tells the user where a report lives whether or not the agent posts it: "Its reports show up in its chat; every run is also listed on the Schedule page." (components.meetCrewmatesFlow.ready_where, 12 catalogs) — the Schedule page's run history is written by the runner, not by the model, so a wake that skipped send_message is still visible there.
The silent choice stays: the runtime's default fan-out includes the owner's Slack DM, which would deliver to a destination the user left switched off (the earlier GPT blocking finding). Evidence of a real wake needs a live gateway, which the launch's evidence path (Vite + stubbed /api) does not provide; noted in the body.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=3216f4be30d3

  • "Your main assistant, default, stays as it is": unquoted name and restated panel line — fixed in 124b1d9

step1_footnote is now “Your main assistant, “default”, stays as it is. Each crewmate gets better at its job over time.” in all 12 catalogs (locale quote marks), dropping the memory/chat/notes restatement the purple panel already carries.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Evidence gaps: step-2 name-grammar hint state and step-4 "Only when I ask" variant — fixed in 124b1d9

Two frames added and attached to the body from this head: meet-2-name-hint-invalid-dark ("Issue Radar" typed, plain hint under the field, Next disabled, no alert, nothing posted) and meet-4-ready-ask-dark (no schedule posted, no reports / Schedule-page copy); a third, meet-3-error-create-unknown-dark, covers the new unanswered-create notice. The harness asserts each state before shooting (135 checks).

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=33f7b000336f

  • F1 Schedule binding uses a mutable display name; F2 Reconciliation accepts an unrelated schedule — fixed in 39d17e9

F1: POST /api/agents now returns the crew's immutable member_id (allocated with its member memory; member_config_for_id resolves it and never a name or slug) beside memory_store, the flow holds THAT as the crewmate's identity and posts the schedule with member_id = that identity, never the display name — so a same-named crewmate remade between the two writes cannot receive the job (the id resolves to the crewmate just made, or to nothing, which the flow reports as a refusal). F2: the reconcile of an unanswered schedule write counts only a job that IS the one asked for — member_id = the held identity AND the same name AND the same message AND the same schedule (cron_expr / every_secs) — so an older or foreign job on the crewmate, and the same job on a same-named crewmate with another identity, are not evidence; the roster read is gone. The cron create API has no client-supplied key, so exact-field identity is the strongest available match. Tests: cron body bound to radar-id; reconcile accepts only the exact job; rejects other-schedule / other-message / other-identity jobs; test_config_api asserts the create response carries member_id. Spec, body and harness (bound by identity) updated.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=49f321101c97

  • A new user who reloads after the tour is counted "already onboarded" — fixed in 39d17e9

The heuristic now tells a mid-first-run reload from a pre-existing install: the tour's completion (markOnboarded) leaves localStorage['mc-crewmates-pending'] on that browser; the crewmatesOnboarded seed and the boot rule both exempt a workspace carrying the mark from "already onboarded counts as done", and markCrewmatesOnboarded clears it. Only a workspace onboarded with no such mark (before this shipped, or from another machine) is treated as existing. No server-side backfill needed. Test: "a NEW user who reloads between the tour and this chapter is still due it" (useMeetCrewmatesGate.test.tsx) — first load runs the tour, second load boots with onboarded: true and still opens the chapter, finishing clears the mark. Spec (config.md) and body record the rule.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author
  • Evidence gap: shots 10/22 showed the pre-fix inline gloss — fixed in 39d17e9

All 23 media re-shot from this head and re-attached (the earlier push had added only the three new frames, leaving the entry and step-1 frames at their pre-fix uploads). The Crew Members entry frame now shows the block-line gloss; the harness asserts each state before shooting (135 checks).

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=6cbf44c41e0a

  • One page, two names ("Crewmates page" vs "Crew Members page") — fixed in 39d17e9

error_create_unknown and open_crewmates now say "Crew Members page" — the page's shipped title, the same words error_name_taken uses — in all 12 catalogs (+ en-XA). The rename to Crewmates is the sibling PR and will move every string at once.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=31af23768d0e

  • eligibility_error points at a page the user may already be on — fixed in 39d17e9

The notice's remedy is now an Open Meet CrewMates button (meet-crewmates-eligibility-open) that fires the same mc-start-meet-crewmates event as the Crew Members entry and dismisses the notice; the sentence no longer names a page (eligibility_error / new eligibility_open, 12 catalogs). Test extended; frame re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=4378d8b709aa

  • Invalid name: grey hint never plainly says the name is rejected — fixed in 39d17e9

The hint under the name field is rendered in the theme's warning colour (text-warn-fg) — it only appears once the name fails the grammar, so "grey while valid" holds by construction — and stays a plain <p> (no role=alert), since nothing failed and no request was made. Frame re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=7d02248701fc

  • Slack row's "Active"/"Off" sits in the toggle column — fixed in 39d17e9

The state word moved into the label line — "Slack DM — Active" / "Slack DM — Off" — and the toggle column is empty; the reason stays under it. Test asserts the label line reads "Slack DM — Off"; both Slack frames re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=73e5f15283f2

  • meet_crewmates_hint is a lowercase fragment — fixed in 39d17e9

Now a sentence: "A guided intro that creates your first crewmate." in all 12 catalogs (+ en-XA); entry frame re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=afaae5c82a69

  • Failed persistence is recorded as completed locally — fixed in 4bb7257

markCrewmatesOnboarded now awaits the PUT FIRST and applies every piece of local completion state — the mc-crewmates-onboarded render cache, the mc-crewmates-pending clear and the in-memory flag — only after the server accepted; a refused write leaves all three untouched, so a reload re-offers the chapter (what the save_failed notice already says) instead of seeding a completion the server never recorded. The gate keeps its one-tolerated-failure exit and additionally does not auto-fire again within the same session after it closed (closedThisSessionRef); the Crew Members entry still opens it on demand. Test: the refused-persist case asserts no render cache, pending mark intact, flag false, no same-session auto-reopen, entry still opens. Spec and body updated.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=d9fed3403e15

  • Focus trap and Escape never install on step 1 in host mode (dep array omits shellHost?.sectionSlot) — fixed in 4bb7257

Correct and my own regression from the round-18 refactor: shellHost?.sectionSlot is back in the keydown effect's dependency array with a comment stating why — in host mode the dialog node does not exist on the commit where open flips, the effect bails at if (!dialogRef.current) return, and it must re-run once the host has rendered the dialog.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=fb1b6e543adc

  • Apply the same name grammar to kirocrew agent create in a follow-up — rebutted

Agreed as a follow-up, as the suggestion itself frames it — not in this PR. The CLI path pre-exists this change, is not touched by it, and the spec/body already name it as the level left; a CLI gate needs its own error surface and tests and is a separate decision.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=2ba22d72034b

  • Taken-name error says "open it from the Crew Members page" but offers no way there — fixed in 4bb7257

The 409 notice under the name field now carries the same footer button as the unknown-create notice — "Open the Crew Members page" (meet-crewmates-name-taken-open, block variant) — which dismisses the flow and navigates there; the grammar (400) notice stays the one-line inline form. Test and harness assert the button; frame re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=5f9b0cb1395c

  • After a 409 the chip still offers the refused name — fixed in 4bb7257

The suggestion chip whose name the server refused is marked: struck through in the danger tint, its gloss replaced by "already exists" (chip_taken, 12 catalogs + en-XA), with a matching title; it clears when the name is edited. Test asserts Radar · already exists; frame re-shot.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=487c65022710

  • ready_no_schedule says "Set one from its page" while the button opens the Schedule page — fixed in 4bb7257

ready_no_schedule now says "Set one from the Schedule page." in all 12 catalogs (+ en-XA), so copy and action agree; frame re-shot.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for 2391c370e2cb0635a49abad3f430c880dcf98dac; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2391c370e2cb0635a49abad3f430c880dcf98dac: <one-sentence reason>

A user with no crewmates and no custom agents had no path from "what
is a crewmate" to owning one: the Crewmates page empty state sent them
to the crew editor, a form that assumes they already know what to fill
in. This adds a four-step first-run chapter in the shipped split-screen
chrome: meet the idea (three example crewmates), name the first one and
pick what it is built from, give it a standing job with a schedule and
a place to report, then open its chat.

Create reuses the existing writes: POST /api/agents makes the crewmate
(the job text lands in its description, the roster's "what it is for"
field) and POST /api/crons binds a schedule to it through member_id so
the job runs on the crewmate's own memory. A taken name stays on step 3
with an ErrorNotice; a failed schedule still reaches "ready" and says
so.

The flow fires once, after the Customize tour, gated on zero crewmates
beyond the built-in default row and zero installed agents beyond the
built-ins, so an existing user with custom agents (who gets the opt-in
step instead) never sees it. Completion or dismissal is recorded as the
new dashboard.crewmates_onboarded flag through the theme endpoints; a
workspace that was already onboarded counts as done and reaches the
flow from the Crewmates page instead, which also keeps the E2E and
capture harnesses (seeding only mc-onboarded) clear of it.
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=33f7b000336f

  • Failure notices omit a sanctioned hand-off decision -- fixed

Round 22 (2391c37): askAgent is on for every notice where nothing can be lost -- the eligibility notice, the step-4 schedule notices and the "done" notice on steps 1 and 4 -- and it closes the flow the way that step's own exit does, because the chat sits behind the dialog. Beside the unsaved name and job on steps 2-3 it stays off with the concrete-draft comment naming the draft, per errors-use-error-notice.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=44cf54d1606b

  • Existing users completing a manual onboarding replay get mc-crewmates-pending set -- fixed

Round 22: markOnboarded writes the pending mark only on a FIRST tour completion (not yet onboarded); a replay from Settings leaves no mark, so a reload does not auto-open the chapter for an existing user. Gate test an existing user replaying the tour leaves no pending mark covers it.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=8bd2dfd2e02f

  • example_fixer_task says "red CI" while the Fixer row reads "failing checks" -- fixed

Round 23 (17bee01): example_fixer_task now reads "Reruns and fixes failing checks before I notice" in all 12 catalogs (en-XA regenerated), matching the Fixer row.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=b4396c191a80

  • Step 2 invalid-name state: the seed-drawn avatar beside the grammar hint reads as a name change -- fixed

Round 23: the avatar is greyed (opacity-40 grayscale) while the grammar hint is showing, so the frame reads as "the name is not accepted", not "the name changed". Frame Name hint re-shot from the new head.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

span=d9fed3403e15

  • Every exit that navigates runs finish then navigate while the host's close is gated on an awaited PUT -- fixed

Round 24 (cbcf162): onDone closes the chapter at once (setOpen(false) before the write) and persists afterwards; a refused write at exit is carried in persistFailed and shown on the next entry, while the create-time write still reports on the ready step. Nothing local is marked on a refusal (unchanged). Gate tests: exit closes before the server answers; refused exit write shows on the next entry until a write succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants