Repository navigation
fix(ci): record restyle-ratchet progress from #12805 so main lints again - #13008
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
19ff2ef to
ad802dc
Compare
GPT 5.6 Review —
|
GPT 5.6 Review —
|
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] e5de8ce |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] e5de8ce |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem: `Frontend Lint & Type Check` is red on main since 914d756 (run https://github.com/kirodotdev/KiroCrew/actions/runs/35819227070, tracked in #13006): restyle ratchet: 347 restyle site(s) in 50 file(s); baseline records 349 in 51 ::error::restyle ratchet: 1 file(s) now have fewer restyle sites than the baseline records. Record the progress so the ceiling cannot drift back up: npm run lint:restyle-ratchet -- --update-baseline website/src/pages/members/MembersPage.tsx: 2 -> 0 The ratchet is two-way: a file that drops below its recorded count fails until the baseline is lowered, so the ceiling cannot drift back up. What changed: `website/scripts/restyle-baseline.json` drops its `MembersPage.tsx` entry (2 -> 0 sites), the output of `npm run lint:restyle-ratchet -- --update-baseline`. The two sites were removed by #12805 (35cf01d, "feat(members): crewmate panel opens on Notes, Work log, Dashboard"), the only commit touching that file in the 04:39Z merge burst (ec99705..914d756). Baseline is now 347 sites in 50 files, matching the tree. Tests: `npm run lint:restyle-ratchet -- --test` and `npm run lint:restyle-ratchet` (green, "every file matches the baseline"), `npx eslint src/ --max-warnings 0` and `npx tsc -p tsconfig.app.json` all exit 0 locally. Not in this PR: the shard-7 `crew-log exc_info` tripwire red on main (#13005) is a separate failure with its own owner. Fixes #13006
ad802dc to
e5de8ce
Compare
…n lints again (kirodotdev#13008) Problem: `Frontend Lint & Type Check` is red on main since 914d756 (run https://github.com/kirodotdev/KiroCrew/actions/runs/35819227070, tracked in kirodotdev#13006): restyle ratchet: 347 restyle site(s) in 50 file(s); baseline records 349 in 51 ::error::restyle ratchet: 1 file(s) now have fewer restyle sites than the baseline records. Record the progress so the ceiling cannot drift back up: npm run lint:restyle-ratchet -- --update-baseline website/src/pages/members/MembersPage.tsx: 2 -> 0 The ratchet is two-way: a file that drops below its recorded count fails until the baseline is lowered, so the ceiling cannot drift back up. What changed: `website/scripts/restyle-baseline.json` drops its `MembersPage.tsx` entry (2 -> 0 sites), the output of `npm run lint:restyle-ratchet -- --update-baseline`. The two sites were removed by kirodotdev#12805 (35cf01d, "feat(members): crewmate panel opens on Notes, Work log, Dashboard"), the only commit touching that file in the 04:39Z merge burst (ec99705..914d756). Baseline is now 347 sites in 50 files, matching the tree. Tests: `npm run lint:restyle-ratchet -- --test` and `npm run lint:restyle-ratchet` (green, "every file matches the baseline"), `npx eslint src/ --max-warnings 0` and `npx tsc -p tsconfig.app.json` all exit 0 locally. Not in this PR: the shard-7 `crew-log exc_info` tripwire red on main (kirodotdev#13005) is a separate failure with its own owner. Fixes kirodotdev#13006
Problem / Motivation
Frontend Lint & Type Checkis red onmainsince914d756fcc(run 35819227070, tracked in #13006). The restyle ratchet refuses the tree because one file has fewershadcn/no-restylesites than its recorded baseline:Why it matters
Every PR is now tested against a red base:
Frontend Lint & Type Checkfails onrefs/pull/<n>/mergefor any branch, so no frontend PR can go green untilmainis healed. The ceiling itself is also stale: until the baseline is lowered, a future change could re-add two restyle sites toMembersPage.tsxunnoticed.What changed (motivation → approach → change)
The baseline now records what the tree has:
website/scripts/restyle-baseline.jsondrops itswebsite/src/pages/members/MembersPage.tsxentry (2 → 0 sites), which is exactly the output ofnpm run lint:restyle-ratchet -- --update-baseline. The baseline totals 347 sites in 50 files, matchingmain.Root cause is merge skew between two green PRs. #12853 (
78da79c498) added the two-way ratchet and seeded the baseline frommainat 01:29Z on 2026-09-23, counting 2 sites inMembersPage.tsx. #12805 (35cf01d60d, "feat(members): crewmate panel opens on Notes, Work log, Dashboard") removed those two sites; its last CI run started at 01:22Z, seven minutes before the ratchet existed, so nothing ever compared its tree against the baseline. It merged at 04:35Z andmainwent red on the first push after it. #12805 is the only commit touchingMembersPage.tsxinec99705bed..914d756fcc.The ratchet is deliberately two-way, so lowering the baseline is the fix it asks for, and the only change: no ceiling is raised, no code moves. Open feature PRs #12832 and #12787 carry this same one-line removal after rebasing onto the red
main; whichever lands first healsmain, and the identical hunk rebases clean for the others.Not in this PR: the
Backend Testsshard 7 red onmain(the crew-logexc_infotripwire) is a separate failure tracked in #13005.Backwards compatibility
Compatible: the diff only lowers one recorded count in a lint baseline; no runtime code, contract or config changes.
Tests
No tests added: the change is a one-line baseline update with no code path. Gates run locally on this head, all exit 0:
npm run lint:restyle-ratchet -- --test(8 probes agree) andnpm run lint:restyle-ratchet(every file matches the baseline)npx eslint src/ --max-warnings 0npx tsc -p tsconfig.app.jsonManual verification
N/A — the ratchet gate run locally is the same check that fails on
main; it passes on this head.Screenshots / video
Why no screenshot: the diff touches only
website/scripts/restyle-baseline.json, a lint baseline; nothing renders differently.Related Issues
Fixes #13006
Pattern harvest
Rule candidate: agents-md
Pattern: a two-way count ratchet (restyle, phantom-classes) goes red on
mainafter merge skew when a PR whose last CI predates the ratchet or the baseline lowers a count nobody re-recorded; the heal is--update-baseline, never a raised ceiling.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)