Skip to content

fix(ci): record restyle-ratchet progress from #12805 so main lints again - #13008

Merged
bolichen97 merged 1 commit into
mainfrom
fix/restyle-ratchet-baseline-after-0439-burst
Sep 23, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/restyle-ratchet-baseline-after-0439-burst

Conversation

@pepmach

@pepmach pepmach commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Frontend Lint & Type Check is red on main since 914d756fcc (run 35819227070, tracked in #13006). The restyle ratchet refuses the tree because one file has fewer shadcn/no-restyle sites than its recorded baseline:

restyle ratchet: 347 restyle site(s) in 50 file(s); baseline records 349 in 51
::error::restyle ratchet: 1 file(s) now have fewer restyle sites than the baseline records. Record the progress so the ceiling cannot drift back up: npm run lint:restyle-ratchet -- --update-baseline
  website/src/pages/members/MembersPage.tsx: 2 -> 0

Why it matters

Every PR is now tested against a red base: Frontend Lint & Type Check fails on refs/pull/<n>/merge for any branch, so no frontend PR can go green until main is healed. The ceiling itself is also stale: until the baseline is lowered, a future change could re-add two restyle sites to MembersPage.tsx unnoticed.

What changed (motivation → approach → change)

The baseline now records what the tree has: website/scripts/restyle-baseline.json drops its website/src/pages/members/MembersPage.tsx entry (2 → 0 sites), which is exactly the output of npm run lint:restyle-ratchet -- --update-baseline. The baseline totals 347 sites in 50 files, matching main.

Root cause is merge skew between two green PRs. #12853 (78da79c498) added the two-way ratchet and seeded the baseline from main at 01:29Z on 2026-09-23, counting 2 sites in MembersPage.tsx. #12805 (35cf01d60d, "feat(members): crewmate panel opens on Notes, Work log, Dashboard") removed those two sites; its last CI run started at 01:22Z, seven minutes before the ratchet existed, so nothing ever compared its tree against the baseline. It merged at 04:35Z and main went red on the first push after it. #12805 is the only commit touching MembersPage.tsx in ec99705bed..914d756fcc.

The ratchet is deliberately two-way, so lowering the baseline is the fix it asks for, and the only change: no ceiling is raised, no code moves. Open feature PRs #12832 and #12787 carry this same one-line removal after rebasing onto the red main; whichever lands first heals main, and the identical hunk rebases clean for the others.

Not in this PR: the Backend Tests shard 7 red on main (the crew-log exc_info tripwire) is a separate failure tracked in #13005.

Backwards compatibility

Compatible: the diff only lowers one recorded count in a lint baseline; no runtime code, contract or config changes.

Tests

No tests added: the change is a one-line baseline update with no code path. Gates run locally on this head, all exit 0:

  • npm run lint:restyle-ratchet -- --test (8 probes agree) and npm run lint:restyle-ratchet (every file matches the baseline)
  • npx eslint src/ --max-warnings 0
  • npx tsc -p tsconfig.app.json

Manual verification

N/A — the ratchet gate run locally is the same check that fails on main; it passes on this head.

Screenshots / video

Why no screenshot: the diff touches only website/scripts/restyle-baseline.json, a lint baseline; nothing renders differently.

Related Issues

Fixes #13006

Pattern harvest

Rule candidate: agents-md
Pattern: a two-way count ratchet (restyle, phantom-classes) goes red on main after merge skew when a PR whose last CI predates the ratchet or the baseline lowers a count nobody re-recorded; the heal is --update-baseline, never a raised ceiling.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@pepmach
pepmach requested a review from a team September 23, 2026 05:24
@pepmach pepmach added the pr-no-autofix Author opted out of PR automation label Sep 23, 2026
@pepmach
pepmach requested a review from iamwhatever September 23, 2026 05:24
@pepmach pepmach added the pr-no-autofix Author opted out of PR automation label Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of e5de8ce7736f7353c4604290b9e2bcac7f565aed and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] e5de8ce

False positive or not applicable? A repository writer can comment:
/ai-review override gpt e5de8ce7736f7353c4604290b9e2bcac7f565aed: <one-sentence reason>

@pepmach
pepmach force-pushed the fix/restyle-ratchet-baseline-after-0439-burst branch from 19ff2ef to ad802dc Compare September 23, 2026 05:26
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for 19ff2efc1d814f5159dd3380e3c8ee37b2ee6cde; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 19ff2efc1d814f5159dd3380e3c8ee37b2ee6cde: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ⚠️ review incomplete

GPT 5.6 did not produce a complete verdict for ad802dc90409a9d7f552169f98324352ea6d1978; inspect the workflow logs and re-run it.

This comment is updated in place on each push.

See the GPT 5.6 Review job logs; this commit has no completed GPT verdict.

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ad802dc90409a9d7f552169f98324352ea6d1978: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of e5de8ce7736f7353c4604290b9e2bcac7f565aed — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] e5de8ce

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of e5de8ce7736f7353c4604290b9e2bcac7f565aed — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] e5de8ce

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed e5de8ce7736f7353c4604290b9e2bcac7f565aed — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] e5de8ce

Verdict parsed from the review's SHA-scoped output markers for commit e5de8ce7736f7353c4604290b9e2bcac7f565aed.

False positive or not applicable? A repository writer can comment:
/ai-review override fable e5de8ce7736f7353c4604290b9e2bcac7f565aed: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 23, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 23, 2026
Problem: `Frontend Lint & Type Check` is red on main since 914d756
(run https://github.com/kirodotdev/KiroCrew/actions/runs/35819227070,
tracked in #13006):

    restyle ratchet: 347 restyle site(s) in 50 file(s); baseline records 349 in 51
    ::error::restyle ratchet: 1 file(s) now have fewer restyle sites than the
    baseline records. Record the progress so the ceiling cannot drift back up:
    npm run lint:restyle-ratchet -- --update-baseline
      website/src/pages/members/MembersPage.tsx: 2 -> 0

The ratchet is two-way: a file that drops below its recorded count fails
until the baseline is lowered, so the ceiling cannot drift back up.

What changed: `website/scripts/restyle-baseline.json` drops its
`MembersPage.tsx` entry (2 -> 0 sites), the output of
`npm run lint:restyle-ratchet -- --update-baseline`. The two sites were
removed by #12805 (35cf01d, "feat(members): crewmate panel opens on
Notes, Work log, Dashboard"), the only commit touching that file in the
04:39Z merge burst (ec99705..914d756). Baseline is now 347 sites
in 50 files, matching the tree.

Tests: `npm run lint:restyle-ratchet -- --test` and
`npm run lint:restyle-ratchet` (green, "every file matches the
baseline"), `npx eslint src/ --max-warnings 0` and
`npx tsc -p tsconfig.app.json` all exit 0 locally.

Not in this PR: the shard-7 `crew-log exc_info` tripwire red on main
(#13005) is a separate failure with its own owner.

Fixes #13006
@pepmach
pepmach force-pushed the fix/restyle-ratchet-baseline-after-0439-burst branch from ad802dc to e5de8ce Compare September 23, 2026 07:53
@bolichen97
bolichen97 enabled auto-merge (squash) September 23, 2026 08:21
@bolichen97
bolichen97 disabled auto-merge September 23, 2026 08:21
@bolichen97
bolichen97 merged commit 21182a5 into main Sep 23, 2026
91 of 93 checks passed
@bolichen97
bolichen97 deleted the fix/restyle-ratchet-baseline-after-0439-burst branch September 23, 2026 08:21
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Sep 23, 2026
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…n lints again (kirodotdev#13008)

Problem: `Frontend Lint & Type Check` is red on main since 914d756
(run https://github.com/kirodotdev/KiroCrew/actions/runs/35819227070,
tracked in kirodotdev#13006):

    restyle ratchet: 347 restyle site(s) in 50 file(s); baseline records 349 in 51
    ::error::restyle ratchet: 1 file(s) now have fewer restyle sites than the
    baseline records. Record the progress so the ceiling cannot drift back up:
    npm run lint:restyle-ratchet -- --update-baseline
      website/src/pages/members/MembersPage.tsx: 2 -> 0

The ratchet is two-way: a file that drops below its recorded count fails
until the baseline is lowered, so the ceiling cannot drift back up.

What changed: `website/scripts/restyle-baseline.json` drops its
`MembersPage.tsx` entry (2 -> 0 sites), the output of
`npm run lint:restyle-ratchet -- --update-baseline`. The two sites were
removed by kirodotdev#12805 (35cf01d, "feat(members): crewmate panel opens on
Notes, Work log, Dashboard"), the only commit touching that file in the
04:39Z merge burst (ec99705..914d756). Baseline is now 347 sites
in 50 files, matching the tree.

Tests: `npm run lint:restyle-ratchet -- --test` and
`npm run lint:restyle-ratchet` (green, "every file matches the
baseline"), `npx eslint src/ --max-warnings 0` and
`npx tsc -p tsconfig.app.json` all exit 0 locally.

Not in this PR: the shard-7 `crew-log exc_info` tripwire red on main
(kirodotdev#13005) is a separate failure with its own owner.

Fixes kirodotdev#13006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-no-autofix Author opted out of PR automation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: main is red -- restyle ratchet baseline is above the tree after the 04:39Z website burst (Frontend Lint & Type Check)

2 participants