Skip to content

test(members): wait for the gone-member redirect before asserting the URL - #13123

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
billygerhard:fix/members-page-gone-member-url-wait
Sep 23, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
billygerhard:fix/members-page-gone-member-url-wait

Conversation

@billygerhard

Copy link
Copy Markdown
Contributor

Problem / Motivation

website/src/pages/members/MembersPage.test.tsx › a URL naming a gone member with NOTHING remembered returns to the roster and SAYS so flakes on Frontend Tests (4) (#13107): expected '/members?member=ghost' to be '/members'.

Why it matters

A red frontend shard on a PR that never touched the Members page; on a fork PR the re-roll also costs a maintainer another workflow release. #11827 hit it once today; the shard was green on the two previous heads and on main.

What changed

Symptom: URL still carries ?member=ghost when read → root cause: the test reads the router location synchronously right after the roster notice renders, but the return to /members is a navigate() issued from an effect once the roster has loaded, so on a slow runner the notice can render a tick before that effect has run → change: await waitFor(() => expect(currentUrl()).toBe('/members')), the same form the file's three other redirect assertions already use. Test-only; no component code touched.

Backwards compatibility

Compatible: test-only change.

Tests

The changed test file (MembersPage.test.tsx, 124 pass locally). The assertion still fails if the page does not return to /members within the waitFor budget.

Manual verification

N/A — unit coverage sufficient; the only change is when the URL is read.

Screenshots / video

N/A — no UI change.

Closes #13107

… URL

The 'gone member with NOTHING remembered' test read the router location
synchronously right after the roster notice rendered, but the return to
/members is a navigate() issued from an effect once the roster has loaded. On
a slow runner the notice renders a tick before that effect runs and the
assertion sees /members?member=ghost (kirodotdev#13107). Wait for the URL with
waitFor, as the file's other redirect assertions already do.

Closes kirodotdev#13107
@billygerhard
billygerhard requested review from a team and CrysisDeu September 23, 2026 17:00
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 252557e3036c465380cef9617ab84174fc783b76 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 252557e

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 252557e3036c465380cef9617ab84174fc783b76 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 252557e

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — ✅ PASS

UX-level review of 252557e3036c465380cef9617ab84174fc783b76 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

Test-only change: one URL assertion in MembersPage.test.tsx wrapped in waitFor. No user-visible control, string, or state is added or changed, so no screenshot is required and no lens applies.

[UX-REVIEWED] 252557e

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 252557e3036c465380cef9617ab84174fc783b76 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 252557e

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 23, 2026
@iamwhatever
iamwhatever merged commit 1646106 into kirodotdev:main Sep 23, 2026
95 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 23, 2026
@billygerhard
billygerhard deleted the fix/members-page-gone-member-url-wait branch September 23, 2026 18:31
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
… URL (kirodotdev#13123)

The 'gone member with NOTHING remembered' test read the router location
synchronously right after the roster notice rendered, but the return to
/members is a navigate() issued from an effect once the roster has loaded. On
a slow runner the notice renders a tick before that effect runs and the
assertion sees /members?member=ghost (kirodotdev#13107). Wait for the URL with
waitFor, as the file's other redirect assertions already do.

Closes kirodotdev#13107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci(frontend): MembersPage "gone member with NOTHING remembered returns to the roster" flakes on shard 4 (URL still /members?member=ghost when asserted)

2 participants