Skip to content

style(settings): use the shared SearchInput for the settings search - #13208

Merged
bolichen97 merged 1 commit into
mainfrom
style/settings-search-shared-input
Sep 24, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
style/settings-search-shared-input

Conversation

@xuejinT

@xuejinT xuejinT commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

The Settings search box drew its own input: its own border, corner radius, focus style and icon. Every other search field in the dashboard (Artifacts, Notifications, the filter bars, the security posture list) uses the shared SearchInput from website/src/components/ui.tsx. So this one box looked slightly different from the rest.

Why it matters

Search fields that look the same read as the same control. A one-off style makes users wonder whether this box behaves differently, and it means a future change to SearchInput misses this box.

What changed (motivation → approach → change)

The desktop Settings search now renders through SearchInput, so it picks up the shared look: rounded-md corners, the standard focus-ring glow, and the shared placeholder tone.

website/src/pages/settings/SettingsSearch.tsx gathers the input's combobox attributes (role, aria wiring, value, change and blur handlers) into one object and hands it to SearchInput. Search, ranking, keyboard navigation and the results dropdown are unchanged. The mobile floating capsule keeps its own borderless input, because the capsule around it already draws the chrome and SearchInput has no way to drop its box. That input hides its outline and nothing replaced it, so it showed no focus at all; the capsule in website/src/components/SidePanelLayout.tsx now turns its border accent-colored while the input has focus (focus-within:border-accent), and the input carries a focus-cue-ok note pointing at it. An unused inputRef is removed.

Backwards compatibility

Compatible: styling only; no props, routes, i18n keys or behavior change. The capsule is shared by every bottom-float header, but Settings is its only consumer today.

Tests

No new tests: the change is visual. The existing Settings search, layout and Settings page suites (401 tests) pass unchanged, along with tsc -p tsconfig.app.json and eslint.

Manual verification

Mounted the real SettingsSearch in the sidebar dock inside the project's own Vite build and captured it on main and on this branch: resting, keyboard-focused, and open with the query "theme" (7 results, no console errors). Also mounted the real SidePanelLayout at 390px wide with the search in the bottom capsule and focused it.

Screenshots / video

Focused, before (main) → after (this PR): tighter corners, focus-ring glow instead of a flat accent border, dimmer placeholder.

Before: focused search box on main

After: focused search box using SearchInput

Open with results after the change; the dropdown is unchanged:

After: search open with results for "theme"

Mobile, focused: the bottom capsule's border turns accent-colored while typing (it showed no focus cue before).

Mobile: bottom search capsule focused, accent border

Related Issues

no linked issue: follow-up to #11381, aligning the relocated search box with the shared SearchInput.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@xuejinT
xuejinT requested review from a team and krishdhasmana September 23, 2026 23:17
@xuejinT

xuejinT commented Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Intent: Make the desktop Settings search box use the shared SearchInput, so it looks like every other search field in the dashboard.
Not a goal: changing search behavior, the results dropdown, or the mobile floating capsule; building a shared search-with-results component.

The desktop settings search built its own input chrome. It now uses SearchInput from components/ui, so it matches the other search fields (corner radius, focus ring, placeholder tone). The mobile capsule keeps its borderless input because its host draws the chrome.
@xuejinT
xuejinT force-pushed the style/settings-search-shared-input branch from 831a212 to 4a080e4 Compare September 23, 2026 23:25
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 4a080e490eb8bfa67bdff2af3758bbe58a1e708f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4a080e4

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4a080e490eb8bfa67bdff2af3758bbe58a1e708f: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 4a080e490eb8bfa67bdff2af3758bbe58a1e708f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Mobile capsule quietly gains a focus-within:border-accent cue the description and screenshots never show — verify the floating-search focus state on mobile.

[DESIGN-REVIEWED] 4a080e4

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 4a080e490eb8bfa67bdff2af3758bbe58a1e708f — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the mobile capsule's new focus-accent border on a narrow viewport — it's the one visual change the description and screenshots never show.

Not justified as shipped

  • Item 2 — undeclared, rides along: the description says "styling only" and the capsule "keeps its own borderless input", but SidePanelLayout.tsx adds focus-within:border-accent, a new mobile focus cue the description never mentions. It is derived, not speculative: the diff-scoped focus-cue-lint gate (scripts/check_focus_cue.py) fires on the rewritten floating-input className, and the focus-cue-ok hatch must name a cue that really exists — before this PR the floating input had none.

What this change ships

Inventory (3 items) — 2 justified

Intent: make the Settings search box look and behave like every other dashboard search field by rendering it through the shared SearchInput — a FIX of a visual inconsistency (follow-up to #11381).

  1. Desktop/sidebar Settings search now draws with the shared look (rounded-md, focus-ring, dimmer placeholder) via SearchInput — justified
  2. Mobile floating capsule border turns accent while the search inside is focused — undeclared; gate-derived rider, no surface of its own
  3. Unused inputRef deleted — justified

SearchInput counted at ~25 real call sites (grep <SearchInput under website/src), so this replaces the last one-off spelling rather than adding one; bottom-float has exactly one consumer (SettingsPage.tsx:219), so the capsule cue reaches only this control.

[FIRST-PRINCIPLES-REVIEWED] 4a080e4

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of 4a080e490eb8bfa67bdff2af3758bbe58a1e708f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify the restyled box and dimmer placeholder:text-muted/50 in light theme — all four screenshots are dark-only.

[UX-REVIEWED] 4a080e4

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 4a080e490eb8bfa67bdff2af3758bbe58a1e708f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4a080e4

Verdict parsed from the review's SHA-scoped output markers for commit 4a080e490eb8bfa67bdff2af3758bbe58a1e708f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4a080e490eb8bfa67bdff2af3758bbe58a1e708f: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 24, 2026
@xuejinT

xuejinT commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor Author
  • span=a1bd47aa6be0 Not justified as shipped: undeclared capsule focus cue (fixed in description)

Outcome: fixed (description only, no code change).
The focus-within:border-accent on the mobile capsule is deliberate: the capsule's input suppresses its outline, so without it mobile search showed no focus at all (Focus Cue Gate flagged it).
The PR description now names it under What changed and Backwards compatibility, and adds a 390px screenshot of the focused capsule.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 24, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) September 24, 2026 06:52

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after an automated readiness screen against this head:

  • readiness: passed label present and the PR Readiness required status is green on this head
  • no failing, cancelled or pending required check on this head
  • mergeable with no conflict against current main
  • no live reviewer CHANGES_REQUESTED (GitHub reviewDecision is not CHANGES_REQUESTED)
  • every review-lane finding on this head is either PASS, withdrawn, disposed of by the author, or advisory-only — no unresolved blocking change request

Auto-merge (squash) is enabled; branch protection still gates the merge.

@bolichen97
bolichen97 merged commit 5b2b2d2 into main Sep 24, 2026
101 of 102 checks passed
@bolichen97
bolichen97 deleted the style/settings-search-shared-input branch September 24, 2026 06:53
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 24, 2026
wknight1 pushed a commit to wknight1/KiroCrew that referenced this pull request Oct 5, 2026
…ox (kirodotdev#13208)

The desktop settings search built its own input chrome. It now uses SearchInput from components/ui, so it matches the other search fields (corner radius, focus ring, placeholder tone). The mobile capsule keeps its borderless input because its host draws the chrome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants