Repository navigation
style(settings): use the shared SearchInput for the settings search - #13208
Conversation
|
Intent: Make the desktop Settings search box use the shared |
The desktop settings search built its own input chrome. It now uses SearchInput from components/ui, so it matches the other search fields (corner radius, focus ring, placeholder tone). The mobile capsule keeps its borderless input because its host draws the chrome.
831a212 to
4a080e4
Compare
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Mobile capsule quietly gains a [DESIGN-REVIEWED] 4a080e4 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the mobile capsule's new focus-accent border on a narrow viewport — it's the one visual change the description and screenshots never show. Not justified as shipped
What this change shipsInventory (3 items) — 2 justifiedIntent: make the Settings search box look and behave like every other dashboard search field by rendering it through the shared
[FIRST-PRINCIPLES-REVIEWED] 4a080e4 |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify the restyled box and dimmer [UX-REVIEWED] 4a080e4 |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
bolichen97
left a comment
There was a problem hiding this comment.
Approving after an automated readiness screen against this head:
readiness: passedlabel present and thePR Readinessrequired status is green on this head- no failing, cancelled or pending required check on this head
mergeablewith no conflict against currentmain- no live reviewer
CHANGES_REQUESTED(GitHubreviewDecisionis notCHANGES_REQUESTED) - every review-lane finding on this head is either PASS, withdrawn, disposed of by the author, or advisory-only — no unresolved blocking change request
Auto-merge (squash) is enabled; branch protection still gates the merge.
…ox (kirodotdev#13208) The desktop settings search built its own input chrome. It now uses SearchInput from components/ui, so it matches the other search fields (corner radius, focus ring, placeholder tone). The mobile capsule keeps its borderless input because its host draws the chrome.
Problem / Motivation
The Settings search box drew its own input: its own border, corner radius, focus style and icon. Every other search field in the dashboard (Artifacts, Notifications, the filter bars, the security posture list) uses the shared
SearchInputfromwebsite/src/components/ui.tsx. So this one box looked slightly different from the rest.Why it matters
Search fields that look the same read as the same control. A one-off style makes users wonder whether this box behaves differently, and it means a future change to
SearchInputmisses this box.What changed (motivation → approach → change)
The desktop Settings search now renders through
SearchInput, so it picks up the shared look:rounded-mdcorners, the standardfocus-ringglow, and the shared placeholder tone.website/src/pages/settings/SettingsSearch.tsxgathers the input's combobox attributes (role, aria wiring, value, change and blur handlers) into one object and hands it toSearchInput. Search, ranking, keyboard navigation and the results dropdown are unchanged. The mobile floating capsule keeps its own borderless input, because the capsule around it already draws the chrome andSearchInputhas no way to drop its box. That input hides its outline and nothing replaced it, so it showed no focus at all; the capsule inwebsite/src/components/SidePanelLayout.tsxnow turns its border accent-colored while the input has focus (focus-within:border-accent), and the input carries afocus-cue-oknote pointing at it. An unusedinputRefis removed.Backwards compatibility
Compatible: styling only; no props, routes, i18n keys or behavior change. The capsule is shared by every
bottom-floatheader, but Settings is its only consumer today.Tests
No new tests: the change is visual. The existing Settings search, layout and Settings page suites (401 tests) pass unchanged, along with
tsc -p tsconfig.app.jsonand eslint.Manual verification
Mounted the real
SettingsSearchin the sidebar dock inside the project's own Vite build and captured it on main and on this branch: resting, keyboard-focused, and open with the query "theme" (7 results, no console errors). Also mounted the realSidePanelLayoutat 390px wide with the search in the bottom capsule and focused it.Screenshots / video
Focused, before (main) → after (this PR): tighter corners,
focus-ringglow instead of a flat accent border, dimmer placeholder.Open with results after the change; the dropdown is unchanged:
Mobile, focused: the bottom capsule's border turns accent-colored while typing (it showed no focus cue before).
Related Issues
no linked issue: follow-up to #11381, aligning the relocated search box with the shared
SearchInput.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)