Repository navigation
fix: warn when desktop finds a stale bundled gateway - #13664
Conversation
a2c9d4f to
bc55ca8
Compare
UX Review (Fable 5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Recovery command must be transcribed from a dismissable dialog, and both Enter and Esc take the degraded Continue path the copy warns against. Watch
Suggestions
[UX-REVIEWED] e9897a8 |
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsFINDING -- website/electron/gateway-supervisor.js:737 -- |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify once on a real signed update that a detached old-bundle listener actually matches the [DESIGN-REVIEWED] e9897a8 |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify on one real macOS update that What this change shipsInventory (8 items) — 8 justifiedIntent: warn desktop users before reusing an older gateway left behind by the previous app bundle — a FIX for a locally reproduced, base-code-verifiable silent reuse (base
Notes checked: [FIRST-PRINCIPLES-REVIEWED] e9897a8 |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed Review detailsNothing blocks — but the new stale-gateway dialog gives instructions that are wrong for the installs that reach it. FINDING — website/electron/gateway-supervisor.js:772 — FINDING — website/electron/gateway-supervisor.js:779 — [OPUS-REVIEWED] e9897a8 |
bc55ca8 to
4ba6eb2
Compare
4ba6eb2 to
854a4f7
Compare
854a4f7 to
a5b61fa
Compare
f658b25 to
e2c1293
Compare
e2c1293 to
c2aeac3
Compare
|
Maintainer action needed for commit |
|
Current head Please rerun the failed jobs after the installation rate limit resets:
CI run |
An app replacement can leave an older bundled gateway detached from the Electron process. The next launch then adopts that same-family gateway and keeps running old code against the new bundle. Identify the exact local bundled listener before requesting its own authenticated, graceful restart. Wait for the installed version and keep remote, separately installed, and ambiguous gateways on the reuse path.
c2aeac3 to
86aee83
Compare
Detect a stale gateway from the current desktop bundle and warn before reuse. Remove the non-functional authenticated restart path so startup does not promise recovery it cannot perform.
86aee83 to
e9897a8
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (readiness sweep 2026-09-29): readiness passed, the required PR Readiness check is green on this head, no live CHANGES_REQUESTED, no open blocking review threads; where the PR's files also moved on main since its merge-base, the PR's own tests were run on the main+PR merge tree and passed. Approving and squash-merging.
Problem / Motivation
Goal: Warn desktop users before reusing an older gateway from the currently installed app bundle.
After a desktop update, a detached gateway from the previous bundle can keep listening on the usual port. The updated desktop otherwise reuses that gateway, so chats continue running against code and prompts from the previous installation.
Why it matters
The dashboard can look connected while updated desktop features are unavailable or incompatible with the older gateway. Users need a clear warning and recovery instructions before choosing whether to continue.
Not a goal
What changed (motivation → approach → change)
A stale bundled gateway can survive an app replacement, but ownership and path checks must remain strict to avoid acting on a tunnel or separate installation. The Electron supervisor now detects the condition only when one local listener is positively attributed to Kiro Crew, its command path is beneath the current packaged
backend-dist, and its same-family version is older than the desktop app.When detected, the desktop shows a native Continue/Quit warning before reuse. It names both versions, explains that updated features may be unavailable, and gives the existing
kirocrew stop --port <port>recovery command. Service-classified listeners get an additional conditional service-recovery hint. No restart request, token mint, polling loop, forced stop, or replacement spawn is added.The desktop lifecycle documentation and focused regressions now describe and enforce detection-and-warning behavior.
Backwards compatibility
Compatible: gateways that do not satisfy every stale bundled-gateway check retain the existing reuse behavior, and Continue still adopts the detected gateway.
Tests
./scripts/docs-lint.sh, Node syntax checks, andgit diff --checkpassed.Manual verification
The refreshed macOS captures show the base and service-classified warning states produced by the current dialog strings. A release-signed update remains release validation, not a claim of this PR.
Screenshots / video
Related Issues
No originating issue was filed; this PR follows a locally reproduced desktop update failure. #13826 explains the token-hardening boundary that makes automatic startup restart intentionally out of scope; this PR does not reopen or modify it.
Pattern harvest
Rule candidate: review-prompt
Pattern: Detect version-skewed companion processes using strict owner, path, product, and version evidence before warning; do not claim automatic recovery without a usable authenticated path.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
N/A — the repository template contains no final CLA text to acknowledge.