Skip to content

docs(rfc): mark composable-layout in-progress (PR 1 of 3 in flight) - #13673

Merged
CrysisDeu merged 1 commit into
mainfrom
docs/composable-layout-in-progress
Sep 25, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
docs/composable-layout-in-progress

Conversation

@dodgeblaster

Copy link
Copy Markdown
Contributor

What & why

The composable-layout RFC merged in #13425 and its first implementation PR is now in flight — #13572, the layout data model + tests, PR 1 of the sequence the RFC's §7 defines. This advances the RFC from draft to in-progress to reflect that implementation has started.

Following the repo convention for a status transition against an open PR (as rfc-append-only-ledger and rfc-conductor-work-ledger v4 did — "moved to in-progress against the open PR named in it rather than against main"), this is a standalone docs(rfc): change, not folded into the feature PR. It has to land on main on its own because the First Principles lens 9 reads RFC status from the base commit, never from a PR's diff — so the feature PR cannot advance its own gate by editing the doc inside itself.

Changed

  • rfc-composable-layout-mechanism.md — front-matter status: draft → in-progress; implementation-prs now records feat: add composable-layout pure-data model (PR 1) #13572; prose Status line rewritten to state PR 1 of §7 is in flight and the mechanism is not yet reachable.
  • README.md — index row draft → in-progress with the PR-1-in-flight description (prior-art detail preserved); audit paragraph appended with the 2026-09-25 transition note against the open PR.

Verification

scripts/docs-lint.sh → All documentation checks passed (exit 0). No code changed.

@dodgeblaster
dodgeblaster requested review from a team and cixuuz September 25, 2026 04:14
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 65dc7d5ec5cec0f600bd4b5771c301d076194ef5 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 65dc7d5

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 65dc7d5ec5cec0f600bd4b5771c301d076194ef5 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 65dc7d5

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 65dc7d5ec5cec0f600bd4b5771c301d076194ef5: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 65dc7d5ec5cec0f600bd4b5771c301d076194ef5 — this comment is updated in place on each push.

Review details

Docs-only status flip is sound, but the front matter now records a branch-only commit as its audit point, contradicting the index row in the same diff.

FINDING — docs/request-for-change/rfc-composable-layout-mechanism.md:7 — audited-at: 20b4c8fee resolves only on origin/feat/layout-model (not an ancestor of main, and gone once #13572 squash-merges), so the field README.md:130-131 declares the authoritative freshness signal ("the commit it was verified against"; "if those two fields are far behind main, distrust the status") becomes unresolvable, while README.md:33 and the index paragraph both still say the row was "Verified at a305e4fba" — the opposite of the convention the same paragraph states for rfc-wake-judge ("read at db5267bda9 on the branch that implements it rather than against main … its main-side audit stands where the row's front matter records it") → Fix: restore audited-at: a305e4fba and leave the branch read (20b4c8fee, #13572) in the prose status line / README paragraph.

[OPUS-REVIEWED] 65dc7d5

Verdict parsed from the review's SHA-scoped output markers for commit 65dc7d5ec5cec0f600bd4b5771c301d076194ef5.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 65dc7d5ec5cec0f600bd4b5771c301d076194ef5: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Sep 25, 2026
@dodgeblaster
dodgeblaster force-pushed the docs/composable-layout-in-progress branch from 10fc53f to 79f001d Compare September 25, 2026 16:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Sep 25, 2026
@dodgeblaster
dodgeblaster force-pushed the docs/composable-layout-in-progress branch 2 times, most recently from 0430157 to ff24f38 Compare September 25, 2026 18:23
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Sep 25, 2026
The composable-layout RFC merged (#13425) and its first implementation PR
is in flight (#13572, the layout model + tests, PR 1 of the RFC's section 7
sequence). Advance the RFC from draft to in-progress against that open PR
rather than against main, following the repo convention (rfc-append-only-ledger,
rfc-conductor-work-ledger v4). Updates the front-matter status, records the
implementation PR, rewrites the prose Status line, and updates the index row
plus its audit note.
@dodgeblaster
dodgeblaster force-pushed the docs/composable-layout-in-progress branch from ff24f38 to 65dc7d5 Compare September 25, 2026 18:41
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 25, 2026
@CrysisDeu
CrysisDeu merged commit 33bb706 into main Sep 25, 2026
94 checks passed
@CrysisDeu
CrysisDeu deleted the docs/composable-layout-in-progress branch September 25, 2026 19:08
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants