Repository navigation
docs(rfc): wake judge -- probe fetches, judge decides - #13790
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The revision drops the branch-vs-main demarcation the prior revision built, while adding more branch-read content and naming two different read SHAs. WatchThe old Status section listed exactly which sections were read off an unmerged branch and instructed "Re-audit at merge" — this diff deletes that list, yet §3.1's shed rule, §3.2's collector, §3.3's brief clauses and §4's table now describe #13759's branch, not main. Meanwhile the README says the placement was "read at [DESIGN-REVIEWED] f0eb139 |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsFive doc-vs-code contradictions in the landed text; nothing blocks the merge. FINDING — docs/request-for-change/rfc-wake-judge.md:104 — §3.1's shed rule is inverted against both trees: "the typed summaries FINDING — docs/request-for-change/rfc-wake-judge.md:514 — §7 Q6 ("DECIDED: it is auto-paused, not deleted … That is what PR G implements") and §8:567 ("AUTO-PAUSED rather than deleted … stays listed with FINDING — docs/request-for-change/rfc-wake-judge.md:211 — §3.3 states the shipped default brief as "a blocker, a failing check or one whose reading is not whole" and §3.3:228 argues 'says "failing", not "newly failing"', while FINDING — docs/request-for-change/README.md:28 — the index's closing claim "only the reader placement and the Decisions-card consent switch remain outstanding" names shipped work and hides unshipped work: the FINDING — docs/request-for-change/rfc-wake-judge.md:6 — the revision re-audits the main-side reading and bumps [OPUS-REVIEWED] f0eb139 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
68124ec to
7b3624c
Compare
|
7b3624c to
9f490ba
Compare
9f490ba to
e9a6d59
Compare
e9a6d59 to
ccba888
Compare
|
|
|
|
Record the placement the wake judge rests on: the gh-pr reader fetches and decides nothing, the whole reading reaches the judge as evidence, and the one deterministic ending -- a merged or closed pull request -- is mapped by the auto-nudge core. The document previously recorded the opposite: the reader answered where it could and the judge ran only on the reader's quiet. That split has the reader deciding the owner's criterion for them, and the criterion is exactly what differs between two loops watching one board. It also leaves a pull-request watch whose bar is a sentence rather than a check conclusion with no way to express it. Also recorded: the evidence kinds the pull-request collector produces (pr_state, pr_checks, pr_comment, pr_review), why the char budget sheds a typed summary before any prose item, the two clauses the built-in brief names explicitly and why, and the retirement of the script-cron driver -- a sandboxed subprocess holds no decisions provider, so a reading made there can reach no judge. Refs #13759
ccba888 to
f0eb139
Compare
What is the problem?
rfc-wake-judge.mdrecords a placement the implementation no longer follows, and records it in a way that cannot work.The document says the reader answers where it can and the judge runs only on the reader's quiet: "defers to the probe's own quiet return for a loop whose probe does run, because only the probe sees a merged or closed subject and ends the watch". Section 9 states the same thing as a composition rule: "probe first, judge on what the probe cannot type".
Why this issue matters to the user
Under that split the reader decides what is worth the owner's turn, and the criterion is exactly what differs between two loops watching one board. One owner wants to be woken when a reviewer asks a question; another only when the board goes red. A reader that answers first has already ruled for both of them.
It also leaves a whole class of watch unable to state its bar. "Wake me when a reviewer asks for a change" lives in prose, on a lane that reports success, so nothing typed sees it -- and a reader that returns quiet before the judge is consulted means the judge never gets the chance.
How our fix solves it
The symptom is a wake criterion an owner cannot express. Following it back: the criterion lives in prose, prose reaches only the judge, and the judge was reached only after a typed reader had already returned quiet. So the reader must stop answering.
This document now records that placement:
total_count, and comment and review bodies bounded per item and in total.Three consequences are recorded with it. The evidence kinds the pull-request collector produces are named (
pr_state,pr_checks,pr_comment,pr_review). The char budget PINS those two typed summaries and sheds the oldest prose item when it binds: the built-in criteria are answered from the summaries, so shedding them would delete the evidence the question is asked against, and they are small enough (42 characters for a 90-lane board) never to be the pressure. The built-in brief names two clauses explicitly rather than leaving them to "a blocker": a remark that asks, which nothing typed can see, and a failing or short-of-whole check board, which is what an owner arming no criteria at all most expects. The clause says "failing" rather than "newly failing" because the state carries the current board and no prior one;last_verdictis what stops a red board waking its owner every tick.The script-cron driver is recorded as retired. A script cron runs as a sandboxed subprocess with no gateway credential and no decisions provider, so a reading made there can reach no judge; keeping the adapter would leave those jobs polling on schedule, deciding nothing and reporting nothing.
What tests we did
Documentation only, so the checks are the documentation gates:
scripts/docs_lint.pypasses, and the comment-history gate passes with no source comments in scope. NoCHANGELOG.mdchange. One commit, two files.The index row and its audit paragraph are updated in the same commit, following the convention the last two revisions of this document used. The audit sentence names the branch sha the placement was read at and says so, and the front matter's own
last-audited/audited-atare left alone: they record the last audit against main, which this change does not re-do.Any other suggestions on the work
The document is split from the implementation deliberately. The First Principles lane on the implementation asks for the record to exist on the base branch before the code that follows it, which is the same path the last two revisions of this document took.
statusstayspartial, which is still accurate: the LLM lane is on main, and the core is on a branch the front matter names.no linked issue: this records a design placement rather than fixing a reported defect. Refs #13759, which implements it and must not be closed by this merge.