Skip to content

test(crew_log): run lease and real-crash suites on macOS again - #13898

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/crew-log-darwin-skip-10704
Sep 25, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/crew-log-darwin-skip-10704

Conversation

@iamwhatever

Copy link
Copy Markdown
Contributor

Problem / Motivation

Two crew-log test suites never run on macOS. test/test_crew_log_lease.py and test/test_crew_log_real_crash.py skip on darwin "tracked in #10704".

Why it matters

These are the only tests that kill a real writer or hold a lease from a second process. On macOS a regression in crash repair or lease ownership would ship unseen.

What changed (motivation → approach → change)

The darwin skip was a bisect step. It isolated these suites from a macOS shard failing with ENOENT: .kirocrew-deps.lock in the apps deps-provisioning tests.

That race is fixed on main by #10464 (9173117), which creates the dependency lock with O_CREAT|O_EXCL. The skip has nothing left to isolate.

Both skip conditions drop darwin and keep win32, whose lock and SIGKILL semantics really differ. The bisect comments go with the skip.

Backwards compatibility

Compatible: test-only change; no production code touched.

Tests

No new tests. The 14 tests in the two files now run on the macOS backend shards. Linux run passes locally (14 passed).

Manual verification

N/A — the CI macOS backend shard is the verification; its job is linked in a comment.

Related Issues

Closes #10704

The darwin skip was a bisect step against the macOS deps-lock ENOENT race, which #10464 fixed with exclusive lock creation. Keep the win32 skip.

Closes #10704
@iamwhatever
iamwhatever requested review from a team and hoang-phan98 September 25, 2026 17:40
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of ecd9502c3485eace3b75617a766bf27557a3d614 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ecd9502

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ecd9502c3485eace3b75617a766bf27557a3d614: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of ecd9502c3485eace3b75617a766bf27557a3d614 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm this PR's own macOS backend shards ran the 14 un-skipped tests green before merge.

[DESIGN-REVIEWED] ecd9502

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed ecd9502c3485eace3b75617a766bf27557a3d614 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ecd9502

Verdict parsed from the review's SHA-scoped output markers for commit ecd9502c3485eace3b75617a766bf27557a3d614.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ecd9502c3485eace3b75617a766bf27557a3d614: <one-sentence reason>

@iamwhatever iamwhatever added the ci:macos Run the on-demand macOS suite against this PR head label Sep 25, 2026
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 25, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor Author

macOS evidence for #10704 (head ecd9502c3485), via the ci:macos label: macOS Tests run 36169736723 is green.

Shard Result
Backend Tests (macOS) (1) 45088 passed, 140 skipped, 0 failed
Backend Tests (macOS) (2) 44957 passed, 265 skipped, 0 failed
Backend Tests (macOS) (3) 43894 passed, 1328 skipped, 4 xfailed, 0 failed

The shards run pytest -q, which does not print test names. test/test_crew_log_lease.py and test/test_crew_log_real_crash.py are on neither test/macos-collect-ignore.txt nor test/macos-expected-failures.txt. After this change their only skip is win32. --splits 3 --group N places every collected test in exactly one shard, so all 14 tests ran on darwin inside these three green shards.

@chenmingwei23
chenmingwei23 merged commit 9b8f09e into main Sep 25, 2026
106 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/crew-log-darwin-skip-10704 branch September 25, 2026 23:08
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:macos Run the on-demand macOS suite against this PR head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ledger crash-repair and cross-process ownership are unverified on macOS behind an unproven skip

2 participants