Repository navigation
docs(rfc): record the owner's file-view redaction switch (#13685) in the redaction RFC - #14022
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the purge-on-re-enable claim (open tabs drop cached reads/diffs, unsaved edits kept) against the shipped frontend — the one fence not confirmed backend-side. [DESIGN-REVIEWED] b8159a0 |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
3cecc65 to
b7a32fc
Compare
|
|
|
|
CI on b7a32fc: every reviewer lane passes with no findings; the five reds are inherited from main and none is reachable from this docs-only diff.
This PR will be rebased once either fix lands so the shards re-run on a green base. |
…xception (#13685) rfc-redaction-explain-and-reveal said redaction "cannot be turned off" and that known credential formats "remain hidden everywhere", and rollout step 6 asked for a read-only Settings section saying so. #13685 shipped an owner-only switch that turns the credential pass off for the files the owner's own dashboard opens for them, as the completion of the RFC's own "save it to a mode-0600 file" remedy. This records that decision where the RFC states the opposite: the "hidden everywhere" clause now names the surfaces it binds (everywhere the agent's output reaches another person or service) and carries the exception with the fences that justify it (default on, owner-only, keystone-stored, audited before the write, credential pass only, one verdict per request for read and diff, every open document purges on re-enable); step 6 becomes a Redaction section that carries that one control while the rules/hosts view stays read-only; fact 1 says the switch does not reach the saved conversation. Front matter: implementation-prs [13685], tracking-issues [13741], re-audited. README row updated.
b7a32fc to
b8159a0
Compare
|
Rebased: main moved to |
Problem / Motivation
rfc-redaction-explain-and-reveal.md(statusaccepted) records that redaction "cannot be turned off", that known credential formats "remain hidden everywhere", and (rollout step 6) that Settings → Security should carry a read-only section saying so. #13685 shipped an owner-only switch that turns the credential pass off for the files the owner's own dashboard opens for them — the completion of the RFC's own "save it to a mode-0600 file" remedy, which the Files view had been undoing by running the same pass over the saved file. Every First Principles review round on #13685 flagged that the accepted RFC states the opposite of what shipped; the PR merged on a maintainer decision, and this document is where that decision has to be recorded so the RFC and the code agree again.What changed
docs/request-for-change/rfc-redaction-explain-and-reveal.md:file_delivery_consent.json, refused by the agent's file tools and mounted read-only in its sandbox; audited before the switch moves, and a disable that cannot be audited does not happen; credential pass only (exfil-URL pass, request-blocking gates, chat and channels untouched); one verdict per request for the read and the diff; every open document purges on re-enable; Settings shows the state and the time. The open decisions (viewer indicator, auto-revert) and Owner-view carve-out for the exfil-URL pass in the Files view (follow-up to #13685) #13741 (the exfil-URL carve-out for the same owner view) are named.status: partial(part of step 6 is on main; the README vocabulary reservesacceptedfor "nothing built yet"),implementation-prs: [13685],tracking-issues: [13741],last-audited/audited-atrefreshed.docs/request-for-change/README.md: the RFC's row moves topartialand its what is on main column names the shipped switch beside the pre-existing CSP, with steps 1/3 still in an open PR and 2/4/5 and the read-only view unstarted.No code changes.
Verification
./scripts/docs-lint.shpasses;test/test_rfc*.py+test/test_docs*.py(353 passed, 33 skipped). Read the three edited passages againstsrc/kiro_crew/security/redaction_switch.py,dashboard/handlers/credential_redaction.pyand the #13685 PR body to make sure every fence named here is one that shipped.Why no screenshot: documentation only; nothing renders.