Skip to content

docs(rfc): record the owner's file-view redaction switch (#13685) in the redaction RFC - #14022

Merged
bolichen97 merged 1 commit into
mainfrom
docs/rfc-redaction-owner-switch
Sep 26, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
docs/rfc-redaction-owner-switch

Conversation

@bolichen97

@bolichen97 bolichen97 commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

rfc-redaction-explain-and-reveal.md (status accepted) records that redaction "cannot be turned off", that known credential formats "remain hidden everywhere", and (rollout step 6) that Settings → Security should carry a read-only section saying so. #13685 shipped an owner-only switch that turns the credential pass off for the files the owner's own dashboard opens for them — the completion of the RFC's own "save it to a mode-0600 file" remedy, which the Files view had been undoing by running the same pass over the saved file. Every First Principles review round on #13685 flagged that the accepted RFC states the opposite of what shipped; the PR merged on a maintainer decision, and this document is where that decision has to be recorded so the RFC and the code agree again.

What changed

docs/request-for-change/rfc-redaction-explain-and-reveal.md:

  • What does not change: the "remain hidden everywhere" clause now names the surfaces it binds (everywhere the agent's output reaches another person or service — chat, every channel, artifacts, logs, backups, links) and carries the one exception, decided with feat(security): owner switch to turn credential redaction off in the file viewer #13685, with the fences that justify it: on by default; owner-only (non-owner and app tokens refused); keystone-stored beside file_delivery_consent.json, refused by the agent's file tools and mounted read-only in its sandbox; audited before the switch moves, and a disable that cannot be audited does not happen; credential pass only (exfil-URL pass, request-blocking gates, chat and channels untouched); one verdict per request for the read and the diff; every open document purges on re-enable; Settings shows the state and the time. The open decisions (viewer indicator, auto-revert) and Owner-view carve-out for the exfil-URL pass in the Files view (follow-up to #13685) #13741 (the exfil-URL carve-out for the same owner view) are named.
  • Rollout step 6: a Redaction section that states which surfaces redaction cannot be turned off for and carries that one control (shipped as Credential redaction in file views), with the rules/hosts view still read-only.
  • Three facts item 1: the switch does not reach the saved conversation.
  • Front matter: status: partial (part of step 6 is on main; the README vocabulary reserves accepted for "nothing built yet"), implementation-prs: [13685], tracking-issues: [13741], last-audited / audited-at refreshed.
  • The fences are stated as they shipped, not rounder: an unaudited disable does not happen (re-enable is the fail-safe direction and proceeds); every open document drops cached reads, diffs and clean tabs while a tab with unsaved edits keeps the owner's typing; the keystone stops a prompt-injected agent through the filesystem, and the known limit (a computer-use agent driving the owner's authenticated browser reaches the PUT; bounded to the owner's own file views and audited) is written down.

docs/request-for-change/README.md: the RFC's row moves to partial and its what is on main column names the shipped switch beside the pre-existing CSP, with steps 1/3 still in an open PR and 2/4/5 and the read-only view unstarted.

No code changes.

Verification

./scripts/docs-lint.sh passes; test/test_rfc*.py + test/test_docs*.py (353 passed, 33 skipped). Read the three edited passages against src/kiro_crew/security/redaction_switch.py, dashboard/handlers/credential_redaction.py and the #13685 PR body to make sure every fence named here is one that shipped.

Why no screenshot: documentation only; nothing renders.

@bolichen97
bolichen97 requested review from a team and patrigao September 25, 2026 23:25
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 25, 2026
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of b8159a00ff269b967d3ebef967d34b2cc4494e38 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b8159a0

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b8159a00ff269b967d3ebef967d34b2cc4494e38: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of b8159a00ff269b967d3ebef967d34b2cc4494e38 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the purge-on-re-enable claim (open tabs drop cached reads/diffs, unsaved edits kept) against the shipped frontend — the one fence not confirmed backend-side.

[DESIGN-REVIEWED] b8159a0

@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed b8159a00ff269b967d3ebef967d34b2cc4494e38 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b8159a0

Verdict parsed from the review's SHA-scoped output markers for commit b8159a00ff269b967d3ebef967d34b2cc4494e38.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b8159a00ff269b967d3ebef967d34b2cc4494e38: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 25, 2026
@bolichen97
bolichen97 enabled auto-merge (squash) September 25, 2026 23:52
@bolichen97
bolichen97 force-pushed the docs/rfc-redaction-owner-switch branch from 3cecc65 to b7a32fc Compare September 25, 2026 23:57
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • fixed span=b27ba3a72fec — both sentences now say what shipped

b7a32fc: 'a disable that cannot be audited does not happen — turning redaction back on is the fail-safe direction and proceeds even when the log is unavailable'; and 'drops the file bodies it holds — cached reads, diffs and clean open tabs; a tab with unsaved edits keeps the owner's own typing'.

@bolichen97

Copy link
Copy Markdown
Contributor Author
  • fixed span=e23818f24c1e — status partial, README column rewritten

b7a32fc: the RFC's front matter is status: partial (the README vocabulary reserves accepted for nothing built); the README row's what is on main column now names the shipped switch beside the pre-existing CSP and drops 'Nothing on main beyond…'; steps 1/3 are described as in an open PR, 2/4/5 and the read-only view as unstarted.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 25, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author
  • fixed span=f9eee2ce4f11 — the audit and injection fences are stated with their limits

b7a32fc: the unaudited-change sentence is narrowed to a disable (re-enable proceeds); the keystone sentence says it stops a prompt-injected agent through the filesystem and records the known limit -- an agent driving the owner's authenticated browser through computer use reaches the PUT, bounded to the owner's own file views and audited -- the same limit the shipped spec paragraph states.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 26, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

CI on b7a32fc: every reviewer lane passes with no findings; the five reds are inherited from main and none is reachable from this docs-only diff.

This PR will be rebased once either fix lands so the shards re-run on a green base.

…xception (#13685)

rfc-redaction-explain-and-reveal said redaction "cannot be turned off" and
that known credential formats "remain hidden everywhere", and rollout step 6
asked for a read-only Settings section saying so. #13685 shipped an
owner-only switch that turns the credential pass off for the files the
owner's own dashboard opens for them, as the completion of the RFC's own
"save it to a mode-0600 file" remedy. This records that decision where the
RFC states the opposite: the "hidden everywhere" clause now names the
surfaces it binds (everywhere the agent's output reaches another person or
service) and carries the exception with the fences that justify it (default
on, owner-only, keystone-stored, audited before the write, credential pass
only, one verdict per request for read and diff, every open document purges
on re-enable); step 6 becomes a Redaction section that carries that one
control while the rules/hosts view stays read-only; fact 1 says the switch
does not reach the saved conversation. Front matter: implementation-prs
[13685], tracking-issues [13741], re-audited. README row updated.
@bolichen97
bolichen97 force-pushed the docs/rfc-redaction-owner-switch branch from b7a32fc to b8159a0 Compare September 26, 2026 02:05
@bolichen97

Copy link
Copy Markdown
Contributor Author

Rebased: main moved to 694f61983e (#14056 fixed the ratchet and spawn-wait reds that were inherited here). Docs diff unchanged; docs-lint green. Head b8159a00ff.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 26, 2026
@bolichen97
bolichen97 merged commit b802726 into main Sep 26, 2026
99 of 100 checks passed
@bolichen97
bolichen97 deleted the docs/rfc-redaction-owner-switch branch September 26, 2026 06:15
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants