Repository navigation
Conversation
…y ratchet Heal for the red main run 36200986526 on 5c66a72, job Backend Tests (3.12, 8): TestLeafOnlyPopulationIsRecorded reports every tier three names over EXPECTED. Cause: #13685 (the owner's credential-redaction switch) added credential_redaction.json to sandbox.py's protected-leaf sets, modelled on file_delivery_consent.json, and landed beside #13935, which pinned the leaf-only population at 235/242/243. Each PR was green alone; together the ratchet is over by exactly the new name, in its three spellings per tier (~/.kiro/crew, ~/.kirocrew, KIROCREW_HOME). Test-only: EXPECTED moves to the measured 238/245/246 and the comment names the leaf and its hold class. sandbox.py is untouched. Whether credential_redaction.json should move under an enclosing directory mask is the maintainers' decision, tracked as a follow-up.
|
Intent: Turn |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the leaf-vs-mask follow-up issue actually exists — the description says "filed separately by the conductor" but links no issue number. [DESIGN-REVIEWED] 7b53f9a |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
mainis red. On5c66a72625(ci.yml run 36200986526, jobBackend Tests (3.12, 8))test/test_sandbox_protected_name_holds.py::TestLeafOnlyPopulationIsRecorded::test_leaf_only_count_has_not_grownfails for every tier: "cc now holds 245 protected names by their own leaf name only, up from 242" (standard 238 vs 235, strict 246 vs 243).Why it matters
Every PR that lands on
mainnow inherits a red backend shard, so a real regression in the sandbox tests would be indistinguishable from this one until the ratchet describes the population that ships.What changed (motivation → approach → change)
Two PRs landed thirteen seconds apart and each was green alone. #13935 pinned the leaf-only population at
EXPECTED = {"standard": 235, "cc": 242, "strict": 243}. #13685 (the owner's credential-redaction switch) addedcredential_redaction.jsonto the protected-leaf sets insrc/kiro_crew/sandbox.py, modelled onfile_delivery_consent.json. Together the ratchet is over by exactly that name: three spellings per tier (~/.kiro/crew,~/.kirocrew,KIROCREW_HOME), measured by running the test's own_split(tier)at2a4457f9f2and at the current tip and diffing the lists. Nothing else changed in any tier.This PR is test-only.
EXPECTEDmoves to the measured 238 / 245 / 246 and its comment names the leaf and its hold class.sandbox.pyis untouched. Whethercredential_redaction.jsonshould move under an enclosing directory mask instead of a leaf hold is the maintainers' decision and is tracked as a follow-up, not decided here.Backwards compatibility
Compatible: a test constant moves to the population main already ships; no runtime code changes.
Tests
test/test_sandbox_protected_name_holds.py-n0: red on the current tip, green with this change (the whole file, all three tiers).test/test_sandbox_governance_mask.py-n0: green, unchanged (649 tests across the two files).Manual verification
N/A — the delta was proven by running
_split(tier)before and after the two merges; the only added names arecredential_redaction.jsonentries.Related Issues
no linked issue: heal for the red
mainrun 36200986526; the leaf-vs-mask question is filed separately by the conductor.Pattern harvest
Rule candidate: review-prompt
Pattern: two green PRs that both touch a ratcheted population land in one merge burst and the ratchet is over by the second PR's addition; the merge queue or a post-merge check should re-run a population ratchet on the actual
maintip, not on each PR's own merge ref.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)