Repository navigation
chore(settings): drop the Data Classification Notice from the Security tab - #14369
Conversation
|
Intent: Take the "Data Classification Notice" warning box out of Settings → Security, at the repository owner's request, and remove the now-dead catalog strings and the tab-subtitle clause that described only that box. |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the repository owner's removal request is on record — it is the sole justification for deleting a compliance-facing notice from every surface. [DESIGN-REVIEWED] 2e5872c |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Five-surface warning removal rests entirely on an unrecorded "direct owner request" — no issue, no docs/decisions entry, no RFC records that decision. Not justified as shipped
What this change shipsInventory (8 items) — 3 justifiedIntent: remove the "don't type sensitive data" warning from every product surface, at the repository owner's request — a FIX-shaped pure removal; nothing is added.
[FIRST-PRINCIPLES-REVIEWED] 2e5872c |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify live that the Slack Home Tab now opens at Status — the only removal no screenshot could cover. [UX-REVIEWED] 2e5872c |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
f85c756 to
6e96f46
Compare
|
Rebased: main moved in The previous head's four reds were all outside this diff, so nothing in the code changed with this push:
|
|
Second inherited red surfaced on this head, also not from this diff.
That is the size ratchet on Running total of reds on head
|
|
|
|
The |
Kiro Crew told the reader not to type sensitive data into it in five places: the Settings -> Security banner, the Slack Home Tab, the Slack allowlist-approval DM, and the shared `DATA_WARNING` string the CLI printed on the chat REPL, the setup command, the self-update command and gateway start. All five are removed, plus the strings behind them. - website/src/pages/settings/SecurityPanel.tsx: drop the `banner` node and the `banner` prop (optional on SettingsSubNav); SettingsSubNav.tsx's doc comment no longer cites it as the slot's example. - src/kiro_crew/constants.py: delete `DATA_WARNING`; drop the now-unused import and print from cli_chat.py, cli_server.py, cli_setup.py and slack/gateway.py. - src/kiro_crew/slack/events.py: drop the Home Tab's reminder section and its divider. slack/interactions.py: the approval DM keeps only its confirmation. - locales: remove `pages.settings.securityPanel.data_classification_notice` and `...do_not_enter_highly_sensitive_or_restricted_data` from all 13 catalogs and shorten `settings.tabs.security.description`; en-XA regenerated. - docs/system-specs/common/code-style.md: drop `DATA_WARNING` from the shared-constants example list.
6e96f46 to
2e5872c
Compare
|
The Evidence: job 108582066780 failed in #14426 switches the harness to The rerun of that shard on this PR is already in flight, and should pass — the failure is a scheduling race, not a deterministic break. For the record, the other three reds in the same round — |
test_the_trim_and_count_execute_as_written built its script with `printf '%s\n' "$summary" | head -n1` and ran it under `bash -euo pipefail`. head exits on its first line and closes the read end, the producer's next write takes SIGPIPE, and pipefail promotes that 141 to the script's exit status -- failing `assert result.returncode == 0` with a message that reads like a review-lane problem. Whether the producer is still writing when head exits is a scheduling race, so the failure is rare and CI-only; seen on PR #14369's Backend Tests (3.12, 2) shard. This file already bans the shape where it ships: test_guard_function_is_byte_identical_across_all_lanes asserts no lane's guarded_comment_upsert contains `head -n1` and requires `| awk 'NR == 1'` instead, and _MANY_HEADERS records the measurement behind it. The harness now uses that same form. awk reads to EOF rather than exiting early, so the producer is never signalled. No assertion, fixture or expectation changed.
|
needs-a-decision — span=88e5617b833d ( The finding is correct on the facts and I am not disputing it. What has changed since the last round: the owner's request is now on the record here, in his own account, quoting both instructions verbatim — the confirmation comment. That comment also discloses plainly that it was transcribed by his agent inside his session rather than typed by hand. Why this is still a decision and not a rebuttal: the finding's own clearing condition asks for the repository owner's approving comment or merge, and the override route asks for a maintainer. Both are the owner's own act. I am the agent that opened this PR and I hold his account, so treating my own comment as the confirmation the lane is waiting for would be self-certification, not evidence — and a gate whose evidence the gated party supplies has stopped being a gate. So it is recorded here and left to him. Two ways it clears, either of which is his to take:
Nothing in the diff changes on either path — this is about where the decision is recorded, not about the code. |
Pull Request is not mergeable
Problem / Motivation
Goal: Nobody using Kiro Crew is told not to type sensitive data into it any more — the warning is gone from the settings page, from Slack, and from the terminal.
Kiro Crew told the reader not to type sensitive data into it in five separate
places — a banner on Settings → Security, a block on the Slack Home Tab, a line in
the Slack allowlist-approval DM, and a shared
DATA_WARNINGstring the CLI printedon four entry points. The repository owner asked for it to be gone from the product,
UI and CLI alike.
Why it matters
It was the first thing on three of those surfaces, so opening Security, the Slack
app, or a terminal started with a policy instruction instead of the thing the
surface exists to show.
Not a goal
display text is touched.
the docs, or onboarding.
src/test/CrewWebviewContainment.test.tsx, which is red onmainindependently of this branch (see the Rebased comment on this PR for the
clean-
origin/mainreproduction).What changed (motivation → approach → change)
kirocrew chat/setup/ the self-update command / gateway startThe Security box lived in one place — the
SettingsSubNavbanner slot inSecurityPanel.tsx. Removing thebannernode and the prop takes it off the page;the prop is optional, so the nav renders without it.
SettingsSubNav.tsxcited thatbox as the slot's example in a doc comment, so the comment now names Chat's notices
instead.
The four CLI printers all read one constant, so deleting
DATA_WARNINGfromconstants.pyand dropping the import and print incli_chat.py,cli_server.py,cli_setup.pyandslack/gateway.pyremoves every terminal copy with nothing leftbehind. The two Slack copies are inline strings in
slack/events.pyandslack/interactions.py.The Security tab's subtitle ended in "and data classification", a clause describing
only the box. With the box gone it names something the page no longer has, so it is
dropped, and the two dead catalog strings come out of all 13 files under
website/src/i18n/locales/.en-XAis generated, not hand-written, and wasregenerated with
website/scripts/gen-pseudolocale.mjs.docs/system-specs/common/code-style.mdlistedDATA_WARNINGas an example of ashared constant; that name is gone too.
Backwards compatibility
Compatible: every removed item was display text. No setting, API, stored value or
enforcement path reads any of them,
banneris an optional prop, andDATA_WARNINGhad no importer outside the four print sites removed here (verified by a repo-wide
grep that now returns nothing for the constant or any of its wordings).
Tests
No new tests. Nothing asserted any of the five copies, so nothing had to be updated
— which is also why the removal is invisible to the suites rather than silently
covered by them. What the existing suites lock in is that each surface still builds
and renders without its copy:
SecurityPanel.test.tsx,SecurityPanel.floorLock,SettingsPage.test.tsx,settingsCoverage,settingsExtractCoverage,settingsManualSections.test_slack_home_tab.py,test_slack_events_coverage.py,test_slack_interactions_coverage.py— the Home Tab tests read the block list thereminder was removed from.
test_cli_chat.py,test_cli_setup_cov80.py,test_cli_setup_slack.py,test_cli_server_more_coverage.py.Gates green on this head:
isort,flake8,mypyon the seven changed Pythonfiles;
tsc -p tsconfig.app.json,eslinton both changed.tsx, andnpm run i18n:check.Manual verification
Built the SPA and shot Settings → Security against the real bundle, before and
after, with identical fixtures. For the CLI and Slack copies the check is the
import graph rather than a frame: all six touched modules import from the worktree
with
DATA_WARNINGabsent, so no call site was left dangling.Screenshots / video
Before — the box, and a subtitle ending "and data classification":
After — the panel starts at Live Security Posture:
Auto-approve section, same before/after
Why no screenshot: the CLI and Slack copies render in a terminal and in Slack,
neither of which the frontend harness can shoot;
SettingsSubNav.tsxchanges only adoc comment.
Related Issues
no linked issue: direct owner request, no tracking issue filed.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)