Skip to content

fix(prepare-pr): trim the out-of-goal sentence back under the skill cap - #14397

Closed
Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/prepare-pr-skill-size
Closed

Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/prepare-pr-skill-size

Conversation

@Pearcekieser

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the prepare-pr skill fits its 68000-byte ceiling again, so the Backend Tests shard that checks it goes green on main and on every PR.

test_slim_skills_do_not_regrow_duplicate_guidance_or_wire_model_ids[prepare-pr-68000] fails on main with assert 68015 <= 68000. Backend Tests shard 3 (Linux and Windows) is red on every open PR because of it.

Why it matters

Every PR carries an inherited red shard and a failed Coverage Gate, so readiness cannot pass on its own and each contributor has to prove the failure is not theirs.

Not a goal

  • Raising the byte ceiling.
  • Rewording any other part of the prepare-pr skill.

What changed (motivation → approach → change)

#14181 grew src/kiro_crew/builtin_skills/kirocrew-dev/prepare-pr/SKILL.md from 67986 to 68015 bytes. Part of that growth restates the PR template's own definition of "out of goal", the list "a new feature, surface, or hardening this PR does not need", which .github/PULL_REQUEST_TEMPLATE.md already carries under ## Not a goal.

This PR keeps the rule in the skill (a defect in code the PR adds or changes is always in scope; only new scope is out of goal) and drops the restated example list. The skill is 67939 bytes, 61 under the ceiling. The ceiling is unchanged, because the growth was duplicate guidance, not new guidance.

Backwards compatibility

Compatible: one sentence of agent guidance in a skill file is shortened; no code, config or contract changes.

Tests

No new tests. The existing ceiling test is the regression check: test/test_review_repair_routing_skill.py passes (20 tests) with this change and fails on main without it.

Manual verification

N/A: the change is one sentence of skill text, and the size test measures it directly.

Related Issues

Fixes #14396

Pattern harvest

Not generalizable: the byte-ceiling test already catches this class and caught it here; the fix is to state a definition once, in the template, and point to it.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…yte skill cap

kirodotdev#14181 copied the PR template's definition of out of goal into the skill,
growing it to 68015 bytes, 15 over the ceiling test_slim_skills_do_not_regrow_
duplicate_guidance_or_wire_model_ids enforces, so every PR's Linux backend
shard fails. Keep the rule and drop the restated example list the template
already carries: 67939 bytes.
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed c30b63701f61cf92836726fa0c91fca8426e61ba via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] c30b637

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of c30b63701f61cf92836726fa0c91fca8426e61ba via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] c30b637

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of c30b63701f61cf92836726fa0c91fca8426e61ba via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the trimmed rule still reads complete where prepare-pr runs without this repo's template — the dropped definition now lives only in AGENTS.md and PULL_REQUEST_TEMPLATE.md.

What this change ships

Inventory (1 item) — 1 justified

Intent: FIX — get the prepare-pr skill back under its 68000-byte ceiling so the red Backend Tests shard on main goes green.

  1. The skill's out-of-goal sentence drops its restated example list; the rule itself stays — justified.

Evidence checked: base SKILL.md measures 68015 bytes against the 68000 ceiling pinned at test/test_review_repair_routing_skill.py:118, so the defect has a failing test on base. The deleted phrase "a new feature, surface, or hardening this PR does not need" exists verbatim at .github/PULL_REQUEST_TEMPLATE.md:32 and AGENTS.md:237 (grep: 3 hits including the deleted one), so the deletion removes a third spelling rather than guidance. The edit saves ~76 bytes, landing at 67939 as claimed. Single hunk, no riders, no pin reversed, no default or capability changed.

[FIRST-PRINCIPLES-REVIEWED] c30b637

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed c30b63701f61cf92836726fa0c91fca8426e61ba via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] c30b637

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 27, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Superseded by #14398, which brought prepare-pr/SKILL.md to 67854 bytes, under the 68000 cap, on main at 07:18Z.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

prepare-pr skill is 15 bytes over its 68000-byte ceiling; a Backend Tests shard fails on main

1 participant