Repository navigation
fix(prepare-pr): trim the out-of-goal sentence back under the skill cap - #14397
Pearcekieser wants to merge 1 commit into
Conversation
…yte skill cap kirodotdev#14181 copied the PR template's definition of out of goal into the skill, growing it to 68015 bytes, 15 over the ceiling test_slim_skills_do_not_regrow_ duplicate_guidance_or_wire_model_ids enforces, so every PR's Linux backend shard fails. Keep the rule and drop the restated example list the template already carries: 67939 bytes.
GPT 5.6 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
Design Review (Fable 5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] c30b637 |
First Principles Review (Fable 5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the trimmed rule still reads complete where prepare-pr runs without this repo's template — the dropped definition now lives only in AGENTS.md and PULL_REQUEST_TEMPLATE.md. What this change shipsInventory (1 item) — 1 justifiedIntent: FIX — get the prepare-pr skill back under its 68000-byte ceiling so the red Backend Tests shard on main goes green.
Evidence checked: base [FIRST-PRINCIPLES-REVIEWED] c30b637 |
Opus 5 Review (fork) — ✅ no blocking findingsReviewed |
|
Superseded by #14398, which brought prepare-pr/SKILL.md to 67854 bytes, under the 68000 cap, on main at 07:18Z. |
Problem / Motivation
Goal: the prepare-pr skill fits its 68000-byte ceiling again, so the Backend Tests shard that checks it goes green on main and on every PR.
test_slim_skills_do_not_regrow_duplicate_guidance_or_wire_model_ids[prepare-pr-68000]fails on main withassert 68015 <= 68000. Backend Tests shard 3 (Linux and Windows) is red on every open PR because of it.Why it matters
Every PR carries an inherited red shard and a failed Coverage Gate, so readiness cannot pass on its own and each contributor has to prove the failure is not theirs.
Not a goal
What changed (motivation → approach → change)
#14181 grew
src/kiro_crew/builtin_skills/kirocrew-dev/prepare-pr/SKILL.mdfrom 67986 to 68015 bytes. Part of that growth restates the PR template's own definition of "out of goal", the list "a new feature, surface, or hardening this PR does not need", which.github/PULL_REQUEST_TEMPLATE.mdalready carries under## Not a goal.This PR keeps the rule in the skill (a defect in code the PR adds or changes is always in scope; only new scope is out of goal) and drops the restated example list. The skill is 67939 bytes, 61 under the ceiling. The ceiling is unchanged, because the growth was duplicate guidance, not new guidance.
Backwards compatibility
Compatible: one sentence of agent guidance in a skill file is shortened; no code, config or contract changes.
Tests
No new tests. The existing ceiling test is the regression check:
test/test_review_repair_routing_skill.pypasses (20 tests) with this change and fails on main without it.Manual verification
N/A: the change is one sentence of skill text, and the size test measures it directly.
Related Issues
Fixes #14396
Pattern harvest
Not generalizable: the byte-ceiling test already catches this class and caught it here; the fix is to state a definition once, in the template, and point to it.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)