Repository navigation
fix(dashboard): nest a member-driven crew under its creator in the conductor lane - #14462
Conversation
…nductor lane ChatPage filters dashboard.slots by surface before the sidebar sees them, so a crew member's own DM thread (surface 'member') never reached the conductor lane. Every worker it opened cited it with a live parent.key, found no row for that key, and rendered at the top level wearing the "opened by a closed session" glyph while the System page nested the same rows. The lane now borrows an unlisted live local creator from the full slot list, transitively, as a dimmed anchor row. The anchor opens on the Members page and withholds rename/close/fork/drag like a peer row.
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the 2026-09-27 maintainer ask to collapse by default — it reverses #13676 from one day earlier and exists only as this PR's assertion. [DESIGN-REVIEWED] 6e87a9d |
First Principles Review (Fable 5) — ✅ human override accepted@chenmingwei23 overrode this lane for |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Clicking the anchor row leaves the chat page, but the blind reader expected it to open the conversation in place — only the small chip hints at the jump. Watch
[UX-REVIEWED] 6e87a9d |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsKeyboard jump order publishes rows the chat page cannot open, so a digit chord lands on a different session than the badge it reads. FINDING — website/src/pages/ChatSidebar.tsx:6076 — FINDING — website/src/pages/ChatSidebar.tsx:9959 — [OPUS-REVIEWED] 6e87a9d Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
e60e1bc to
31b6b24
Compare
|
Capture frames on head Shut by default - the member-driven crew is one dimmed anchor row: the Opened - one press on the chevron nests the three workers one level under it. The aggregate leaves with the fold; the count stays. |
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
219d757 to
8b751d7
Compare
|
/ai-review override first-principles 8b751d7: Maintainer decision 2026-09-27: the conductor lane arrives collapsed by default, superseding #13676's expanded default for this lane; recorded in the PR description and docs/feature-map/README.md Sessions row. Re-posted after a dead-catalog-key fix moved the head. |
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
8b751d7 to
87ea60c
Compare
|
/ai-review override first-principles 87ea60c: Maintainer decision 2026-09-27: the conductor lane arrives collapsed by default, superseding #13676's expanded default for this lane; recorded in the PR description and docs/feature-map/README.md Sessions row. Re-posted after a feature-map wording fix moved the head. |
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
87ea60c to
666e32c
Compare
|
/ai-review override first-principles 666e32c: Maintainer decision 2026-09-27: the conductor lane arrives collapsed by default, superseding #13676's expanded default for this lane; recorded in the PR description and docs/feature-map/README.md Sessions row. Re-posted after the anchor chip was reworded for the UX lane. |
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
Requested by the maintainer on 2026-09-27 after seeing the lane with every member-driven crew open: even once the workers were attached to their creator, a fully expanded lane still did not read as N crews. Every crew now arrives collapsed at every level, as one row carrying its child count and the subtree's needs-you / running badges, and the person opens the crews they care about. The persisted fold set flips sense: mc-sidebar-conductor-expanded holds the rows the user has opened, and a row absent from it is shut. The superseded mc-sidebar-conductor-collapsed key is removed on first read. Reveal, adoption, search and session_create behave as before around the new default. Alongside, for the two reviewer notes on the anchor row: the row wears a small "Members" chip so the page jump is visible text and not hover-only, and the child count carries "N sessions this one opened" as its accessible name and tooltip so the bare number has a unit. The feature-map Sessions row records the collapsed default, the new key and the member-anchor behaviour.
666e32c to
6e87a9d
Compare
|
/ai-review override first-principles 6e87a9d: Maintainer decision 2026-09-27: the conductor lane arrives collapsed by default, superseding #13676's expanded default for this lane; recorded in the PR description and docs/feature-map/README.md Sessions row. Re-posted after the cold-start lineage_pending guard moved the head. |
Human judgment recorded@chenmingwei23 marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (sweep 2026-09-27): readiness passed, required checks green on 6e87a9d, no blocking review threads, security posture unchanged. Approving and merging.


Problem / Motivation
Goal: In the sidebar's conductor lane, a crew whose conductor is a crew member reads as ONE unit of work: its workers nest under the member's thread instead of scattering across the top level - and every crew arrives collapsed, so a lane with three crews reads as three rows, not thirty.
Open the conductor lane while a crew member (for example
kirocrew-pipeline-conductor) is dispatching workers throughsession_create. Every one of its workers sits at the top level, each wearing the bent-arrow glyph whose tooltip says opened by a closed session - while the member is open, running, and visible on the System page's Sessions table with those same workers nested under it. The screenshot pair below is the actual state of one such sidebar: a dozenissue-fix:rows scattered through the list, none of them attached to anything.Why it matters
The lane exists so that a conductor and its workers can be read together. Member-driven crews are the ones with the most workers (the pipeline conductor alone runs ten to thirty at a time), so this is the case where the nesting matters most and it is exactly the case that did not nest. The glyph also states a falsehood about a live session - "closed" - which sends a reader to look for a creator that is running.
Not a goal
parent.key. The wire was correct: the backend already resolved the citation to the member's live slot.What changed (motivation -> approach -> change)
Symptom -> root cause:
ChatPagefiltersdashboard.slotsbyisChatPageSurface(surface ?? mode)before the list reachesChatSidebar(ChatPage.tsx:535), and a member's DM slot ismode: 'member'/surface: 'member'. So the sidebar's population never contained the member's row.nestsUnderrequires the cited key to name a row in the population it is given; it did not, so each worker became a root, andcitedCreatorExists(built over the same population) could not find the creator either, so the row took the orphan glyph rather than the cites-parent one. The System page reads/api/sessions/memory, which carries every session, so it nested fine - the two views diverged on exactly one kind of creator.Change, in
website/src/pages/ChatSidebar.tsx:creatorAnchors: for the conductor lane only, walk from every listed local row to the creator itsparent.keynames; when that creator is a live local slot indashboard.slotsbut not in the listed rows, admit it. The walk is transitive (member -> lead -> worker) and bounded by the live population. Peer rows are excluded: theirparent.keyis in another gateway's key space and is resolved against the peer listing already.lanePopulation = allRows + creatorAnchorsfeedscitedCreatorExists,conductorRowsand the adoption-move tracker.conductorMatchingis unchanged (built fromflatSlots), so a borrowed creator can never be a match: it renders as the existing dimmed anchor with its chevron, only while a descendant is on screen.SessionRowgainsonOpenElsewhere.renderSessionRowsets it for any local row whose surface the chat page does not render, navigating to/members?member=<agent>. With it set, click and Enter go there instead ofswitchSlot; rename, close, fork, drag and the row menu are withheld exactly as they are for a peer row (foreignRow = !!peerId || onOpenElsewhere != null); the hover title says where the row opens.pages.chatSidebar.opens_on_members_page, inen.manual.jsonand every shipped locale (en-XA regenerated).website/capture/session-tree-member-anchor.{html,tsx}+scripts/capture-session-tree-member-anchor.mjs: an isolated capture entry that reproduces the product's store-vs-prop split through the realChatSidebar, plus a behaviour check (worker depths before and after, the orphan glyph, the anchor's depth and dimming, its hover title, and an unrelated chat-conductor control pair).Second commit - collapsed by default (maintainer decision, 2026-09-27). With the workers attached to their creator, a fully expanded lane still did not read as N crews: the maintainer opened it on a live box and asked for every crew to arrive shut. This supersedes the expanded default #13676 recorded one day earlier; that decision was made before a member-driven crew had ever nested here, and the shut row keeps everything #13676 wanted visible (chevron, child count, the subtree's needs-you / running badges).
mc-sidebar-conductor-expandedholds the rows the user has OPENED. A row absent from it is shut. The supersededmc-sidebar-conductor-collapsedkey is deleted on first read (a user's old "folded away" set is the new default, so nothing they hid comes back open).session_createbehave as before around the new default: a revealed or newly adopted row opens its ancestors so the row is on screen.Members pagechip with the leave-this-page glyph (pages.chatSidebar.members_page_chip) so the page jump is visible text naming the DESTINATION, not hover-only and not the bare noun "Members", which in this product also means the crew's participants; the child count carriesN sessions this one openedas its accessible name and tooltip (pages.chatSidebar.opened_sessions_count, plural, registered inpluralKeys.json), so the bare number has a unit.docs/feature-map/README.md, Sessions row: records the collapsed default, the new key, and the member-anchor behaviour.lineage_pending): the cold-start frame ships every rowparent: nullwhile the gateway's projection seeds, and recording those nulls would read the settling frame's citations as one move per row and persist every crew open on every reload. Skipped, the settling frame is each row's first sighting - a creation - so the collapsed default holds; a row seen settled before keeps the baseline it had.Backwards compatibility
Compatible on the wire and in the backend. The only new rows are creators that were previously absent, and they carry no local-only affordance. Client-side, the fold set changes name and sense:
mc-sidebar-conductor-collapsed(what the user closed) is removed on first read andmc-sidebar-conductor-expanded(what the user opened) starts empty. A user who had folded a conductor away still finds it folded, because folded is now the default; what they lose is any crew they had left open, which reopens with one press.Tests
website/src/test/ChatSidebar.conductorLane.test.tsx, new block a creator this page does not list, run withnpx vitest run src/test/ChatSidebar.conductorLane.test.tsx- 55 passed (46 existing + 6 anchor pins + 2 UX pins: theMembers pagechip on the anchor and not on a worker; the child count's accessible name + 1 cold-start pin: alineage_pendingframe followed by the settled one leaves every crew shut and the opened set empty; reverting the one-line guard reddens exactly that pin). The harness gained an optionalstoreSlotsargument so the store can hold more than the prop, which is the split under test./members?member=kirocrew-pipeline-conductorand leaveschat.activeSlotuntouchedparent.key: null, no such slot in the store) still reads as an orphanMutation check: with
website/src/pages/ChatSidebar.tsxalone replaced by itsorigin/mainversion and the same file re-run, the result is 4 failed | 48 passed (52) - four of the six new anchor pins redden and the two guard pins (the "borrows nothing" and "still reads as an orphan" cases) stay green, which is what those two are for. The file was restored and verified byte-identical by sha256 afterwards.Collapsed default, same file: the pin
is EXPANDED by defaultis rewritten tois COLLAPSED by default, plus pins for the shut row's count and aggregate, the opened-set persistence, the migration that deletes the old key, and reveal / adopt / search opening ancestors. Mutation check: inverting the default (!conductorExpanded.has(key)) reddens exactly the 3 default pins and leaves the other 51 green.website/src/test/ChatSidebar.laneFolderHideParity.test.tsx- 32 passed. ItsbeforeEachnow opens the one crew the fixture nests, because a shut crew would hide the nested child for a reason unrelated to folder hiding, which is what that file tests.Also run:
tsc -p tsconfig.app.jsonclean;eslinton the changed files clean;node scripts/i18n-check.mjsexit 0 (19 checks);node scripts/check-i18n-keys.mjsexit 0;node scripts/gen-pseudolocale.mjsregenerated en-XA.Manual verification
node scripts/capture-session-tree-member-anchor.mjsagainst a dev server on the final head: every checkok,RESULT: ok- before: three workers at depth 0, each withdata-orphan-of="member-kirocrew-pipeline-conductor", and no member row present; after: member at depth 0 withdata-conductor-anchor="true"andopacity=0.55, workers at depth 1, zero orphan glyphs, the anchor's title naming the Members page, control pair (chat conductor + worker) unchanged.Screenshots / video
Before - the state Raymond's sidebar was in: the pipeline conductor's workers float at the top level with the "closed creator" glyph.
After, shut by default (final head) - the member-driven crew is one dimmed anchor row: the
Members pagechip with the leave-this-page glyph, the child count (3) and the subtree's needs-you / running badges; no worker on screen.After, opened (final head) - one press on the chevron nests the three workers one level under it; the aggregate leaves with the fold, the count stays. The unrelated chat conductor beside it is unchanged.
Related Issues
Part of #12757 (conductor lane / session tree). Supersedes the expanded-by-default decision of #13676 for the conductor lane (maintainer decision 2026-09-27, recorded above and in the feature map).
Pattern harvest
Rule candidate: review-prompt
Pattern: a view derives a relation over a FILTERED population and then labels the unresolved side with a fact ("closed", "gone", "missing") that is only true of the UNFILTERED one. When a component receives a pre-filtered list and joins on identities that can point outside it, the join and any "does X exist" glyph must read the full population, or the glyph must be phrased as "not shown here".
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)docs/feature-map/README.mdSessions row now states the collapsed default, themc-sidebar-conductor-expandedkey, and the member-anchor row