Skip to content

fix(ci): clear two main-red pins left by same-day merges - #14520

Closed
Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/main-red-bn-electron
Closed

Pearcekieser wants to merge 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/main-red-bn-electron

Conversation

@Pearcekieser

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: main's Frontend Tests and Electron Shell Tests pass again, so they stop failing readiness on every open PR.

Since the merges at 17:18Z on 2026-09-27, main CI (run 36337451146 on 20ed6a1dc7) fails two pins. Frontend Tests shard 2 fails the bn numerals ratchet with 9 violations against a limit of 8. Electron Shell Tests fails two list-every-site checks in port-owner-self-asserted-identity.test.js.

Why it matters

Every open PR inherits both failures, so none of them can reach a green readiness verdict until main is fixed.

Not a goal

  • Changing any runtime code in gateway-supervisor.js, or reclassifying how it decides port ownership.
  • Lowering the bn numerals limit or converting the other 8 existing Bengali-digit values.

What changed (motivation → approach → change)

The bn failure came from #14097, which added app.metrics_card_old_data with the Bengali digits ৯০. style/bn.md §2 asks for Western digits, so the value now reads 90. That brings the catalog back to 8 violations, within the limit.

The Electron failure came from a merge race. #13883 added a pin that must list every probeGatewayPortOwner call and every owner-sentinel literal in gateway-supervisor.js. #13344, merged the day before, had already added two checks the pin does not list:

  • the restart successor check (successorOwnsPort), which confirms that the process now holding the port is this app and fails the restart if it is someone else;
  • the boot check that refuses to adopt a foreign holder when no remote crew is configured.

Both decide who holds the port, not whether it is held. So they are identity judgements, and I added six exact-text entries for them to IDENTITY_SITES. The occupancy checks in the pin still pass unchanged.

Backwards compatibility

Compatible: one Bengali display string and a test list change. No key, schema or runtime behaviour changes.

Tests

  • website/electron/test/port-owner-self-asserted-identity.test.js: 7 of 7 pass locally, where 2 failed before. Each new entry pins its exact source text and count, so rewording either check fails the pin again.
  • bn numerals: counting Bengali-digit values in bn.json gives 8, which is within the limit of 8.

Manual verification

N/A. The unit pins are the only consumers of these two changes.

Related Issues

Fixes #14519

Pattern harvest

Rule candidate: review-prompt
Pattern: an exhaustive-list source pin merged after a sibling PR added matching sites; the author should rebase the pin onto current main and re-run it before merge, because CI on a stale base cannot see the sibling's sites.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

N/A. The CLA text has not been supplied yet.

kirodotdev#14097 added the bn metrics_card_old_data value with Bengali digits, taking
the bn catalog to 9 against the numerals ratchet of 8; the value now uses
Western digits, as style/bn.md section 2 asks.

kirodotdev#13883 added a list-every-site pin over gateway-supervisor.js that predates
the restart successor-ownership check and the boot refuse-to-adopt check
from kirodotdev#13344, so both fail it as unclaimed. Both are identity judgements
(is the holder this app, or someone else), so they join IDENTITY_SITES.
No runtime code changes.
@Pearcekieser
Pearcekieser requested a review from a team September 27, 2026 19:14
@Pearcekieser
Pearcekieser requested a review from a team as a code owner September 27, 2026 19:14
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — ✅ PASS

UX-level review of 78ad3d7e20111ff4e67e2b811d2ac1835d531859 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] 78ad3d7

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 78ad3d7e20111ff4e67e2b811d2ac1835d531859 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 78ad3d7

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of 78ad3d7e20111ff4e67e2b811d2ac1835d531859 via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the PR's own Electron CI is green — the fail-closed pin will itself surface any #13344 site the six entries still miss.

What this change ships

Inventory (2 items) — 2 justified

Intent: unwedge main's two red CI pins so open PRs can reach readiness again — a FIX.

  1. The Bengali "metrics card" string shows "90" in Western digits — justified
  2. The port-owner pin now lists the six restart/boot identity sites fix(electron): restore the in-app way back from the local-gateway opt-out #13344 added — justified

Evidence checked against base: bn.json carries 9 Bengali-digit values (grep [০-৯]) against the documented debt limit of 8 (src/i18n/style/bn.md §7, pinned by bnStyle.test.ts), and §2 mandates Western digits, so item 1 is invariant-mandated and restores the ratchet exactly. All six pinned strings occur exactly once in gateway-supervisor.js (counted individually), all read probeGatewayPortOwner's verdict rather than the occupancy probe, so IDENTITY_SITES is the classification the pin's own rule requires; on base those calls and sentinels are unclaimed, which reproduces the reported failure. No riders, no deleted pins, both Not a goal exclusions honored.

[FIRST-PRINCIPLES-REVIEWED] 78ad3d7

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ⚠️ could not complete

The design review did not produce a verdict for 78ad3d7e20111ff4e67e2b811d2ac1835d531859 (the review step completed but returned no verdict header). See the Fork Design Review job logs. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 78ad3d7e20111ff4e67e2b811d2ac1835d531859 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 78ad3d7

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #14516, which fixes the same two main-red pins and was opened first in this repo.

@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main CI red: bn numerals ratchet and Electron port-owner site pin

1 participant