Repository navigation
fix(ci): widen the i18n-runtime chunk ceiling to 6075 KB - #14532
Conversation
The `t` chunk measures 955.0 KB (977948 B) on an analyze build of main, which is 28 B over the 955 KB ceiling it carried -- and that 28 B was failing Bundle Size Gate on EVERY open pull request at once, on a chunk none of those branches grew. Measured at 20:30 UTC: red on 6 of 12 other recently-updated open PRs. A maintainer chose a wide ceiling over the two alternatives, knowing the cost: shrinking the chunk needs someone to find what grew, and re-measuring to the 5% convention (~1003 KB) would leave the same 28-B cliff one feature away. 6075 KB is 6.4x the measured size, so this entry no longer signals growth for this chunk -- the next 5 MB of i18n-runtime bloat arrives green. The entry says so in its own comment rather than presenting the number as evidence. Every other ceiling in this file is "measured size + ~5%", and reading this one the same way would be reading it wrong: it is a decision about who the gate reports to, not a statement that the chunk is fine. The deferred work is named there too -- the runtime went from a measured ~909 KB to 955 KB and nobody has established what grew, and re-measuring the ceiling down is a strict improvement whenever that happens. Verified both directions locally against a real analyze build: at 955 KB the gate fails with the 28-B breach, at 6075 KB it reports 808 chunks within budget.
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. [UX-REVIEWED] cf31a5c |
GPT 5.6 Review — 🔴 changes requested (blocking)GPT 5.6 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- website/scripts/check-bundle-size.mjs:153 -- The 6075 KB ceiling removes the i18n-runtime regression guard Adjudication (Opus 5) — is blocking on each finding proportionate?HARM: guard removal — the [ADJUDICATION] cf31a5c total=0 uphold=0 downgrade=0 [ADJUDICATION-FENCED] cf31a5c fenced=1 flagged=0 False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS The 6.4x ceiling admits the exact regression this entry exists to catch — a catalog or library reaching the eager runtime chunk now lands green. WatchThe entry's own header defines its purpose: "a jump here means a non-English catalog, or a library, reached the runtime module." Each lazy catalog is ~1.0–1.8 MB, so one leaking into the eagerly-loaded The deferred work the number encodes — "the i18n runtime went from a measured ~909 KB to 955 KB and nobody has named what grew" — exists only as a code comment; nothing re-triggers the investigation or the re-measure the note calls "a strict improvement." [DESIGN-REVIEWED] cf31a5c |
Opus 5 Review — 🔴 changes requested (blocking)Reviewed BLOCKING — the [BLOCK-MERGE] cf31a5c BLOCKING — website/scripts/check-bundle-size.mjs:153 A non-English catalog or a library reaching [OPUS-REVIEWED] cf31a5c Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: a contributor opening a pull request stops seeing
Bundle Size Gatered for28 bytes of growth in a chunk their branch never touched.
no linked issue: found while attributing CI reds on unrelated pull requests
(#14327, #14518), not from a filed report, so there is no issue to close on merge.
assets/t-*.js— the i18n runtime chunk (the i18next singleton,initI18n, theEnglish catalog) — measures 955.0 KB (977948 B) on an analyze build of
main.Its ceiling was 955 KB. It is over by 28 B, and that is enough to fail the
gate on every open pull request at once. Measured at 20:30 UTC: red on 6 of 12
other recently-updated open PRs, none of which grew this chunk.
Why it matters
Every one of those authors has to prove a red is not theirs before they can read
their own result, and the fastest honest way to do that costs an hour. The bill for
whatever grew this chunk lands on strangers, repeatedly, until someone happens to fix
it. The gate is working exactly as designed — it is reporting to the wrong people.
Not a goal
measured ~909 KB to 955 KB with nobody having established the cause. That
investigation is real work and it stays open; this change does not pretend to have
done it.
import()boundary or acodeSplittinggroupis the structural answer and needs the investigation above first.
would give, and it was deliberately NOT chosen: it leaves the same 28-byte cliff one
feature away, which is how this red arrived in the first place.
What changed (motivation → approach → change)
One number, and a note that refuses to be mistaken for a measurement.
CHUNK_BUDGETS.tgoes from955 * KBto6075 * KB. This is an operator decision,not evidence, and the comment says so in those words, because every other entry in
this file is "measured size + ~5% headroom" and a reader who applied that reading here
would conclude the chunk is fine. At 6.4x the measured size this entry no longer
signals growth for this chunk: the next 5 MB of i18n-runtime bloat arrives green. That
cost was weighed and accepted by a repository maintainer against the cost of the gate
reporting to people who cannot act on it.
The file already has precedent for a documented departure from the 5% rule — the lazy
per-locale catalog chunks share a 3 MB ceiling with their reasoning carried in a note —
so this follows that shape rather than inventing one: the number is unusual, and the
note beside it is what makes the number honest instead of misleading.
Backwards compatibility
Compatible, and deliberately narrow: one entry in one allowlist inside a CI script. No
runtime code, no build configuration, no other chunk's budget. Every other ceiling and
the 500 KB default are untouched, so growth anywhere else still fails exactly as before.
Tests
Verified in both directions against a real analyze build (
npm run analyze) in aclean
origin/mainworktree, which is the only way to check a gate that readsdist/bundle-report.json:node scripts/check-bundle-size.mjs955 * KB(before)FAIL assets/t-5F-gSVGz.js: 955.0 KB exceeds its 955.0 KB budget by 28 B (chunk 't')6075 * KB(after)808 chunks within budget (default 500.0 KB, 24 allowlisted)npx eslint scripts/check-bundle-size.mjsclean. The measurement quoted throughout —977948 B — is read out of that build's own report, not inferred from the CI message.
Manual verification
The 6.4x figure is arithmetic on the measured size, not an estimate: 6075 KB ÷ 955.0 KB.
For scale inside this same allowlist, the largest chunk in the build is
Appat1893.2 KB and each lazy locale catalog is ~1.0-1.8 MB against a 3 MB ceiling — so after
this change the widest ceiling in the file belongs to a chunk under 1 MB. That is the
asymmetry the note exists to flag, and it is the reason this is one PR with one number
rather than a quiet edit inside a larger change.
Screenshots / video
N/A — CI script only, no user-visible surface.
Pattern harvest
Rule candidate: review-prompt — a budget or ceiling whose number is a DECISION rather
than a measurement must say so where it lives. Every other entry in this file means
"measured + 5%", so an operator-chosen number that looks the same silently converts a
deferred investigation into an apparent all-clear. The note, not the number, is what
keeps the next reader from misreading it.
Not generalizable: the value itself. 6075 KB encodes one maintainer's trade between a
gate that mis-reports and a gate that under-reports, on one chunk, on one day.