Repository navigation
fix(chat): outline the whole split follow-up chip on hover - #14720
kyleseaman wants to merge 1 commit into
Conversation
The follow-up chip with a send segment is two sibling buttons, each with its own hover:border, so hovering the up-arrow outlined only that segment while the label and divider stayed dim. Key the border on a group/chip wrapper so the whole pill outlines together; each half keeps its own text/fill hover to show which one is armed.
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 480f0b9 |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the one counted sibling split control — ArtifactsPage's "New artifact" + caret Not justified as shipped
What this change shipsInventory (3 items) — 2 justifiedIntent: hovering either half of a split follow-up chip should outline the whole pill — a FIX.
Fix sits at cause level: the outline was a per-button property when it belongs to the pill, and the change moves it to the wrapper. Grepped [FIRST-PRINCIPLES-REVIEWED] 480f0b9 |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify the compose-vs-send split stays legible: blind reader read the unified pill as one send button ("clicking anywhere on it would send that reply"). [UX-REVIEWED] 480f0b9 |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
Closing as superseded: #14568 (one glass dock for the composer band) rebuilt the split follow-up chip so the wrapper draws and brightens the whole pill on hover, which fixes the one-segment hover outline this PR targeted. Per-half hover cues are retained there too. Nothing left to land. |
Problem / Motivation
Goal: Hovering a follow-up chip's send arrow outlines the whole chip, not just the arrow.
Follow-up option chips with a send (↑) segment are split pills. Hovering the ↑ segment lit only that segment's top, right and bottom edges. The label half and the divider stayed dim, so the pill looked like it had a piece broken off.
Why it matters
These chips sit directly above the composer on almost every turn. The half-lit outline reads as a rendering glitch on one of the most-seen controls in chat.
Not a goal
What changed (motivation → approach → change)
The split chip is two sibling buttons, each carrying its own
hover:border-accent/40, so only the button under the pointer changed its border. The divider is the label button's right border, so it stayed dim too.The outline belongs to the whole pill, so it now keys on the wrapper. In
website/src/components/FollowUpBar.tsxthe split wrapper getsgroup/chip, and both halves usegroup-hover/chip:border-accent/40instead of their ownhover:border-*. Each half still shows which one is armed: the label brightens its text, and the ↑ segment turns its arrow accent on a liftedhover:bg-bg-hoverfill. Picked chips and standalone chips are unchanged.Backwards compatibility
Compatible: class-name-only change on one component; no props, events or behaviour change.
Tests
website/src/test/FollowUpBar.test.tsxadds two cases. One pins that the split wrapper carriesgroup/chipand that neither half has its ownhover:border-*, while each keeps its own text hover. The other pins that the standalone chip keeps its ownhover:border-accent/40. The first was mutation-checked: restoring the old per-segment border class fails it.Manual verification
Rendered the real
FollowUpBaron a local Vite page and captured headless Chromium at 2x, hovering the ↑ segment and then the label, on main and on this branch.Screenshots / video
Hovering the ↑ segment, before (main): only the segment is outlined.
Hovering the ↑ segment, after: the whole pill is outlined and the arrow is accented.
Hovering the label, after: the whole pill is outlined and the label text brightens.
Related Issues
None — reported directly from the dashboard.
Pattern harvest
Not generalizable: a per-half hover border on a two-button pill is a visual judgement a lint cannot tell apart from two ordinary adjacent buttons.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)