Skip to content

fix(chat): outline the whole split follow-up chip on hover - #14720

Closed
kyleseaman wants to merge 1 commit into
mainfrom
fix/followup-split-chip-hover
Closed

kyleseaman wants to merge 1 commit into
mainfrom
fix/followup-split-chip-hover

Conversation

@kyleseaman

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Hovering a follow-up chip's send arrow outlines the whole chip, not just the arrow.

Follow-up option chips with a send (↑) segment are split pills. Hovering the ↑ segment lit only that segment's top, right and bottom edges. The label half and the divider stayed dim, so the pill looked like it had a piece broken off.

Why it matters

These chips sit directly above the composer on almost every turn. The half-lit outline reads as a rendering glitch on one of the most-seen controls in chat.

Not a goal

  • Changing chip sizing, layout, click/double-click semantics, or the picked/pending states.
  • Restyling the standalone chip (no send segment), which already outlines as one piece.

What changed (motivation → approach → change)

The split chip is two sibling buttons, each carrying its own hover:border-accent/40, so only the button under the pointer changed its border. The divider is the label button's right border, so it stayed dim too.

The outline belongs to the whole pill, so it now keys on the wrapper. In website/src/components/FollowUpBar.tsx the split wrapper gets group/chip, and both halves use group-hover/chip:border-accent/40 instead of their own hover:border-*. Each half still shows which one is armed: the label brightens its text, and the ↑ segment turns its arrow accent on a lifted hover:bg-bg-hover fill. Picked chips and standalone chips are unchanged.

Backwards compatibility

Compatible: class-name-only change on one component; no props, events or behaviour change.

Tests

website/src/test/FollowUpBar.test.tsx adds two cases. One pins that the split wrapper carries group/chip and that neither half has its own hover:border-*, while each keeps its own text hover. The other pins that the standalone chip keeps its own hover:border-accent/40. The first was mutation-checked: restoring the old per-segment border class fails it.

Manual verification

Rendered the real FollowUpBar on a local Vite page and captured headless Chromium at 2x, hovering the ↑ segment and then the label, on main and on this branch.

Screenshots / video

Hovering the ↑ segment, before (main): only the segment is outlined.

Before: hovering the send arrow outlines only the arrow segment

Hovering the ↑ segment, after: the whole pill is outlined and the arrow is accented.

After: hovering the send arrow outlines the whole chip

Hovering the label, after: the whole pill is outlined and the label text brightens.

After: hovering the label outlines the whole chip

Related Issues

None — reported directly from the dashboard.

Pattern harvest

Not generalizable: a per-half hover border on a two-button pill is a visual judgement a lint cannot tell apart from two ordinary adjacent buttons.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

The follow-up chip with a send segment is two sibling buttons, each with
its own hover:border, so hovering the up-arrow outlined only that segment
while the label and divider stayed dim. Key the border on a group/chip
wrapper so the whole pill outlines together; each half keeps its own
text/fill hover to show which one is armed.
@kyleseaman
kyleseaman requested a review from a team September 28, 2026 15:22
@kyleseaman
kyleseaman requested a review from a team as a code owner September 28, 2026 15:22
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 480f0b9916a0fa859e93e87c9e8cc19d5c35d856 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 480f0b9

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 480f0b9916a0fa859e93e87c9e8cc19d5c35d856: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 480f0b9916a0fa859e93e87c9e8cc19d5c35d856 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 480f0b9

@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 480f0b9916a0fa859e93e87c9e8cc19d5c35d856 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the one counted sibling split control — ArtifactsPage's "New artifact" + caret Btn pair (website/src/pages/ArtifactsPage.tsx:1792) keeps per-half hover borders, deliberately left unfixed.

Not justified as shipped

  • Item 2 — rides along: the outline fix is complete without hover:bg-bg-hover; the segment's existing hover:text-accent already marked which half is armed. Harm-free and declared ("the ↑ segment turns its arrow accent on a lifted hover:bg-hover fill").

What this change ships

Inventory (3 items) — 2 justified

Intent: hovering either half of a split follow-up chip should outline the whole pill — a FIX.

  1. Hovering either half of a split chip outlines the whole pill, divider included — justified
  2. The ↑ segment additionally lifts its background fill on hover — rides along: not needed to remove the half-lit outline
  3. Two tests pin the wrapper-keyed outline and the standalone chip's own hover — justified

Fix sits at cause level: the outline was a per-button property when it belongs to the pill, and the change moves it to the wrapper. Grepped rounded-l-lg|rounded-r-lg|border-l-0 across website/src: one structural sibling (the ArtifactsPage split Btn), named in the punchline; the description's "Pattern harvest" declares non-generalizability, and whether that subtler hover:border-border-strong seam reads as broken is a visual judgement, not a counted defect.

[FIRST-PRINCIPLES-REVIEWED] 480f0b9

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of 480f0b9916a0fa859e93e87c9e8cc19d5c35d856 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify the compose-vs-send split stays legible: blind reader read the unified pill as one send button ("clicking anywhere on it would send that reply").

[UX-REVIEWED] 480f0b9

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 480f0b9916a0fa859e93e87c9e8cc19d5c35d856 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 480f0b9

Verdict parsed from the review's SHA-scoped output markers for commit 480f0b9916a0fa859e93e87c9e8cc19d5c35d856.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 480f0b9916a0fa859e93e87c9e8cc19d5c35d856: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention merge conflict Branch has merge conflicts with its base — author must resolve before merge and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@kyleseaman

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #14568 (one glass dock for the composer band) rebuilt the split follow-up chip so the wrapper draws and brightens the whole pill on hover, which fixes the one-segment hover outline this PR targeted. Per-half hover cues are retained there too. Nothing left to land.

@kyleseaman kyleseaman closed this Sep 28, 2026
@github-actions github-actions Bot removed the readiness: action required A blocking check or review needs attention label Sep 28, 2026
@bolichen97
bolichen97 deleted the fix/followup-split-chip-hover branch November 6, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant