Skip to content

fix(website): keep touch taps from opening InstantTip hints - #14798

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/instant-tip-touch
Oct 2, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/instant-tip-touch

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a phone, one tap on a tooltip-carrying button runs its action.

On iPhone the first tap on a follow-up option chip, an inline-code copy chip, the feedback pill's "Request a feature" button or the image "Resized" badge often does nothing, and the second tap works. All four use the shared useInstantTip hook. The paste-token chip in the composer has the same problem with its preview.

Why it matters

Every phone user hits it on the controls they use most in a chat: picking a suggested reply and copying an inline value. A tap that silently fails reads as a broken button.

Not a goal

  • Radix menu modality, touch hit-area size and the ungated hover: variant. Each has its own PR.
  • The follow-up chip's pick-then-send gesture. One tap selects and a second tap sends by design; that is not this bug.
  • A touch way to read a clamped chip label or the resize figures. The accessible name still carries both.
  • Three other rendered sites that reveal content from onMouseEnter with no pointer-type check, and so can cost an iOS tap's click the same way, are left unfixed here: apps/issue-radar/components/RefLink.tsx (320ms hover card), hooks/useHoverIntent.ts (320ms open), components/MarkdownToc.tsx (synchronous expand) and the collapsed nav rail's useNavTip in App.tsx (synchronous label). They are tracked in iOS: three more onMouseEnter reveals cost the tap's click #15341, which also tracks replacing the feedback pill's openOnTap with visible warning text on touch.

What changed (motivation → approach → change)

A tap on a tooltip button no longer opens its tooltip, so on iPhone the first tap runs the button's action. Mouse hover and keyboard focus still show the tooltip.

For a tap, iOS Safari replays mouseover/mouseenter before it decides to send the click. If content appears during that replay, Safari treats the tap as a hover and drops the click. useInstantTip in website/src/components/InstantTip.tsx opened its tooltip from onMouseEnter on a 100ms timer with no pointer check, so the tooltip was that content.

The hook now listens to the anchor's own pointerenter, pointerdown and pointerup. A touch pointer marks the next TOUCH_REPLAY_WINDOW_MS (1s) as a tap replay, and a mouseenter or focus inside that window opens nothing. Any other pointer type clears the mark at once. The gate reads the event rather than the device, so a mouse on a touch laptop or tablet still hovers. Keyboard focus outside the window still shows the tip immediately. A held outcome such as the copy chip's "Copied!" still opens at the tapped anchor, because focus records the anchor before it returns.

The resize badge in website/src/components/chat-input/FilePreviewStrip.tsx has no click action, so a tap there has no click to lose and its bubble is the only way a phone reads the sizes. It passes a new openOnTap option, which keeps the old tap-opens behaviour. The feedback pill's "Request a feature" button in website/src/components/FeedbackPill.tsx passes it too, because its bubble is the only place that says the click starts an agent turn that spends monthly usage (#13342). A phone user still sees that warning on the first tap, and on iOS that button may still need a second tap to act.

website/src/components/PasteTokenNode.tsx opens its hover preview from onPointerEnter when the pointer is not a touch, in place of onMouseEnter. A tap's replayed mouseenter no longer opens it, and a mouse or pen on a touch device still previews on hover. onFocus still previews, and the tap toggles the preview through onClick as before. The chip doesn't need the hook's timed window: it opens from the pointer event itself, which carries pointerType, and never listens to the replayed mouseenter.

McpInfoButton also opens a popover from onMouseEnter, but no page renders it today, so it is left alone.

Backwards compatibility

Compatible: mouse and keyboard paths are unchanged. Only mouse events that follow a touch pointer on the same anchor are ignored.

The touch gate applies on every touch browser, not only iOS, because the code has no reliable way to tell iOS WebKit apart and Android's tap was never broken. On Android, a tap therefore no longer opens a tooltip either, so a clamped follow-up chip label has no tap-to-read path there, just as on iPhone. The feedback pill's usage warning keeps its tap-open on every platform. On Android the warning appears as the tap starts the agent turn, which is what happened before this PR.

Tests

  • website/src/test/InstantTip.test.tsx: a full tap sequence runs the anchor's click and mounts no tooltip; a pointerType: 'mouse' enter still opens after the delay; a mouse right after a tap hovers normally; keyboard focus after the window shows at once; a held outcome after a tap still opens.
  • website/src/test/ChatInput.resizeBadge.test.tsx and InstantTip.test.tsx: with openOnTap, a touch tap still opens the bubble.
  • website/src/test/FeedbackPill.test.tsx: a touch tap on "Request a feature" shows the usage warning and still calls the action once. It fails with openOnTap removed.
  • website/src/test/FollowUpBar.test.tsx: a touch tap on a chip calls onSelect once and mounts no tooltip.
  • website/src/test/LexicalComposerInput.test.tsx: a touch pointerenter plus replayed mouseenter does not open the paste preview, a tap toggles it, a mouse pointerenter previews, and keyboard focus still previews.

With the production hunks reverted, the three touch-tap tests fail.

Manual verification

Not yet run on an iPhone. iOS WebKit's click suppression does not run in Chromium, jsdom or Linux WebKit, so CI cannot exercise it. The on-device check, pending from the maintainer who has the device: tap a follow-up option chip once, tap an inline-code copy chip once, and tap the "Resized" badge on a downscaled image attachment once. The chip and the copy chip should each act on the first tap, and the badge should open its size bubble.

The two premises the fix rests on are read from WebKit's source, Source/WebCore/page/cocoa/ContentChangeObserver.cpp at 49480340a1, rather than from the order the tests replay:

  1. Which mount costs the click. The observer watches the tap from touchstart, through the gap between touchend and the synthetic mouseMoved (isBetweenTouchEndAndMouseMoved), through mouseMoved dispatch, and then for a short fixed window. didInstallDOMTimer follows any single-shot timer of 400ms or less (maximumDelayForTimers) installed in that span, and an element that becomes visible when such a timer fires counts as a content change, so no click is sent. The old onMouseEnter ran inside mouseMoved dispatch and installed a 100ms single-shot timer, so the tooltip mount was an observed change. With this PR the replayed mouseenter returns before it installs any timer. focus comes from the synthetic mousedown, which WebKit sends only after it has decided to click, so the focus path could not cost the click. It is gated anyway so a tap does not leave a tooltip open with no leave event to close it.
  2. That the tap's pointer events arrive before the replayed mouse events. WebKit sends a touch's pointerdown/pointerup from the touch events themselves (PointerCaptureController::dispatchEventForTouchAtIndex, called from touch dispatch in EventHandler), and the synthetic mouse events start only at mouseMoved, after touchend. So notePointer has set the touch window before mouseenter runs, which is the order the tap() helper in InstantTip.test.tsx replays.

Screenshots / video

Why no screenshot: the change removes a tooltip from the touch tap path; mouse and keyboard rendering is pixel-identical, and the touch difference is an event order that desktop capture cannot show.

Related Issues

Fixes #14797

Pattern harvest

Rule candidate: review-prompt
Pattern: content revealed from onMouseEnter/mouseover (a timer-mounted tooltip, a popover, a preview) with no touch or pointer-type check costs iOS users the tap's click.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested a review from a team September 28, 2026 18:41
@Pearcekieser
Pearcekieser requested a review from a team as a code owner September 28, 2026 18:41
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Intent: A single touch tap on any button that uses the shared InstantTip hook (follow-up chips, inline-code copy chips, the feedback pill, the image resize badge) and on the composer's paste-token chip runs its action on the first tap, because the tap no longer opens a hover tooltip or preview that iOS Safari treats as a hover.
Not a goal: changing mouse or keyboard tooltip behaviour, the follow-up chip's pick-then-send gesture, Radix menu modality, touch hit-area size, the ungated hover: variant, or adding a touch way to read clamped labels.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running labels Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5, fork) — ✅ PASS

Premise-level review of 9324daa46da3f672ab4d4dde8753c65009fc735e via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the pending on-device iPhone check (#53's three taps): iOS click suppression runs in no CI browser, so the WebKit-source premises are untested on hardware.

What this change ships

Inventory (8 items) — 8 justified

Intent: on a phone, one tap on a tooltip-carrying button runs its action — a FIX (provenance: touch-tap tests added here fail with the production hunks reverted; mechanism read from WebKit's ContentChangeObserver.cpp at a pinned commit).

  1. On iPhone, the first tap on a follow-up chip or inline-code copy chip now runs its action — justified
  2. A tap no longer opens a tooltip on any touch browser, Android included — justified
  3. The shared hint hook gains an openOnTap opt-in — justified
  4. The image "Resized" badge still opens its size bubble on tap — justified
  5. The feedback pill's usage warning still opens on tap; its action may still take two taps on iOS — justified
  6. The paste-token chip's preview no longer opens from a tap's replayed hover; the tap still toggles it — justified
  7. Keyboard focus within 1s of a tap on the same anchor paints no tooltip — justified
  8. A held outcome ("Copied!") after a tap still opens at the tapped anchor — justified

Counts run: openOnTap has 2 real consumers (FilePreviewStrip.tsx:15, FeedbackPill.tsx:107); grep onMouseEnter across website/src confirms the declared unfixed siblings (RefLink.tsx:199, useHoverIntent.ts:411, MarkdownToc.tsx:250, useNavTip in App.tsx:643/appRail.tsx:233, all tracked in #15341); PastedChip.tsx:67 is already guarded by isTouchDevice(); McpInfoButton has 0 render sites outside tests, as the description says. No deleted pin: the one rewritten test line (LexicalComposerInput.test.tsx:125) preserves the behaviour it pinned. docs/decisions/ records no tooltip-on-tap decision.

[FIRST-PRINCIPLES-REVIEWED] 9324daa

Description read

[DESCRIPTION-READ] 9bb532ed395cbdd5c9154c56f8c700709d78fe8d68261dac9a47ea1767a40238

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — 🟡 CONCERNS

Design-level review of 9324daa46da3f672ab4d4dde8753c65009fc735e via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: CONCERNS

The fix's effectiveness is untested on the only platform that shows the bug — the iPhone check the PR names is still pending.

Watch

Both load-bearing premises (tooltip mount during replay costs the click; pointer events precede the replayed mouse events) are read from WebKit source, not observed on a device; jsdom replays the order the author assumed. If either premise is off on real iOS, phone users keep double-tapping while every Android user has already paid the cost of losing tap-to-read tooltips ("On Android, a tap therefore no longer opens a tooltip either").
Clears when: the on-device check the description specifies (first-tap on a follow-up chip, an inline-code copy chip, and the Resized badge on an iPhone) is run and its result posted on the PR.

[DESIGN-REVIEWED] 9324daa

Description read

[DESCRIPTION-READ] 2cf4b45c8269d2d6ab6adc19357ef7370b50fe9296cc5c2dc852f9622b8ec9e6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — ✅ PASS

UX-level review of 9324daa46da3f672ab4d4dde8753c65009fc735e via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify the pending on-device iPhone check: one tap on a follow-up chip, a copy chip, and the "Resized" badge behaves as the description promises.

[UX-REVIEWED] 9324daa

Description read

[DESCRIPTION-READ] d3e098f306b03e07313f4eda13938a22866f958b46bfc48a8cd20f2626166d16

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 9324daa46da3f672ab4d4dde8753c65009fc735e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 9324daa

@github-actions

github-actions Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 9324daa46da3f672ab4d4dde8753c65009fc735e via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 9324daa

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: PasteTokenNode opens its hover preview from a non-touch pointerenter instead of an isTouchDevice() check

  • fixed: PasteTokenNode no longer sniffs the device (span=72fb73b3db4c)

suggestion (non-blocking): fixed in 63b7a35. The chip now opens its preview from onPointerEnter when pointerType !== 'touch', replacing onMouseEnter plus isTouchDevice().
A tap's replayed mouseenter no longer reaches the preview, and a mouse or pen on an iPad with a trackpad still previews on hover. Keyboard focus still previews.
LexicalComposerInput.test.tsx covers a touch pointerenter (no preview), a mouse pointerenter (preview), a tap (toggles) and focus (preview).

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: on-device iPhone result (span=84de6c43d340)

question (non-blocking): agreed that the iOS claim needs a device. iOS WebKit's click suppression cannot run in the Linux CI browsers, so the tests pin the event order and the mechanism only.
@Pearcekieser, please post the two-control result from a phone: tap a follow-up option chip once and an inline-code chip once, and say whether each acted on the first tap.
Until that result is posted, the claim rests on the WebKit behaviour described in #14797 and the tests.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: useInstantTip openOnTap option, used by ChatInput's ResizeBadge

  • fixed: the resize badge opens on a tap again (span=da4d612417e4)

issue (non-blocking): fixed in 63b7a35. ResizeBadge has no click action, so a tap there has no click to lose and its bubble is the only way a phone reads the sizes.
useInstantTip({ openOnTap: true }) skips the touch-replay gate for that anchor only, which is its behaviour before this PR. Every other consumer has a click action and keeps the gate.
ChatInput.resizeBadge.test.tsx and InstantTip.test.tsx pin that a touch tap opens the bubble under openOnTap.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: on-device iPhone check at this revision (span=113be09408f9)

question (blocking): agreed. The iOS click-drop cannot run in the Linux CI browsers, so only a device can clear this.
@Pearcekieser, please run this on an iPhone against this head and post the result here. Tap a follow-up option chip once, tap an inline-code copy chip once, and tap the "Resized" badge on a downscaled image attachment once.
Expected: the chip and the copy chip each act on the first tap, and the badge opens its size bubble.
No code change is planned until that result is in. If a tap still fails, the result tells us which path to fix.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 28, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: the two platform facts are now read from WebKit source; the iPhone run is still pending (span=113be09408f9)

question (blocking): the review names two facts it says only a device shows. Both are in WebKit's own source, ContentChangeObserver.cpp at 49480340a1, and the "Manual verification" section now cites them.

Which mount costs the click. The observer runs from touchstart through the synthetic mouseMoved dispatch and a short fixed window after it. didInstallDOMTimer tracks every single-shot timer of 400ms or less (maximumDelayForTimers) installed in that span, and an element made visible when one fires is a content change, so no click is sent. The old onMouseEnter installed a 100ms single-shot timer inside mouseMoved, which is the tracked case. focus comes from the synthetic mousedown, which WebKit sends only after it has decided to click, so it cannot cost the click. With this PR neither path mounts anything for a tap, so the answer does not change the fix.

Pointer events before the replayed mouse events. WebKit sends a touch's pointerdown/pointerup from touch dispatch (PointerCaptureController::dispatchEventForTouchAtIndex), and the observer's own state isBetweenTouchEndAndMouseMoved shows the synthetic mouse events start after touchend. That is the order tap() in InstantTip.test.tsx replays.

The on-device run is still not done, and I have no iPhone. Maintainers: please rule whether the source evidence clears this block, or @Pearcekieser please run the check at head 6a2f334fcd (same diff as 63b7a350bc, rebased): tap a follow-up option chip once, an inline-code copy chip once, and the "Resized" badge on a downscaled image attachment once. The chips should act on the first tap and the badge should open its size bubble.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: on-device iPhone run, or a maintainer ruling on the WebKit-source evidence (span=7f2f92bb5cab)

question (blocking): agreed that only a device or a maintainer can clear this. No code change is planned. The source reading behind the fix is in the "Manual verification" section and in issuecomment-5904938194.
Maintainers: please say whether the ContentChangeObserver.cpp derivation is enough to merge.
@Pearcekieser: or run the check on head 6a2f334fcd. Tap a follow-up option chip once, an inline-code copy chip once, and the "Resized" badge on a downscaled image attachment once. The two chips should act on the first tap, and the badge should open its size bubble.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased onto current main with no code change; new head 60ba6eaeb7, range-diff identical to 63b7a350bc.

The red Backend Tests (3.12, 1) shard on 6a2f334fcd failed three test/test_acp_runtime.py spawn tests with "Agent 'kirocrew' has no prepared skill discovery view". This PR touches only website files. Main has since landed #15202, which changes how skill-view mode names map to their agent, so this push picks that up and re-runs the shard. The Design question above still needs a device run or a maintainer ruling.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Same tree as 60ba6eaeb7, with only the commit timestamp changed; new head 8a498c96a8. This reruns seven lanes that failed at 06:31-06:33Z on the CI app's installation API rate limit: GPT, Opus, Security Scope, Internal Content Scan, readiness publish, desktop matrix and Screenshot Evidence.

Backend Tests (3.12, 1) failed again with the same three test_acp_runtime.py spawn tests ("no prepared skill discovery view"). This PR changes no backend code, and those two tests pass on this tree when run on their own, so the failure depends on what else runs in the shard, not on this diff.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Sep 30, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/instant-tip-touch branch from 1acce2d to af3988b Compare October 1, 2026 03:00
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Re-synced onto main with no code change; new head af3988b699. Main had gained 29 commits, and green_age reported the head stale against them, including an edit to FeedbackPill.tsx, a file this PR also changes. The five touched test files pass (161/161) and tsc is clean. This push also reruns Backend Tests (Windows) (4), so the rerun request above is no longer needed.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 1, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Frontend Tests (4) on af3988b699 failed one test, src/pages/members/MembersPage.test.tsx "roster rows show the last message preview, not an Idle/Working label". It comes from main, not this PR. I ran that test file locally on this PR's merge base (7114800dd6, plain main) and it fails the same way: 1 failed, 230 passed. The test passes when run on its own, so the failure depends on test order within the file. This PR doesn't touch pages/members. The Opus lane reported "review incomplete", which is a lane run problem, not a finding.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

issue (non-blocking): agreed. useNavTip in App.tsx mounts its label synchronously from onMouseEnter with no pointer-type check. It runs only when the nav rail is collapsed, which a tablet can reach. It's now listed in #15341 (issuecomment-5924415889) next to the other three sites, and the "Not a goal" section of this PR names it.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: the iPhone run is still pending (span=fd854bdd7baa)

question (non-blocking): agreed. The three-tap check in "Manual verification" is open for @Pearcekieser, or a maintainer can rule on the WebKit-source evidence in issuecomment-5904938194. No code change is planned for this item.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

suggestion (non-blocking): agreed that showing the warning as visible text, or as a confirm step on touch, would protect #13342 without the iOS double tap. That changes the top bar's layout and copy, which is outside this PR, so it's tracked in #15341 (issuecomment-5924415889) as the follow-up. Until then openOnTap keeps the warning visible before the metered action.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 1, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/instant-tip-touch branch from af3988b to 1f4ddc9 Compare October 1, 2026 05:01
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Re-synced onto main with no code change. New head 1f4ddc98b9. This picks up #15711, which fixes the MembersPage.test.tsx roster test that failed Frontend Tests (4) on the previous head. That test file and the five files this PR touches pass locally (395/395). This push also reruns the incomplete Opus lane.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: on-device iPhone run, or a maintainer ruling on the WebKit-source evidence (span=8c73c5ac2aeb)

question (blocking): this is now the only red check on 1f4ddc98b9; every CI job and the GPT, Opus and UX lanes pass. No code change can clear it.
@Pearcekieser: please run the three-tap check on this head. Tap a follow-up option chip, an inline-code copy chip, and the "Resized" badge on a downscaled image attachment once each. The chips should act on the first tap and the badge should open its size bubble.
Maintainers: alternatively, rule whether the source evidence in issuecomment-5904938194 is enough to merge.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
  • needs-a-decision: same device check as the Design blocker (span=f71f538faeac)

question (non-blocking): same premise and same clearing step as Design span 8c73c5ac2aeb. It needs the iPhone run or a maintainer ruling, and no code change is planned for it.

On iOS Safari a tap replays mouseover/mouseenter before the click, and a
hint mounted in that window counts as a hover content change, so Safari
drops the click and the chip needs a second tap. useInstantTip now reads
the tap's own pointer events and ignores the replayed mouseenter and
focus for a short window; a mouse (pointerType mouse) still hovers and a
held outcome still opens. PasteTokenNode opens its hover preview from a
non-touch pointerenter instead of mouseenter, for the same reason.
@Pearcekieser
Pearcekieser force-pushed the fix/instant-tip-touch branch from 1f4ddc9 to 9324daa Compare October 2, 2026 02:45
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased onto current main (fa37aa5), no code change: range-diff of 1f4ddc9 vs 9324daa is identical. The five touched test files pass locally (164 tests) and tsc is clean. Pushed in a patrol-granted slot to refresh CI against main.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 2, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Design Review on 9324daa returned CONCERNS (advisory) with one Watch item, the on-device iPhone check. Disposition: needs-a-decision, unchanged from earlier heads. This head is a no-code-change rebase, so the WebKit-source evidence in the description still applies. The Watch item clears when the three first-tap checks (follow-up chip, inline-code copy chip, Resized badge) are run on an iPhone and posted here.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 2, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: PR Readiness green on this head, merges cleanly into current main, no outstanding blocking review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPhone: first tap on tooltip buttons (follow-up chips, copy chips) does nothing

2 participants