Skip to content

test: record the pid-reader site that #14510 added - #14883

Merged
bolichen97 merged 1 commit into
mainfrom
fix/pid-reader-ratchet-161
Sep 29, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
fix/pid-reader-ratchet-161

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: make test_pid_reader_sites_match_the_recorded_count_exactly pass on main again.

The ratchet scans 161 pid-reader sites on main and records 160, so Backend Tests (3.12, 4) and Backend Tests (Windows) (4) fail on every open PR whose CI merges past a452877dc5. The extra site is src/kiro_crew/session_cleanup.py (2 -> 3), from #14510, which started asking the ownership record which sessions run on a pid without re-recording the count in the same commit. Tracked in #14776.

Why it matters

Shard 4 is red for the whole repository, not for the PRs it appears on. Until the count matches the tree, every PR carries a red it cannot fix, and a second real regression on that shard would hide behind this one.

What changed

  • test/test_pid_reader_ratchet.py: _BASELINE_SITES 160 -> 161.

That is the step the ratchet's own doc prescribes for an added reader: record the new number. The site is an ordinary reader in a sweep, not the module that owns a runtime or the function that ends it, so pid-owner-ok does not apply to it.

Not a goal

Tests

  • test/test_pid_reader_ratchet.py: 6 passed on this branch; 1 failed on unmodified origin/main with pid-reader sites: 161 in 31 files (recorded 160).
  • black --check, flake8, comment-history gate (COMMENT_HISTORY_BASE_REF=origin/main): clean.

Manual verification

Reproduced the failure on a fresh worktree at origin/main before the change; the same command passes after it.

Security & Privacy

None. Test constant only.

Rollback

Revert the commit.

Pattern harvest

Rule candidate: a PR that adds a pid-reader site must move _BASELINE_SITES in the same commit; the ratchet says so in its failure message, and a reviewer can check the two hunks travel together.

Related

The ratchet counts 161 reader sites on main and records 160. The extra site is session_cleanup.py (2 -> 3), added when the sweep started asking the ownership record which sessions run on a pid, without the count being re-recorded in the same commit. Record it, so shard 4 stops failing on every open PR.
@bolichen97
bolichen97 requested a review from a team as a code owner September 29, 2026 00:42
@bolichen97
bolichen97 merged commit 9932337 into main Sep 29, 2026
85 checks passed
@bolichen97
bolichen97 deleted the fix/pid-reader-ratchet-161 branch September 29, 2026 00:45
@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ⚠️ could not complete

The design review did not produce a verdict for a7d4af2df2f15646c11c5f2b8a41052311f250ec (the review step completed but returned no verdict header). See the Design Review job logs. Advisory — does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of a7d4af2df2f15646c11c5f2b8a41052311f250ec and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a7d4af2

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a7d4af2df2f15646c11c5f2b8a41052311f250ec: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed a7d4af2df2f15646c11c5f2b8a41052311f250ec — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a7d4af2

Verdict parsed from the review's SHA-scoped output markers for commit a7d4af2df2f15646c11c5f2b8a41052311f250ec.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a7d4af2df2f15646c11c5f2b8a41052311f250ec: <one-sentence reason>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant