Repository navigation
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm the 2026-09-28 product-owner revision is a real human decision — this PR reverses the RFC's earlier explicit "never a package's" exclusion. [DESIGN-REVIEWED] 19975b9 Description read[DESCRIPTION-READ] 3926f103b6d45313fb29e8f889f888938322b6f20daeadad023efdbb9c2cdf0a That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsThe revised §03 excludes the runtime's agents by a source stamp none of their enrolled rows carry, so the exclusion is vacuous and contradicts §7 in the same diff. FINDING — docs/request-for-change/rfc-crewmates-launch.md:161 — FINDING — docs/request-for-change/rfc-crewmates-launch.md:177 — [OPUS-REVIEWED] 19975b9 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
The launch RFC's screen 03 limited the startup prune to rows bound to the person's own agents. The old sync enrolled package-installed agents the same way, so those rows are the same leftover state and stay on the roster forever under that rule. Section 03 now covers package-installed specs, leaves the runtime's own and uninstalled specs alone, defines "chatted with" as a turn in the crewmate's own Crewmates-page thread, states that a created crewmate is never removed, and keeps an unreadable thread's crewmate without holding the rest of the pass back.
19975b9 to
d2b6faf
Compare
|
Folded into #14897: the RFC §03 amendment now ships in the same commit as the prune change it records. |
Problem / Motivation
Goal: the crewmates launch RFC records the startup prune rule that removes every never-chatted crewmate the old agent sync generated, including those bound to package-installed agents.
Screen 03 of
rfc-crewmates-launch.mdlimits the one-time prune to rows bound to "a custom agent of the person's own — never ... a package's". The sync that generated those rows enrolled package-installed agents the same way, so on an install whose agents mostly come from packages the prune removes almost nothing and the Crewmates roster stays full of templates. The RFC also never says what "chatted with" means, which left the implementation counting any session that ran the agent.Why it matters
#14897 implements the wider rule and is blocked by the First Principles lane until an accepted RFC on main records it.
Not a goal
What changed (motivation → approach → change)
Section 03 of
docs/request-for-change/rfc-crewmates-launch.mdnow names the rule #14897 ships.kirocrewstamp), a private copy, or an uninstalled specmember_idis never removedThe reasoning paragraph says why package rows count (the same sync made them, and one click re-enrols them), why only the crewmate's own thread counts, and why one bad file keeps only its own crewmate. Sections 6, 7 and 8 and the
implementation-prsfront matter match.Backwards compatibility
Compatible: documentation only; no code, config or API changes.
Tests
N/A — documentation only;
scripts/docs-lint.shpasses.Manual verification
N/A — documentation only.
Related Issues
no linked issue: records the product decision #14897 implements.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)