Repository navigation
feat(ui): notification panes wear the composer's liquid glass - #14921
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify in the light-theme recording that a banner over bright, busy page content stays legible — the deleted 88% banner tint existed for exactly that case. [DESIGN-REVIEWED] 738bdc3 Description read[DESCRIPTION-READ] 3902ac79b4901da3931000e4b7fb616743720fd7962f62d0d2f6604fb58c940f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the banner's legibility over busy light-theme page content: the deleted 88 % tint's own comment said the banner "needs a denser tint" there. What this change shipsInventory (10 items) — 10 justifiedIntent: make the notification banner and bell-popover rows wear the same Liquid Glass material as the composer, at the maintainer's request — an ADDITION (restyle).
The elevation test deleted in [FIRST-PRINCIPLES-REVIEWED] 738bdc3 Description read[DESCRIPTION-READ] 91c73935c8574b89871bbbe5888d67ae8bc3ee0fc1e4894f8afebd665113f060 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS One purple glass step means two things — the blind reader had "no idea" why the selected row was purple, since the Keep/Mute prompt wears the same accent tint. Watch
[UX-REVIEWED] 738bdc3 Description read[DESCRIPTION-READ] df59e560de3d42f252ed1533ef7b91e89bb4695597e57d0e7adf363584c3d3fb That sha256 names everything this verdict read: the PR description, plus the 18 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsRecession and muting are expressed as FINDING — website/src/components/notifications/NotificationCard.tsx:122 — FINDING — website/src/components/notifications/NotificationFeed.tsx:494 — FINDING — website/src/components/notifications/NotificationFeed.tsx:397 — the mac feed renders one [OPUS-REVIEWED] 7c29b95 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
The in-app notification banner and the bell popover's rows were the
last floating surfaces still built from their own tint, blur, border
and shadow classes (MAC_CARD_* / BANNER_CARD_* / CARD_MATERIAL in
notifMeta) while the composer dock and the mobile Settings capsule had
moved onto the Glass primitive. Two generations of material sat one
above the other on the same screen.
NotificationCard is now a <Glass variant="panel" radius={16}> pane, so
the banner card, every popover row, the banner's blank deck shells, its
"+N more in your inbox" pill, the feed's controls card and its stack
edges are one material. The card no longer knows which surface it is
on: the pane reads correctly over the sheet's scrim and over page
content alike, so the elevation prop (popover / banner) and its
data-elevation attribute, whose only remaining job was picking one of
two tints, are deleted with the tints. State is a tint step on the
host, never an edge and never an opacity: glass-accent for the selected
row (was a border-accent + accent-subtle fill), glass-hover on a
pressable card, and a new glass-faded step (the tint thinned to 55%)
for a silenced row (was a dashed border), a collapsed stack's edges and
the banner's deck shells. Opacity on a glass host would make it a
backdrop root and void its own blur, so the banner deck's per-depth
wrapper opacity goes too; the shells carry the faded step instead. The
first-note-from-a-channel prompt becomes its own accent-tinted chip
pane under the row, since a pane has one radius and cannot be glued to
the card's bottom edge. Action capsules are unchanged.
A list of panes mounts many equal boxes in one commit, so the
displacement map — a pure function of size, radius and band — is now
memoised across LiquidGlass instances in a small bounded cache: N equal
popover rows cost one canvas encode, not N.
Every pane still carries notif-material: the index.css hook that
solidifies these surfaces to the card colour where backdrop-filter is
unsupported, and the selector the sheet's background-press verdict keys
on. The material constants are deleted; the shared-card test pins that
the card is a Glass pane with no material classes, no opacity and no
surface marker of its own, and that state is a tint step. The banner
capture harness gains popover-states (selected + silenced + collapsed
stack) and popover-channel-prompt frames.
7c29b95 to
738bdc3
Compare
|
self-added: yes
|
|
self-added: yes
|
The strip behind the bell sheet's rows was 12% black with a 4px blur (#3029, added for text contrast when the rows were flat cards). Since the rows became liquid glass (#14921) each carries its own tint and glass-shadow, so the scrim stacked under them and read as a heavy shadow down the sheet's left edge: on a white page it darkened the strip from 248 to 217, on the dark theme from 28 to 24. Set it to 2% black with a 2px blur. The strip still separates the column from the page (248 -> 243 light, 28 -> 27 dark) without reading as a shadow; the rows carry the contrast now. Adds capture-notification-scrim.mjs: opens the seeded sheet on the built SPA in both themes and photographs the viewport, with an optional SCRIM_CSS override so the previous strength can be shot from the same build for a before/after pair.
The strip behind the bell sheet's rows was 12% black with a 4px blur (#3029, added for text contrast when the rows were flat cards). Since the rows became liquid glass (#14921) each carries its own tint and glass-shadow, so the scrim stacked under them and read as a heavy shadow down the sheet's left edge: on a white page it darkened the strip from 248 to 217, on the dark theme from 28 to 24. Set it to 2% black with a 2px blur. The strip still separates the column from the page (248 -> 243 light, 28 -> 27 dark) without reading as a shadow; the rows carry the contrast now. Adds capture-notification-scrim.mjs: opens the seeded sheet on the built SPA in both themes and photographs the viewport, with an optional SCRIM_CSS override so the previous strength can be shot from the same build for a before/after pair.
…15391) The strip behind the bell sheet's rows was 12% black with a 4px blur (#3029, added for text contrast when the rows were flat cards). Since the rows became liquid glass (#14921) each carries its own tint and glass-shadow, so the scrim stacked under them and read as a heavy shadow down the sheet's left edge: on a white page it darkened the strip from 248 to 217, on the dark theme from 28 to 24. Set it to 2% black with a 2px blur. The strip still separates the column from the page (248 -> 243 light, 28 -> 27 dark) without reading as a shadow; the rows carry the contrast now. Adds capture-notification-scrim.mjs: opens the seeded sheet on the built SPA in both themes and photographs the viewport, with an optional SCRIM_CSS override so the previous strength can be shot from the same build for a before/after pair.
Problem / Motivation
Goal: The in-app notification banner and the bell popover's rows wear the same Liquid Glass material as the composer dock, so every surface floating over the page is one glass.
Since #14460 / #14568 the composer band and the mobile Settings capsule are
Glasspanes. The notification panes — the Notification Center-style banner under the top bar and the popover's rows and controls card — were still assembled from their owncolor-mixtint,backdrop-blur-2xl, hairline border andshadow-md/lgclasses (MAC_CARD_*,BANNER_CARD_*,CARD_MATERIALinnotifMeta.tsx/NotificationCard.tsx). A banner arriving while the user types sat directly above the glass composer in a different material. This is the maintainer's own request: "we have a new glass component, I want notifications to use it too."Why it matters
The dashboard's chrome reads as two generations side by side: a glass composer at the bottom of the chat and a frosted-card banner arriving above it, plus a bell popover whose rows are a third rendering of "translucent card". Aligning the notification panes closes that gap on a surface every user sees the moment an agent finishes something.
Not a goal
Glass.tsx,ui/liquid-glass.tsx, the--glass-*tokens) and no new variant: the card uses the existingpanelrecipe, the small pills the existingchiprecipe.MAC_ACTION_BTN_CLASS) are unchanged. Three options were photographed on the real app (card glass with flat capsules / card + capsule glass / a lighter recipe on both); the maintainer chose the first. Mock sheet at the end.panelvariant of the feed (the/notificationspage list) is a different, denser layout by design and is not touched.What changed (motivation → approach → change)
The card IS a Glass pane.
NotificationCardrenders<Glass variant="panel" radius={CARD_RADIUS}>(16 px, therounded-2xlit had) withglass-shadowfor the rest shadow, and carries no tint, blur, border or shadow class of its own — the pane's layers are the material.The card no longer knows which surface it is on. The
elevationprop (popover/banner) existed to pick one of two tints and two shadows (72 % +shadow-mdinside the sheet's scrim, 88 % +shadow-lgover page content). The glass pane reads correctly over both, so the prop, itsNotificationCardElevationtype and thedata-elevationattribute it emitted are deleted along with the tints; the two host call sites drop the argument. Nothing at runtime read the attribute.State is a tint step, never an edge — and never an opacity. The feed's selected row was
border border-accent bg-accent-subtle; it is nowglass-accent, the same step a picked follow-up chip takes. A pressable card isglass-hover. A silenced row was a 35 %-tint ghost with a dashed border; it now takes a newglass-fadedstep (index.css:--glass-tint-faded, the polarity's tint thinned to 55 %), with the content dim and muted title it already had. Recession is a tint step because anopacityon a glass host makes it a backdrop root: the pane's ownbackdrop-filterlayers then have nothing to sample and the glass turns into a flat, unblurred wash — so no glass host in this diff carries an opacity, and the banner deck's per-depth wrapper opacity (DECK_OPACITY, which wrapped the shells) is removed for the same reason. A critical note is still signalled only by its danger dot and the approval icon tint. Thematerialprop (the feed's per-row override) is removed: there is nothing left for a host to override.Everything around the card is the same pane. The banner's blank deck shells (
as="button", the one control "show me the rest", on theglass-fadedstep), its "+N more in your inbox" pill (chip, radius 12, and — as every pressable glass pane —glass-hover), the popover's controls card (header, search, muted disclosure, permission hint) and the two stack edges peeking under a collapsed group (the same glass on theglass-fadedstep instead of two hand-tinted divs) all render throughGlass.One map for N equal panes. A list of panes mounts many equal boxes in one commit (the popover's rows here, a row of follow-up chips already). The displacement map is a pure function of (size, radius, band), so
LiquidGlassnow memoises the rasterised data URL across instances in a small bounded cache (MAP_CACHE_MAX64, oldest evicted; an empty map from a canvas with no 2D context is never remembered). N equal rows cost one canvas encode, not N. The recipe itself is untouched.The first-note-from-a-channel prompt stands on its own. It used to be a strip glued to the card's bottom (
rounded-b-2xl,border-t-0, cardrounded-b-none). A pane has one radius and cannot lose a corner, so the prompt is now its ownglass-accentchip pane (radius 12) directly under the row, with the row's bottom margin cut to 4 px. Same body (bell, message, Keep, Mute), lifted into onepromptBodyhelper the mac and panel variants both render.The solidifying fallbacks still hold. Every pane keeps
notif-material: theindex.csshook under@supports not (backdrop-filter)andprefers-reduced-transparencythat solidifies notification surfaces tovar(--card)(they float over page content, so the card colour, not the page background). The rule follows the.liquid-glassrules in source order and wins, so a solidified notification pane is a card-coloured box as before.notif-materialis also one of the selectorsisSheetBackgroundPress(App.tsx) treats as material, so the sheet's background-press dismissal is unchanged —App.notificationSheetBackgroundDismiss.test.tsx's DOM walk still finds every pressable element marked.Dead constants deleted.
MAC_CARD_TINT_CLASS,MAC_CARD_BLUR_CLASS,MAC_CARD_SHADOW_CLASS,MAC_CARD_BORDER_CLASS,BANNER_CARD_TINT_CLASS,BANNER_CARD_SHADOW_CLASSandCARD_MATERIALhave no consumers left and are removed.MAC_ACTION_BTN_CLASSstays (the capsules).website/src/components/notifications/NotificationCard.tsx<Glass variant="panel" radius={CARD_RADIUS}>;elevationandmaterialprops removed;active→glass-accent, pressable →glass-hover,muted→opacity-70; exportsCARD_RADIUSwebsite/src/components/notifications/NotificationBanner.tsxglass-faded) and inbox pill areGlassbuttons;DECK_OPACITYremoved from the deck wrapper's motion target; noelevationargumentwebsite/src/components/notifications/NotificationFeed.tsxGlass; row material override and its ternary gone;promptBodyhelper; noelevationargumentwebsite/src/components/notifications/notifMeta.tsxGlasswebsite/src/components/ui/liquid-glass.tsxdisplacementMapFor, bounded cache,resetDisplacementMapCachetest seam); recipe unchangedwebsite/src/components/Glass.tsxwebsite/src/index.cssglass-fadedtint step (--glass-tint-fadedon:root,.glass-fadedswap) with the backdrop-root rationale; comment on the.notif-materialfallback rule (why it follows.liquid-glass)website/src/test/NotificationCard.shared.test.tsx,LiquidGlass.test.tsx,ChatInput.liquidGlass.test.tsxwebsite/scripts/capture-notification-banner.mjspopover-states(selected + silenced + collapsed stack) andpopover-channel-prompt(Keep / Mute pane);openSheetre-presses the bell when a sheet opened mid-boot is torn down; the route is let settle before the first pressdocs/system-specs/modules/app-notifications.mdGlasspane with no elevation, the tint-step states, the prompt pane and thenotif-materialhookBackwards compatibility
Compatible: no API, config, store or wire shape changes. Two component props (
elevation,material) on an internal component are removed; both in-repo call sites are updated in this diff and nothing outsidewebsite/src/components/notifications/used them.Tests
website/src/test/NotificationCard.shared.test.tsx(rewritten):NotificationCard(unchanged pins), and the banner card is aliquid-glasshost;Glasspane:liquid-glass+glass-shadow+notif-materialon the host,[data-liquid-glass-layer]children present, and nobg-[,backdrop-blur,borderorshadow-md|lgclass of its own — a re-introduced hand-rolled material fails here;active→glass-accentand noborder-accent/bg-accent-subtle; pressable →glass-hover;muted→glass-faded, noglass-hover, noborder-dashed; and noopacity-*class on the host in any state;data-elevationattribute and nopopover/bannertoken in its class string.website/src/test/LiquidGlass.test.tsx: three panes of one size rasterise one map (oneputImageData), a pane of another radius one more; the cache is reset per test through the exported seam so the existing rasterisation counts still hold.website/src/test/ChatInput.liquidGlass.test.tsx: the:roottint-step line now includes--glass-tint-faded, and.glass-faded { --glass-tint: var(--glass-tint-faded); }is pinned beside the other steps.Local static gates on this head:
tsc -p tsconfig.app.json,eslinton the touched files,I18N_BASE_REF=origin/main npm run i18n:check,scripts/docs-lint.sh— all green. Ten notification test files plusLiquidGlass,ChatInput.liquidGlassandFollowUpBarrun green locally (NotificationCard.shared,NotificationBanner,NotificationFeed.phase3/phase4,App.notificationSheetBackgroundDismiss,App.notificationSheetCrashFallback,App.notificationSheetExit,NotificationPermission,NotificationsPage.deepLink,notifMeta.codeScan). Full suite: CI.Manual verification
Frames below are from the shipped harness
website/scripts/capture-notification-banner.mjsagainst the built SPA on this branch. Two frames are new in this PR (popover-states,popover-channel-prompt) and assert what they show: exactly oneglass-accentrow and oneglass-fadedrow, no row carryingborder-dashed/border-accent, the stack collapsed to one head, and the prompt pane on the accent tint step. Every one of its own assertions passed on the glass panes: deck shells blank, the pill reads "Show 2 more", the mobile close is resting-visible, hover pauses auto-hide, a critical card outlives the auto-hide delay, the expanded list caps at four cards. Frames are cropped to the notification area.Screenshots / video
Banner with two actions, dark and light:
Deck expanded to a list:
Bell popover — controls card, a critical approval row (Approve / Reject), a default row, an acked row:
Every restyled row state in one popover — a SELECTED row (accent tint step, top), a collapsed STACK of three (count badge, two glass edges peeking below), a SILENCED row (
glass-fadedpane, dim content, muted title, shown via the muted disclosure), a plain unread row; dark and light:First note from an app channel: the Keep / Mute prompt as its own accent pane under the row:
Banner deck collapsed — top card plus two blank glass shells and the "Show 2 more" pill:
Banner expanded with overflow — four cards and the "+2 more in your inbox" glass pill:
Mobile (390 px), close visible at rest:
Motion (arrival, hover hold, travel into the bell; three arrivals stacking then expanding):
Design options photographed before implementing (left to right: current · A card glass · B card + capsule glass · C lighter recipe). A was chosen:
Related Issues
No linked issue: maintainer request made directly in a design session (follow-on to #14460 / #14568).
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement