Skip to content

feat(ui): notification panes wear the composer's liquid glass - #14921

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/notification-glass
Sep 29, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/notification-glass

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The in-app notification banner and the bell popover's rows wear the same Liquid Glass material as the composer dock, so every surface floating over the page is one glass.

Since #14460 / #14568 the composer band and the mobile Settings capsule are Glass panes. The notification panes — the Notification Center-style banner under the top bar and the popover's rows and controls card — were still assembled from their own color-mix tint, backdrop-blur-2xl, hairline border and shadow-md/lg classes (MAC_CARD_*, BANNER_CARD_*, CARD_MATERIAL in notifMeta.tsx / NotificationCard.tsx). A banner arriving while the user types sat directly above the glass composer in a different material. This is the maintainer's own request: "we have a new glass component, I want notifications to use it too."

Why it matters

The dashboard's chrome reads as two generations side by side: a glass composer at the bottom of the chat and a frosted-card banner arriving above it, plus a bell popover whose rows are a third rendering of "translucent card". Aligning the notification panes closes that gap on a surface every user sees the moment an agent finishes something.

Not a goal

  • No change to what a card does: open, dismiss, Approve / Reject / Review, the deck, auto-hide, the sheet's background-press dismissal all keep their behavior, test ids and accessible names.
  • No change to the material's recipe (Glass.tsx, ui/liquid-glass.tsx, the --glass-* tokens) and no new variant: the card uses the existing panel recipe, the small pills the existing chip recipe.
  • The action capsules on a card (MAC_ACTION_BTN_CLASS) are unchanged. Three options were photographed on the real app (card glass with flat capsules / card + capsule glass / a lighter recipe on both); the maintainer chose the first. Mock sheet at the end.
  • The non-mac panel variant of the feed (the /notifications page list) is a different, denser layout by design and is not touched.

What changed (motivation → approach → change)

The card IS a Glass pane. NotificationCard renders <Glass variant="panel" radius={CARD_RADIUS}> (16 px, the rounded-2xl it had) with glass-shadow for the rest shadow, and carries no tint, blur, border or shadow class of its own — the pane's layers are the material.

The card no longer knows which surface it is on. The elevation prop (popover / banner) existed to pick one of two tints and two shadows (72 % + shadow-md inside the sheet's scrim, 88 % + shadow-lg over page content). The glass pane reads correctly over both, so the prop, its NotificationCardElevation type and the data-elevation attribute it emitted are deleted along with the tints; the two host call sites drop the argument. Nothing at runtime read the attribute.

State is a tint step, never an edge — and never an opacity. The feed's selected row was border border-accent bg-accent-subtle; it is now glass-accent, the same step a picked follow-up chip takes. A pressable card is glass-hover. A silenced row was a 35 %-tint ghost with a dashed border; it now takes a new glass-faded step (index.css: --glass-tint-faded, the polarity's tint thinned to 55 %), with the content dim and muted title it already had. Recession is a tint step because an opacity on a glass host makes it a backdrop root: the pane's own backdrop-filter layers then have nothing to sample and the glass turns into a flat, unblurred wash — so no glass host in this diff carries an opacity, and the banner deck's per-depth wrapper opacity (DECK_OPACITY, which wrapped the shells) is removed for the same reason. A critical note is still signalled only by its danger dot and the approval icon tint. The material prop (the feed's per-row override) is removed: there is nothing left for a host to override.

Everything around the card is the same pane. The banner's blank deck shells (as="button", the one control "show me the rest", on the glass-faded step), its "+N more in your inbox" pill (chip, radius 12, and — as every pressable glass pane — glass-hover), the popover's controls card (header, search, muted disclosure, permission hint) and the two stack edges peeking under a collapsed group (the same glass on the glass-faded step instead of two hand-tinted divs) all render through Glass.

One map for N equal panes. A list of panes mounts many equal boxes in one commit (the popover's rows here, a row of follow-up chips already). The displacement map is a pure function of (size, radius, band), so LiquidGlass now memoises the rasterised data URL across instances in a small bounded cache (MAP_CACHE_MAX 64, oldest evicted; an empty map from a canvas with no 2D context is never remembered). N equal rows cost one canvas encode, not N. The recipe itself is untouched.

The first-note-from-a-channel prompt stands on its own. It used to be a strip glued to the card's bottom (rounded-b-2xl, border-t-0, card rounded-b-none). A pane has one radius and cannot lose a corner, so the prompt is now its own glass-accent chip pane (radius 12) directly under the row, with the row's bottom margin cut to 4 px. Same body (bell, message, Keep, Mute), lifted into one promptBody helper the mac and panel variants both render.

The solidifying fallbacks still hold. Every pane keeps notif-material: the index.css hook under @supports not (backdrop-filter) and prefers-reduced-transparency that solidifies notification surfaces to var(--card) (they float over page content, so the card colour, not the page background). The rule follows the .liquid-glass rules in source order and wins, so a solidified notification pane is a card-coloured box as before. notif-material is also one of the selectors isSheetBackgroundPress (App.tsx) treats as material, so the sheet's background-press dismissal is unchanged — App.notificationSheetBackgroundDismiss.test.tsx's DOM walk still finds every pressable element marked.

Dead constants deleted. MAC_CARD_TINT_CLASS, MAC_CARD_BLUR_CLASS, MAC_CARD_SHADOW_CLASS, MAC_CARD_BORDER_CLASS, BANNER_CARD_TINT_CLASS, BANNER_CARD_SHADOW_CLASS and CARD_MATERIAL have no consumers left and are removed. MAC_ACTION_BTN_CLASS stays (the capsules).

File Change
website/src/components/notifications/NotificationCard.tsx Host is <Glass variant="panel" radius={CARD_RADIUS}>; elevation and material props removed; active → glass-accent, pressable → glass-hover, muted → opacity-70; exports CARD_RADIUS
website/src/components/notifications/NotificationBanner.tsx Deck shell (glass-faded) and inbox pill are Glass buttons; DECK_OPACITY removed from the deck wrapper's motion target; no elevation argument
website/src/components/notifications/NotificationFeed.tsx Controls card, stack edges and channel prompt on Glass; row material override and its ternary gone; promptBody helper; no elevation argument
website/src/components/notifications/notifMeta.tsx Six material constants deleted; note pointing at Glass
website/src/components/ui/liquid-glass.tsx Displacement map memoised across instances (displacementMapFor, bounded cache, resetDisplacementMapCache test seam); recipe unchanged
website/src/components/Glass.tsx Header lists the notification panes among the material's surfaces
website/src/index.css New glass-faded tint step (--glass-tint-faded on :root, .glass-faded swap) with the backdrop-root rationale; comment on the .notif-material fallback rule (why it follows .liquid-glass)
website/src/test/NotificationCard.shared.test.tsx, LiquidGlass.test.tsx, ChatInput.liquidGlass.test.tsx See Tests
website/scripts/capture-notification-banner.mjs Two new frames: popover-states (selected + silenced + collapsed stack) and popover-channel-prompt (Keep / Mute pane); openSheet re-presses the bell when a sheet opened mid-boot is torn down; the route is let settle before the first press
docs/system-specs/modules/app-notifications.md In-app banner section describes the card as a Glass pane with no elevation, the tint-step states, the prompt pane and the notif-material hook

Backwards compatibility

Compatible: no API, config, store or wire shape changes. Two component props (elevation, material) on an internal component are removed; both in-repo call sites are updated in this diff and nothing outside website/src/components/notifications/ used them.

Tests

website/src/test/NotificationCard.shared.test.tsx (rewritten):

  • the bell popover's mac rows and the banner's top card both render through NotificationCard (unchanged pins), and the banner card is a liquid-glass host;
  • the card is a Glass pane: liquid-glass + glass-shadow + notif-material on the host, [data-liquid-glass-layer] children present, and no bg-[, backdrop-blur, border or shadow-md|lg class of its own — a re-introduced hand-rolled material fails here;
  • state is a tint step: active → glass-accent and no border-accent / bg-accent-subtle; pressable → glass-hover; muted → glass-faded, no glass-hover, no border-dashed; and no opacity-* class on the host in any state;
  • the card carries no surface marker: no data-elevation attribute and no popover / banner token in its class string.

website/src/test/LiquidGlass.test.tsx: three panes of one size rasterise one map (one putImageData), a pane of another radius one more; the cache is reset per test through the exported seam so the existing rasterisation counts still hold.

website/src/test/ChatInput.liquidGlass.test.tsx: the :root tint-step line now includes --glass-tint-faded, and .glass-faded { --glass-tint: var(--glass-tint-faded); } is pinned beside the other steps.

Local static gates on this head: tsc -p tsconfig.app.json, eslint on the touched files, I18N_BASE_REF=origin/main npm run i18n:check, scripts/docs-lint.sh — all green. Ten notification test files plus LiquidGlass, ChatInput.liquidGlass and FollowUpBar run green locally (NotificationCard.shared, NotificationBanner, NotificationFeed.phase3/phase4, App.notificationSheetBackgroundDismiss, App.notificationSheetCrashFallback, App.notificationSheetExit, NotificationPermission, NotificationsPage.deepLink, notifMeta.codeScan). Full suite: CI.

Manual verification

Frames below are from the shipped harness website/scripts/capture-notification-banner.mjs against the built SPA on this branch. Two frames are new in this PR (popover-states, popover-channel-prompt) and assert what they show: exactly one glass-accent row and one glass-faded row, no row carrying border-dashed / border-accent, the stack collapsed to one head, and the prompt pane on the accent tint step. Every one of its own assertions passed on the glass panes: deck shells blank, the pill reads "Show 2 more", the mobile close is resting-visible, hover pauses auto-hide, a critical card outlives the auto-hide delay, the expanded list caps at four cards. Frames are cropped to the notification area.

Screenshots / video

Banner with two actions, dark and light:

Banner card with two actions, dark
Banner card with two actions, light

Deck expanded to a list:

Three banner cards expanded, dark

Bell popover — controls card, a critical approval row (Approve / Reject), a default row, an acked row:

Bell popover, dark
Bell popover, light

Every restyled row state in one popover — a SELECTED row (accent tint step, top), a collapsed STACK of three (count badge, two glass edges peeking below), a SILENCED row (glass-faded pane, dim content, muted title, shown via the muted disclosure), a plain unread row; dark and light:

Bell popover with a selected row, a collapsed stack and a silenced row, dark
Bell popover with a selected row, a collapsed stack and a silenced row, light

First note from an app channel: the Keep / Mute prompt as its own accent pane under the row:

Bell popover with the channel prompt pane, dark

Banner deck collapsed — top card plus two blank glass shells and the "Show 2 more" pill:

Collapsed banner deck, dark

Banner expanded with overflow — four cards and the "+2 more in your inbox" glass pill:

Expanded banner with the inbox overflow pill, dark

Mobile (390 px), close visible at rest:

Banner on a phone, dark

Motion (arrival, hover hold, travel into the bell; three arrivals stacking then expanding):

Auto-hide flow
Deck expanding

Design options photographed before implementing (left to right: current · A card glass · B card + capsule glass · C lighter recipe). A was chosen:

Mock options, banner
Mock options, popover

Related Issues

No linked issue: maintainer request made directly in a design session (follow-on to #14460 / #14568).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@CrysisDeu
CrysisDeu requested a review from a team September 29, 2026 03:53
@CrysisDeu
CrysisDeu requested a review from a team as a code owner September 29, 2026 03:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 738bdc35e6c78d802d8df61a0e6d16d664ec0037 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify in the light-theme recording that a banner over bright, busy page content stays legible — the deleted 88% banner tint existed for exactly that case.

[DESIGN-REVIEWED] 738bdc3

Description read

[DESCRIPTION-READ] 3902ac79b4901da3931000e4b7fb616743720fd7962f62d0d2f6604fb58c940f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 738bdc35e6c78d802d8df61a0e6d16d664ec0037 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 738bdc3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 738bdc35e6c78d802d8df61a0e6d16d664ec0037: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 738bdc35e6c78d802d8df61a0e6d16d664ec0037 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Verify the banner's legibility over busy light-theme page content: the deleted 88 % tint's own comment said the banner "needs a denser tint" there.

What this change ships

Inventory (10 items) — 10 justified

Intent: make the notification banner and bell-popover rows wear the same Liquid Glass material as the composer, at the maintainer's request — an ADDITION (restyle).

  1. Notification card is the composer's glass pane on both surfaces — justified
  2. The card no longer knows popover vs banner: elevation prop, per-surface tints and data-elevation deleted — justified
  3. Selected feed row: accent border → accent tint step — justified
  4. Silenced row: dashed-border ghost → new glass-faded tint step — justified
  5. Banner deck shells lose per-depth opacity; recession is the faded tint (opacity would void the blur) — justified
  6. Deck shells, "+N more" pill, controls card and stack edges render through Glass — justified
  7. First-note channel prompt becomes its own detached glass chip under the row — justified
  8. Displacement map memoised across equal panes (bounded cache, test reset seam) — justified
  9. Capture script: two new frames plus a sheet-open retry / route-settle wait — justified
  10. Spec and fallback-rule comments updated in the same commit — justified

The elevation test deleted in NotificationCard.shared.test.tsx pinned the two-material decision; the description names the deletion and its physical ground (one pane reads over both, photographed options, maintainer's pick), so framing matches the diff. glass-faded has 4 counted consumers (card muted, deck shell, two stack edges); CARD_RADIUS has 4.

[FIRST-PRINCIPLES-REVIEWED] 738bdc3

Description read

[DESCRIPTION-READ] 91c73935c8574b89871bbbe5888d67ae8bc3ee0fc1e4894f8afebd665113f060

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — 🟡 CONCERNS

UX-level review of 738bdc35e6c78d802d8df61a0e6d16d664ec0037 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

One purple glass step means two things — the blind reader had "no idea" why the selected row was purple, since the Keep/Mute prompt wears the same accent tint.

Watch

  • Selected-state legibility: replacing border border-accent bg-accent-subtle with glass-accent (NotificationFeed.tsx) leaves selection sharing its exact tint with the channel prompt pane (shot-08); the reader on the selected row (shot-06): "maybe it's highlighted, maybe it's brand new, maybe it's selected → no idea." Every popover open with a selection; friction, every time. Smallest fix: a second cue on the selected row (e.g. its side-line step) or a non-accent step for the prompt.
  • Deck shells lost their recession cue: with DECK_OPACITY removed, a blank full-opacity glass-faded shell reads as a broken card — the reader on shot-09: "blank/faded, like a message that is appearing or disappearing… nothing readable to click," though it is the "show me the rest" control. The "Show 2 more" pill carries the action, so friction only; consider a deeper faded step or stronger scale/offset so shells read as depth.
  • Both supplied GIF recordings opened as blank white for the blind reader; have a human confirm they actually play before trusting them as the deck-motion evidence.

[UX-REVIEWED] 738bdc3

Description read

[DESCRIPTION-READ] df59e560de3d42f252ed1533ef7b91e89bb4695597e57d0e7adf363584c3d3fb

That sha256 names everything this verdict read: the PR description, plus the 18 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 7c29b95de28b53f6005048a21956df78a663f922 — this comment is updated in place on each push.

Review details

Recession and muting are expressed as opacity on the new Glass hosts, which makes each host a backdrop root and silently voids the pane's own backdrop-filter — the material the PR is adding.

FINDING — website/src/components/notifications/NotificationCard.tsx:122 — ${muted ? 'opacity-70' : ''} on the pane host composites with the untouched const dim = muted ? 'opacity-50' (line 95) on the inner content wrapper, so a silenced feed row's title and body paint at 0.70 × 0.50 = 0.35 effective opacity over text-muted, where the base branch gave 0.5 → Fix: drop the muted branch from dim so the pane's fade is the only muting lever.

FINDING — website/src/components/notifications/NotificationFeed.tsx:494 — opacity-80 / opacity-55 (and opacity-50 / opacity-35) on the deck-shell Glass hosts makes each host a backdrop root, so the descendant [data-liquid-glass-layer] backdrop-filter spans have nothing to sample and the shells collapse to --glass-tint × their own opacity (≈0.3α, no blur) where the deleted bg-[color-mix(in_srgb,var(--card)_58%,transparent)] backdrop-blur-xl was opaque enough to stop page content printing through; the same mechanism voids the blur on NotificationCard.tsx:122's opacity-70 row and on the banner shells nested inside DECK_OPACITY's motion.div → Fix: set a lower-alpha --glass-tint inline on those panes instead of opacity (App.tsx:1569 already records that a backdrop root breaks the cards' blur).

FINDING — website/src/components/notifications/NotificationFeed.tsx:397 — the mac feed renders one Glass/LiquidGlass pane per row with no virtualization against a NOTIFICATIONS_RING_CAP = 200 store, so opening the bell popover runs N buildDisplacementMap + canvas.toDataURL() PNG encodes in a single commit and leaves 2N stacked backdrop-filter layers to composite on every scroll frame → Fix: glass only the visible window (or one glass surface behind plain rows) and cache maps across equal-size panes. (origin: validation)

[OPUS-REVIEWED] 7c29b95

Verdict parsed from the review's SHA-scoped output markers for commit 7c29b95de28b53f6005048a21956df78a663f922.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 7c29b95de28b53f6005048a21956df78a663f922: <one-sentence reason>

The in-app notification banner and the bell popover's rows were the
last floating surfaces still built from their own tint, blur, border
and shadow classes (MAC_CARD_* / BANNER_CARD_* / CARD_MATERIAL in
notifMeta) while the composer dock and the mobile Settings capsule had
moved onto the Glass primitive. Two generations of material sat one
above the other on the same screen.

NotificationCard is now a <Glass variant="panel" radius={16}> pane, so
the banner card, every popover row, the banner's blank deck shells, its
"+N more in your inbox" pill, the feed's controls card and its stack
edges are one material. The card no longer knows which surface it is
on: the pane reads correctly over the sheet's scrim and over page
content alike, so the elevation prop (popover / banner) and its
data-elevation attribute, whose only remaining job was picking one of
two tints, are deleted with the tints. State is a tint step on the
host, never an edge and never an opacity: glass-accent for the selected
row (was a border-accent + accent-subtle fill), glass-hover on a
pressable card, and a new glass-faded step (the tint thinned to 55%)
for a silenced row (was a dashed border), a collapsed stack's edges and
the banner's deck shells. Opacity on a glass host would make it a
backdrop root and void its own blur, so the banner deck's per-depth
wrapper opacity goes too; the shells carry the faded step instead. The
first-note-from-a-channel prompt becomes its own accent-tinted chip
pane under the row, since a pane has one radius and cannot be glued to
the card's bottom edge. Action capsules are unchanged.

A list of panes mounts many equal boxes in one commit, so the
displacement map — a pure function of size, radius and band — is now
memoised across LiquidGlass instances in a small bounded cache: N equal
popover rows cost one canvas encode, not N.

Every pane still carries notif-material: the index.css hook that
solidifies these surfaces to the card colour where backdrop-filter is
unsupported, and the selector the sheet's background-press verdict keys
on. The material constants are deleted; the shared-card test pins that
the card is a Glass pane with no material classes, no opacity and no
surface marker of its own, and that state is a tint step. The banner
capture harness gains popover-states (selected + silenced + collapsed
stack) and popover-channel-prompt frames.
@CrysisDeu
CrysisDeu force-pushed the feat/notification-glass branch from 7c29b95 to 738bdc3 Compare September 29, 2026 04:38
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • Item 3 — elevation prop with zero runtime consumers span=7c77d2d8d78d — FIXED on 738bdc3

The prop, the NotificationCardElevation type and the data-elevation attribute are deleted from NotificationCard.tsx; both host call sites (NotificationBanner.tsx, NotificationFeed.tsx) drop the argument.
The card no longer knows which surface it is on: the glass pane reads correctly over the sheet's scrim and over page content alike, so there is nothing left for an elevation to pick.
NotificationCard.shared.test.tsx now pins the inverse: no data-elevation attribute and no popover / banner token on the card. The spec's In-app banner section says the same.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

self-added: yes

  • Item 5 — inbox-overflow pill gains glass-hover, undeclared span=56ebd9553d49 — ACCEPTED, now declared

Kept: every pressable glass pane in the dock wears glass-hover (a follow-up chip, the jump-to-bottom button), and the pill is a pressable glass pane, so leaving it out would be the inconsistency.
The description now names it in "Everything around the card is the same pane" ("and — as every pressable glass pane — glass-hover") rather than letting it ride along.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
@CrysisDeu
CrysisDeu merged commit e076ee0 into main Sep 29, 2026
99 of 107 checks passed
@CrysisDeu
CrysisDeu deleted the feat/notification-glass branch September 29, 2026 05:32
CrysisDeu added a commit that referenced this pull request Sep 30, 2026
The strip behind the bell sheet's rows was 12% black with a 4px blur
(#3029, added for text contrast when the rows were flat cards). Since
the rows became liquid glass (#14921) each carries its own tint and
glass-shadow, so the scrim stacked under them and read as a heavy
shadow down the sheet's left edge: on a white page it darkened the
strip from 248 to 217, on the dark theme from 28 to 24.

Set it to 2% black with a 2px blur. The strip still separates the
column from the page (248 -> 243 light, 28 -> 27 dark) without reading
as a shadow; the rows carry the contrast now.

Adds capture-notification-scrim.mjs: opens the seeded sheet on the
built SPA in both themes and photographs the viewport, with an optional
SCRIM_CSS override so the previous strength can be shot from the same
build for a before/after pair.
CrysisDeu added a commit that referenced this pull request Sep 30, 2026
The strip behind the bell sheet's rows was 12% black with a 4px blur
(#3029, added for text contrast when the rows were flat cards). Since
the rows became liquid glass (#14921) each carries its own tint and
glass-shadow, so the scrim stacked under them and read as a heavy
shadow down the sheet's left edge: on a white page it darkened the
strip from 248 to 217, on the dark theme from 28 to 24.

Set it to 2% black with a 2px blur. The strip still separates the
column from the page (248 -> 243 light, 28 -> 27 dark) without reading
as a shadow; the rows carry the contrast now.

Adds capture-notification-scrim.mjs: opens the seeded sheet on the
built SPA in both themes and photographs the viewport, with an optional
SCRIM_CSS override so the previous strength can be shot from the same
build for a before/after pair.
CrysisDeu added a commit that referenced this pull request Oct 1, 2026
…15391)

The strip behind the bell sheet's rows was 12% black with a 4px blur
(#3029, added for text contrast when the rows were flat cards). Since
the rows became liquid glass (#14921) each carries its own tint and
glass-shadow, so the scrim stacked under them and read as a heavy
shadow down the sheet's left edge: on a white page it darkened the
strip from 248 to 217, on the dark theme from 28 to 24.

Set it to 2% black with a 2px blur. The strip still separates the
column from the page (248 -> 243 light, 28 -> 27 dark) without reading
as a shadow; the rows carry the contrast now.

Adds capture-notification-scrim.mjs: opens the seeded sheet on the
built SPA in both themes and photographs the viewport, with an optional
SCRIM_CSS override so the previous strength can be shot from the same
build for a before/after pair.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: checking Automated validation is still running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants