Repository navigation
feat: show crew display names in select_crew and route_crew - #14926
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify a [DESIGN-REVIEWED] f4a1c35 Description read[DESCRIPTION-READ] eb02bf5d16ad1a2c2240a6e43cb55e4efa127e1fee617339127552a0ab5c91a3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing to check. What this change shipsInventory (6 items) — 6 justifiedIntent: let the routing agent map the label a user says to the immutable key
Evidence: [FIRST-PRINCIPLES-REVIEWED] f4a1c35 Description read[DESCRIPTION-READ] 0fbd3f20cfb73f2839308f1f149e606d783e721788647ef792df7b92990be480 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
9817e8a to
d0b1cf1
Compare
|
d0b1cf1 to
75c2e8b
Compare
|
75c2e8b to
530e4c4
Compare
|
The user names a crew by the label the dashboard shows, but spawn_run(crew=...) takes the config key. Both routing tools returned only the key, so a crew whose label no longer resembles its id (a renamed crew, or a non-Latin label keyed by a derived id) could not be matched to the user's words. Each roster entry and route_crew match now carries display_name when it differs from the key, and the roster guidance says to dispatch by name.
530e4c4 to
f4a1c35
Compare
|
|
|
|
Problem / Motivation
Goal: An agent routing work can map the crew name a user says to the key it must pass to
spawn_run(crew=...), even when that label no longer looks like the key.select_crewandroute_crewreturn only the config key. A user says "hand it to Release Notes", but that crew's key is stilllaunch-notesfrom before a rename, or a Chinese label sits on a derived key. The agent sees nothing that connects the two, so it guesses from triggers and can dispatch to the wrong crew.Why it matters
Crew keys are immutable ids while
display_nameis free to change (#13561, and #14865 keys new crews by id). Every rename widens the gap between what the user says and what the agent sees, and a wrong dispatch runs the task with another crew's memory and template.Not a goal
crew=on the tool side. The agent still dispatches by key.What changed (motivation → approach → change)
The routing tools now show the label next to the key. Each
select_crewroster entry and eachroute_crewmatch orunavailableentry carriesdisplay_namewhen the crew has one that differs from its key, the unknown-crew error lists each key with its label, and the roster guidance tells the agent to dispatch byname. A crew with no label, or a label equal to its key, looks exactly as before.docs/system-specs/modules/crew-mode.mdrecords the field.Backwards compatibility
Compatible: one optional field is added to two JSON outputs; no existing field changes or disappears.
Tests
test/test_select_crew.py: a renamed crew's roster entry, toproute_crewmatch andunavailableentry carrydisplay_name; a label equal to its key is not repeated; the guidance namesdisplay_name. The unknown-crewavailablelist showslaunch-notes (Release Notes). All four new tests fail when the field is not written.Manual verification
N/A — unit coverage sufficient; the change is two JSON shapes that the tests read back.
Related Issues
no linked issue: companion to #14865, which keys new crews by id and keeps the typed name as
display_name.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)