Repository navigation
fix(ui): end the list search dock at the glass pane, not 4px below it - #14995
Conversation
The dock shipped in #14896 ended 4px under the pane: the search row kept its pb-1, and a bare field's shelf still painted a 4px scrim fade. A row scrolling under the dock therefore emerged through a strip of a third tone between the blurred glass and the sharp list, and that strip read as a leftover box behind the pane. The pane's bottom edge is now the dock's edge. The search row drops its bottom padding, the shelf hides when empty (the roster's star-error wrapper mounts only while there is an error, so it does not hold the shelf open), and the 4px rest gap between dock and first row moves into the measured variable: ListDock publishes --list-dock-h as its height plus the gap and --list-dock-pin-inset as the gap, so the lane pads and scroll-pads to dock + 4 while a pinned folder header still sits exactly on the dock's bottom edge. The keyboard-reveal band subtracts the inset too, so it ends where the header stack ends instead of 4px past it.
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS The reversed "Never hidden" shelf pin rests on the maintainer's #14896 report — confirm that comment exists before merge; it is the sole evidence. What this change shipsInventory (7 items) — 7 justifiedIntent: rows scrolling under the glass search field should emerge at the pane's edge, not through a 4px pale band below it — a FIX (follow-up to #14896).
[FIRST-PRINCIPLES-REVIEWED] f33b496 Description read[DESCRIPTION-READ] 9ebf2b5ed70c8bd32c3b754f301ec1b343ec61612c0cd4860ac9374e6d564fc9 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the bare-field dock stays pinned closed: a future always-mounted shelf child silently re-opens the 4px scrim, and no current gate catches it. Suggestions
[DESIGN-REVIEWED] f33b496 Description read[DESCRIPTION-READ] dde9e3208002def9e5daca1f48fcc3e4a91956cdfea5ef7f234301b28e93e254 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify arrow-key navigation on a grouped list once: the reveal-band inset change ( [UX-REVIEWED] f33b496 Description read[DESCRIPTION-READ] 9190ecdeb104b3c7995f8460e8a66295811032114845c552ef28edbb47a82288 That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
iamwhatever
left a comment
There was a problem hiding this comment.
Reviewed. ListDock sets --list-dock-h to height+4 and --list-dock-pin-inset to 4px; the pinned header lands at the dock's bottom edge; the shelf gets empty:hidden and SearchFilterBar drops pb-1. Only ChatSidebar and MembersPage mount ListDock and both shelves are conditional, so :empty holds at rest. sessionRowNav reads the inherited property and falls back to 0 with no dock, so no-dock behaviour is unchanged. No security touch.
Non-blocking test gap: the inset subtraction in clearPinnedHeaders (sessionRowNav.ts:103) has no unit test, and nothing in CI exercises empty:hidden; a small arrowNav test with --list-dock-pin-inset set on the scroller would pin it.
Problem / Motivation
Goal: A row scrolling under the list panels' glass search field emerges at the glass, not through a strip of a third tone below it.
After #14896 the dock ended 4px under the pane: the search row kept its
pb-1, and with nothing on the shelf the shelf still painted a 4px scrim fade. Scrolled under, a row passed through that band — half-clipped text on a pale strip, then a hard step into the row's own colour — and the maintainer read it as a leftover box behind the pane.Why it matters
The seam sits on the two surfaces every user scrolls first, and it undoes the point of the material: the glass should be the only thing between the list and the chrome.
Not a goal
What changed (motivation → approach → change)
The pane's bottom edge is the dock's edge.
SearchFilterBar's wrapper drops itspb-1(both mounts sit in a dock, whose business the gap now is); the shelf isempty:hidden, so a bare field's dock ends at the glass (measured: dock 40px = pane bottom on both lists, was 44px). The roster's star-error wrapper mounts only while there is an error, so an empty wrapper no longer holds the shelf — and its 4px scrim — open.The rest gap moves into the measured variable.
ListDockpublishes--list-dock-has its height plus 4px and--list-dock-pin-insetas 4px, soLIST_BODY_CLSstill pads and scroll-pads the lane to dock + 4 (first row clear at rest, deep-linked rows land clear) while a pinned folder header, offset by the inset, sits exactly on the dock's bottom edge (measured 40.14 = 40.14).clearPinnedHeaderssubtracts the inset too, so the keyboard-reveal band ends where the header stack ends instead of 4px past it (the overshoot Opus noted on #14896).Backwards compatibility
Compatible: same components, ids and names;
SearchFilterBar's default wrapper loses 4px of bottom padding and its only two mounts are the docks this fixes.Tests
src/test/ListDock.test.tsx:--list-dock-his the measured height plus the gap (48px for a 44px dock, 88 after growth) and--list-dock-pin-insetis 4px.playwright/sidebar-sticky-folder-header.spec.ts(unchanged) still measures pinned headers against the dock's bottom edge, which is where they sit.src/test/ChatSidebar.arrowNav.test.tsx(unchanged) covers the band with no dock var; the inset subtraction is exercised by the sticky spec's arrow-key claim in the browser gate.Manual verification
website/scripts/capture-glass-search-dock.mjsnow asserts each scroller's padding equals dock height + 4 and the pinned header's top equals the dock's bottom, on both lists, dark and light, in all seven scenes.Screenshots / video
Sessions sidebar, dark — rows scrolled under; the row now emerges at the pane's edge (compare #14896's frame, where a pale 4px band sat between):
Rest, roster, light
Related Issues
Follow-up to #14896.
Pattern harvest
Not generalizable: a padding left on a row that became the edge of a floating surface; the dock now owns its own edge.
Checklist