Repository navigation
fix(crewmates): accept any crewmate name in meet crewmates - #15085
Conversation
5f0090e to
dfa90d4
Compare
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify the pinned [DESIGN-REVIEWED] 07f78b2 Description read[DESCRIPTION-READ] 6b8e29b8103db0a5e2a611f6a9ec4d152786d4e7cba5ac2ad4a91dbf4cb6d81d That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify one rider effect: every flow-created crewmate now persists a pinned ghost face, so a later rename keeps the face drawn from the originally typed name. The core claims check out in the repo: What this change shipsInventory (9 items) — 9 justifiedIntent: Let the Meet CrewMates onboarding accept any crewmate name the server accepts. FIX.
[FIRST-PRINCIPLES-REVIEWED] 07f78b2 Description read[DESCRIPTION-READ] 6793ecc6a8a8ebad096a65b1234f2ad0edc16b0c27f8a0c4690b136cb8e76767 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Fable 5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS Server name refusals give no reason: both 400 codes collapse into "This name can't be used," leaving the user guessing which names work. Watch
Suggestions
[UX-REVIEWED] 07f78b2 Description read[DESCRIPTION-READ] 8fb915b68e4ec11863bc0cc0bbbb0f601658be717c660102e2d3fff1cba3b238 That sha256 names everything this verdict read: the PR description, plus the 9 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsNothing blocks: the candidate defects were all either unreachable on the current backend or cosmetic; one spec-accuracy gap remains advisory. FINDING — docs/system-specs/modules/config.md:3002 — the owning spec's Meet CrewMates section, edited by this PR for the free-form name, still says [OPUS-REVIEWED] 07f78b2 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
dfa90d4 to
1ec78fe
Compare
76b6df0 to
0367092
Compare
|
Opus 5 BLOCKING (MeetCrewmatesFlow.tsx:390, open chat navigates by typed label): fixed in 0367092. The create response's |
|
Opus 5 FINDING (hi.json |
|
Opus 5 FINDING (rfc-crewmates-launch.md:280 still records the name grammar): fixed in 0367092. Added a dated 2026-09-29 amendment under screen 08: the name is free-form and |
|
UX BLOCK (missing screenshot of the refusal state): fixed. The description now carries step 2 after a forced |
0367092 to
d8c7ca5
Compare
|
UX BLOCK (missing step-4 ready screenshot): fixed. The description now carries "Issue Radar" end to end against an isolated gateway built from this branch at 390x664: step 2, the ready step, and Open chat landing on |
|
UX Watch (step-2 face differs from the permanent one for free-form names): fixed in d8c7ca5, by pinning rather than mirroring the slug. Create now sends |
|
UX Watch (one message for both refusal codes): deferred. Both codes are rare server refusals of names the flow otherwise accepts, and a per-code string means a new key in all 13 locales. Out of this PR's goal (letting free-form names through); happy to follow up if a maintainer wants it. |
|
UX Watch (the chat header shows both "Issue Radar" and "issue-radar"): deferred to the maintainer. The header is outside this diff, and it already renders that way for any crew with a display name, whichever surface created it. The refusal-copy item is the same one answered above (deferred: per-code copy is out of this PR's goal). |
POST /api/agents keeps a free-form name as the crew's label and derives an id-shaped key from it, so the flow's copy of the old agent-name regex blocked names the server accepts, such as "Issue Radar" or a CJK name. Next is now disabled only on a blank name, and the server's invalid_member_name and credential_shaped_name refusals land under the name field with a generic "can't be used" message.
d8c7ca5 to
07f78b2
Compare
|
UX Suggestion (align "Pick another name" in |
Problem / Motivation
Goal: Meet CrewMates accepts any crewmate name the server accepts, such as "Issue Radar" or a CJK name.
Typing a name with a space, a CJK character, or a leading hyphen on step 2 greys out the avatar, shows "Use letters, numbers, - and _ only; start and end with a letter or number." and disables Next. That rule is stale: since #14865,
POST /api/agentskeeps a free-form name as the crew's label and derives an id-shaped key from it (members.key_new_crew), andinvalid_agent_nameno longer exists anywhere in the backend.Why it matters
The onboarding flow for a new user refuses the most natural names ("Issue Radar", "小明") that every other create surface accepts, so the first crewmate a user makes is forced into a slug.
Not a goal
validate_member_name) or how a crew id is derived.What changed (motivation → approach → change)
MeetCrewmatesFlow.tsxstill carried a copy of the old_AGENT_NAME_REfrom before crews were keyed by an id.isValidCrewmateNamenow only refuses a blank name; the typing-time hint, the greyed avatar andaria-invalidfor it are gone.invalid_member_nameorcredential_shaped_namereturns the user to step 2 with "This name can't be used. Pick a different one." under the field (new keyerror_name_unusablein all 13 locales, replacingerror_name_shape). The 409agent_existshandling is unchanged.Issue Radar->issue-radar) and returns it asname. The flow now holds that key and uses it for the ready step's avatar and for Open chat's/members?member=link; the typed text stays the label everywhere it is read.avatar: {kind: 'ghost', traits: seededTraits(<typed name>)}). The roster draws an unpinned crew from its config key, so without the pin a free-form crewmate would wear a different face from the one shown while naming it. The ready step renders the same pinned face.test/test_meet_crewmates_builtin_pin.pyonly kept the removed regex copy in step with the backend, so it is deleted. The config spec paragraph is updated, andrfc-crewmates-launch.mdscreen 08 gets a dated amendment recording that the name is free-form andvalidate_member_nameis the gate.Backwards compatibility
Compatible: the flow now accepts a superset of the names it accepted, and every one of them is accepted by the server today.
Tests
MeetCrewmatesFlow.test.tsx: "Issue Radar", "雷达" and "-radar" enable Next, show no hint, and are posted as typed; a blank name disables Next; both server name-refusal codes land under the name field on step 2;isValidCrewmateNameonly refuses blank; Open chat navigates to the server-derived key (/members?member=issue-radar), not the typed label (fails with the label). The new free-form and refusal-code tests fail against origin/main's flow (6 failures).tsc, eslint and docs-lint are clean.Manual verification
Against an isolated test-mode gateway built from this branch at 390x844: typed "Issue Radar", went through to Create.
POST /api/agentsanswered 200 with idissue-radar, the schedule was created bound to that member id, and step 4 read "Issue Radar is ready".Screenshots / video
Step 2 with "Issue Radar", before (origin/main) and after, 390px wide:
Step 2 after the server refuses a name (
credential_shaped_nameforced onPOST /api/agents), 390x664:"Issue Radar" end to end against an isolated gateway built from this branch, 390x664: step 2, the ready step, and Open chat landing on the crewmate (
/members?member=issue-radar). The face is the same in all three.Related Issues
Follows #14865.
Pattern harvest
Not generalizable: a single client-side copy of a server rule that the server later relaxed; the pin test that guarded it compared against the old regex, not the create route.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
N/A — placeholder pending OSPO.