Skip to content

fix(acp): backport skill-view visibility and bounds to release/0.8.0 - #15151

Closed
bolichen97 wants to merge 2 commits into
kirodotdev:release/0.8.0from
bolichen97:backport/skill-view-release-0.8.0
Closed

bolichen97 wants to merge 2 commits into
kirodotdev:release/0.8.0from
bolichen97:backport/skill-view-release-0.8.0

Conversation

@bolichen97

@bolichen97 bolichen97 commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Ship the 0.8.0.2 skill-view incident fix (#15121, #15119) on the 0.8 line, so a 0.8.0.x hot patch can turn native skill projection back on for hosts where another program rewrites ~/.kiro/agents.

This is a backport of #15150 and the two PRs it stacks on (#15132, #15125) to release/0.8.0. All three commits cherry-pick cleanly, and skill_projection.py is byte-identical between release/0.8.0 and main. The root cause, the design and the evidence are in #15150.

Why it matters

0.8.0.2 is on the stable channel. Every affected user either loses every turn (Agent spec 'kirocrew-skill-view-...' is not installed) or runs with KIROCREW_NATIVE_SKILL_PROJECTION=0, which turns bounded skill discovery off.

Not a goal

What changed (motivation → approach → change)

Two commits, following the release-branch backport shape of #11339 and #11645 (one combined PR, source SHAs as cherry picked from trailers):

Commit Source on main What it brings
fix(acp): backport skill-view alias naming and set_mode fallback #15132 (d6d0309, 6313e50) + #15125 (5608475), squashed aliases named without MCP env values and with the source path (skill_projection.py); set_mode keeps the spawn alias, retries a miss for 3 s, then runs the authored agent (acp/runtime.py, acp/session_handle.py), with the kirocrew.acp.skill_view.fallback counter (metrics/events.py, metrics.md)
fix(acp): make skill-view publication visible and bounded #15150's own commit (7f60c56) same-bytes in-place announcement after each publication, parsed currency, view-digest ownership, sidecar and .lock sweeps (skill_projection.py), the kirocrew doctor residue line (doctor_checks/resources.py, agent_sdk/drivers/acp.py), and the relaunch harness

Every cherry-pick applied without conflict resolution. The spec text in acp-client.md comes along with them. The design and evidence are in #15125 and #15150.

Backwards compatibility

Compatible, for the same reasons as #15125 and #15150: alias names for an unchanged view and the existing sidecar keys are unchanged, translate defaults to the current send, and the only behaviour changes are on paths that failed or leaked before.

Tests

The same tests as the source PRs, run against this branch's tree. The relaunch harness (test/test_skill_view_relaunch_harness.py, 50 spawns × 4 agents under a rewriting launcher), the fallback suite (test/test_acp_set_mode_projection_fallback.py), test/test_native_skill_projection.py, test/test_cli_doctor.py, test/test_worker_agent.py, test/test_acp_runtime.py and test/test_acp_client.py all pass (1,737 tests).

Manual verification

As in #15150, measured on kiro-cli 2.26.0 and 2.25.0 in a throwaway HOME. The 0.8.0.2 host behaviour this targets is the one reproduced there.

Related Issues

Backport of #15132, #15125 and #15150. Refs #15121, #15119.

Pattern harvest

Not generalizable: a backport. The patterns are recorded in #15125 and #15150.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (acp-client.md, metrics.md, carried by the cherry-picks)
  • No secrets, credentials, or internal references in the diff

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Sep 29, 2026
@bolichen97
bolichen97 force-pushed the backport/skill-view-release-0.8.0 branch from 30488f4 to f1afbfd Compare September 29, 2026 23:40
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Sep 29, 2026
bolichen97 and others added 2 commits September 30, 2026 00:07
Backport of kirodotdev#15132 (name skill-view aliases without MCP env values,
keep the source path in the name) and kirodotdev#15125 (set_mode keeps the spawn
alias, retries a miss and falls back to the authored agent) to
release/0.8.0, squashed to keep the backport within two commits.

(cherry picked from commit d6d0309)
(cherry picked from commit 6313e50)
(cherry picked from commit 5608475)

Co-authored-by: buluoray <38930179+buluoray@users.noreply.github.com>
kiro-cli reloads ~/.kiro/agents only on a create, data write or remove
of a *.json, never on the rename atomic_write publishes with. A new
alias stays "Mode ... not found" until set_mode falls back to the
authored agent, and an alias republished over a known name keeps its
old content. A launcher that rewrites every spec on each launch also
forced a rewrite of every alias per preparation and stranded ownership
sidecars.

- every publication ends in a same-bytes in-place rewrite, which the
  watcher reloads on and a racing reader never sees torn
- currency compares parsed specs, so re-serialization is no rewrite
- sidecars also bind the view identity; a moved-bytes pair is removed
  together, and orphaned sidecars and <alias>.lock residue are swept
  in bounded batches at boot and per spawn
- a kirocrew doctor "skill-view residue" line

Adds an inotify-driven harness that replays the incident over 50
spawns under a rewriting launcher.

Fixes kirodotdev#15119
Refs kirodotdev#15121

(cherry picked from commit 7f60c56)
@bolichen97

Copy link
Copy Markdown
Contributor Author

Posted on behalf of @bolichen97. Superseded by #15295, opened from a branch on kirodotdev/KiroCrew: release-branch PRs opened from a fork never start the review lanes. It carries the same backport, restacked on #15125 86fa402d37 and #15150 0dc36a1243. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant