Skip to content

feat(ui): top bar search, readout and feedback pills wear the glass - #15523

Merged
CrysisDeu merged 1 commit into
mainfrom
feat/topbar-glass-controls
Oct 1, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
feat/topbar-glass-controls

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the three pills in the top bar -- the search / command-palette trigger, the readout capsule and the Request a Feature pill -- wear the same Liquid Glass as the rest of the shell.

They were bordered or bg-card boxes next to a composer dock, a sidebar search field and a crewmate DM header that are all Liquid Glass panes, so the top row read as a different, older material from everything under it. The maintainer picked this shape (option A, "swap the material of the controls only") from three mocks.

Why it matters

The top bar is on every page; while its controls stay flat boxes the glass elsewhere reads as unfinished rather than as one system. It is also the one place where the kiro-light theme needed a special inset ring to keep a bg-card pill visible on the white chrome -- a glass pane carries its own edge and retires that exception.

Not a goal

  • Changing the top bar strip itself (.topbar-glass): option B, a transparent bar with free-floating capsules, was not chosen.
  • Touching the bell or focus-mode buttons: they stay borderless icon buttons.
  • The mobile nav-rail search tile: it is a rail item, not a top-bar control.
  • Any change to the glass recipe (components/Glass.tsx, ui/liquid-glass.tsx) beyond one new tint step.

What changed (motivation → approach → change)

Goal → approach: reuse the existing primitive as the control itself, the way the follow-up chips and the jump-to-bottom button already do, rather than wrapping each control in a glass box (a wrapper would break the capsule's structural collapse rungs and the trigger's flex-1 sizing).

Change:

  • App.tsx: the search trigger is <Glass as="button" variant="chip" radius={12}> with glass-hover; the readout capsule is a Glass pane hosting its segments directly (the motion layout wrapper moves outside it as a plain flex div, so the width tween is unchanged); offline is glass-danger instead of a bg-danger-subtle fill. 12px is the rounded-xl the update pill already wears.
  • components/FeedbackPill.tsx: the pill is a Glass pane; its two buttons sit transparent on it. The feedback-pill class had one consumer (the kiro-light ring below) and is dropped.
  • index.css: the two terminal rungs were .tb-capsule > *:not(:first-child); a Glass host's first children are its effect layers, so that would have kept a layer and hidden the connection dot. Both rungs now hide every non-layer child that has a non-layer sibling before it -- still structural, since registered extension segments cannot be enumerated. New glass-danger tint step beside glass-accent / glass-warn, mirrored in all three solidifying blocks. The kiro-light inset ring on .tb-capsule / .feedback-pill is removed.
  • components/Glass.tsx header and website/docs/theming-contract.md: the surface list and the "card must carry its own edge" paragraph now name the three pills and shrink the kiro-light hook list to the user bubble.
  • scripts/capture-topbar-glass.mjs: the evidence harness (below).

Backwards compatibility

Compatible: no API, config or storage shape changes. .tb-capsule keeps its class and the rung container queries fire at the same widths; downstream top-bar extension segments (getCapsuleSegments) render exactly as before, as children of the capsule.

Tests

  • src/test/App.test.tsx: the terminal-rung assertions now pin the layer-skipping selector, so a future :first-child regression that would hide the dot behind a glass layer fails the test.
  • src/test/kiroLightShellHooks.test.ts: the hook table and the ring assertion shrink to the user bubble, so the removed rule cannot come back unnoticed and the dropped class does not read as load-bearing.
  • src/test/ChatInput.liquidGlass.test.tsx (unchanged) pins that the glass-danger line was added to the media block and its attribute mirror identically.

Manual verification

Real gateway serving this branch's website/dist, Chromium 1400x900, Translucent panels on and off, plus the harness's rung frame pinning .tb-right to 180px (under the 200px terminal rung): all 5 glass layers still render and exactly the first segment (the dot) stays visible. The gateway was then stopped with the page open to photograph the glass-danger capsule. The harness asserts each pill is a .liquid-glass host, the trigger has no border, the capsule's layers precede its segments, and the transparency switch state.

Screenshots / video

Each frame is the centre track (top) and the right group (bottom), 2x, Translucent panels on.

dark dark
dark, search hovered (glass-hover) dark hover
light light
kiro-light (white chrome, no ring needed) kiro-light
gateway stopped → glass-danger capsule offline
right group pinned to 180px: dot only, all 5 glass layers intact (3x) rung
rest vs hover on the search trigger, 3x: glass-hover lifts the pane ~12/255 on dark (measured mean 33,31,38 -> 45,43,50) plus text-muted -> text-text hover compare
Translucent panels off (fresh-browser default): the same panes in their solid fallback solid
Whole page, dark

page

Related Issues

N/A — maintainer request in the crewmate DM thread (follow-up to #14896 glass search field and #15167 glass identity pill).

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested a review from a team September 30, 2026 18:14
@CrysisDeu
CrysisDeu requested a review from a team as a code owner September 30, 2026 18:14
@CrysisDeu
CrysisDeu force-pushed the feat/topbar-glass-controls branch from 88a1f70 to 014d44d Compare September 30, 2026 18:31
@CrysisDeu
CrysisDeu force-pushed the feat/topbar-glass-controls branch from 014d44d to 5f61bc7 Compare September 30, 2026 19:11
@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 30, 2026
@CrysisDeu
CrysisDeu force-pushed the feat/topbar-glass-controls branch from 5f61bc7 to 069c7c2 Compare September 30, 2026 19:34
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 30, 2026
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of ba9167d3cf52f924f07c851e57c22e582e4585cb — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

The option-A material pick lives only in an unlinked crewmate DM thread — a maintainer should confirm that choice is theirs before merge.

What this change ships

Inventory (8 items) — 8 justified

Intent: make the top bar's three pills wear the same Liquid Glass material as the rest of the shell — an ADDITION (restyle), maintainer-picked from three mocks.

  1. The search / command-palette trigger is now a glass pane instead of a bordered box — justified
  2. The readout capsule is now a glass pane instead of a bg-card box — justified
  3. Offline now shows a red-tinted glass capsule instead of a flat red fill (new glass-danger tint step, one consumer, on the existing tint mechanism) — justified
  4. The Request a Feature pill is now a glass pane; its feedback-pill class is dropped with its only consumer — justified
  5. The kiro-light inset ring on the two capsules is removed — justified (the deleted pin compensated a bg-card fill this diff removes; declared with kiro-light screenshot evidence)
  6. The capsule's narrow-width collapse rungs now skip the glass effect layers so the connection dot stays visible — justified (mechanism-level consequence of item 2, pinned by test)
  7. A screenshot harness script for the top-bar pills is committed — justified (713 sibling capture-*.mjs scripts; repo evidence convention)
  8. theming-contract.md and the Glass header now name the three pills and shrink the kiro-light hook list — justified (same-commit doc rule in AGENTS.md)

[FIRST-PRINCIPLES-REVIEWED] ba9167d

Description read

[DESCRIPTION-READ] 70b9ed92d05c7191220927339b6c0ede05c641c9a24527656bec06eb167b4602

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of ba9167d3cf52f924f07c851e57c22e582e4585cb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] ba9167d

Description read

[DESCRIPTION-READ] 0de3bbea4751522f2705bd6eeebaa392fc457cd4591cd403a86461158f8ce247

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of ba9167d3cf52f924f07c851e57c22e582e4585cb and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ba9167d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ba9167d3cf52f924f07c851e57c22e582e4585cb: <one-sentence reason>

@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Fable 5) — ✅ PASS

UX-level review of ba9167d3cf52f924f07c851e57c22e582e4585cb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Verify live that the search trigger's hover is perceptible: the blind reader saw no difference between the rest and hovered full-bar frames (shot-01 vs shot-02).

[UX-REVIEWED] ba9167d

Description read

[DESCRIPTION-READ] 3bb75d3a5fa757645b263c1d037c434e7d9345897ea5bf8114802cf06796ef5e

That sha256 names everything this verdict read: the PR description, plus the 12 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Sep 30, 2026
The three pills in the top bar -- the search / command-palette trigger in the
centre track, the readout capsule (connection dot, metrics, credits) and the
Request a Feature pill -- were bordered or bg-card boxes beside a composer
dock, a sidebar search field and a crewmate header that are all Liquid Glass.
They are now `components/Glass.tsx` panes (chip recipe, 12px radius, the
`rounded-xl` the update pill already wears), rendered as the control itself:
the trigger is `<Glass as="button">`, the capsule hosts its segments directly
so the collapse rungs still see them, and the pill's two buttons sit
transparent on the pane. The topbar's own blurred strip is unchanged (option A
of the three mocks the maintainer chose from).

Consequences the change has to carry:

- The capsule's terminal rungs in index.css were `> *:not(:first-child)`; the
  Glass host's effect layers are its first children, so that would have kept a
  layer and hidden the connection dot. Both rungs now hide every non-layer child
  that has a non-layer sibling before it, still structural (registered
  extension segments cannot be enumerated), and the test pins the selector.
- Offline is a tint step, `glass-danger`, added beside `glass-accent` /
  `glass-warn` in all three solidifying blocks (the mirror test keeps them in
  step), never a flat `bg-danger-subtle` fill.
- The kiro-light inset ring on `.tb-capsule` / `.feedback-pill` is gone: the
  glass draws its own lit edge on the white chrome, and the hook test and the
  theming contract shrink to the user bubble. `.feedback-pill` no longer has a
  rule, so the class is dropped; `.tb-capsule` stays as the rung hook.
- The motion layout wrapper around the capsule is now a plain flex div outside
  the pane, so the width tween is unchanged.

Evidence harness: scripts/capture-topbar-glass.mjs (dark / light / kiro-light,
hover, the solid fallback with the Translucent panels switch off, the offline
tint, and a 180px-container probe of the terminal rung).
@CrysisDeu
CrysisDeu force-pushed the feat/topbar-glass-controls branch from 069c7c2 to ba9167d Compare September 30, 2026 20:48
@github-actions

github-actions Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed ba9167d3cf52f924f07c851e57c22e582e4585cb — this comment is updated in place on each push.

Review details

Nothing blocks — two advisory findings, both in the new capture harness.

FINDING — website/scripts/capture-topbar-glass.mjs:170 — check('rung: every glass layer still renders', shown.layers > 0 && shown.layersShown === shown.layers) throws on every run where GLASS is unset (the solid-fallback mode this file's own docstring documents as supported), because with the default html[data-reduce-transparency="on"] the solidify block sets .liquid-glass>[data-liquid-glass-layer]{display:none} so layersShown is 0 while layers is 5 → the run aborts after the three theme frames and never writes report.json → Fix: gate that assertion on GLASS_ON (assert all layers hidden in the solid pass instead). (origin: validation)

FINDING — website/scripts/capture-topbar-glass.mjs:115 — with OFFLINE=1 and STOP_FILE unset, readFileSync(stopFile) throws ERR_INVALID_ARG_TYPE, which the bare catch { /* not yet */ } swallows identically to "not yet", so the loop can never break: the run burns 120 s and then reports a .tb-capsule.glass-danger locator timeout instead of the missing variable → Fix: throw up front when STOP_FILE is unset (as podInfo does for POD_INFO) and narrow the catch to ENOENT.

[OPUS-REVIEWED] ba9167d

Verdict parsed from the review's SHA-scoped output markers for commit ba9167d3cf52f924f07c851e57c22e582e4585cb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ba9167d3cf52f924f07c851e57c22e582e4585cb: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Sep 30, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I checked this at head ba9167d3cf.

The search trigger, readout capsule and feedback pill now wear the shared liquid-glass material. Because liquid-glass.tsx inserts its effect layers before {children}, the old :first-child collapse rungs would have matched a layer instead of the first segment; both terminal rungs now use .tb-capsule > :not([data-liquid-glass-layer]) ~ :not([data-liquid-glass-layer]) (index.css:2161, :2174), which keeps the first real segment and hides the rest. The new glass-danger tint is built only from theme variables (--danger into --glass-tint) and is mirrored in all three solid-fallback blocks plus a prefers-contrast outline. Focus rings come from the existing .liquid-glass:focus-visible rules; dropping overflow-hidden from FeedbackPill is safe because InstantTip portals out. The removed .feedback-pill class has no remaining users.

Mutation: putting the 200px rung back to .tb-capsule > *:not(:first-child) reddens App.test.tsx "shifts the collapse rungs…". The three changed test files pass 139/139. No assertion was weakened; the kiro-light ring assertion left together with the rule it pinned. All five review bots pass at this SHA with no CONCERNS or BLOCK.

Non-blocking follow-ups:

  • The PR body calls ChatInput.liquidGlass.test.tsx "(unchanged)", but the diff edits it (adds --glass-tint-danger to the :root regex and a .glass-danger assertion).
  • The per-block loop in that file (~line 276) pins glass-warn in each fallback block but not glass-danger, so the @supports not (backdrop-filter) block's glass-danger line is untested.
  • capture-topbar-glass.mjs: with GLASS unset, the solid fallback hides the glass layers, so layersShown === layers (line ~170) fails and the run throws before writing report.json; with OFFLINE=1 and no STOP_FILE, readFileSync(undefined) is swallowed and the run times out after 120s (line ~115). Dev-script only.

@CrysisDeu
CrysisDeu merged commit a115160 into main Oct 1, 2026
142 of 143 checks passed
@CrysisDeu
CrysisDeu deleted the feat/topbar-glass-controls branch October 1, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants