Skip to content

fix(dashboard): backport queued/steered text shown as typed to release/0.8.0 - #15577

Merged
bolichen97 merged 1 commit into
release/0.8.0from
backport/0.8.0-queued-user-text
Sep 30, 2026
Merged

bolichen97 merged 1 commit into
release/0.8.0from
backport/0.8.0-queued-user-text

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On a 0.8.0.x build, a message the user sends while a turn is running is shown to them exactly as they typed it, as an ordinary send already is.

This backports #15197 to release/0.8.0; it is already merged on main (1b5f87e). On 0.8.0, a send that is steered into the running turn or queued for the next one shows [REDACTED: suspicious URL to <host>] in place of a link the user just pasted. Cancelling a queued message refills the composer with the placeholder, so the link is lost from the user's own draft. Root cause and design are in #15197.

Why it matters

0.8.0.x is on the stable channel. Anyone who pastes a link mid-turn sees their own words replaced and concludes the agent never got the link.

Not a goal

What changed (motivation → approach → change)

One commit, git cherry-pick -x 1b5f87ed8a (Ray Xu's commit, authorship kept), in the #11339 / #11645 / #15314 backport shape. It applied without conflict, and every line matches the source.

  • Symptom: the user's own queued or steered text is shown redacted.
  • Root cause: the queue and steer egress redacted text by path, not by author, so user-authored text got output-side redaction there but not on the ordinary send path.
  • Change: dashboard/chat_delivery.py, chat_handlers.py and chat_runner.py carry the entry's origin and show user-authored queued/steered text as typed; security_posture.py and learn-cron-dashboard.md document it.

Dependencies: none; no other main-only commit is needed.

Backwards compatibility

Compatible: only the display of the user's own queued/steered text changes. Model-facing delivery and redaction of agent output are unchanged.

Tests

test/test_queued_user_text_display.py (new, from #15197). Run on this branch (output in the PR comment):

  • Touched-module suites: 526 passed (test_queued_user_text_display.py, test_chat_runner_coverage.py, test_chat_runner_early_recovery_actor.py, test_chat_runner_folder_steering.py, test_dashboard_chat_handlers_coverage.py, test_security_posture.py).
  • With src/ reverted to release/0.8.0 and the test kept: 9 of 12 fail.

Backend CI (ci.yml) does not run on release-branch PRs, so these local runs are the backend evidence.

Manual verification

N/A beyond #15197: the code is byte-identical to main's fix.

Related Issues

Backport of #15197 to release/0.8.0.

Pattern harvest

Rule candidate: review-prompt
Pattern: an egress that redacts text by path instead of by author, so user-authored text gets output-side redaction on one path but not its sibling. (Harvested in #15197.)

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

@bolichen97
bolichen97 requested a review from a team as a code owner September 30, 2026 21:08
@bolichen97
bolichen97 requested review from cruisercohen and removed request for a team September 30, 2026 21:08
@bolichen97

Copy link
Copy Markdown
Contributor Author

Local test evidence on the release/0.8.0 tree (head 86eac229cd)

Backend CI (ci.yml) does not run on release-branch PRs, so this is the backend evidence. Runs are from a worktree of this head, Python 3.12.13, on Linux; pytest's pythonpath = src resolves to the worktree.

$ /workplace/bolichen/KiroCrew/.venv/bin/python -m pytest -q -n 8 --dist loadgroup --max-worker-restart=2 test/test_queued_user_text_display.py test/test_chat_runner_coverage.py test/test_chat_runner_early_recovery_actor.py \
    test/test_chat_runner_folder_steering.py test/test_dashboard_chat_handlers_coverage.py test/test_security_posture.py
526 passed, 162 warnings in 26.50s

Regression test fails without the change (dashboard/chat_delivery.py, chat_handlers.py, chat_runner.py, security_posture.py -> release/0.8.0):

$ pytest test/test_queued_user_text_display.py
9 failed, 3 passed   (incl. TestQueueEgress::test_cancel_restores_the_users_own_text, test_slot_detail_reload_follows_the_entry_origin)

Static gates on this head (run from the worktree, no flags): scripts/check_black_formatting.py passed (nothing in scope unformatted outside the baseline); scripts/check_subprocess_encoding.py rc=0; isort --check-only and flake8 on the changed .py files rc=0; mypy src/kiro_crew: Success: no issues found in 1860 source files. scripts/docs-lint.sh: All documentation checks passed.

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Sep 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Fable 5) — ✅ PASS

Premise-level review of 86eac229cdb5041c8f4c15941c3976973978a9f7 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

With no shell, byte-identity to main's 1b5f87e is unverifiable here — a human should confirm the cherry-pick carries nothing beyond #15197.

What this change ships

Inventory (8 items) — 8 justified

Intent: on the stable 0.8.0 channel, show a user their own mid-turn (queued/steered) message exactly as typed — a FIX, backporting merged #15197.

  1. A link pasted mid-turn shows as typed on the queued card and queue list — justified
  2. Cancelling a queued message refills the composer with the text as typed, not a placeholder — justified
  3. The user's own steer card and its persisted row hold the text as typed across reloads — justified
  4. Peer, app, channel and disk-restored entries (including Slack's dual-stamped ones) stay display-redacted — justified
  5. The drained queue_pop frame and drained row stay redacted, matching what the turn received — justified
  6. Slot-detail snapshot carries the two origin stamps so a reload keeps the typed card — justified
  7. Steer lifecycle row lookup accepts both spellings (typed and sanitized) — justified
  8. Spec, security-posture sink text and a pinning test ship in the same commit — justified

[FIRST-PRINCIPLES-REVIEWED] 86eac22

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 86eac229cdb5041c8f4c15941c3976973978a9f7 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Backend CI skips release-branch PRs, so confirm the posted local test-run comment (526 passed; 9/12 fail with src reverted) exists on the PR.

[DESIGN-REVIEWED] 86eac22

@github-actions

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 86eac229cdb5041c8f4c15941c3976973978a9f7 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 86eac22

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 86eac229cdb5041c8f4c15941c3976973978a9f7: <one-sentence reason>

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 86eac229cdb5041c8f4c15941c3976973978a9f7 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 86eac22

Verdict parsed from the review's SHA-scoped output markers for commit 86eac229cdb5041c8f4c15941c3976973978a9f7.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 86eac229cdb5041c8f4c15941c3976973978a9f7: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Sep 30, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

Byte-identity and combined-tree checks (the review lanes asked for these; they have no shell)

  • sha256 of git diff HEAD^ HEAD +/- lines equals that of git diff 1b5f87ed8a^ 1b5f87ed8a (369f9468bb4f1573).

Combined check across all eight 0.8.0 backports (#15574 to #15581). They octopus-merge cleanly onto release/0.8.0 @ 556bf8e (merge e948b10401). release/0.8.0 has since gained #15544 (adaptive concurrency), which touches none of these PRs' files, so no rebase is needed. On that merged tree, scripts/local-gate.py --base origin/release/0.8.0:

  • Backend related set, 4 batches: 26519 + 39518 + 41054 + 16738 passed. 24 tests were deselected because they fail identically on untouched release/0.8.0 on this host: PDF-extractor child processes, installed-version metadata (0.8.0-rc.1), fresh-interpreter import probes, a systemd service probe, aws_control packaging producer CLI, and a peak-RSS reading. The failure sets were compared file by file on both trees.
  • Frontend related set, 3 batches: 9805 + 13140 + 4400 passed. Batch 1's 12 failures (SchedulePage.secrets, ArtifactDetailPage, ChatInput.approval) fail identically on untouched release. Batch 2/3's failures were Denied ID .../node_modules/@pierre/diffs/... from my symlinked node_modules. Rerun with a real node_modules in the fix(chat): backport recycle-notice answer visibility to release/0.8.0 #15578 worktree, the only frontend change in the set, all 8 affected files pass (205 tests).

@bolichen97
bolichen97 merged commit 15ab6d5 into release/0.8.0 Sep 30, 2026
22 checks passed
@bolichen97
bolichen97 deleted the backport/0.8.0-queued-user-text branch September 30, 2026 23:42
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants