Repository navigation
fix: backport the boot, crash and data-loss fixes to release/0.8.0 - #15634
Conversation
Backport of #13308, #14302, #14860, #14961, #15070 to release/0.8.0, cherry-picked in main's merge order. * fix(sel): anchor the chain lock on the log directory (#13308) (cherry picked from commit 998b045) * fix(watchdog): decide the loop-stall exit on the monotonic clock (#14302) (cherry picked from commit 1d37ab1) * fix(ops-mission-control): strict read in ledger resolve_conflict (#14860) (cherry picked from commit b8ea16b) * fix(env): skip a mise candidate whose probe is denied instead of aborting boot (#14961) (cherry picked from commit e054c95) * fix(lessons): retire only a finding on a contradiction verdict (#15070) (cherry picked from commit dd5e840)
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Confirm release-branch CI runs the three [DESIGN-REVIEWED] e09062d |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Verify the fidelity claim: this reviewer cannot read the five source commits, so "every +/- line equals its source's" and the hand-merged memory-skills-hooks.md span rest on the author's word. Every hunk in the diff maps to one of the five named source PRs; nothing ships beyond them (no CHANGELOG, no version bump, matching What this change shipsInventory (10 items) — 10 justifiedIntent: FIX — backport five merged P0 fixes from main onto release/0.8.0 so a stable-channel gateway stops dying on resume or a denied mise probe and stops destroying the SEL key, the shared OMC ledger, or a standing lesson rule.
[FIRST-PRINCIPLES-REVIEWED] e09062d |
GPT 5.6 Review — 🔴 changes requested (blocking)GPT 5.6 found at least one blocking issue that must be resolved before merging This comment is updated in place on each push. BLOCKING -- src/kiro_crew/sel.py:3672 -- Windows leaves the chain-lock directory swappable Adjudication (Opus 5) — is blocking on each finding proportionate?UNBOUNDED as written (audit-chain corruption), but subsumed: the same actor already holds the signing key. 🏷️ Fenced finding(s) machine-flagged as likely edge caseThe security fence keeps these findings blocking regardless of adjudication; the only clearance path is a human override. The annotate-only pass judged the condition combination each one requires extreme, and pre-drafted the override rationale below. A repository writer must independently verify a rationale before posting it — it is machine-authored, and a wrong override on a security-class finding ships exactly the class the fence exists to stop.
False positive or not applicable? A repository writer can comment: |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsOne advisory finding: the new pre-exec alarm cancel is unconditional, so it clears a deadline the process may not own. FINDING — src/kiro_crew/platform_compat.py:87 — [OPUS-REVIEWED] e09062d Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: On a 0.8.0.x build, the gateway no longer dies on a laptop resume or on a denied mise candidate, and no longer destroys the SEL key, the shared OMC ledger or a user's standing lesson rule.
mainalready fixes all five.Backport of 5 P0 fixes, all merged on
main(root causes and designs are in each source PR):resolve_conflictwiped the shared Ops Mission Control ledger and pushed it.PermissionErroron a denied mise candidate aborted gateway boot.Why it matters
0.8.0.x is on the stable channel, and insider.3 / 0.8.0.4 are built from it. Each row is a P0 in the 2026-09-30 backport triage.
Not a goal
main. No version bump, noCHANGELOG.md.What changed (motivation → approach → change)
git cherry-pick -xof each source inmain's merge order onto the currentrelease/0.8.0(a68fbe9). The picks have five different authors, so PR Hygiene's two-commit cap means one commit. It keeps every source's subject and(cherry picked from commit …)line, plus aCo-authored-byfor each author. Merge commits: 998b045, 1d37ab1, b8ea16b, e054c95, dd5e840.Four picked cleanly. One conflict, docs only: #15070's
docs/system-specs/modules/memory-skills-hooks.md. The "Crossing a budget…" paragraph differs between release andmainearlier on, becausemain-only #15161 changed the lesson-ranking sentences. I applied #15070's own rewritten span (the contradiction-verdict sentences, located by the source's common prefix and suffix) to release's paragraph and left release's ranking text alone. Every other +/- line of every pick equals its source's.Backwards compatibility
Same as the source PRs.
Tests
The source PRs' own tests, unchanged. Every touched test file: 1108 passed, 2 skipped, 3 failed. The 3 failures are #14302's new
test_loop_watchdog.pyend-to-end alarm tests (test_real_stall_ends_the_process_by_the_alarmand two siblings). They fail identically onmainHEAD (6697253) on this host, where the child exits 1 instead of on SIGALRM. They are a host artifact, not a backport defect. Regression proof: with each pick's source reverted and its tests kept, every source's tests fail (#13308 13, #14302 4 + 1 error, #14860 1, #14961 2, #15070 2). black baseline, subprocess-encoding, isort, flake8 and mypy (0 issues) pass.Related Issues
Backport of #13308, #14302, #14860, #14961 and #15070 to
release/0.8.0.Pattern harvest
Not generalizable here: each source PR carries its own harvest.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement