Repository navigation
Conversation
UX Review (Fable 5, fork) — ✅ PASSUX-level review of UX-Verdict: PASS Verify a user-clicked slot open that 404s stays announced when no newer refresh of that slot has applied — suppression must cover only superseded races. [UX-REVIEWED] c6449cd Description read[DESCRIPTION-READ] c37b14fa683ac61fc81af5e51ae9bee52158f0875218b9e54feca6482e2aeb04 That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Fable 5, fork) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Browser heuristics reconstruct response ordering the wire could state in one field; each new race variant will demand another interlocking rule. WatchThe spec added here admits the root cause — "Neither response carries one shared monotonic server revision that proves their order" — then compensates in the client: a segment comparer keyed on anchor+ordinal, symbol-based persistence proofs, request-scoped claims, per-slot issue tokens, count baselines, and a 3×10-request retry budget spread across seven Suggestions
[DESIGN-REVIEWED] c6449cd Description read[DESCRIPTION-READ] d01b3a4b36b787b3c073a5df2536876cf5b1ded36de195a3027e1b3afcd39b10 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 5.6 Review (fork) — 🔴 changes requested (blocking)Reviewed 1 of 1 blocking finding(s) are security-class and were withheld from adjudication, so the blocking verdict stands. BLOCKING -- website/src/store/chat/slotRefresh.ts:457 -- Older refresh can overwrite a newer switch
Adjudication (Opus 5) — is blocking on each finding proportionate?F1 — harm UNBOUNDED-class as fenced (transcript rows silently dropped from the active view). Conditions confirmed: Recovery exists (a later refresh carries a higher [ADJUDICATION] c6449cd total=0 uphold=0 downgrade=0 |
First Principles Review (Fable 5, fork) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS A ~1,900-line assistant-reply reconciliation engine ships inside a fix whose frozen goal is keeping one confirmed user message visible. Not justified as shipped
What this change shipsInventory (10 items) — 7 justifiedIntent: FIX — a server-confirmed sent message disappears from the dashboard during a running turn; keep it visible until persistence catches up.
[FIRST-PRINCIPLES-REVIEWED] c6449cd Description read[DESCRIPTION-READ] e0e3a86e69015d20f5a9deb40e795021e809c9b483b63f2c669d68d38030fd32 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review (fork) — 🔴 changes requested (blocking)Reviewed The switch-back replay floor is now read off the post-merge array, so a retained steer silently disables it and already-shown text is appended twice. BLOCKING — website/src/store/chat/slotSwitch.ts:580 A receipt-confirmed steer ( |
43e2348 to
fb33e68
Compare
|
self-added: yes
|
fb33e68 to
c230258
Compare
|
self-added: yes
|
|
self-added: yes
|
|
self-added: yes
|
c230258 to
76191b3
Compare
|
self-added: yes
|
|
self-added: yes
|
|
|
self-added: yes
|
|
Rebased: |
f82f8ef to
44273a3
Compare
Keep confirmed user sends and locally completed replies visible when a running slot fetch returns an older transcript snapshot. Reconcile fetched and local segments by durable turn identity, segment order, request-scoped finalizer evidence, and retained server counts. Remote rewinds remain authoritative.
44273a3 to
c6449cd
Compare
|
🤖 Kiro Crew [operator: dwu96#8c08bee0]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
For reference, the merge conflict itself is small — 6 hunks in When you've addressed these, the pipeline will re-assess on its next cycle. If you'd prefer no automation on this PR at all, add the |
|
Thank you for this careful investigation, @junjiequ. We are closing it because the disappearing-send symptom has since been fixed on main by smaller changes: #18658 (sending right after opening a chat) and #25630 (sending during a slot refresh). This branch now conflicts with both, and it still has an open blocking review at The branch is left untouched, so you can reopen this PR at any time, or open a fresh one on current main, if you want to pick it back up. |
Problem / Motivation
Goal: Keep a sent message visible while an active chat refresh catches up with transcript persistence.
A server-confirmed user message can disappear from the dashboard during a running turn even though the agent received and processed it.
Why it matters
A disappearing message makes a successful send look lost. The user may send the instruction again and trigger duplicate work.
Not a goal
What changed (motivation → approach → change)
Messages you send and replies already shown stay visible while transcript persistence catches up. The gateway can confirm a send or stream a reply before its disk snapshot includes that row. Replacing the live transcript with that older page made confirmed work disappear and invited duplicate instructions.
The slot-detail reader already merges its captured in-memory unflushed tail, but it cannot order independent responses when a read snapshots first, a send confirms second, and the read response arrives last. Neither response carries one shared server revision, so the browser must reconcile that inversion.
sendIdand servermid. Sequence and generation evidence orders open and finalized copies.Empty running pages keep only the confirmed user suffix. Bounded reads walk back to an exact shared anchor instead of guessing from text or timestamps. Dispatched cron, app, recovery, replay, and synthesis rows use one shared turn-opener contract; passive notes never anchor a segment. Multi-segment replies use ordinals, so one prompt's second or third segment cannot be confused with its first.
A request-scoped claim records the exact local accumulators and finalizers changed while a switch fetch is in flight. Fulfillments apply only while their pending issue or claim still owns the same slot; eviction makes late responses no-ops. An ordered rowless boundary finalizes the fetched segment before later local segments are inserted, while unknown anchors never collapse two open segments. Canonical rows deduplicate by
midorsendId; stale open rows converge to one completed segment only with compatible proof. Assistant-role compaction, stuck-turn, and session-reload notices remain visible but never identify or count as reply segments. A raced active refresh re-snapshots the current view for at most three bounded attempts, with a 30-request ceiling including capped window walks. Per-slot issue tokens order overlapping refreshes and switches, so an older-issued read cannot win merely by settling later. A newer refresh that out-ranks an in-flight switch owns the bounded paging cursor too; whether the older switch fulfills or rejects, it settles without transcript or cursor mutation, and rejection emits no stale failure notice or sidebar eviction. Equal or older refreshes remain blocked. Each refresh also compares count changes with its dispatch-time baseline rather than a global count another response moved. Coverage remains bounded, retained steers keep finalize-before-insert ordering, ordinary sends keep their existing order, and idle refresh pages remain authoritative.website/src/store/chatowns the reconciliation, request claims, paging rules, and turn-opener contract. Tests underwebsite/src/testandwebsite/src/storecover empty and stale pages, forged metadata, request isolation, open/finalized ordering, multi-segment turns, cron and passive-note boundaries, remote rewinds, live-tail rescue, exact and ambiguous identities, payload immutability, and opposite authority cases.docs/system-specs/modules/learn-cron-dashboard.mdrecords the behavior.Backwards compatibility
Compatible: the change adds client-side reconciliation evidence and does not reject, rename, or remove any existing input or output.
Removes nothing: no API, accepted field, transcript role, or user-visible capability is removed.
Tests
npm --prefix website run build../scripts/docs-lint.sh,git diff --check, and the single-commit base guard.Manual verification
N/A — reducer tests reproduce the timing races and verify both stale-page and authoritative-page outcomes without a visual-only assertion.
Screenshots / video
Why no screenshot: This changes transcript reconciliation only; rendered messages look the same except that confirmed content no longer disappears.
Related Issues
no linked issue: the incident was reported directly from an affected dashboard session.
Pattern harvest
Rule candidate: review-prompt
Pattern: Reconcile stale server pages only with exact row or turn identity and request-scoped ordering; use retained server counts to distinguish stale tails from remote rewinds.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)