Repository navigation
feat(chat): config flag to list crewmates in the agent picker - #16026
Conversation
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Flip [DESIGN-REVIEWED] 905ae86 Description read[DESCRIPTION-READ] 1fe6be23c7c646c305687305623a442cc83c66b86601d2fdbf18b9a1f67ded09 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Fable 5) — ✅ PASSUX-level review of UX-Verdict: PASS Verify the flag-on picker once in a live dashboard — the no-visual-delta claim rests on existing tests, not pixels. Suggestions
[UX-REVIEWED] 905ae86 Description read[DESCRIPTION-READ] 73d27d2ec8bb3faf93ae94f180cf3012a88c36cb29a2f27ad400a96ce3a3cc4f That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS Two test files hand-roll a QueryClient Not justified as shipped
What this change shipsInventory (7 items) — 6 justifiedIntent: let a user re-list crewmates in the chat agent picker via one config key, default unchanged — an ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 905ae86 Description read[DESCRIPTION-READ] 4c07866d39b040e392ade833aa22f00536c393b64da2f12583c4f5036b0394f6 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
|
a00e6ff to
11a2e02
Compare
11a2e02 to
a9a1793
Compare
|
|
Add dashboard.crewmates_in_agent_picker (default off). useAgents reads it from the shared kirocrewConfig query and shows member rows in the chat picker only when it is true. Replaces the hard-coded HIDE_CREWMATE_CHOICES constant; the feature map names the key.
a9a1793 to
905ae86
Compare
|
|
|
Problem / Motivation
Goal: Let a user turn crewmates back on in the chat agent picker by setting one config key.
#12755 hid crewmates from the chat agent picker behind a hard-coded constant. Users who keep one crewmate per project (each with its own workspace and memory) used that picker to move a chat onto the right crewmate. #16033 since narrowed the hide to crewmates a listed template covers (same name, or no memory of its own on a listed template), but a covered crewmate is still reachable only from the Crew page's "Chat with this member" button, and there is no switch to list every crewmate short of a code change.
Why it matters
People who split projects across crewmates to keep their memories apart lost the quick way to pick one. Without a switch, every such user waits for a release that flips the constant.
Not a goal
withoutCoveredCrewmates).What changed (motivation → approach → change)
A hard-coded hide had no off switch → make it a gateway config key → the picker reads it the way other dashboard flags already reach the SPA.
src/kiro_crew/config/sections.py,src/kiro_crew/config/loader.py)dashboard.crewmates_in_agent_picker(defaultfalse); a non-bool value reads as offwebsite/src/hooks/useAgents.ts)['kirocrewConfig']query (asuseCrewmateThreadsFlagdoes) and lists every crewmate when it istrue; otherwise main'swithoutCoveredCrewmatesfilter applies. TheHIDE_CREWMATE_CHOICESconstant is removedThe name-only list (cron, channel bindings, the keyboard agent cycle) is untouched, so nothing that resolves an agent by name changes.
config-baseline.jsonis regenerated. The Agent picker row indocs/feature-map/README.mdnames the key, its default, and the covered-crewmate rule. Comments that named the old constant now name the key, inwebsite/src/components/AgentDropdownList.tsx,website/src/pages/overview/KiroCrewCfgTab.tsx, the capture harness and the crew-mode spec.Backwards compatibility
Compatible: the new key defaults to off, which is today's behaviour, and no route or response changes.
Tests
test/test_crewmates_in_agent_picker_config.py: the key defaults off, loads from the config file ("yes"reads as off), and survivesto_dict(), which is whatGET /api/config/kirocrewserves.website/src/test/useAgents.hideCrewmates.test.tsx: covered crewmates are hidden (uncovered ones stay) when the key is absent,false, a non-boolean, or the config read fails; every crewmate is listed whentrue; the name-only list stays complete either way.website/src/test/useAgents.projectScope.test.tsanduseAgents.sessionKey.test.tsrender the hook inside aQueryClientProvider, which it now needs.Manual verification
N/A — the default render is unchanged, and the on-state renders the two-group list
AgentDropdownList.test.tsxalready covers.Screenshots / video
Why no screenshot: with the key unset the picker renders exactly as on main; with it set the picker renders the existing two-group layout from before #12755, which this PR does not restyle.
Related Issues
no linked issue: reported in team chat.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)