Repository navigation
docs(conductor): arm patrol loops with watch=work-ledger - #16036
Conversation
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 93b6acf Description read[DESCRIPTION-READ] f2206f8834eff4ca2ba03ed4016dcab1d21d34e397c2baa64412b8feb255c01b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The conductor's own system prompt still says the Not justified as shipped
What this change shipsInventory (4 items) — 3 justifiedIntent: make a conductor dispatching work-ledger workers arm its patrol loop with the already-shipped
(The gate itself is on main — [FIRST-PRINCIPLES-REVIEWED] 93b6acf Description read[DESCRIPTION-READ] 171d5e8263deb98a2f003ac68f4af85e606e57cce36cc67460cae02c67e957e5 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsAdvisory only: the new FINDING — src/kiro_crew/builtin_skills/goal-conductor/SKILL.md:241 — FINDING — src/kiro_crew/builtin_skills/goal-conductor/SKILL.md:243 — [OPUS-REVIEWED] 93b6acf Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
goal-conductor still said monitor_start could not gate on the work ledger, which #12781 shipped. Tell the conductor to pass watch="work-ledger" when it arms its patrol, and add one line to the system prompt's monitor_start guidance so any conductor that dispatched work-ledger workers does the same.
1dd2132 to
93b6acf
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Approved: PR Readiness green on this head, merges cleanly into current main, no outstanding blocking review.
Problem / Motivation
Goal: a conductor that dispatched work-ledger workers arms its patrol loop with
watch="work-ledger", so quiet patrol cycles stop costing a model turn.#12781 shipped the
watch="work-ledger"field onmonitor_start, but nothing an agent reads tells it to pass that field.goal-conductor's "Known limits" section still saysmonitor_start"gates on a single pull-request URL and nothing else today" and to wait for the field. The system prompt's monitor_start guidance only describes PR URLs. Live patrol loops on a host running current main are being armed without the field, so every one of them is a plain timer and wakes its conductor every interval.Why it matters
A patrol loop on a timer pays one full turn per interval whether or not any worker reported, which is the cost #12781 was built to remove. The cost is only recovered when the agent arming the loop knows about the field.
Not a goal
watchfield, the probe and the gate are unchanged.watch="work-ledger"would observe an empty ledger for them).What changed (motivation -> approach -> change)
Symptom: patrol loops armed without
watch. Cause: the guidance agents copy predates #12781 and says the field does not exist. Change, docs only:goal-conductor/SKILL.mdPatrol section: arm the loop withwatch="work-ledger", what it buys (no turn on a quiet cycle, a report pulls the next cycle forward), and to add it withmonitor_update(watch="work-ledger")on a loop found without it.goal-conductor/SKILL.mdKnown limits: drop the stale "patrol loop is on a timer" entry.config/prompt.md"Using monitor_start" item 1: one sentence telling a conductor patrolling work-ledger workers to passwatch="work-ledger".The decision this follows is already recorded in
docs/request-for-change/rfc-conductor-work-ledger.md(statuspartial), whose Phase 3 is thewatch: "work-ledger"gate on the conductor's patrol loop.Backwards compatibility
Compatible: guidance text only; loops armed without
watchkeep working exactly as today.Tests
No new tests (docs only). Ran the tests that read these two files:
test/test_babysit_guidance_gates.py(the monitor_start block in prompt.md must still show a gating PR URL within its first 1200 characters),test/test_conductor_agent.py,test/test_ledger_conductor_agent.py,test/test_work_ledger_doc.py,test/test_builtin_skill_index_line.py,test/test_context.py,test/test_agent_refactor_spec_bytes.py,test/test_babysit_monitor_scenarios.py,test/metrics/test_context_blocks.py,test/test_patrol_budget.py: 373 passed, 0 failed.Manual verification
N/A -- wording change; the field it points to is covered by #12781's tests.
Related Issues
Follows #12781.
Checklist