Skip to content

test(composer): pin list continuation across send modes and selections - #16071

Merged
iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/list-continuation-prod-gaps
Oct 2, 2026
Merged

iamwhatever merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/list-continuation-prod-gaps

Conversation

@Pearcekieser

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Lock in the list continuation from #15911 for the composer cases its test file does not cover yet.

#15911 made the textarea composer continue markdown lists on a new line. An audit of that PR against its acceptance list showed the behaviour is right in every case. Five of those cases were checked only by a local probe, not by the committed suite: a new line over a selection, Shift+Enter in the two non-default send modes, plain Enter sending in enter-ctrl-newline mode, and the default composer being the textarea.

Why it matters

Each of these is a way the feature could regress quietly. One example is the Lexical editor becoming the default before it has list-continuation parity. Another is a send-mode change making Shift+Enter send a list draft. The current suite would stay green through either one.

Not a goal

What changed (motivation → approach → change)

Nothing changes for users. This PR adds regression tests so that the list continuation #15911 shipped cannot break without CI going red. Five cases go into website/src/test/ChatInput.listContinuation.test.tsx. They use the file's existing mount and newLine helpers, which drive the real ChatInput and the native beforeinput event.

Case Asserts
Default composer the Message input element is a TEXTAREA and no contenteditable is mounted
Shift+Enter, ctrl-enter and enter-ctrl-newline 1. test becomes 1. test\n2. and nothing is sent
Plain Enter, enter-ctrl-newline the list draft is sent unchanged
Selection a new line over a selection is left to the browser and adds no marker

Backwards compatibility

Compatible: test-only change.

Tests

The five cases above. The file passes 23/23, and the neighbouring helper suite composerListContinuation.test.ts still passes. The selection and send-mode cases pass because of the selectionStart !== selectionEnd early return in chat-input/listContinuation.ts and the send-key branch in keyboard.ts.

Manual verification

N/A. The change is test-only. The behaviour itself was checked in a browser on #15911's head (desktop 1400px, 600px and mobile 390px viewports).

Screenshots / video

Why no screenshot: test-only diff; no component, style or string changes.

Related Issues

no linked issue: follow-up coverage for #15911, which merged as e858043.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

…every send mode and the default textarea

Adds five cases to ChatInput.listContinuation.test.tsx that kirodotdev#15911's suite left to a local probe: a new line over a selection keeps the native break, Shift+Enter continues the list in ctrl-enter and enter-ctrl-newline modes, plain Enter still sends in enter-ctrl-newline, and the default composer renders the textarea rather than the Lexical editor.
@Pearcekieser
Pearcekieser requested a review from a team as a code owner October 2, 2026 05:46
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Intent: Add regression tests that pin the textarea list continuation shipped in #15911 for a selection, Shift+Enter in every send mode, plain Enter sending in enter-ctrl-newline mode, and the default composer being the textarea.
Not a goal: Any production code change or new composer behaviour.

@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention labels Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

UX Review (Fable 5, fork) — ✅ PASS

UX-level review of 12c021e23da030361556a9b3bc25b9ec64f65384 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Nothing to check.

[UX-REVIEWED] 12c021e

Description read

[DESCRIPTION-READ] 9f7f6a013adeca4050c8f6ddbe0a4798161134dd4127ef957e914dce2837ec97

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

GPT 5.6 Review (fork) — ✅ no blocking findings

Reviewed 12c021e23da030361556a9b3bc25b9ec64f65384 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 12c021e

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Design Review (Fable 5, fork) — ✅ PASS

Design-level review of 12c021e23da030361556a9b3bc25b9ec64f65384 via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Default-composer pin guards ChatInput's prop default only; a ChatPage-level lexicalComposer opt-in would bypass it — confirm that's the intended guard layer.

[DESIGN-REVIEWED] 12c021e

Description read

[DESCRIPTION-READ] 976839dffbc09755bad808861552152f3d6501f44a3e4bbef968d3de3473b8b9

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Opus 5 Review (fork) — ✅ no blocking findings

Reviewed 12c021e23da030361556a9b3bc25b9ec64f65384 via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 12c021e

@github-actions github-actions Bot added the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed: test-only. Pins textarea as the default composer, Shift+Enter list continuation in both ctrl modes, plain Enter still sending in enter-ctrl-newline, and a selection newline adding no marker. CI green.

@iamwhatever
iamwhatever enabled auto-merge (squash) October 2, 2026 16:40
@iamwhatever
iamwhatever merged commit 1b3057a into kirodotdev:main Oct 2, 2026
99 checks passed
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
@Pearcekieser
Pearcekieser deleted the fix/list-continuation-prod-gaps branch October 2, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants