Skip to content

test: keep the command-cron pin live on sandbox-less POSIX hosts - #16096

Merged
bolichen97 merged 2 commits into
mainfrom
test/followup-16083-review
Oct 2, 2026
Merged

bolichen97 merged 2 commits into
mainfrom
test/followup-16083-review

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: the two tests fixed in #16083 keep guarding what they guard on every host that can run them.

Opus reviewed #16083 after it merged and found two gaps:

  1. The new command-cron skip runs the shell probe BEFORE the test patches wrap_argv. On a POSIX host with /bin/sh but no OS sandbox backend, the unpatched probe raises inside wrap_argv, gets cached as "not a POSIX shell", and the test skips -- on exactly the host it was written for, with a false reason.
  2. The frozen build_message signature does not list thread_replies_text, so the snapshot no longer describes main exactly (the comparison tolerates it, but the table is wrong).

Why it matters

Gap 1 silently stands down the command-cron half of the apps-tree-mask pin on sandbox-less POSIX hosts. Gap 2 leaves a pin table that misdescribes the surface it pins.

Not a goal

  • Going back to a byte-exact signature comparison. test: fix two Windows-red tests and write down why #16083 made the pin tolerate a new keyword-only parameter with a default, so a feature branch and a pin branch merged side by side do not red main. That trade-off is kept; Opus's first finding is answered in a PR comment, not absorbed here.
  • Any product change.

What changed (motivation → approach → change)

  • test/test_app_script_cron_sibling_import.py: the probe moves into the test body, after _record_spawns patches wrap_argv, with _POSIX_STRICT_CACHE cleared first so an earlier unpatched verdict cannot leak in. The probe's own spawns are cleared from the recorder before the command runs. A shell-less host (Windows) still skips; a sandbox-less POSIX host now runs the case. The real-sandbox command case also gates on the (unpatched) probe, so a host with a backend but no passing shell skips instead of failing on the refusal.
  • test/test_context_composition_contract.py: thread_replies_text: 'str | None' = None is recorded in its declared position in _BUILDER_MEMBERS["build_message"].
  • docs/system-specs/common/testing-conventions.md: one sentence -- run a gating probe under the same patches the test body uses.

Backwards compatibility

Compatible: test and doc changes only.

Tests

On Windows: both files 125 passed, 3 skipped (the command case skips, as before); --noconftest on the cron file passes; flake8, black and the comment-history gate are clean. The sandbox-less POSIX path is proved by the Linux/macOS shards of this round, which must run (not skip) TestACommandCronRunningBundleCode::test_the_call_site_leaves_the_bundle_readable.

Manual verification

N/A — unit coverage sufficient; nothing user-visible changes.

Related Issues

Follow-up to #16083.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Address Opus review of #16083: probe the command shell after the recorder patches wrap_argv (unpatched, the probe raises on a POSIX host with no sandbox backend and wrongly skips), and re-record thread_replies_text in the frozen build_message signature so the snapshot describes main exactly.
@bolichen97
bolichen97 requested a review from a team as a code owner October 2, 2026 07:17
@bolichen97
bolichen97 requested a review from CrysisDeu October 2, 2026 07:17
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Fable 5) — ✅ PASS

Design-level review of 19b9ece7f9aeafcf1a45e93e466d297d8de14112 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Verify the Linux/macOS shards of this round ran (not skipped) test_the_call_site_leaves_the_bundle_readable — the PR's own stated proof for gap 1.

[DESIGN-REVIEWED] 19b9ece

Description read

[DESCRIPTION-READ] 16d4310a7e30624c843fa5588f089f3b9457ab7ef169e9fd60d340b1d8bc42fb

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

GPT 5.6 Review — ✅ no blocking findings

GPT 5.6 completed its review of 19b9ece7f9aeafcf1a45e93e466d297d8de14112 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 19b9ece

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 19b9ece7f9aeafcf1a45e93e466d297d8de14112: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5 Review — ✅ no blocking findings

Reviewed 19b9ece7f9aeafcf1a45e93e466d297d8de14112 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 19b9ece

Verdict parsed from the review's SHA-scoped output markers for commit 19b9ece7f9aeafcf1a45e93e466d297d8de14112.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 19b9ece7f9aeafcf1a45e93e466d297d8de14112: <one-sentence reason>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 2, 2026
@bolichen97
bolichen97 merged commit 3d465a6 into main Oct 2, 2026
141 of 143 checks passed
@bolichen97
bolichen97 deleted the test/followup-16083-review branch October 2, 2026 08:20
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant