Skip to content

revert: pinned prompt hands over by its bottom edge, no fold - #16342

Closed
CrysisDeu wants to merge 2 commits into
mainfrom
revert/pinned-prompt-fold-chain
Closed

CrysisDeu wants to merge 2 commits into
mainfrom
revert/pinned-prompt-fold-chain

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A prompt taller than the viewport can be read in full again: the pinned-prompt banner goes back to pinning one line once the prompt has scrolled past, and never hides or shrinks the row it points at.

Since #11462 (2026-09-22) the pinned-prompt card is a progressive "fold": the moment a user prompt's row top crosses the fold line the whole row goes visibility: hidden, the card stands in for it, and the card shrinks line by line as the reader scrolls. #13630 re-based the fold on the bubble's height and re-showed the action strip beneath the card; #15828 capped the card at maxH so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt unreadable: the row is hidden as soon as its top passes the fold, the card shows only the first maxH pixels, and scrolling down only makes the card shorter. The lines below the cap can never be reached (before #15828 they sat under the composer instead). The maintainer's screenshot: the card's bottom edge cuts through the middle of a line while the rest of the prompt is unreachable.

Why it matters

The maintainer writes long prompts routinely; every one of them is unreadable after it scrolls past the fold. The banner exists for one thing -- keep one line of the latest prompt in view as a click target to jump back -- and the fold chain broke that one thing while adding ~23 files / ~6,900 lines of geometry, tests and capture scripts.

Not a goal

What changed (motivation → approach → change)

Observed: a tall prompt is hidden the moment its top passes the fold and the card never shows more than its first maxH pixels → root cause: the fold design itself (row hidden + card as stand-in + height tracks the row's remaining height) → change: revert the chain, newest first.

Reverted, as one squashed commit:

  • 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
  • 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
  • c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)
  • 65e23bb fix(chat): keep a long prompt readable instead of pinning it (#16321) -- merged while this revert was in review. It patches the same symptom from inside the fold geometry (bubbleBottom, foldY, restingH); with the fold gone the bottom-edge hand-off already does what its guard did, so its hunks in usePinnedPrompt.ts, its test rewrite and its page-layout.md paragraph go with the chain.

Conflict resolution, no behaviour beyond the revert:

The decision is recorded in docs/decisions/2026-10-02-pinned-prompt-is-one-line-to-jump-back.md (second commit).

Backwards compatibility

Compatible: UI-only; no API, config, or storage shape changes.

Reader: website/src/index.css:[data-pinned-standin] -- chat -- the rule set is removed with the attribute it targeted; no other reader (grep on origin/main: data-pinned-standin, computeLiveCardH, computePinnedCardMaxH, scrollTranscriptBy, stripUncovered all return nothing outside the reverted files).

Tests

Removed with the reverted code: PinnedPrompt.foldScroll, PinnedPrompt.foldContent, PinnedPrompt.ceiling, UserMessage.pinnedStandinActions, MarkdownRenderer.reservedDataHooks, plus the fold/ceiling cases in usePinnedPrompt.test.tsx and pinnedPrompt.test.ts. The pre-#11462 cases in those two files are restored verbatim. Two later tests outside the chain had pinned the data-message-* reservation as a dropped attribute (MarkdownRenderer.surface.test.tsx ATTRS row, MarkdownRenderer.domGolden.test.tsx raw-div input); the reserved inputs are removed so their snapshots stay as they are. Local gates: tsc -b, eslint on every changed file, scripts/docs-lint.sh -- all clean. Test suites run in CI.

Manual verification

Captured with a Playwright harness against the built SPA from both trees (same 60-line prompt, 1280×860, same scroll offsets):

scroll main: row main: card this PR: row this PR: card
+300 hidden 619px, stuck on line 01 visible, scrolls none yet
+900 hidden 619px, stuck on line 01 visible, scrolls none yet
+1200 hidden 619px, stuck on line 01 visible, scrolls none yet

Screenshots / video

Left: main (fold chain). Right: this PR. Same prompt, same scroll position.

scroll +300: before vs after

scroll +900: before vs after

The restored card once the tall prompt has scrolled past the band (hand-off by the row's bottom edge; card is the one-line 48px banner, 368px expanded):

restored card, collapsed

restored card, expanded

Recording of the hand-off (14 frames, 40px scroll steps; the row stays visible until its bottom reaches the band, then the one-line card takes over):

hand-off recording

Related Issues

Closes #16340

Pattern harvest

Not generalizable: a product-shape decision (the banner is a jump target, not a continuation of the bubble), recorded in docs/decisions/ so the fold is not re-introduced.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested a review from a team October 3, 2026 00:52
@CrysisDeu
CrysisDeu requested a review from a team as a code owner October 3, 2026 00:52
@CrysisDeu
CrysisDeu requested a review from bolichen97 October 3, 2026 00:52
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — 🟡 CONCERNS

UX-level review of 37ca3067e68f1f9c8d0b8e3736abca4633336ece — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

The blind reader didn't know that clicking the one-line banner jumps back to the prompt; they expected a click to expand it.

Watch

  • The banner's main action isn't clear. The PR says the banner exists as "a click target to jump back". The blind reader saw the shot-03 bar as "a short one-line summary of my long message… clicking probably opens it to show the whole message", and added "nothing says 'your message'". In the code, a click on the body calls onJump and only the chevron expands, so a click on the text could do something the user didn't expect. This happens every time a long prompt is pinned, but the cost is friction, not a failed task. It is also old behaviour that the revert brings back. Smallest fix: give the body button visible jump wording or an icon, such as "Jump to your message".
  • Scrolling over the card no longer moves the transcript. The revert deletes the wheel/touch forwarder. The deleted comment says a wheel over the card "left the scroller at scrollTop 0", because the card sits in an overlay beside the scroller, not inside it. Scrolling with the pointer over the collapsed card, or over the 368px expanded card in shot-04, now does nothing. The blind reader was already unsure how to "get it out of the way". This hits often for anyone whose pointer is in the upper transcript, and it is friction rather than failure. Smallest fix: keep fix(chat): convert a line-mode wheel with the paragraph line height #12891's line-height fix and the wheel forwarder as their own small change.
  • The jump is back, as the PR says. The PR knowingly brings back the "card appears a band-height lower than the row left" jump, which is a hard swap with a stated reason. Static images can't show it, and shot-05 gave the blind reader one frame only. A human should watch the attached recording to check the jump is acceptable.
  • Text shows through around the band. In shot-03, a line of answer text shows between the chat header and the card. The blind reader called it "a bit messy". This is low severity and on every pinned view. Smallest fix: make the band cover everything from the header down to the card.

[UX-REVIEWED] 37ca306

Description read

[DESCRIPTION-READ] 29af9d72030b8114d49c28c45b1b2f92ac63c367102a08f7f9fe06ba1e0b0995

That sha256 names everything this verdict read: the PR description, plus the 8 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 37ca3067e68f1f9c8d0b8e3736abca4633336ece — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Confirm #16340 carries the maintainer's direction. This PR is the only place the ledger entry's "Decided by" line is recorded, and no base RFC covers the banner.

What this change ships

Inventory (9 items) — 9 justified

Intent: let a user read a prompt taller than the viewport again by putting the pinned banner back to one clickable line. This is a FIX (a rollback).

  1. A tall prompt's row stays visible and scrolls normally. It is no longer hidden as soon as its top crosses the fold. — justified
  2. The banner takes over at the row's bottom edge, not its top, and brings back the known one-band jump. — justified
  3. The banner no longer grows or shrinks line by line while scrolling, and has no composer-dock ceiling (liveH/maxH gone). — justified
  4. The wheel forwarder over the card (scrollTranscriptBy) is gone. — justified
  5. The action strip is no longer re-shown under the card, and the Edit pencil is no longer hidden there (data-pinned-standin CSS, data-message-* hooks gone). — justified
  6. The sanitizer no longer reserves data-message-*. The base checkout has no remaining reader of data-message-, data-pinned-standin, stripUncovered or scrollTranscriptBy (grep: 0 files). — justified
  7. The bottom fade on the expanded pinned paragraph (.pinned-scroll-more) is gone. — justified
  8. The fold's capture and probe scripts and the paragraph in page-layout.md are deleted. — justified
  9. A ledger entry recording the decision is added to docs/decisions/. — justified

[FIRST-PRINCIPLES-REVIEWED] 37ca306

Description read

[DESCRIPTION-READ] c21f4cd91830b987017498a8253cdda0598476c7cc1a703e0750084b2f394fb3

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 37ca3067e68f1f9c8d0b8e3736abca4633336ece — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check the tall-prompt case in the attached recording: the full row stays reachable by scrolling until the one-line card takes over, with no clipped or hidden lines.

[DESIGN-REVIEWED] 37ca306

Description read

[DESCRIPTION-READ] df704221fede26893a164b76dc1efcbc2f73e072a0c1089e1cd200f0926aa914

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 37ca3067e68f1f9c8d0b8e3736abca4633336ece and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 37ca306

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 37ca3067e68f1f9c8d0b8e3736abca4633336ece: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 3, 2026
@github-actions

github-actions Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 37ca3067e68f1f9c8d0b8e3736abca4633336ece — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 37ca306

Verdict parsed from the review's SHA-scoped output markers for commit 37ca3067e68f1f9c8d0b8e3736abca4633336ece.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 37ca3067e68f1f9c8d0b8e3736abca4633336ece: <one-sentence reason>

@CrysisDeu
CrysisDeu force-pushed the revert/pinned-prompt-fold-chain branch from 9566112 to 37faed1 Compare October 3, 2026 01:51
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
The pinned prompt is one clamped line to click and jump back; the
transcript row stays visible and the banner never stands in for it,
folds, or shrinks with the scroll. Evidence points at #16340 and the
revert PR #16342.

Refs #16340
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 3, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Dispositions for R1 (9566112121) → R2 head 37faed1dc8

Lane Finding Disposition
UX Review restored card never shown; no hand-off recording Closed. PR body now carries the collapsed card (48px one-line banner), the expanded card (368px) and a 14-frame hand-off recording (handoff.gif, 40px scroll steps through the row→card swap).
First Principles item 1 / Design decision record not on head Closed. docs/decisions/2026-10-02-pinned-prompt-is-one-line-to-jump-back.md + README row are the second commit (37faed1dc8).
First Principles item 4 / Design / Opus / Frontend Tests 1+2 two later tests still pin the data-message-* reservation Fixed in the revert commit: the reserved inputs are removed from MarkdownRenderer.surface.test.tsx (ATTRS row) and MarkdownRenderer.domGolden.test.tsx (raw-div input); snapshots untouched.
GPT F1 expanded card no longer capped at the transcript floor (#15828) Rebutted — declared rollback. #15828 exists only to cap the fold's card; the maintainer's decision (#16340, the decisions entry on head) is to roll back to the pre-#11462 banner. The expanded card on a short pane is the pre-#11462 behaviour this PR restores on purpose (Not a goal, bullet 1; FP inventory item 6 "declared rollback of #15828").
GPT F2 / Opus an editing row can be hidden by the pin (#13630's data-message-editing guard) Rebutted — declared rollback. Pre-#11462 behaviour (the row hide itself dates to #950/#1131); #13630 added the guard as part of the fold chain. Restoring it alone would be new scope on a revert PR (FP inventory item 7, declared ride-along). If a guard is wanted it is a follow-up issue, not this PR.
Opus wheel over the pinned card scrolls nothing (forwarder removed) Rebutted — declared rollback. The forwarder was #11462's, needed because the fold held the card over unread lines; with the one-line banner there is nothing under it to read (FP inventory item 5, declared).

No new scope; the diff is the three reverts plus the two sibling-test subtractions and the decision record.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 3, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Re-triggering CI: the 01:51Z force-push to 37faed1 registered no pull_request workflow runs (only pull_request_target lanes). Closing and reopening to fire the lanes on the current head; no code change.

@CrysisDeu CrysisDeu closed this Oct 3, 2026
@CrysisDeu CrysisDeu reopened this Oct 3, 2026
@CrysisDeu
CrysisDeu force-pushed the revert/pinned-prompt-fold-chain branch from 37faed1 to 3e19670 Compare October 3, 2026 02:51
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
The pinned prompt is one clamped line to click and jump back; the
transcript row stays visible and the banner never stands in for it,
folds, or shrinks with the scroll. Evidence points at #16340 and the
revert PR #16342.

Refs #16340
@CrysisDeu
CrysisDeu force-pushed the revert/pinned-prompt-fold-chain branch from 3e19670 to 746fbba Compare October 3, 2026 03:51
CrysisDeu added a commit that referenced this pull request Oct 3, 2026
The pinned prompt is one clamped line to click and jump back; the
transcript row stays visible and the banner never stands in for it,
folds, or shrinks with the scroll. Evidence points at #16340 and the
revert PR #16342.

Refs #16340
@github-actions github-actions Bot removed the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 3, 2026
…chain)

Reverts, newest first:
- 5534a7a fix(chat): keep the pinned prompt card above the composer dock (#15828)
- 1a3732a fix(chat): keep message actions visible under a pinned long prompt (#13630)
- c250d3e fix(chat): hand the pinned prompt over at the pin line, not past it (#11462)
- 65e23bb fix(chat): keep a long prompt readable instead of pinning it (#16321),
  merged while this revert was in review: its guard is written against the
  fold geometry (`bubbleBottom`, `foldY`, `restingH`) and is subsumed by the
  bottom-edge hand-off this revert restores.

the moment its top crosses the fold line, the card stands in for it, and
the card shrinks line by line as the reader scrolls. #13630 re-based the
fold on the bubble and re-showed the action strip beneath the card; #15828
capped the card at the transcript floor so it stops at the composer dock.

For a prompt taller than the viewport the three together make the prompt
unreadable: the row is hidden as soon as its top passes the fold, the card
shows only the first `maxH` pixels, and scrolling down only makes the card
shorter -- the lines below the cap can never be reached (before #15828
they sat under the composer instead). The maintainer's call is that the
whole fold / stand-in / hand-off geometry is over-engineering: the banner
exists to keep one line of the latest prompt at the top as a click target
to jump back, not to be a seamless continuation of the bubble. Roll back to
the pre-#11462 behaviour -- the row stays visible and scrolls normally, the
card appears once the row's bottom edge has passed the band.

Conflict resolution, no behaviour beyond the revert:
- `components/markdown/sanitize.ts`: the `data-message-*` attribute
  reservation #13630 added to MarkdownRenderer had moved here in #14580;
  removed here instead.
- `pages/chat/PinnedPrompt.tsx`: #13318's `max-w-full` (Content Width
  setting) is kept; #12891's line-height fix lived inside the wheel
  forwarder #11462 added and goes with it.
- `.github/coverage-baselines/frontend.txt`: current baseline kept.
- `test/MarkdownRenderer.surface.test.tsx`, `test/MarkdownRenderer.domGolden.test.tsx`:
  two later tests encoded the `data-message-*` reservation as a dropped
  attribute; the reserved inputs are removed so the snapshots stay as is.
- `test/PinnedPrompt.images.test.tsx` (new): the fold's tests carried this
  file's coverage; without them it reads 78.4%. The thumbnail / failed-image
  fallback and the jump click were untested pre-#11462 and are covered here.

Refs #16340
The pinned prompt is one clamped line to click and jump back; the
transcript row stays visible and the banner never stands in for it,
folds, or shrinks with the scroll. Evidence points at #16340 and the
revert PR #16342.

Refs #16340
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 3, 2026
@CrysisDeu
CrysisDeu force-pushed the revert/pinned-prompt-fold-chain branch from 746fbba to 37ca306 Compare October 3, 2026 05:10
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 3, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Dispositions for R3 (746fbba928) → R4 head 37ca3067e6

Lane Finding Disposition
Coverage Gate src/pages/chat/PinnedPrompt.tsx 78.4% (76/97), below the 80% floor Fixed. The fold's tests had been carrying this file. New website/src/test/PinnedPrompt.images.test.tsx covers pre-#11462 behaviour that was never tested: one thumbnail per image, dropping only the thumbnail whose load failed, the ImageOff glyph once every image has failed (collapsed and expanded card), and the jump-back click. Folded into the revert commit; no baseline row added.
UX Review (CONCERNS) wheel/touch over the restored card no longer scrolls the chat Declared rollback. The forwarder was #11462's, needed because the fold held the card over unread lines; the one-line banner covers nothing the reader has not reached. Advisory, not re-added.
UX Review (CONCERNS) expanded card lost the "more below" fade Declared rollback. pinned-scroll-more arrived with #11462; the pre-#11462 expanded card never had it. Advisory, not re-added.
UX Review (CONCERNS) the banner's click-to-jump is not discoverable Noted as follow-up, out of scope. Pre-existing to the whole chain; the reviewer's own note says no fix is needed in this rollback.

R4 head also carries the rebase onto main past #16321 (listed in the commit and the description).

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 3, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

Read-only review: the revert of the pinned-prompt fold chain (#11462, #13630, #15828, #16321) is clean; head files carry no leftover data-pinned-standin, stripUncovered, card-height or scrollTranscriptBy code, and CSS, the data-message-* sanitizer reservation and matching tests were removed together. Not approving from my side because open #16372 (buluoray) repairs the #16321 gate this removes and #16021 builds on the fold code; both collide in usePinnedPrompt.ts and PinnedPrompt.tsx. Maintainers should pick one direction first, then close or rebase the others.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Oct 3, 2026
@dwu96 dwu96 added needs-pr-triage PR scanner: awaiting automated triage and removed needs-pr-triage PR scanner: awaiting automated triage labels Oct 6, 2026

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[operator: bolichen97]

Review of #16342 at head 37ca306 (main checked: b00e744, 2026-10-16 02:07 PDT).

Recommendation: close as superseded (or hold until a maintainer posts a design decision on #16340). The revert itself was clean on its own base, but its premise has been overtaken on main and it no longer merges.

Counts: 2 blocking, 1 should-fix, 2 nit.

Blocking

  1. The bug it fixes is already guarded on main, and the direction is parked. website/src/pages/chat/usePinnedPrompt.ts:81

    • Why: main carries #16321 (on main: usePinnedPrompt.ts:296-305, "A prompt taller than the resting card is NOT pinned while any of it is still below the card's resting bottom") and its repair #16372 (merged 2026-10-03 10:02 PDT). The tall-prompt-unreadable symptom in #16340 is the case that guard covers. What is left is a product call (fold vs. one-line jump target). On #16340 the Captain asked for maintainer design sign-off (2026-10-08) and cruisercohen parked it on 2026-10-13 ("not on the current plan"). Merging would roll back shipped behaviour with no sign-off. Not verified: I did not re-run a browser repro of the tall prompt on main; this is from reading main's code and tests.
    • Fix: close this PR, pointing at #16321/#16372. If a maintainer later picks the revert direction on #16340, re-cut it from current main.
  2. 11 conflicts; main has built on the fold since this was cut. website/src/pages/chat/PinnedPrompt.tsx:390

    • Why: merge-base is 5c7a6fd (2026-10-02 19:36 PDT). A trial merge against main conflicts in PinnedPrompt.tsx, usePinnedPrompt.ts, UserMessage.tsx, ChatPage.tsx, ChatPane.tsx, index.css, sanitize.ts, page-layout.md, docs/decisions/README.md, usePinnedPrompt.test.tsx, plus modify/delete on capture/pinned-prompt-handoff.tsx and UserMessage.pinnedStandinActions.test.tsx. Since then main landed fold-dependent work on these files: #16372, #16970 (thumbnail expands the card), #16842 (mask under the card), #15919 (keep the pin while reading the last reply), #19139 (Alt+Up/Down), and #21054 (moved the row markup into pages/chat/page/ChatTranscriptView.tsx, which now also carries data-pinned-standin, and PinnedPrompt.peek.test.tsx pins it). A rebase is no longer a mechanical revert: each of those needs its own keep/drop call.
    • Fix: do not rebase this branch. If the revert is approved, open a fresh one-commit revert from current main that lists those PRs too and states, per PR, what is kept.

Should-fix

  1. The decision record says a decision was made that was not. docs/decisions/2026-10-02-pinned-prompt-is-one-line-to-jump-back.md:3
    • Why: "Decided by: ... (maintainer)" and the "Decision" section record the fold as rejected, but #16340 never got the sign-off the Captain asked for and is parked. The ledger exists so later PRs trust it; an unratified entry would block future fold work on a decision nobody took.
    • Fix: drop this commit, or reword it as "Proposed" until a maintainer confirms on #16340.

Nit

  1. Evidence list omits #16321. docs/decisions/2026-10-02-pinned-prompt-is-one-line-to-jump-back.md:18

    • Why: the PR body and commit also revert #16321, but the entry names only #15828, #13630 and #11462.
    • Fix: add #16321 to the reverted chain here and in "Why".
  2. Jump button's purpose is only in title. website/src/pages/chat/PinnedPrompt.tsx:390

    • Why: the accessible name is the prompt text; title is not reliably announced, so a screen-reader user does not hear that activating it jumps back (the UX lane hit the same confusion). Main has the same pattern (PinnedPrompt.tsx:754), so this is not introduced here.
    • Fix: add an sr-only "Jump to this turn" span referenced by aria-describedby (or prefix the label), in whichever version ships.

What checks out

  • On its own base the revert is complete: no leftover data-pinned-standin, computeLiveCardH, computePinnedCardMaxH, scrollTranscriptBy or stripUncovered in the head tree; CSS, sanitizer reservation, capture scripts and fold tests go together; pre-#11462 tests restored; new PinnedPrompt.images.test.tsx covers the restored card.
  • Keyboard on the restored card: both controls are native <button type="button">; the chevron has aria-expanded + aria-label; keyboard focus opens the peek, pointer focus does not.
  • AI lanes on this head: Opus 5.5 no findings, GPT 6.1 no findings, First Principles PASS, Design PASS, UX CONCERNS (advisory). No human reviews in the REST list.

// A prompt hands over to the banner only once it is entirely behind the band
// (bottom edge at or above the band's bottom), so a prompt taller than the
// band scrolls away line by line instead of collapsing the moment it is sent.
const handoffY = pinHandoffY(foldY, pinCollapsedHRef.current)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking. Main already carries #16321's tall-prompt guard (main usePinnedPrompt.ts:296-305) and its repair #16372, so the #16340 symptom is covered there. #16340 is parked (2026-10-13) with no maintainer design sign-off. Fix: close this PR; re-cut from main only if a maintainer picks the revert direction on #16340.

// which would let the column refuse to shrink below the full prompt.
className={`min-w-0 min-h-0 flex-1 flex flex-col bg-transparent border-none p-0 m-0 text-left ${folding ? '' : 'cursor-pointer'}`}
onClick={onJump}
title={i18nT('pages.chat.pinnedPrompt.jump_to_this_turn')}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking. 11 conflicts against main. Main has built on the fold since: #16372, #16970, #16842, #15919, #19139, #21054 (ChatTranscriptView.tsx now also carries data-pinned-standin). A rebase is no longer a mechanical revert. Fix: if approved, a fresh revert from main listing those PRs and what is kept from each.

Nit (a11y, pre-existing). The jump action lives only in title, which screen readers do not reliably announce. Fix: sr-only "Jump to this turn" via aria-describedby.

@@ -0,0 +1,19 @@
# The pinned prompt is one line to click and jump back, never a stand-in for the row

Decided by: Zezhen Xu (maintainer, @CrysisDeu)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should-fix. Records a decision as made, but #16340 never got the requested maintainer sign-off and is parked. Fix: drop this commit or mark it "Proposed" until a maintainer confirms.

## Evidence

- https://github.com/kirodotdev/KiroCrew/issues/16340 -- the issue recording the decision and the maintainer's direction.
- https://github.com/kirodotdev/KiroCrew/pull/16342 -- the revert of #15828, #13630 and #11462 and the pull request that adds this entry.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. The PR also reverts #16321; list it with the chain here and in "Why".

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Oct 17, 2026
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Closing this as superseded. The parent issue #16340 was parked by the maintainer on 10-13, and main has kept building on the pinned-prompt fold since then, so reverting the fold no longer fits main. @bolichen97 also suggested closing it. The branch is kept, so this can be reopened if the direction changes.

@CrysisDeu CrysisDeu closed this Oct 29, 2026
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 29, 2026
@bolichen97
bolichen97 deleted the revert/pinned-prompt-fold-chain branch November 6, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflict Branch has merge conflicts with its base — author must resolve before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert the pinned-prompt fold chain (#11462, #13630, #15828): a tall prompt is unreadable

4 participants