Skip to content

docs(rfc): accept rfc-remote-crew-sidebar - #16699

Merged
chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-remote-crew-accepted
Oct 4, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
docs/rfc-remote-crew-accepted

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record maintainer iamwhatever's acceptance of rfc-remote-crew-sidebar, so "the peer owns a crew session, the local dashboard is only a window, plus per-machine sidebar groups" is a decision on main.

The RFC merged in #16489 as status: draft. The First Principles lane reads RFC status off the base branch, and draft is not a decision. The wave PRs that build it (per-machine sidebar groups, the window view) change what a person sees, so they need the decision on main first.

Why it matters

The design is accepted. Until main says so, every implementation PR for its waves BLOCKs on "product-shape change without accepted RFC", however green its other checks are.

Not a goal

  • Any code change. Each wave ships in its own PR.
  • Revising the design. The document is unchanged apart from the status, doc-pr, the audit fields and the recorded decision.
  • Deciding the document's Open questions 1 to 5. They are settled in the wave PR that meets each one.

What changed (motivation → approach → change)

This follows the directory's acceptance convention (as for rfc-terminal-exit-closes-tab in #15531):

  • docs/request-for-change/rfc-remote-crew-sidebar.md:
    • status: draft becomes status: accepted.
    • doc-pr is set to 16489, the PR that merged the document.
    • audited-at is re-read against current main.
    • The prose status line names the acceptance.
    • A dated "Decided 2026-10-03 by iamwhatever (maintainer)" record goes under Open questions.
  • docs/request-for-change/README.md: the table row reads accepted ("the decision, not yet the code"), and the audit log gains one sentence for the move.

The main-side reading is re-verified at f31e2f7091: remote_relay.py, useInstanceSessions.ts, ssh_tunnel_manager.py, diagnostics.py and the other files the RFC cites are unchanged since e698e8ca7a; the two that moved (chat_handlers.py, ChatPage.tsx) changed in code the RFC does not cite. So "nothing here is built" still holds.

This PR records maintainer iamwhatever's acceptance. Opened by an agent on iamwhatever's behalf.

Backwards compatibility

Compatible: documentation only; nothing main accepts changes.

Removes nothing: only an RFC status and its index row change.

Tests

N/A, docs only. scripts/docs-lint.sh and scripts/docs_lint.py --test pass locally, and the one related test file, test/test_pr_quality_gates.py, passes.

Manual verification

N/A, docs only.

Related Issues

Part of #6180. Records the decision for the RFC merged in #16489. Related: #7445, #10618, #10826, #14585.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested a review from a team as a code owner October 4, 2026 07:00
@iamwhatever
iamwhatever requested a review from buluoray October 4, 2026 07:00
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 8249e0219d7b87360554ccad85863064bcfd78c8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Confirm iamwhatever actually made this acceptance, for example with a PR comment or approval. An agent opened the PR on their behalf, and the status flip is the whole change.

[DESIGN-REVIEWED] 8249e02

Description read

[DESCRIPTION-READ] f2f6d8159f876f88526f5ecb930e19ee7b4b4602bf5c7fe0e436120248df6f99

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 8249e0219d7b87360554ccad85863064bcfd78c8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 8249e02

Verdict parsed from the review's SHA-scoped output markers for commit 8249e0219d7b87360554ccad85863064bcfd78c8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 8249e0219d7b87360554ccad85863064bcfd78c8: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 8249e0219d7b87360554ccad85863064bcfd78c8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 8249e02

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 8249e0219d7b87360554ccad85863064bcfd78c8: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 4, 2026
Record maintainer iamwhatever's acceptance of the remote-crew sidebar
RFC (option (b): the peer owns a crew session and the local dashboard
is only a window, plus per-machine sidebar groups). Status moves from
draft to accepted, doc-pr names #16489, the prose status line and the
directory README row say so, and the decision is written under the
document's Open questions with its date. Nothing is implemented on main.
@iamwhatever
iamwhatever force-pushed the docs/rfc-remote-crew-accepted branch from b2d4294 to 8249e02 Compare October 4, 2026 09:21
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 4, 2026
@chenmingwei23
chenmingwei23 merged commit 4b2e177 into main Oct 4, 2026
98 checks passed
@chenmingwei23
chenmingwei23 deleted the docs/rfc-remote-crew-accepted branch October 4, 2026 16:36
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 4, 2026
@bolichen97 bolichen97 mentioned this pull request Oct 6, 2026
5 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants