Repository navigation
test: drop removed 're' binding from handlers composition contract - #16702
bolichen97 wants to merge 1 commit into
Conversation
#15917 removed the unused `import re` from chat_handlers.py; the frozen _BASE_NAMES list still required it, so two contract tests failed on main.
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] ea328cf Description read[DESCRIPTION-READ] 20122f4363841b5367d70bba202f8d484e7865d18e798009c6160db877d1d4c6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
Closing as a duplicate of #16695, which makes the identical one-line change and was opened first. |
Problem / Motivation
Goal:
mainpasses the chat handlers composition contract again.Two tests in
test/test_chat_handlers_composition_contract.pyfail onmain:test_every_name_the_handlers_bound_at_the_base_still_resolvesandtest_a_fresh_interpreter_sees_every_base_public_name. Both report['re']missing.Why it matters
Every PR that runs the Python suite goes red on these two tests until
mainis fixed.Not a goal
chat_handlersexports.What changed (motivation → approach → change)
#15917 removed the unused
import refromchat_handlers.py. The contract's frozen_BASE_NAMESlist still asked forre.reis the stdlib module, not a handlers name any caller reads, so it is dropped from the list.Backwards compatibility
Compatible: test-only change.
Tests
test/test_chat_handlers_composition_contract.pypasses (124 tests) on this head.Manual verification
N/A — test-only change; the failing tests are the verification.
Screenshots / video
N/A — no UI change.
Related Issues
Fixes #16693
Also reported as #16701 (closed as a duplicate of #16693).
Pattern harvest
None.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)