Skip to content

test: drop removed 're' binding from handlers composition contract - #16702

Closed
bolichen97 wants to merge 1 commit into
mainfrom
fix/handlers-contract-drop-re
Closed

bolichen97 wants to merge 1 commit into
mainfrom
fix/handlers-contract-drop-re

Conversation

@bolichen97

@bolichen97 bolichen97 commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: main passes the chat handlers composition contract again.

Two tests in test/test_chat_handlers_composition_contract.py fail on main: test_every_name_the_handlers_bound_at_the_base_still_resolves and test_a_fresh_interpreter_sees_every_base_public_name. Both report ['re'] missing.

Why it matters

Every PR that runs the Python suite goes red on these two tests until main is fixed.

Not a goal

  • Changing what names chat_handlers exports.
  • Changing how the contract freezes its name list.

What changed (motivation → approach → change)

#15917 removed the unused import re from chat_handlers.py. The contract's frozen _BASE_NAMES list still asked for re. re is the stdlib module, not a handlers name any caller reads, so it is dropped from the list.

Backwards compatibility

Compatible: test-only change.

Tests

test/test_chat_handlers_composition_contract.py passes (124 tests) on this head.

Manual verification

N/A — test-only change; the failing tests are the verification.

Screenshots / video

N/A — no UI change.

Related Issues

Fixes #16693
Also reported as #16701 (closed as a duplicate of #16693).

Pattern harvest

None.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable): N/A
  • No secrets, credentials, or internal references in the diff

#15917 removed the unused `import re` from chat_handlers.py; the frozen _BASE_NAMES list still required it, so two contract tests failed on main.
@bolichen97
bolichen97 requested a review from a team as a code owner October 4, 2026 07:04
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of ea328cf9944b9d095d2916492f48857cc747febb — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] ea328cf

Description read

[DESCRIPTION-READ] 20122f4363841b5367d70bba202f8d484e7865d18e798009c6160db877d1d4c6

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed ea328cf9944b9d095d2916492f48857cc747febb — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] ea328cf

Verdict parsed from the review's SHA-scoped output markers for commit ea328cf9944b9d095d2916492f48857cc747febb.

False positive or not applicable? A repository writer can comment:
/ai-review override fable ea328cf9944b9d095d2916492f48857cc747febb: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of ea328cf9944b9d095d2916492f48857cc747febb and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] ea328cf

False positive or not applicable? A repository writer can comment:
/ai-review override gpt ea328cf9944b9d095d2916492f48857cc747febb: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #16695, which makes the identical one-line change and was opened first.

@bolichen97 bolichen97 closed this Oct 4, 2026
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test: chat_handlers composition contract still pins re after #15917 removed the import (main red)

1 participant