Skip to content

fix(i18n): gloss "remote crew" on the Developer feature previews - #16708

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/12767-crew-gloss
Oct 4, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/12767-crew-gloss

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: On Developer > Feature Previews, a reader can tell that "remote crew" means another machine, not their agents.

The Feature Previews page shows "crew" in two senses side by side: the Crewmates card (your agents) and the Remote crew sessions card (another machine you connected). The Remote crew sessions hint says "Merge a connected remote crew's live sessions…" with no gloss, so it reads as the agent team. In Russian it is worse, since «команда» also means "team".

Why it matters

Someone turning on the preview can think it merges their own agents' sessions. That is wrong, and the toggle gives no other clue.

Not a goal

What changed (motivation → approach → change)

Two senses of one word on one page → say which sense this card means, once → one sentence added to the existing hint pages.developer.featurePreviewsTab.merge_a_connected_remote_instances_live_sessions: "A remote crew is another machine you have connected, not your agents." It sits before the closing "Functional, but not finished." Amending the existing hint is smaller than a new key and needs no component change. The sentence is translated in all 11 other locale catalogs under website/src/i18n/locales/ (en.json plus bn, de, es, fr, hi, it, ja, ko, pt, ru, zh-CN), reusing each locale's existing word for remote crew. The en-XA pseudolocale and the generated settings registry (settingsRegistry.gen.ts, settings-registry.generated.json) are regenerated, so the command palette shows the same text.

Backwards compatibility

Compatible: one string value changes; no key is added, renamed, or removed.

Removes nothing: only adds a sentence to an existing hint.

Tests

No new tests: this is a copy change. npm run i18n:check with I18N_BASE_REF=origin/main passes all 19 checks, including changed-values QA and pseudolocale sync. vitest run src/i18n (45 files, 733 tests, includes every locale style test) and vitest run src/pages/settings (20 files, 494 tests) pass.

Manual verification

Built the SPA and opened Settings > Developer with stubbed APIs, in light and dark themes. The Remote crew sessions hint shows the new sentence.

Screenshots / video

Settings > Developer > Feature Previews, Remote crew sessions card.

Feature Previews, light theme

Feature Previews, dark theme

Remote crew sessions hint open, showing the new sentence (light theme):

Remote crew sessions hint open, light theme

Related Issues

Closes #12767

Pattern harvest

Not generalizable: a one-off copy gloss for one overloaded word on one card.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@iamwhatever
iamwhatever requested a review from a team October 4, 2026 07:31
@iamwhatever
iamwhatever requested a review from a team as a code owner October 4, 2026 07:31
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 4b5b430cec5a34e541017b2ffdd497d05b72b6e3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 4b5b430

Description read

[DESCRIPTION-READ] 1592022ae28f95141eb0c54fc1056aeb3536a1e2fface5752a5629c48bb7501c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 4b5b430cec5a34e541017b2ffdd497d05b72b6e3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: Make it clear to someone on Developer > Feature Previews that "remote crew" means another machine they connected, not their own agents. This is a FIX (Closes #12767).

  1. The Remote crew sessions hint gets one more sentence: "A remote crew is another machine you have connected, not your agents." It is in English and the 11 other locales. — justified
  2. The command-palette and settings-registry descriptions show the same new sentence. They are regenerated from the hint, not written by hand. — justified

[FIRST-PRINCIPLES-REVIEWED] 4b5b430

Description read

[DESCRIPTION-READ] fccce7468b1c5129e8f427eca484c13a4ecb7206cb4b581787f7d186f29ba880

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 4b5b430cec5a34e541017b2ffdd497d05b72b6e3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 4b5b430

Verdict parsed from the review's SHA-scoped output markers for commit 4b5b430cec5a34e541017b2ffdd497d05b72b6e3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 4b5b430cec5a34e541017b2ffdd497d05b72b6e3: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 4b5b430cec5a34e541017b2ffdd497d05b72b6e3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that the gloss is enough while it sits behind the (i): from the row alone, the blind reader still had "no idea from this shot" what "Remote crew sessions" does.

Suggestions

  • In merge_a_connected_remote_instances_live_sessions, point to where the connection is made: "…another machine you connected under Settings > Remote Crew, not your agents." The blind reader "can't tell how" the "Remote Crew" menu item and this toggle relate.

[UX-REVIEWED] 4b5b430

Description read

[DESCRIPTION-READ] 42306074210c11df339b990dd2b0d71ec22bd19b15d9abb3c3f2577ac8313107

That sha256 names everything this verdict read: the PR description, plus the 6 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 4b5b430cec5a34e541017b2ffdd497d05b72b6e3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 4b5b430

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 4b5b430cec5a34e541017b2ffdd497d05b72b6e3: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 4, 2026
The Remote crew sessions preview hint now says a remote crew is another
machine you have connected, not your agents, so the word no longer reads
as the agent team on a page that shows both senses. Translated in every
locale; en-XA and the settings registry regenerated.

Closes #12767
@iamwhatever
iamwhatever force-pushed the fix/12767-crew-gloss branch from f2987a5 to 4b5b430 Compare October 4, 2026 07:57
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 4, 2026
@chenmingwei23
chenmingwei23 merged commit a887f0e into main Oct 4, 2026
99 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/12767-crew-gloss branch October 4, 2026 16:36
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/ui: disambiguate "crew" if the Crew Members → Agents rename does not land

2 participants