Skip to content

fix(skills): bring prepare-pr SKILL.md back under its byte ceiling - #16720

Closed
bolichen97 wants to merge 1 commit into
mainfrom
fix/prepare-pr-skill-ceiling
Closed

bolichen97 wants to merge 1 commit into
mainfrom
fix/prepare-pr-skill-ceiling

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: main's prepare-pr/SKILL.md fits its 68 000-byte ceiling again, so test_review_repair_routing_skill.py::test_slim_skills_do_not_regrow_duplicate_guidance_or_wire_model_ids[prepare-pr-68000] stops failing on every PR.

#16196 and #16634 each grew the file and each was green alone; merged together the file is 68 077 bytes, 77 over. Backend Tests shard 3 is red on Linux and Windows for every PR built on current main (e.g. #16503, #16697).

Why it matters

Every open PR inherits the red.

Not a goal

  • Raising the ceiling: it exists to stop the file regrowing.
  • The wider prepare-pr slimming, which comes separately.

What changed (motivation -> approach -> change)

  • Drop three repeated pointers (— see above, — see the profile section) after (single_commit only): the profile section already states that rule once.
  • Shorten the Issue Gate tier-label clause to lacks exactly one tier:T1..tier:T4 label.
  • No instruction is removed. File is now 67 983 bytes.

Backwards compatibility

Compatible: skill text only.

Tests

  • The ceiling test passes; every prepare-pr / skill test file: 1191 passed, 43 skipped on Windows.

Manual verification

N/A - text-only change covered by the skill tests.

Related Issues

Part of #16506

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@bolichen97
bolichen97 requested a review from a team as a code owner October 4, 2026 07:42
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 44a29d66ef0cd013a22a13f65e5b103c14aa0f11 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Nothing to check.

What this change ships

Inventory (2 items) — 2 justified

Intent: unblock every PR by bringing prepare-pr/SKILL.md back under its pinned 68 000-byte ceiling (FIX).

  1. Squash and push steps no longer say "see above" / "see the profile section" after (single_commit only). The rule is still stated once, at line 282. — justified
  2. The Issue Gate tier-label sentence is shorter (lacks exactly one tier:T1..tier:T4 label), and its meaning is unchanged. — justified

[FIRST-PRINCIPLES-REVIEWED] 44a29d6

Description read

[DESCRIPTION-READ] 63232b185f7a7e9fb98eec0916e6f6dc210ff1c6db659dd21ca4c8c04864d358

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 44a29d66ef0cd013a22a13f65e5b103c14aa0f11 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check the cross-PR race: no merge-time gate stops two green PRs from growing this file past its ceiling together, which caused this break.

[DESIGN-REVIEWED] 44a29d6

Description read

[DESCRIPTION-READ] 3fa214aeb15e5570926d77f1aebea717ba5f60c5e0f58d5a26c1d85dbbbc7ff5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 44a29d66ef0cd013a22a13f65e5b103c14aa0f11 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 44a29d6

Verdict parsed from the review's SHA-scoped output markers for commit 44a29d66ef0cd013a22a13f65e5b103c14aa0f11.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 44a29d66ef0cd013a22a13f65e5b103c14aa0f11: <one-sentence reason>

@bolichen97

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of #16719, which fixes the same byte-ceiling red and is being merged.

@bolichen97 bolichen97 closed this Oct 4, 2026
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 44a29d66ef0cd013a22a13f65e5b103c14aa0f11 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 44a29d6

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 44a29d66ef0cd013a22a13f65e5b103c14aa0f11: <one-sentence reason>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant