Skip to content

fix(mcp): move three McpTab badge hints onto focusable InfoTips - #16749

Merged
chenmingwei23 merged 1 commit into
mainfrom
fix/mcp-tab-badge-a11y-8359-main
Oct 4, 2026
Merged

chenmingwei23 merged 1 commit into
mainfrom
fix/mcp-tab-badge-a11y-8359-main

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Replaces fork PR #10642 by @chuqijiang2026 so it can run CI from the main repo
(the fork branch conflicted with main). Authorship is preserved in git — the
commit's Author is @chuqijiang2026 and it carries a Co-authored-by: trailer.

Problem / Motivation

Goal: make the three remaining McpTab status-badge hints reachable by
keyboard, touch, and assistive technology instead of hover-only.

Three status badges in website/src/pages/overview/McpTab.tsx explained
themselves only through a hover-only native title:

  • the declared badge (tool list read from the package's declaration),
  • the ok badge's host-check caveat ("Online" is the gateway's own probe result),
  • the probe-failing badge.

A native title is unreachable by keyboard, touch, and assistive technology —
the exact gap #3626 identified and #3715 closed for the sibling needs_auth
badge in the same file. These three were left as a deferred follow-up (#8359).

Why it matters

The badges carry the only default-reachable explanation of what each status
means (e.g. "Online" is the gateway's probe result, not proof a session mounted
the server). A keyboard, touch, or screen-reader user cannot reach a hover-only
title, so that explanation is invisible to them.

Not a goal

Not changing which statuses carry a hint, nor adding new hints: mcpStatusHint
still returns a string only for ok and needs_auth, so error/outdated/
disabled get no hint. Not restyling the badges, the table, or the InfoTip
component — this only moves the existing hints onto the existing focusable
affordance.

What changed (motivation → approach → change)

  • Root cause: the shared focusable InfoTip affordance existed and was
    already used for needs_auth, but three sibling badges still used title.
  • Approach: reuse InfoTip at each site rather than inventing anything,
    matching the pattern fix(mcp): make needs-auth hint accessible #3715 established.
  • Change: each badge drops its title and renders an <InfoTip> (a
    focusable, tappable ? button) beside it. The ok hint stays a named
    exception — mcpStatusHint returns a string only for ok and needs_auth,
    so error/outdated/disabled get no hint (no title, no InfoTip), not a
    blanket hint on every badge. Ported onto main's current badge (which now
    derives its variant from disabledInConfigVariant(s) and labels invalid
    values), so the two changes coexist.

Tests

website/src/test/McpTab.test.tsx:

  • Updated the two existing tests that pinned the old title (ok host-check,
    probe-failing count) to assert the hint now opens from a focusable InfoTip,
    and that error/outdated/disabled carry neither a title nor an InfoTip.
  • Added a describe block pinning the InfoTip affordance on the declared and
    probe-failing badges, so a future regression to title fails here.

Verified locally against fresh origin/main: vitest run src/test/McpTab.test.tsx
→ 46 pass (includes main's own disabled-in-config suite); tsc --noEmit clean.

Pattern harvest

Rule candidate: a status/metadata hint whose only carrier is a hover-only native
title attribute is unreachable by keyboard, touch and assistive technology; UI
hints that convey meaning should ride the shared focusable InfoTip affordance
instead. This is the fourth McpTab badge to hit the same defect (#3626/#3715 for
needs_auth, now these three), so it is a generalizable, lint-worthy pattern —
flag a title= on a <Badge> (or similar status chip) that carries explanatory
text rather than a copy/label value.

Manual verification

Screenshots captured from this branch's HEAD (1c646f681) in a real browser
(the real McpTab component rendered against main's current badge), light and
dark. Each badge now exposes a focusable ? InfoTip button; a screen reader /
keyboard / touch user reaches the same hint a mouse hover used to show.

The fixture shows several Online rows, a Declared row, a Failing row
with its Reset count button, a disabled-in-config row, plus the
needs_auth and invalid-value rows — all with the ? affordance fitting the cell.

Full MCP tab — dark:

McpTab badge InfoTips — dark, HEAD 1c646f681

Full MCP tab — light:

McpTab badge InfoTips — light, HEAD 1c646f681

Declared badge's InfoTip open (keyboard-focused ?) — dark:

Declared InfoTip open, focus ring — dark

Declared badge's InfoTip open (keyboard-focused ?) — light:

Declared InfoTip open, focus ring — light

Related Issues

Fixes #8359
Follows up on #3715
Supersedes #10642 (credit: @chuqijiang2026)

@iamwhatever
iamwhatever requested a review from a team October 4, 2026 10:18
@iamwhatever
iamwhatever requested a review from a team as a code owner October 4, 2026 10:18
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 40c15d3889b60aa38c6a1981225d5041b422d8d3 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Line 734 of McpTab.tsx still puts the disabled-in-config / config-error chip's explanation in a hover-only title. That is the same defect, left in the same file.

What this change ships

Inventory (3 items) — 3 justified

Intent: let keyboard, touch and screen-reader users reach the explanations on three McpTab status badges (#8359). This is a FIX.

  1. The "Declared" badge's explanation moves from a hover tooltip to a focusable ? button beside it — justified
  2. Every "Online" badge now shows a ? button carrying the host-check caveat, which was hover-only before — justified
  3. The "Failing" badge's failure-count explanation moves from a hover tooltip to a ? button beside "Reset count" — justified

[FIRST-PRINCIPLES-REVIEWED] 40c15d3

Description read

[DESCRIPTION-READ] 1f7e1b7efa3e803a42202432ed3df57a595178ab835b7df421cf4ddb9d0d56e4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 40c15d3889b60aa38c6a1981225d5041b422d8d3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Every Online row now adds its own ? tab stop, and each one is named only "More information" with no row context. Check that this is acceptable on a long table.

[DESIGN-REVIEWED] 40c15d3

Description read

[DESCRIPTION-READ] 81ac35b6ca2dba5f671f7870b5039eb9c32801503560ed3c2f92f02fbdd8e40c

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 40c15d3889b60aa38c6a1981225d5041b422d8d3 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 40c15d3

Verdict parsed from the review's SHA-scoped output markers for commit 40c15d3889b60aa38c6a1981225d5041b422d8d3.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 40c15d3889b60aa38c6a1981225d5041b422d8d3: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 40c15d3889b60aa38c6a1981225d5041b422d8d3 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that the open "Failing" InfoTip shows the failure count clearly next to "Reset count". The screenshots only show the "Declared" tip open.

[UX-REVIEWED] 40c15d3

Description read

[DESCRIPTION-READ] 6dca29ef7425a8a7bd462db2e811216f2d8e94ea712c4a42b2fe1ba8ebff6f7f

That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 4, 2026
@github-actions

github-actions Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 40c15d3889b60aa38c6a1981225d5041b422d8d3 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 40c15d3

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 40c15d3889b60aa38c6a1981225d5041b422d8d3: <one-sentence reason>

The declared, ok (host-check caveat) and probe-failing status badges in
McpTab explained themselves only through a hover-only `title`, unreachable
by keyboard, touch and assistive technology — the same gap #3626/#3715 closed
for the needs_auth badge. Route each hint through the shared, focusable/tappable
InfoTip instead, matching that badge. The ok hint stays a named exception:
mcpStatusHint returns a string only for ok and needs_auth, so error/outdated/
disabled still get no hint (no title, no InfoTip).

Fixes #8359

(cherry picked from commit f890838)

Co-authored-by: chuqijiang2026 <318122400+chuqijiang2026@users.noreply.github.com>
@iamwhatever
iamwhatever force-pushed the fix/mcp-tab-badge-a11y-8359-main branch from 1c646f6 to 40c15d3 Compare October 4, 2026 11:29
@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 4, 2026
@chenmingwei23
chenmingwei23 merged commit 8034db5 into main Oct 4, 2026
98 checks passed
@chenmingwei23
chenmingwei23 deleted the fix/mcp-tab-badge-a11y-8359-main branch October 4, 2026 16:35
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y(mcp): three McpTab badges still carry hover-only title hints

2 participants