Repository navigation
fix(mcp): move three McpTab badge hints onto focusable InfoTips - #16749
Conversation
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Line 734 of What this change shipsInventory (3 items) — 3 justifiedIntent: let keyboard, touch and screen-reader users reach the explanations on three McpTab status badges (#8359). This is a FIX.
[FIRST-PRINCIPLES-REVIEWED] 40c15d3 Description read[DESCRIPTION-READ] 1f7e1b7efa3e803a42202432ed3df57a595178ab835b7df421cf4ddb9d0d56e4 That sha256 names the PR description this verdict read. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Every Online row now adds its own [DESIGN-REVIEWED] 40c15d3 Description read[DESCRIPTION-READ] 81ac35b6ca2dba5f671f7870b5039eb9c32801503560ed3c2f92f02fbdd8e40c That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that the open "Failing" InfoTip shows the failure count clearly next to "Reset count". The screenshots only show the "Declared" tip open. [UX-REVIEWED] 40c15d3 Description read[DESCRIPTION-READ] 6dca29ef7425a8a7bd462db2e811216f2d8e94ea712c4a42b2fe1ba8ebff6f7f That sha256 names everything this verdict read: the PR description, plus the 7 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
The declared, ok (host-check caveat) and probe-failing status badges in McpTab explained themselves only through a hover-only `title`, unreachable by keyboard, touch and assistive technology — the same gap #3626/#3715 closed for the needs_auth badge. Route each hint through the shared, focusable/tappable InfoTip instead, matching that badge. The ok hint stays a named exception: mcpStatusHint returns a string only for ok and needs_auth, so error/outdated/ disabled still get no hint (no title, no InfoTip). Fixes #8359 (cherry picked from commit f890838) Co-authored-by: chuqijiang2026 <318122400+chuqijiang2026@users.noreply.github.com>
1c646f6 to
40c15d3
Compare
Replaces fork PR #10642 by @chuqijiang2026 so it can run CI from the main repo
(the fork branch conflicted with
main). Authorship is preserved in git — thecommit's
Authoris @chuqijiang2026 and it carries aCo-authored-by:trailer.Problem / Motivation
Goal: make the three remaining
McpTabstatus-badge hints reachable bykeyboard, touch, and assistive technology instead of hover-only.
Three status badges in
website/src/pages/overview/McpTab.tsxexplainedthemselves only through a hover-only native
title:A native
titleis unreachable by keyboard, touch, and assistive technology —the exact gap #3626 identified and #3715 closed for the sibling
needs_authbadge in the same file. These three were left as a deferred follow-up (#8359).
Why it matters
The badges carry the only default-reachable explanation of what each status
means (e.g. "Online" is the gateway's probe result, not proof a session mounted
the server). A keyboard, touch, or screen-reader user cannot reach a hover-only
title, so that explanation is invisible to them.Not a goal
Not changing which statuses carry a hint, nor adding new hints:
mcpStatusHintstill returns a string only for
okandneeds_auth, soerror/outdated/disabledget no hint. Not restyling the badges, the table, or the InfoTipcomponent — this only moves the existing hints onto the existing focusable
affordance.
What changed (motivation → approach → change)
InfoTipaffordance existed and wasalready used for
needs_auth, but three sibling badges still usedtitle.InfoTipat each site rather than inventing anything,matching the pattern fix(mcp): make needs-auth hint accessible #3715 established.
titleand renders an<InfoTip>(afocusable, tappable
?button) beside it. Theokhint stays a namedexception —
mcpStatusHintreturns a string only forokandneeds_auth,so
error/outdated/disabledget no hint (notitle, no InfoTip), not ablanket hint on every badge. Ported onto
main's current badge (which nowderives its variant from
disabledInConfigVariant(s)and labels invalidvalues), so the two changes coexist.
Tests
website/src/test/McpTab.test.tsx:title(ok host-check,probe-failing count) to assert the hint now opens from a focusable InfoTip,
and that
error/outdated/disabledcarry neither atitlenor an InfoTip.probe-failing badges, so a future regression to
titlefails here.Verified locally against fresh
origin/main:vitest run src/test/McpTab.test.tsx→ 46 pass (includes
main's owndisabled-in-configsuite);tsc --noEmitclean.Pattern harvest
Rule candidate: a status/metadata hint whose only carrier is a hover-only native
titleattribute is unreachable by keyboard, touch and assistive technology; UIhints that convey meaning should ride the shared focusable
InfoTipaffordanceinstead. This is the fourth McpTab badge to hit the same defect (#3626/#3715 for
needs_auth, now these three), so it is a generalizable, lint-worthy pattern —flag a
title=on a<Badge>(or similar status chip) that carries explanatorytext rather than a copy/label value.
Manual verification
Screenshots captured from this branch's HEAD (
1c646f681) in a real browser(the real
McpTabcomponent rendered againstmain's current badge), light anddark. Each badge now exposes a focusable
?InfoTip button; a screen reader /keyboard / touch user reaches the same hint a mouse hover used to show.
The fixture shows several Online rows, a Declared row, a Failing row
with its Reset count button, a disabled-in-config row, plus the
needs_auth and invalid-value rows — all with the
?affordance fitting the cell.Full MCP tab — dark:
Full MCP tab — light:
Declared badge's InfoTip open (keyboard-focused
?) — dark:Declared badge's InfoTip open (keyboard-focused
?) — light:Related Issues
Fixes #8359
Follows up on #3715
Supersedes #10642 (credit: @chuqijiang2026)