Repository navigation
feat(chat): show loaded skills as markdown cards - #16788
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that legacy rows, recognised only by the exact [DESIGN-REVIEWED] b8fa754 Description read[DESCRIPTION-READ] 6bcd5b06715a024c305833a41a50bfeb18c6d3e9cde16c3667928277a1a474c6 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — 🟡 CONCERNSPremise-level review of First-Principles-Verdict: CONCERNS The capped skill body's bottom fade adds Not justified as shipped
What this change shipsInventory (9 items) — 7 justifiedIntent: let users read the exact skill instructions a
[FIRST-PRINCIPLES-REVIEWED] b8fa754 Description read[DESCRIPTION-READ] f7e2ae01beb1548e2de6ec012f29f2e809a02191bf083c573f45e8d4ffc82fcf That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS The first-time reader's take on the collapsed "Loaded skills" header was only "a guess", and the word "turn" in the new copy confused them. Watch
Suggestions
[UX-REVIEWED] b8fa754 Description read[DESCRIPTION-READ] 6d9eb716ac277b9ef7a81bcbc9e98344a72b25797dffc4939a6a54ba0684447e That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
61da41f to
3e62210
Compare
|
|
|
|
|
UX evidence follow-up: the legacy row was planted by hand with the exact old notice. The upgraded row is visible here: https://github.com/user-attachments/assets/22a59a4b-6030-40d2-b0a8-4bbec3712470 |
|
UX evidence follow-up: the two-skill state is now shown collapsed and expanded: https://github.com/user-attachments/assets/e08db939-7e81-4009-aaba-0d9259688f3a and https://github.com/user-attachments/assets/2d869e19-1df1-4cb2-9d9d-4ed646450ff9 |
|
|
|
|
Design follow-up: saving each redacted skill body in |
|
First Principles follow-up: the saved-body growth is accepted for this design because exact historical instructions are the feature, and existing skill count and read caps bound each row. The shared disclosure toggle is again a native |
|
3e62210 to
607adc1
Compare
|
The seven final screenshots are shown once in the PR body under Screenshots / video. |
1 similar comment
|
The seven final screenshots are shown once in the PR body under Screenshots / video. |
26138fb to
e7ef335
Compare
|
Re-reviewed at e7ef335. I checked the sanitization concern myself: skill bodies render through the shared MarkdownRenderer, the same one assistant messages use, with rehypeSanitize after rehypeRaw. So third-party skill text gets the same treatment as model output, and I'm dropping that concern. The new per-skill disclosure and the empty/legacy states look reasonable. I'm still holding because #16754 is still needs-investigation, so the product shape isn't accepted yet. Once a maintainer moves it out of investigation, I'll approve. I wrote two temporary diff scripts in the workspace and deleted them, so no files are left behind. |
|
Sweep 2026-10-06: the PR this one was stacked on (#16681) is now merged into main, and GitHub reports this branch as conflicting. Please rebase onto current main so only this PR's own commit remains; I will review and merge once PR Readiness is green on the new head. |
e7ef335 to
5adbe42
Compare
Snapshot redacted skill bodies in transcript metadata and render them inside a reusable, collapsed markdown disclosure card.
5adbe42 to
b8fa754
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (sweep 2026-10-06): full diff read after the rebase (now only this PR's own change), callers verified against current main, readiness passed, CI green. Product shape accepted on the owner's behalf: the one-line skill chip becomes a collapsed markdown card; bodies pass the same redaction as the block sent to the model and render through the sanitizing MarkdownRenderer. Approving and merging.
Problem / Motivation
Goal: Let users inspect the exact skill instructions loaded through the
$picker without expanding the transcript by default.A selected skill currently leaves one plain confirmation line. The transcript gives no way to inspect the instructions that entered that turn.
Why it matters
Users can verify which procedure guided a turn. The collapsed default keeps routine skill loads compact, while the saved body remains accurate after a skill changes or disappears.
Not a goal
$picker resolves or loads skills.What changed
Skills are reusable instruction documents that guide an agent turn. The card lets users verify those exact instructions without keeping them expanded in the transcript.
src/kiro_crew/dashboardwebsite/src/pages/chatandwebsite/src/app-sdkwebsite/src/i18nwebsite/src/testThe gateway attaches body snapshots to the existing system row, so expansion needs no later filesystem read. The frontend validates the metadata and falls back to a finished, non-interactive name-only card for older rows.
Saving the redacted body in history is intentional. It preserves the exact instructions used by the turn after a skill changes or disappears. Existing dollar-skill count and file-read caps bound each row, and the collapsed default prevents visual transcript growth.
The rendered body uses the existing sanitized markdown pipeline.
Backwards compatibility
Compatible: existing transcript rows retain their text and render as finished name-only cards when no body snapshot exists.
Removes nothing: skill selection, prompt injection, persisted rows, and older gateway payloads remain supported.
Tests
Manual verification
One isolated gateway ran from this worktree's own virtual environment. It used a fresh temporary home copied from the
minimalfixture, the standalone profile, disabled crons, a disabled tunnel, and the packaged fake ACP backend.The legacy prompt, exact legacy row, and a short assistant reply were planted by hand before gateway startup. The row was
📎 Loaded skill(s) via$: **legacy-explain-for**.The mixed-body prompt, structured row, and a short assistant reply were also planted before startup. The row contains one saved body and one empty body. A live load can produce this mix only when one resolved skill's body is empty, because
_expand_dollar_skillssaves a body for every resolved skill. The empty row says “This skill has no instructions”. A malformed row is not needed.Every other
$message was typed into the dashboard composer and sent with Enter. No message was posted directly to the chat API. Each screenshot confirms that the prompt bubble is visible above its card.The seven screenshots show the completed legacy turn, the collapsed multi-skill card under the visible header hover, both collapsed skill rows, one capped skill body with the other row still reachable, the unchanged single-skill body at desktop and 390 by 844, and the completed planted mixed turn. Geometry checks confirmed the active bottom fade, 15px H1, 14px H2, and no mobile horizontal overflow on commit
b8fa754cc792c4b0533465df9eb60b9fb9a66dc3.The gateway was stopped by its recorded PID. Its temporary home was deleted.
Screenshots / video
Before
After
Legacy name-only row
Two skills collapsed with header hover
Two skill rows collapsed
One skill row open
Single skill at desktop width
Single skill at 390 by 844
Mixed saved and empty bodies
Related Issues
Closes #16754
Checklist