Repository navigation
ci: backport Issue Gate workflow to release/0.8.0 - #16869
Conversation
PR Readiness reads main's lane list, which waits on an Issue Gate check. Issue Gate is a pull_request workflow, so GitHub reads it from the PR's merge ref, and release/0.8.0 has no issue-gate.yml. Every PR into the release branch therefore waits on a check that never starts. Copy .github/workflows/issue-gate.yml from main unchanged. Its grammar script is read from a checkout of the default branch at run time, so the workflow file is the only piece the release branch needs. Source: origin/main 2359397 (file last changed there in #16740; introduced by #16241, #16634, #16697). Fixes #16868
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Fable 5) — ✅ PASSDesign-level review of Design-Verdict: PASS Verify this PR's own Issue Gate run started and PR Readiness stopped reporting "not started" — the fix's only proof is its own checks tab. Suggestions
[DESIGN-REVIEWED] f09c1ec |
First Principles Review (Fable 5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Confirm the file is byte-identical to main @ Not justified as shipped
What this change shipsInventory (3 items) — 1 justifiedIntent: give PRs into
Defect provenance is linked (#16868, #16388) and self-verifying on this PR's own checks. The cause (readiness verdict computed from main's lane list, lanes read from the base branch) is named in the description and its general fix is excluded by the frozen Goal; every other lane main's release-cut list names exists on this branch (grepped [FIRST-PRINCIPLES-REVIEWED] f09c1ec |
Opus 5 Review — ✅ no blocking findingsReviewed Review detailsAdvisory only: the backport ships the gate file without the readiness enrolment and doc section its own header claims exist, so the advertised one-line enablement would produce a gate that cannot block. FINDING — .github/workflows/issue-gate.yml:29 — [OPUS-REVIEWED] f09c1ec Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
|
|
|
|
|
Problem / Motivation
Goal: a pull request into
release/0.8.0gets anIssue Gatecheck, soPR Readinesscan finish instead of waiting forever.Every PR into
release/0.8.0now sits onPR Readiness: pending — 1 readiness check(s) still pending; waiting on Issue Gate (not started), even with every other check green. #16388 shows it on head2d90fd42a0: 23 checks green, readiness pending for over an hour, and aneditedevent re-ran the otherpull_requestlanes but started no Issue Gate run.Why it matters
The 0.8 line is what users install. Every backport into it is blocked on a required status that can never pass, so each one needs a maintainer to merge past
PR Readiness.Not a goal
pr-readiness.ymllane list or the gate's rule.GATE_ENFORCED: "false"), exactly as on main..github/scripts/issue_gate_refs.pyor the prepare-pr scripts it imports (see below).What changed (motivation → approach → change)
release/0.8.0PR.PR Readinessruns onpull_request_target, so it reads main's lane list, which includesissue-gate.yml|Issue Gate.Issue Gateruns onpull_request, which GitHub reads from the PR's merge ref.issue-gate.ymllanded on main (ci: require every PR to reference a triaged issue #16241, ci(issue-gate): require exactly one tier label on the issue #16634, ci(issue-gate): gate on tier + triaged labels and pause it until the Captain scan runs #16697, docs(skills): rename prepare-pr, slim it and match current ci #16740) afterrelease/0.8.0was cut, so the release branch has no such workflow..github/workflows/issue-gate.ymlfromorigin/main@2359397574byte-for-byte. A cherry-pick of the four main commits is not clean (docs(skills): rename prepare-pr, slim it and match current ci #16740 is a large skill rename), so the file is taken whole.Only the workflow file is needed. Its job checks out
${{ github.event.repository.default_branch }}intobase/and runsbase/.github/scripts/issue_gate_refs.pyfrom there, so the grammar script and itspr_status.pyimport are always read from main, never from the release branch. A copy of them here would be dead code.Backwards compatibility
Compatible: this adds one CI check that is paused (passes without reading the PR). Nothing that works on
release/0.8.0today stops working.Tests
No new tests: workflow file only. The 60 test files under
test/that read.github/workflowspass on this tree (6382 passed, 2 skipped).Manual verification
This PR's own
Issue Gaterun is the check: it must start and pass, andPR Readinessmust stop naming it as "not started".Related Issues
Fixes #16868
Unblocks #16388 and every other PR into
release/0.8.0.Pattern harvest
Not generalizable: a one-off gap from a release branch cut before a new
pull_requestlane landed on main.Checklist