Repository navigation
fix(crewmate-chat): drop the per-run author line and avatar gutter - #16974
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing to check. [DESIGN-REVIEWED] 3483e33 Description read[DESCRIPTION-READ] ac7ae5b4244ba1c52fadf82825d1b5434f77311ad4c4dc0bf1c5f50caa8c74c2 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ human override accepted@CrysisDeu overrode this lane for |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Check that removing the always-visible time is acceptable: the blind reader "can't tell why the timestamp is missing in shot-01 but present in shot-02" (it only shows on hover). [UX-REVIEWED] 3483e33 Description read[DESCRIPTION-READ] 04792364b06d3beec7892abfe5b274f103885d6ca3a9e4c3bb189c472960fe0b That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
A crewmate's chat drew an author line (avatar + name + time) above the first bubble of every run and indented every bubble by a 38px avatar gutter. Since #15167 the DM header already shows the crewmate as one face + name chip, and the thread has exactly one speaker besides the user, so the row and the gutter repeated what the header says. CrewmateMessage now places the bubble alone, in the full text column; consecutive messages still read as one speaker through the grouped corners crewmateBubbleClass paints along a run. With the author line gone two bordered bubbles 2px apart read as one surface with a seam, so bubbles inside a run sit 6px apart and a run opens with 12px. The message time stays where the single chat has it: in the footer row of the run's last bubble (hover-revealed, always shown under hover:none). CREWMATE_AVATAR_PX loses its only consumer and goes; opensCrewmateRun stays (ThreadPanel and the corner rule read it). The module comment, the crew-mode spec and the feature map describe the run without the author line. Evidence harness: website/capture/crewmate-run.{html,tsx} renders the real ChatMessageList + crewmate renderers with a two-bubble run; scripts/capture-crewmate-run.mjs asserts no author row / gutter (or, with --expect-author, the pre-change shape for the before frame); scripts/capture-crewmate-run-members.mjs shoots the real Members page (header identity pill + thread + hover footer time). The members-page capture entry gains the ThemeProvider the drawer's CrewDashboardFrame needs; it threw on mount without one. Closes #16617
7973055 to
3483e33
Compare
|
Dispositions for round 1 ( First Principles — BLOCK, items 1 & 2 (product-shape change, no RFC) — Design — PASS, "crewmate replies may now show no time anywhere" and UX — "Message times are now gone entirely" — UX — "The screenshots crop out the DM header" — |
Human judgment recorded@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for
This decision applies only to this commit. A new push requires a new judgment. |
iamwhatever
left a comment
There was a problem hiding this comment.
The change is clean and does what #16617 asks. The header chip already names the crewmate, the run corners still group a turn, and the time stays in the footer, which keyboard focus reveals. One small accessibility nit: screen-reader users no longer hear the crewmate's name per run, because nothing in the transcript labels the speaker. Consider a visually hidden name on each run's first bubble, as a follow-up is fine. The author triaged this T3 issue himself, so this approval also serves as the independent maintainer sign-off on the product decision. Approving.
Problem / Motivation
Goal: A crewmate's chat shows each reply as a bubble alone, without repeating the crewmate's face, name and a time above every run.
Every run of crewmate messages opened with an author line — the crewmate's avatar, its name and the message time — and every bubble in the run was indented by a 38px avatar gutter. Since #15167 the DM header already shows the crewmate as one face + name chip, and the thread has exactly one speaker besides the user, so the row and the gutter repeated what the header says (Zezhen, 2026-10-03: "crew mate chat 里面不需要再加 avatar、matename 和时间那一行了,因为重复了").
Why it matters
Every run cost a row of chrome and a left gutter that carried no new information, and a user reading the thread saw the same face twice on screen. Left as is, the duplication grows with every reply.
Not a goal
ThreadPanelkeeps readingopensCrewmateRun.crewmateRunPosition,crewmateBubbleClass) is unchanged.What changed (motivation → approach → change)
CrewmateMessagedrew acrewmate-authorrow (CrewAvataratCREWMATE_AVATAR_PX, the label,fmtMessageTime) wheneveropensCrewmateRun(pos)was true and wrapped every bubble in apl-[38px]gutter. Both repeat the header chip.The component now places the bubble alone in the row its run position dictates (
crewmateRowClass), in the full text column. Consecutive messages still read as one speaker through the grouped corners the run rule paints. Thecrewmateandtsprops go with the row;transcriptRendererspasses onlypos. The time is not lost:renderAssistantBubblealready passestimestampinto the footer of the run's last bubble (forceFooteronsingle/end), hover-revealed and always visible under hover:none, exactly as on the single-chat page.CREWMATE_AVATAR_PXlost its only consumer and is removed;CrewmateIdentitystays exported because the pane, the Members page and the renderer's presence check on it still route a chat through the crewmate bubble.Without the author line, two bordered bubbles 2px apart read as one surface with a seam, so
crewmateRowClassnow gives bubbles inside a run 6px and a run opener 12px — the only thing separating two turns.crewmateBubbles.tsrule 2,docs/system-specs/modules/crew-mode.md(the file table and the "How it is drawn" paragraph) and the twodocs/feature-map/README.mdrows describe the run without the author line. A new capture pagewebsite/capture/crewmate-run.{html,tsx}renders the realChatMessageList+ crewmate renderers with a two-bubble run, andwebsite/scripts/capture-crewmate-run.mjsasserts the shape (no author row, no gutter;--expect-authorasserts the pre-change shape for the before frame).website/scripts/capture-crewmate-run-members.mjsshoots the real Members page throughcapture/members-page.html(header identity pill + thread + the hover footer time); that entry gains theThemeProviderthe drawer'sCrewDashboardFramereads, without which it threw on mount.This is a product-shape change (a removed user-facing element) with no RFC: it executes a maintainer decision recorded on #16617, so the First Principles lane needs a maintainer override.
Backwards compatibility
Compatible: a rendering-only change; no API, transcript or storage shape changes.
CrewmateMessagedrops two props that onlytranscriptRenderers.tsxpassed (updated in this diff).Reader:
website/src/pages/chat/transcriptRenderers.tsx:CrewmateMessage-- crew page -- now passes onlypos;tsc --noEmitclean.Reader:
website/src/test/CrewmateMessage.test.tsx:CREWMATE_AVATAR_PX-- crew page (test) -- rewritten to assert no author row / gutter at every run position.Reader:
website/src/pages/members/ThreadPanel.tsx:opensCrewmateRun-- crew page -- unchanged; the helper stays exported.Tests
website/src/test/CrewmateMessage.test.tsx(rewritten): at every run position (single/start/cont/end) nocrewmate-authorrow, no avatar, no[title]time element; the bubble is the row's only child and nopl-[gutter class is present; the row carriescrewmateRowClass(pos).website/src/components/chat/crewmateBubbles.test.ts:crewmateRowClasspinsmt-1.5inside a run andmt-3on a run opener; the run / corner rule tests are untouched and still pass.Manual verification
tsc --noEmit,eslinton the changed files: clean.node scripts/capture-crewmate-run.mjs http://127.0.0.1:6882 <out> afteron this head: all checks OK, both themes; the same script with--expect-authoragainst anorigin/mainworktree: all checks OK (that is the before frame).node scripts/capture-crewmate-run-members.mjs http://127.0.0.1:6882 <out>: all checks OK, both themes (identity pill names Radar; no author row; hover on the run's last bubble shows its time).Screenshots / video
The real Members page thread (dark): the header pill names the speaker, bubbles alone below it; then the pointer on the run's last bubble, footer row with the time:
Transcript only, dark, before → after:
Light: Members page, hover, and transcript before → after
Related Issues
Closes #16617
Pattern harvest
Not generalizable: a deliberate layout decision made redundant by a later header change (#15167), not a defect class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)