Skip to content

fix(crewmate-chat): drop the per-run author line and avatar gutter - #16974

Merged
iamwhatever merged 1 commit into
mainfrom
fix/crewmate-author-line
Oct 5, 2026
Merged

iamwhatever merged 1 commit into
mainfrom
fix/crewmate-author-line

Conversation

@CrysisDeu

@CrysisDeu CrysisDeu commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: A crewmate's chat shows each reply as a bubble alone, without repeating the crewmate's face, name and a time above every run.

Every run of crewmate messages opened with an author line — the crewmate's avatar, its name and the message time — and every bubble in the run was indented by a 38px avatar gutter. Since #15167 the DM header already shows the crewmate as one face + name chip, and the thread has exactly one speaker besides the user, so the row and the gutter repeated what the header says (Zezhen, 2026-10-03: "crew mate chat 里面不需要再加 avatar、matename 和时间那一行了,因为重复了").

Why it matters

Every run cost a row of chrome and a left gutter that carried no new information, and a user reading the thread saw the same face twice on screen. Left as is, the duplication grows with every reply.

Not a goal

What changed (motivation → approach → change)

CrewmateMessage drew a crewmate-author row (CrewAvatar at CREWMATE_AVATAR_PX, the label, fmtMessageTime) whenever opensCrewmateRun(pos) was true and wrapped every bubble in a pl-[38px] gutter. Both repeat the header chip.

The component now places the bubble alone in the row its run position dictates (crewmateRowClass), in the full text column. Consecutive messages still read as one speaker through the grouped corners the run rule paints. The crewmate and ts props go with the row; transcriptRenderers passes only pos. The time is not lost: renderAssistantBubble already passes timestamp into the footer of the run's last bubble (forceFooter on single/end), hover-revealed and always visible under hover:none, exactly as on the single-chat page. CREWMATE_AVATAR_PX lost its only consumer and is removed; CrewmateIdentity stays exported because the pane, the Members page and the renderer's presence check on it still route a chat through the crewmate bubble.

Without the author line, two bordered bubbles 2px apart read as one surface with a seam, so crewmateRowClass now gives bubbles inside a run 6px and a run opener 12px — the only thing separating two turns. crewmateBubbles.ts rule 2, docs/system-specs/modules/crew-mode.md (the file table and the "How it is drawn" paragraph) and the two docs/feature-map/README.md rows describe the run without the author line. A new capture page website/capture/crewmate-run.{html,tsx} renders the real ChatMessageList + crewmate renderers with a two-bubble run, and website/scripts/capture-crewmate-run.mjs asserts the shape (no author row, no gutter; --expect-author asserts the pre-change shape for the before frame). website/scripts/capture-crewmate-run-members.mjs shoots the real Members page through capture/members-page.html (header identity pill + thread + the hover footer time); that entry gains the ThemeProvider the drawer's CrewDashboardFrame reads, without which it threw on mount.

This is a product-shape change (a removed user-facing element) with no RFC: it executes a maintainer decision recorded on #16617, so the First Principles lane needs a maintainer override.

Backwards compatibility

Compatible: a rendering-only change; no API, transcript or storage shape changes. CrewmateMessage drops two props that only transcriptRenderers.tsx passed (updated in this diff).

Reader: website/src/pages/chat/transcriptRenderers.tsx:CrewmateMessage -- crew page -- now passes only pos; tsc --noEmit clean.
Reader: website/src/test/CrewmateMessage.test.tsx:CREWMATE_AVATAR_PX -- crew page (test) -- rewritten to assert no author row / gutter at every run position.
Reader: website/src/pages/members/ThreadPanel.tsx:opensCrewmateRun -- crew page -- unchanged; the helper stays exported.

Tests

  • website/src/test/CrewmateMessage.test.tsx (rewritten): at every run position (single/start/cont/end) no crewmate-author row, no avatar, no [title] time element; the bubble is the row's only child and no pl-[ gutter class is present; the row carries crewmateRowClass(pos).
  • website/src/components/chat/crewmateBubbles.test.ts: crewmateRowClass pins mt-1.5 inside a run and mt-3 on a run opener; the run / corner rule tests are untouched and still pass.

Manual verification

  • tsc --noEmit, eslint on the changed files: clean.
  • node scripts/capture-crewmate-run.mjs http://127.0.0.1:6882 <out> after on this head: all checks OK, both themes; the same script with --expect-author against an origin/main worktree: all checks OK (that is the before frame).
  • node scripts/capture-crewmate-run-members.mjs http://127.0.0.1:6882 <out>: all checks OK, both themes (identity pill names Radar; no author row; hover on the run's last bubble shows its time).

Screenshots / video

The real Members page thread (dark): the header pill names the speaker, bubbles alone below it; then the pointer on the run's last bubble, footer row with the time:

members thread after, dark: identity pill in the header, bubbles without author line
members thread after, dark, hovering the last bubble: footer with the message time

Transcript only, dark, before → after:

crewmate chat before, dark: avatar + name + time above each run, bubbles indented
crewmate chat after, dark: bubbles alone, full text column

Light: Members page, hover, and transcript before → after

members thread after, light
members thread after, light, hover footer time

crewmate chat before, light
crewmate chat after, light

Related Issues

Closes #16617

Pattern harvest

Not generalizable: a deliberate layout decision made redundant by a later header change (#15167), not a defect class.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@CrysisDeu
CrysisDeu requested a review from a team as a code owner October 5, 2026 08:33
@CrysisDeu
CrysisDeu requested a review from buluoray October 5, 2026 08:33
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Nothing to check.

[DESIGN-REVIEWED] 3483e33

Description read

[DESCRIPTION-READ] ac7ae5b4244ba1c52fadf82825d1b5434f77311ad4c4dc0bf1c5f50caa8c74c2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ human override accepted

@CrysisDeu overrode this lane for 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f via /ai-review override (this commit only).

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: PASS

Check that removing the always-visible time is acceptable: the blind reader "can't tell why the timestamp is missing in shot-01 but present in shot-02" (it only shows on hover).

[UX-REVIEWED] 3483e33

Description read

[DESCRIPTION-READ] 04792364b06d3beec7892abfe5b274f103885d6ca3a9e4c3bb189c472960fe0b

That sha256 names everything this verdict read: the PR description, plus the 11 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3483e33

Verdict parsed from the review's SHA-scoped output markers for commit 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f: <one-sentence reason>

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3483e33

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f: <one-sentence reason>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention labels Oct 5, 2026
A crewmate's chat drew an author line (avatar + name + time) above the
first bubble of every run and indented every bubble by a 38px avatar
gutter. Since #15167 the DM header already shows the crewmate as one
face + name chip, and the thread has exactly one speaker besides the
user, so the row and the gutter repeated what the header says.

CrewmateMessage now places the bubble alone, in the full text column;
consecutive messages still read as one speaker through the grouped
corners crewmateBubbleClass paints along a run. With the author line
gone two bordered bubbles 2px apart read as one surface with a seam, so
bubbles inside a run sit 6px apart and a run opens with 12px. The
message time stays where the single chat has it: in the footer row of
the run's last bubble (hover-revealed, always shown under hover:none).
CREWMATE_AVATAR_PX loses its only consumer and goes; opensCrewmateRun
stays (ThreadPanel and the corner rule read it). The module comment,
the crew-mode spec and the feature map describe the run without the
author line.

Evidence harness: website/capture/crewmate-run.{html,tsx} renders the
real ChatMessageList + crewmate renderers with a two-bubble run;
scripts/capture-crewmate-run.mjs asserts no author row / gutter (or,
with --expect-author, the pre-change shape for the before frame);
scripts/capture-crewmate-run-members.mjs shoots the real Members page
(header identity pill + thread + hover footer time). The members-page
capture entry gains the ThemeProvider the drawer's CrewDashboardFrame
needs; it threw on mount without one.

Closes #16617
@CrysisDeu
CrysisDeu force-pushed the fix/crewmate-author-line branch from 7973055 to 3483e33 Compare October 5, 2026 09:57
@CrysisDeu

Copy link
Copy Markdown
Contributor Author

Dispositions for round 1 (797305565a), carried to 3483e33dd2 (the two commits squashed into one; same diff plus the Members-page evidence harness).

First Principles — BLOCK, items 1 & 2 (product-shape change, no RFC) — needs-a-decision. The removal executes the maintainer's decision recorded on #16617 (reported by @CrysisDeu, triaged tier:T3 → triaged). rfc-crewmates-launch.md:227 does describe the author line; the DM header identity pill (#15167) landed after it and made the row redundant. An RFC amendment shipped in this PR would not count for this lane, so the path is the maintainer override: /ai-review override first-principles 3483e33dd2: author line duplicates the #15167 header pill; decided on #16617. Item 2 is also factually answered below.

Design — PASS, "crewmate replies may now show no time anywhere" and UX — "Message times are now gone entirely" — rebutted. The time is not gone. renderAssistantBubble passes timestamp/timestampTitle into every crewmate bubble; AssistantMessage draws it in the footer action row of the run's last bubble (forceFooter on single/end), hover-revealed on pointer devices and always visible under hover:none — exactly the single-chat page's affordance. What the PR removes is the author line's second, always-visible copy. The PR body's earlier sentence ("the author line was the only place a crewmate bubble showed its timestamp") was wrong and is corrected. Evidence: members-dark-hover.png / members-light-hover.png in the body, produced by scripts/capture-crewmate-run-members.mjs, which asserts the footer time is rendered at opacity 1 after hovering the run's last bubble.

UX — "The screenshots crop out the DM header" — fixed. Added the real Members-page frames (members-dark.png, members-light.png): the header identity pill (member-identity-pill, "Radar") above the thread with its bubbles. The harness asserts the pill is present and names the crewmate. Fixing it surfaced that capture/members-page.tsx threw on mount (the drawer's CrewDashboardFrame reads useTheme() with no provider); the entry now wraps MembersPage in ThemeProvider, in this diff.

@CrysisDeu

Copy link
Copy Markdown
Contributor Author

/ai-review override first-principles 3483e33: author line duplicates the #15167 header pill; decided on #16617

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Human judgment recorded

@CrysisDeu marked the first-principles AI finding as false positive, not applicable, or explicitly accepted for 3483e33dd29d73c16b68f2a776a5e7ecbfeb120f.

author line duplicates the #15167 header pill; decided on #16617

This decision applies only to this commit. A new push requires a new judgment.

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Oct 5, 2026

@iamwhatever iamwhatever left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is clean and does what #16617 asks. The header chip already names the crewmate, the run corners still group a turn, and the time stays in the footer, which keyboard focus reveals. One small accessibility nit: screen-reader users no longer hear the crewmate's name per run, because nothing in the transcript labels the speaker. Consider a visually hidden name on each run's first bubble, as a follow-up is fine. The author triaged this T3 issue himself, so this approval also serves as the independent maintainer sign-off on the product decision. Approving.

@iamwhatever
iamwhatever enabled auto-merge (squash) October 5, 2026 16:15
@iamwhatever
iamwhatever merged commit ef61a9a into main Oct 5, 2026
98 of 99 checks passed
@iamwhatever
iamwhatever deleted the fix/crewmate-author-line branch October 5, 2026 16:19
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crewmate chat: drop the per-run author line (avatar + name + time)

2 participants