Repository navigation
fix(sidebar): sit the folder disclosure chevron in a notch inside the glyph - #17047
Conversation
Design Review (Opus 5.5, fork) — ✅ PASSDesign-level review of Design-Verdict: PASS Check that the notch geometry still looks right at the larger [DESIGN-REVIEWED] bae9195 Description read[DESCRIPTION-READ] 81c7e972d1f51560a12e9ff22e131191d4760b87832cfd011a054e0676107aee That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5, fork) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Check the emoji-row screenshots before merging. The notch now cuts into every emoji icon, close to what What this change shipsInventory (6 items) — 6 justifiedIntent: make the open/closed chevron on a sidebar folder row look like a clean badge on the icon instead of a smudge running into the name. FIX (#17046).
[FIRST-PRINCIPLES-REVIEWED] bae9195 Description read[DESCRIPTION-READ] 90ec58f761736b3e21d87ad8af2880a737582bb0d1df9f0e0857687771e9252f That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5, fork) — 🟡 CONCERNSUX-level review of UX-Verdict: CONCERNS On colored, hovered and emoji folders the notch shows as a visible bite or disc edge, not a clean cutout. Every state is shown, but no first-time reader has seen any of them. Watch
[UX-REVIEWED] bae9195 Description read[DESCRIPTION-READ] ef0a614e8e27d3a3bd8da86c9997b4d99cd3c5508115ba36fef467c573cacb14 That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review (fork) — ✅ no blocking findingsReviewed |
|
self-added: no
|
a777d9f to
062690a
Compare
|
Rebased onto main a92dde1 (was a97659d), same diff, no code change. The rebase reruns the lanes that did not finish on a777d9f: GPT 6.1 Review ran for about an hour without posting, Cross-Platform Portability was cancelled when its checkout hit the 5-minute job limit, and Backend Tests (Windows) 4 and 6 failed in test_stale_asset_watchdog.py and test_subagent_queue_max_wait.py. This PR only touches frontend files, and main's CI passed both shards. It also lets UX Review read the light-theme and hover screenshots added to the description. |
GPT 6.1 Review (fork) — ✅ no blocking findingsReviewed Review detailsNo findings. |
|
self-added: yes
|
062690a to
8eb3b0b
Compare
|
Rebased: main moved in website/src/components (VoiceDisabledModal.tsx, same directory) since this head went green (a92dde1 -> 6f70008); CI re-running. No code change. Related vitest (FolderGlyph, folder alignment, chevron grammar, VoiceDisabledModal) and tsc pass on the new head. On 062690a: GPT 6.1 Review ran about 45 minutes without posting, as on the previous head. Backend Tests (Windows) 6 failed in test_subagent_queue_max_wait.py::TestEveryWaitingRowExpires::test_a_row_without_a_durable_queue_is_bounded_too. That is a different test in the same file as the round before (the file landed on main in #16347 today). This PR does not touch backend code. This push also lets UX Review read the emoji and colored-folder screenshots now in the description. |
|
self-added: yes
|
|
The only check left on 8eb3b0b is Frontend Coverage Merge in CI run 37352773635 (job 111931326377). It has been queued on ubuntu-latest since 18:57Z, while runners keep picking up jobs from newer CI runs, so it looks orphaned. Its frontend-test shards all passed. As a fork contributor I cannot re-run it. Could a maintainer re-run that job? |
8eb3b0b to
dc9bfa2
Compare
|
Pushed c44508a, which has the same tree as 9afb41c. Only the commit timestamp changed. On 9afb41c the reds were again tests outside this PR's four files, each a different test from the previous run:
The previous run failed on a different ChatInput Lexical test (lexicalUndo) and a different Windows shard 8 test (test_subagent_memory_wake). CI needs approve-and-run again. |
c44508a to
c40fc15
Compare
|
Pushed c40fc15: the same single commit rebased onto current main (791b10a), with no code change (range-diff is identical to c44508a). On c44508a the only real failures were four tests in |
c40fc15 to
70a0105
Compare
|
Pushed 70a0105, which has the same tree as c40fc15. Only the commit timestamp changed. On c40fc15 the reds were runner failures outside this PR's four files:
CI needs approve-and-run again. |
70a0105 to
bae9195
Compare
|
Pushed bae9195, which has the same tree as 70a0105. Only the commit timestamp changed. On 70a0105 all four review lanes passed. The reds were tests outside this PR's four files, none of which touch Python:
CI needs approve-and-run again. |
|
This moves the folder disclosure chevron inside the glyph box and cuts a round radial-gradient mask notch under it, so the chevron no longer crosses the outline or crowds the name. The code is small and correct for that. The chevron stays inside the 12px box, folder-alignment geometry is untouched, and the coverage-baseline line is removed correctly. HOLD because it is an open visual/product decision, not a code defect. The UX lane has raised the same CONCERNS on every head, including the current one, bae9195. On coloured, hovered and emoji folders the notch shows as a visible disc or bite (attachments 03 and 04). The author's dispositions say that keeping the cutout on filled glyphs or dropping it "is a product choice the PR author is deciding", and no disposition exists yet for the current head. A maintainer should look at the screenshots and choose: notch everywhere, or no notch on filled/emoji glyphs. After that, a final disposition on this head will close it. The CI reds over recent heads were unrelated flakes, and the current head is green. — crew-pr-reviewer |
self-added: yes mechanism: round notch masked out of the folder glyph under the disclosure chevron
@iamwhatever the call is notch everywhere; this is the final disposition for bae9195. |
bolichen97
left a comment
There was a problem hiding this comment.
Reviewed on behalf of the maintainers (sweep 2026-10-09): readiness passed, required checks green on bae9195, no blocking review threads, security posture unchanged. Approving and merging.
Problem / Motivation
Goal: The open/closed chevron on a sidebar folder row reads as a clean badge on the folder icon instead of a smudge between the icon and the name.
The chevron added for #11269 is drawn on top of the 12px folder outline and hangs about 4px past the glyph box, so it touches the first letter of the folder name. On the pinned folder header it looks like a stray mark.
Why it matters
Every folder row without an emoji icon shows it, in every theme, and the pinned header at the top of the lane shows it all the time. The sidebar is the first thing a user sees.
Not a goal
ChatSidebar.folderAlignment.test.tsxfix the glyph box width and the name column, and this PR leaves them alone.openstill get it, callers that omit it still get the bare glyph.What changed (motivation → approach → change)
The chevron was a 7px
ChevronRightwith stroke 3, pinned at-bottom-0.5 -right-1. That spot is on the folder outline and partly outside the box.The chevron now sits inside the glyph box's bottom-right corner, and the folder shape has a round notch cut under it with a CSS radial-gradient mask. A mask works on any row background (hover, pinned header, every theme), where a backing disc in the row color would not. The chevron is 9px with stroke 2.5, and its ink stays inside the 12px box. The same notch applies to emoji icons.
The geometry lives in
folderDisclosureNotchinfolderColorPaint.ts, the paint-only module that the i18n literal gate already exempts, soFolderGlyph.tsxstays fully covered by that gate. The new test coversfolderColorPaint.tsfully, so its entry comes out of.github/coverage-baselines/frontend.txt, as the per-file coverage gate requires once a baselined file meets the floor.Backwards compatibility
Compatible: same props, same box size, same
-disclosuretest id. The glyph gains a-shapetest id on the masked element.Removes nothing: the chevron, its rotation and every caller stay as they were.
Tests
FolderGlyph.disclosureCue.test.tsxchecks that the lucide and emoji shapes carry the notch mask whenopenis passed, that the chevron is centred on the notch, and that the chevron's ink stays inside the glyph box. The bare-glyph case checks that no mask is applied. The folder alignment and chevron grammar suites pass unchanged.Manual verification
Built the SPA and ran
website/scripts/capture-folder-glyph.mjson main and on this branch, plus 6x row captures of emoji, plain and colored folders, collapsed and expanded, in the light and dark themes, at rest and hovered. Emoji folders and a colored folder were captured with the Twemoji font installed.Screenshots / video
Rows at 6x device scale. Left is main, right is this branch.
Light and dark themes, at rest and hovered (left to right: light rest, light hover, dark rest, dark hover). The chevron stays readable in all four.
Close-up of one collapsed row (light rest, light hover, dark hover). On a hovered row the folder's own fill differs from the row colour, so the notch edge shows as a curve in the fill. The chevron sits on the row colour.
Emoji folders ("Kiro", "Sidebar", "Design") and a blue folder ("Infra"), at rest. Columns: light main, light branch, dark main, dark branch. On main the chevron hangs off the emoji's corner into the name gap. On the branch it sits in a cutout of the emoji, the same way it does on the folder shape.
Every row on the branch: emoji, plain and colored folders, collapsed and expanded. Columns: light rest, light hover, dark rest, dark hover.
Full sidebar, before and after
Related Issues
Closes #17046
Pattern harvest
Not generalizable: a one-off icon placement. The fix is specific to an overlay on a 12px glyph.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)