Skip to content

fix(sidebar): sit the folder disclosure chevron in a notch inside the glyph - #17047

Merged
bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/sidebar-folder-chevron
Oct 9, 2026
Merged

bolichen97 merged 1 commit into
kirodotdev:mainfrom
Pearcekieser:fix/sidebar-folder-chevron

Conversation

@Pearcekieser

@Pearcekieser Pearcekieser commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: The open/closed chevron on a sidebar folder row reads as a clean badge on the folder icon instead of a smudge between the icon and the name.

The chevron added for #11269 is drawn on top of the 12px folder outline and hangs about 4px past the glyph box, so it touches the first letter of the folder name. On the pinned folder header it looks like a stray mark.

Why it matters

Every folder row without an emoji icon shows it, in every theme, and the pinned header at the top of the lane shows it all the time. The sidebar is the first thing a user sees.

Not a goal

  • Moving the chevron out of the glyph box or in front of it. The folder alignment guides in ChatSidebar.folderAlignment.test.tsx fix the glyph box width and the name column, and this PR leaves them alone.
  • Changing when the chevron appears. Callers that pass open still get it, callers that omit it still get the bare glyph.
  • Redrawing emoji folder icons.

What changed (motivation → approach → change)

The chevron was a 7px ChevronRight with stroke 3, pinned at -bottom-0.5 -right-1. That spot is on the folder outline and partly outside the box.

The chevron now sits inside the glyph box's bottom-right corner, and the folder shape has a round notch cut under it with a CSS radial-gradient mask. A mask works on any row background (hover, pinned header, every theme), where a backing disc in the row color would not. The chevron is 9px with stroke 2.5, and its ink stays inside the 12px box. The same notch applies to emoji icons.

The geometry lives in folderDisclosureNotch in folderColorPaint.ts, the paint-only module that the i18n literal gate already exempts, so FolderGlyph.tsx stays fully covered by that gate. The new test covers folderColorPaint.ts fully, so its entry comes out of .github/coverage-baselines/frontend.txt, as the per-file coverage gate requires once a baselined file meets the floor.

Backwards compatibility

Compatible: same props, same box size, same -disclosure test id. The glyph gains a -shape test id on the masked element.

Removes nothing: the chevron, its rotation and every caller stay as they were.

Tests

FolderGlyph.disclosureCue.test.tsx checks that the lucide and emoji shapes carry the notch mask when open is passed, that the chevron is centred on the notch, and that the chevron's ink stays inside the glyph box. The bare-glyph case checks that no mask is applied. The folder alignment and chevron grammar suites pass unchanged.

Manual verification

Built the SPA and ran website/scripts/capture-folder-glyph.mjs on main and on this branch, plus 6x row captures of emoji, plain and colored folders, collapsed and expanded, in the light and dark themes, at rest and hovered. Emoji folders and a colored folder were captured with the Twemoji font installed.

Screenshots / video

Rows at 6x device scale. Left is main, right is this branch.

before-after

Light and dark themes, at rest and hovered (left to right: light rest, light hover, dark rest, dark hover). The chevron stays readable in all four.

light and dark, rest and hover

Close-up of one collapsed row (light rest, light hover, dark hover). On a hovered row the folder's own fill differs from the row colour, so the notch edge shows as a curve in the fill. The chevron sits on the row colour.

notch close-up

Emoji folders ("Kiro", "Sidebar", "Design") and a blue folder ("Infra"), at rest. Columns: light main, light branch, dark main, dark branch. On main the chevron hangs off the emoji's corner into the name gap. On the branch it sits in a cutout of the emoji, the same way it does on the folder shape.

emoji and colored folders, before and after

Every row on the branch: emoji, plain and colored folders, collapsed and expanded. Columns: light rest, light hover, dark rest, dark hover.

all variants on the branch

Full sidebar, before and after

before
after

Related Issues

Closes #17046

Pattern harvest

Not generalizable: a one-off icon placement. The fix is specific to an overlay on a 12px glyph.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

@Pearcekieser
Pearcekieser requested a review from a team as a code owner October 5, 2026 16:06
@github-actions github-actions Bot added fork Pull request from a fork (external contributor) readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5, fork) — ✅ PASS

Design-level review of bae91958ea1dc1f4f6677ac7d083bd45b13023ea via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

Design-Verdict: PASS

Check that the notch geometry still looks right at the larger size values other callers pass, not only the 12px row shown in the screenshots.

[DESIGN-REVIEWED] bae9195

Description read

[DESCRIPTION-READ] 81c7e972d1f51560a12e9ff22e131191d4760b87832cfd011a054e0676107aee

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5, fork) — ✅ PASS

Premise-level review of bae91958ea1dc1f4f6677ac7d083bd45b13023ea via the fork AI-review pipeline — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

First-Principles-Verdict: PASS

Check the emoji-row screenshots before merging. The notch now cuts into every emoji icon, close to what Not a goal rules out ("Redrawing emoji folder icons").

What this change ships

Inventory (6 items) — 6 justified

Intent: make the open/closed chevron on a sidebar folder row look like a clean badge on the icon instead of a smudge running into the name. FIX (#17046).

  1. The chevron moves from hanging past the glyph's corner to sitting inside its bottom-right corner — justified
  2. The chevron is larger (7px→9px) with a thinner stroke (3→2.5) — justified
  3. The folder outline gets a round cutout under the chevron — justified
  4. Emoji folder icons get the same cutout under the chevron — justified
  5. A -shape test id is added on the masked element — justified
  6. folderColorPaint.ts comes off the frontend coverage baseline — justified

[FIRST-PRINCIPLES-REVIEWED] bae9195

Description read

[DESCRIPTION-READ] 90ec58f761736b3e21d87ad8af2880a737582bb0d1df9f0e0857687771e9252f

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5, fork) — 🟡 CONCERNS

UX-level review of bae91958ea1dc1f4f6677ac7d083bd45b13023ea via the fork AI-review pipeline — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS/CONCERNS are advisory.

UX-Verdict: CONCERNS

On colored, hovered and emoji folders the notch shows as a visible bite or disc edge, not a clean cutout. Every state is shown, but no first-time reader has seen any of them.

Watch

  • The notch shows as a second shape. The shape is masked with radial-gradient(circle at ${centre}px ..., transparent ${radius}px ...), and wherever the folder's own fill differs from the row colour, the hole shows that edge. On "Infra" (dark, branch), attachment-04 shows a dark disc bulging past the blue outline. In attachment-03, hovered light rows show a pale crescent. On "Design" and "Sidebar", attachment-04 shows a chunk bitten out of the emoji. So instead of reading as a badge, the chevron can read as a stain or a broken emoji, which is close to the smudge this PR is meant to remove. Severity is low to moderate: it appears on every colored or emoji folder row and stays there, but it is cosmetic and nothing stops working. Smallest fix: shrink the notch radius on emoji and colored glyphs, or keep the wash fill out of the moat, so that only the row colour shows inside the notch.

[UX-REVIEWED] bae9195

Description read

[DESCRIPTION-READ] ef0a614e8e27d3a3bd8da86c9997b4d99cd3c5508115ba36fef467c573cacb14

That sha256 names everything this verdict read: the PR description, plus the 10 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review (fork) — ✅ no blocking findings

Reviewed bae91958ea1dc1f4f6677ac7d083bd45b13023ea via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] bae9195

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: no

fixed (evidence only, no code change): the description now has light and dark rows at rest and hovered, plus a close-up of one collapsed row in light rest, light hover and dark hover.
The chevron stays readable inside the notch in all four. On a hovered row the folder's own fill differs from the row colour, so the notch edge shows as a curve in the fill, and the chevron sits on the row colour.
Captured from the built SPA with website/scripts/capture-folder-glyph.mjs's fixtures, seeding the mc-theme mode and hovering each folder row.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 5, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from a777d9f to 062690a Compare October 5, 2026 17:15
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased onto main a92dde1 (was a97659d), same diff, no code change. The rebase reruns the lanes that did not finish on a777d9f: GPT 6.1 Review ran for about an hour without posting, Cross-Platform Portability was cancelled when its checkout hit the 5-minute job limit, and Backend Tests (Windows) 4 and 6 failed in test_stale_asset_watchdog.py and test_subagent_queue_max_wait.py. This PR only touches frontend files, and main's CI passed both shards. It also lets UX Review read the light-theme and hover screenshots added to the description.

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 5, 2026
@github-actions

github-actions Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review (fork) — ✅ no blocking findings

Reviewed bae91958ea1dc1f4f6677ac7d083bd45b13023ea via the fork AI-review pipeline; updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] bae9195

@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Oct 5, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: round notch masked out of the folder glyph under the disclosure chevron

rebutted: the visible curve on hovered rows (and at rest on colored folders) is the notch doing its job. The chevron sits in a cutout of the shape the way a status dot sits on an avatar, so it never overlaps the folder fill or the emoji.
The moat is already small. The chevron ink reaches ~3.0px from centre (path extent plus half the 2.5 stroke) and the hole radius is 3.75px, so shrinking it as suggested buys at most ~0.7px before the hole clips the chevron's own ink. The curve stays visible either way.
The evidence gap in the same verdict, emoji folders, is closed: the description now has emoji and colored folders before/after, plus every row on the branch in light/dark at rest and hovered, captured with the Twemoji font.

@github-actions github-actions Bot added the readiness: action required A blocking check or review needs attention label Oct 5, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from 062690a to 8eb3b0b Compare October 5, 2026 18:00
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Rebased: main moved in website/src/components (VoiceDisabledModal.tsx, same directory) since this head went green (a92dde1 -> 6f70008); CI re-running. No code change. Related vitest (FolderGlyph, folder alignment, chevron grammar, VoiceDisabledModal) and tsc pass on the new head.

On 062690a: GPT 6.1 Review ran about 45 minutes without posting, as on the previous head. Backend Tests (Windows) 6 failed in test_subagent_queue_max_wait.py::TestEveryWaitingRowExpires::test_a_row_without_a_durable_queue_is_bounded_too. That is a different test in the same file as the round before (the file landed on main in #16347 today). This PR does not touch backend code. This push also lets UX Review read the emoji and colored-folder screenshots now in the description.

@Pearcekieser

Copy link
Copy Markdown
Contributor Author

self-added: yes
mechanism: round notch masked out of the folder glyph under the disclosure chevron

rebutted, same class as span e76d8bfc9bb3 on 062690a: the disc in the row colour is the cutout itself. It is what keeps the chevron off the folder fill and off the emoji, the same separation a status dot gets on an avatar.
The suggested shrink does not remove it. The chevron ink reaches about 3.0px from the notch centre (path extent plus half the 2.5 stroke) and the hole is 3.75px, so a 0.5px moat leaves a 3.5px hole, a 0.25px change, and the disc stays visible on every filled glyph.
The real alternative is no cutout on filled glyphs (emoji and colored folders), which puts the chevron back on top of the fill. The PR author is deciding between the two. The rest-state captures of the blue folder and the emoji are in the description (attachment 04).

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Oct 5, 2026
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

The only check left on 8eb3b0b is Frontend Coverage Merge in CI run 37352773635 (job 111931326377). It has been queued on ubuntu-latest since 18:57Z, while runners keep picking up jobs from newer CI runs, so it looks orphaned. Its frontend-test shards all passed. As a fork contributor I cannot re-run it. Could a maintainer re-run that job? gh run rerun 37352773635 --job 111931326377 -R kirodotdev/KiroCrew

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Oct 5, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from 8eb3b0b to dc9bfa2 Compare October 5, 2026 22:00
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Pushed c44508a, which has the same tree as 9afb41c. Only the commit timestamp changed. On 9afb41c the reds were again tests outside this PR's four files, each a different test from the previous run:

  • Frontend Tests (4): src/test/ChatInput.lexicalKeys.test.tsx "Ctrl+Shift+Enter optimizes the prompt instead of sending it" (expected +0 to be 1). It passes 2/2 locally on this head. Frontend Coverage Merge and Coverage Gate failed only because of this shard (frontend-test=failure -- failing closed).
  • Backend Tests (Windows) (8): test/test_loop_watchdog.py::test_alarm_dump_survives_a_temporary_sigalrm_owner_that_restores_sig_dfl, where the subprocess exited 3221225477 (a Windows access violation).

The previous run failed on a different ChatInput Lexical test (lexicalUndo) and a different Windows shard 8 test (test_subagent_memory_wake). CI needs approve-and-run again.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 8, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from c44508a to c40fc15 Compare October 8, 2026 10:52
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Pushed c40fc15: the same single commit rebased onto current main (791b10a), with no code change (range-diff is identical to c44508a). On c44508a the only real failures were four tests in test/test_crew_recency.py that were red on main itself (chat_handlers had no attribute cron_creator_refusal). Main fixed them in #18021, so this rebase picks that up. The disclosureCue vitest file passes 8/8 on the new head. CI needs approve-and-run again.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 8, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from c40fc15 to 70a0105 Compare October 8, 2026 11:53
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Pushed 70a0105, which has the same tree as c40fc15. Only the commit timestamp changed. On c40fc15 the reds were runner failures outside this PR's four files:

  • Screenshot Evidence was cancelled inside its actions/checkout step after five minutes, before any screenshot step ran. It passed on this same tree under c44508a and 9afb41c.
  • Frontend Tests (2) ran all 675 files and 11013 tests green, then exited 1 on a vitest-pool "Worker exited unexpectedly" crash at teardown. Frontend Coverage Merge failed only because of that shard.

CI needs approve-and-run again.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: action required A blocking check or review needs attention and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 8, 2026
@Pearcekieser
Pearcekieser force-pushed the fix/sidebar-folder-chevron branch from 70a0105 to bae9195 Compare October 8, 2026 12:43
@Pearcekieser

Copy link
Copy Markdown
Contributor Author

Pushed bae9195, which has the same tree as 70a0105. Only the commit timestamp changed. On 70a0105 all four review lanes passed. The reds were tests outside this PR's four files, none of which touch Python:

  • Integration (in-process gateway): test/integration/test_owner_only_boot.py::test_a_fresh_boot_leaves_nothing_readable_by_others found 0o644 autonudge.json, crew-log lock files and a 0o755 inbound-spool. The test came in with fix: create data-home files 0600 and directories 0700 #17629 and the same job passed on main's CI for this base, 791b10a.
  • Frontend Tests (1): all 675 files and 12411 tests passed, then vitest exited 1 on a "Worker exited unexpectedly" crash at teardown. Frontend Tests (2) hit the same crash on c40fc15. Frontend Coverage Merge and Coverage Gate failed only because of this shard.
  • Backend Tests (Windows) (1): test/test_dashboard_server_coverage.py::TestWindowEntryHandler::test_handler_follows_a_re_pointed_dist failed with WinError 32, a temp file held open by another process.
  • Backend Tests (3.12, 2): test/test_terminal_ctty_shim.py::test_shim_child_owns_the_terminal_so_ctrl_c_reaches_it reported that Ctrl+C did not deliver SIGINT, 1 failed of 25717.

CI needs approve-and-run again.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: action required A blocking check or review needs attention readiness: checking Automated validation is still running labels Oct 8, 2026
@iamwhatever

Copy link
Copy Markdown
Contributor

This moves the folder disclosure chevron inside the glyph box and cuts a round radial-gradient mask notch under it, so the chevron no longer crosses the outline or crowds the name. The code is small and correct for that. The chevron stays inside the 12px box, folder-alignment geometry is untouched, and the coverage-baseline line is removed correctly. HOLD because it is an open visual/product decision, not a code defect. The UX lane has raised the same CONCERNS on every head, including the current one, bae9195. On coloured, hovered and emoji folders the notch shows as a visible disc or bite (attachments 03 and 04). The author's dispositions say that keeping the cutout on filled glyphs or dropping it "is a product choice the PR author is deciding", and no disposition exists yet for the current head. A maintainer should look at the screenshots and choose: notch everywhere, or no notch on filled/emoji glyphs. After that, a final disposition on this head will close it. The CI reds over recent heads were unrelated flakes, and the current head is green. — crew-pr-reviewer

@Pearcekieser

Copy link
Copy Markdown
Contributor Author
self-added: yes mechanism: round notch masked out of the folder glyph under the disclosure chevron

rebutted. Decision made: the notch stays on every folder glyph, including colored, hovered and emoji folders. I looked at attachments 03 and 04 and chose this on purpose. The disc is the cutout itself, and it keeps the chevron off the fill and off the emoji in the same way a status dot sits on an avatar. Dropping the notch on filled glyphs would put the chevron straight on top of the emoji with nothing between them, which is the crowding this PR fixes.
This closes the open product question from earlier heads (spans a16ca24f6269, 6413d8a013cf, 815fe4b87979, 01f915cdb513, e76d8bfc9bb3). No code change follows from it.

@iamwhatever the call is notch everywhere; this is the final disposition for bae9195.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on behalf of the maintainers (sweep 2026-10-09): readiness passed, required checks green on bae9195, no blocking review threads, security posture unchanged. Approving and merging.

@bolichen97
bolichen97 merged commit f274973 into kirodotdev:main Oct 9, 2026
104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fork Pull request from a fork (external contributor)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(sidebar): folder disclosure chevron overlaps the folder outline and crowds the name

3 participants